D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#359676 , @poboiko wrote: > It seems like you've pushed something that was not intended to be pushed (XML extractor parts) No. Phabricator is just stupid. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

poboiko added a comment. It seems like you've pushed something related to XML extractor as well REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

This revision was automatically updated to reflect the committed changes. Closed by commit R286:205ed84ee213: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16498?vs=44408=45492#toc

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Apart from trivial comment, this looks fine. I've tested it on my setup (with bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It also reduced the size of the

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns removed a reviewer: pino. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns requested review of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. @pino - you have not answered for a week. You have set this to "Needs Revision", which removes it from the "Needs Review" queue for everyone else. If you wan't to see an extractor based on libspectre, thats fine, but then **you** have to write it. REPOSITORY

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#352323 , @pino wrote: > In D16498#352314 , @bruns wrote: > > > Please answer why you consider running a full blown postscript interpreter in an uncontrolled

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#352314 , @bruns wrote: > Please answer why you consider running a full blown postscript interpreter in an uncontrolled environment (no sandboxing, runs without user interaction) is better than 20 code lines of

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. @pino Please answer why you consider running a full blown postscript interpreter in an uncontrolled environment (no sandboxing, runs without user interaction) is better than 20 code lines of trivial text parsing. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350460 , @pino wrote: > In D16498#350426 , @bruns wrote: > > > In D16498#350422 , @pino wrote: > > > > > In

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#350426 , @bruns wrote: > In D16498#350422 , @pino wrote: > > > In D16498#350289 , @bruns wrote: > > > > > In

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350422 , @pino wrote: > In D16498#350289 , @bruns wrote: > > > In D16498#350286 , @pino wrote: > > > > > Ugh no manual

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino added a comment. In D16498#350289 , @bruns wrote: > In D16498#350286 , @pino wrote: > > > Ugh no manual parsing of PS files -- please use libspectre. > > > This is not Postscript parsing,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. @pino - please remove your change request, if you have not read the code at all ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko, pino Cc: pino, kde-frameworks-devel,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#350286 , @pino wrote: > Ugh no manual parsing of PS files -- please use libspectre. This is not Postscript parsing, but DSC parsing - read the specification to understand the difference! REPOSITORY

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Ugh no manual parsing of PS files -- please use libspectre. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo,

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns updated this revision to Diff 44408. bruns added a comment. Replace QDir::Separator with "/" REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16498?vs=44388=44408 BRANCH postscript_dsc REVISION DETAIL https://phabricator.kde.org/D16498

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns created this revision. bruns added reviewers: Frameworks, Baloo, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Postscript files currently fall back to the