D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove abandoned this revision. niccolove added a comment. in favor of https://phabricator.kde.org/D28353 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis, filipf, ngraham,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I'll make this patch again, as much has change since then, there are things I'd do differently, and I'm not a fan of rebasing svg files. I will post the progress I did there. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. In D27122#617594 , @niccolove wrote: > F8131397: image.png Now that //is// relaxing :) I like it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76382. niccolove added a comment. re-tweaked commits REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76381=76382 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76381. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76373=76381 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#617614 , @trmdi wrote: > Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? Definitively. *sigh* REPOSITORY R242 Plasma Framework (Library) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

trmdi added a comment. Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I felt that the transparency was not working very well with the headerbar on some wallpapers, so I toned down the transparency a bit, going from F8131395: image.png to F8131397: image.png

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 76373. niccolove added a comment. Tweaked values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75787=76373 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Couple of screenshots more from this patch: F8115905: Screenshot_20200220_194559.png F8115907: Screenshot_20200220_194611.png F8115910: Screenshot_20200220_194622.png

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. niccolove added dependencies: D27189: Created a top area based on widgets/toparea.svg, D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Regarding maximized windows: I don't think it's possible to make the dialog and panel feel united in this case; windows has this problem as well: F8107248: image.png I'd say this is the expected behavior for a theme with

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75787. niccolove added a comment. Make the panel always as transparent as the dialogs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75786=75787 BRANCH contrast_effect_background_color

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75786. niccolove added a comment. - Merge branch 'master' into contrast_effect_background_color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75277=75786 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#609276 , @ndavis wrote: > I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described, we could have a way to automatically adjust the global plasmashell opacity. REPOSITORY

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. - Breeze panel and dialog being different when using a dark theme - Avoiding controls to be used in ViewBackground areas / using Background Breeze color without it looking gray I have no idea how these could be fixed without just using a color file-d theme

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. One thing I notice other platforms do is to make the panel more opaque when there's a maximized window up against it. That resolves the issue of a translucent panel reflecting the wallpaper color in a way that's jarringly different from pop-ups that appear on top

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Right, I also noticed the color-aware theme now has somewhat more pronounced discrepancy between the panel and the popups when dark color schemes are used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. In D27122#608443 , @niccolove wrote: > Using Background for panels would break the visual integration with dialogs, so I would avoid doing that. > > Regarding panel popups / dialogs; I'm already working on the

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Arcpatched and compiled and I was getting an overly transparent Breeze Dark: F8094138: image.png It was only when I turned Contrast Effect off and then on again that I was seeing what's in the test plan. We should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608324 , @ndavis wrote: > Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham accepted this revision. ngraham added a comment. Me too! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

cblack accepted this revision. cblack added a comment. Style-wise, the tinting effect definitely an improvement over what we currently have. Everything here LGTM. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75277. niccolove added a comment. Changed saturation to 6.0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75145=75277 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#608074 , @ngraham wrote: > But ultimately, don't let this become design-by-committee. This is your patch, and your proposal. It's good to take into account feedback, but not to the extent that it compromises

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. But ultimately, don't let this become design-by-committee. This is your patch, and your proposal. It's good to take into account feedback, but not to the extent that it compromises what you're trying to accomplish in the interests of pleasing people who

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. My result was 0.644. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I personally choose 0.4 for opacity, but I was now thinking whether higher or lower values could be better. I took 50 screenshots in different conditions, but since those are a bit difficult to upload to Phab, I also made a website which helps you pick a value:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#607167 , @ngraham wrote: > Please add a comment in the Description section of this patch explaining why the previously disabled Intensity value is now enabled. ✓ REPOSITORY R242 Plasma Framework

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham accepted this revision. ngraham added a comment. Can confirm that it works, and I do think it looks better now. I'm not an expert on the SVG changes but I don't see anything obviously wrong in there. Please add a comment in the Description section of this patch explaining why

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75145. niccolove added a comment. Fixed mistakes in breeze dark cmakelist REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75019=75145 BRANCH contrast_effect_background_color (branched

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. Nope, I'm absolutely unable to build plasma-framework right now, I have many problems that I don't understand :-/ Also, I have 0 Cmake experience If somebody has time, can they look into how to make Cmake read that file? REPOSITORY R242 Plasma Framework

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I'm unable to build anything right now unluckly so I tried to use code from the breeze folder but I'm not good at cmake. I will try to make cmake for me tomorrow REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. Still not installing the file for me. Is this working for you? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75019. niccolove added a comment. Replace dialogs with widgets as that's the actual one REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75018=75019 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75018. niccolove added a comment. Fix cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75017=75018 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:12 > > +FILE(GLOB translucent_dialogs translucent/dialogs/*.svg) > +plasma_install_desktoptheme_svgs(default SUBPATH translucent/dialogs

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75017. niccolove added a comment. Updated cmake REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75010=75017 BRANCH contrast_effect_background_color (branched from master) REVISION

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. Light version still looks good to me. For the dark version, I still see a difference between the background opacity of the panel and the pop-up: F8085688: Screenshot_20200204_132412.png REPOSITORY R242 Plasma Framework

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I've done the dark theme again, should be nice now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 75010. niccolove added a comment. Tweaked contrast effect for dark and light versions, added new panel file for dark REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74911=75010 BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605987 , @ndavis wrote: > Don't make a color file for the breeze desktop theme. It doesn't have one so that it can use any system color scheme. Uhm; but then, there's no way for the default theme to

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. In D27122#605982 , @niccolove wrote: > In D27122#605981 , @ndavis wrote: > > > In D27122#605976 , @niccolove wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605981 , @ndavis wrote: > In D27122#605976 , @niccolove wrote: > > > In D27122#605975 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. In D27122#605976 , @niccolove wrote: > In D27122#605975 , @ndavis wrote: > > > Also, you can set contrast effects per desktop theme. If you do that, you may be able to

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605975 , @ndavis wrote: > Also, you can set contrast effects per desktop theme. If you do that, you may be able to improve the look of breeze light without hurting breeze dark. Let the Breeze desktop theme

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. Also, you can set contrast effects per desktop theme. If you do that, you may be able to improve the look of breeze light without hurting breeze dark. Let the Breeze desktop theme be a fairly neutral one that works well with most colorschemes. REPOSITORY R242

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. In D27122#605969 , @niccolove wrote: > In D27122#605804 , @ndavis wrote: > > > Using View Background is semantically incorrect. If you want to change the color, you should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605973 , @ndavis wrote: > In D27122#605969 , @niccolove wrote: > > > In D27122#605804 , @ndavis wrote: > > > > >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. In D27122#605804 , @ndavis wrote: > Using View Background is semantically incorrect. If you want to change the color, you should patch the color scheme. But in order to change ColorScheme-Background I should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. Why View Background? That's semantically incorrect. If you want to change the color, you should patch the color scheme. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ndavis, filipf, ngraham,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. In D27122#605489 , @filipf wrote: > I really like this all in all, and the light version looks ready to go. > > The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. I really like this all in all, and the light version looks ready to go. The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be somewhat darker and then the Plasma theme would also be darker. What's more important

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I agree that the dark variant needs a bit of work still. I had focused on the light version. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ngraham, davidedmundson, kde-frameworks-devel,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. Though I said I wouldn't be in favor of making Plasma elements more transparent, I have to admit that the changes look really, really good to my eye, at least for the light version. The dark version looks a bit odd to me though. It seems too transparent and not dark

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a task: T11925: Breeze Desktop Theme Transparency. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added inline comments. INLINE COMMENTS > davidedmundson wrote in metadata.desktop.cmake:98 > There's an explicit comment on why this is as it is. > > That needs some addressing as to why it no longer applies or is less > important that some other change. Simply put, it doesn't work.

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

davidedmundson resigned from this revision. davidedmundson added a comment. Change is now purely visual, so VDG can have say on the details. INLINE COMMENTS > metadata.desktop.cmake:98 > -contrast=0.2 > -#intensity is disabled, in order to auto adjust to the chosen theme color >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove updated this revision to Diff 74911. niccolove added a comment. Fixed accidental changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=74907=74911 BRANCH contrast_effect_background_color (branched from master)

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the summary of this revision. niccolove added projects: Plasma, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > metadata.desktop.cmake:81 > X-KDE-PluginInfo-Name=default > -X-KDE-PluginInfo-Version=@KF5_VERSION@ > +X-KDE-PluginInfo-Version=5.66.0 >

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY I tweaked the contrast effect values to make Breeze a bit prettier (also similiarly to what's described here