kate5 won't build with latest ktexteditor

2014-01-19 Thread Treeve Jelbert
I have been unable to build kate5 for several days /var/git/kate5/addons/kate/project/kateprojectpluginview.cpp: In constructor 'KateProjectPluginView::KateProjectPluginView(KateProjectPlugin*, KTextEditor::MainWindow*)': /var/git/kate5/addons/kate/project/kateprojectpluginview.cpp:55:175:

Re: kate5 won't build with latest ktexteditor

2014-01-19 Thread Christoph Cullmann
Hi, build.kde.org says it builds, perhaps your ktexteditor.git is too old ;) Greetings Christoph - Ursprüngliche Mail - I have been unable to build kate5 for several days /var/git/kate5/addons/kate/project/kateprojectpluginview.cpp: In constructor

Re: Review Request 115100: Rename kmailservice/ktelnetservice binaries to kmailservice5/ktelnetservice5

2014-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115100/#review47670 --- This review has been submitted with commit

Re: Review Request 115100: Rename kmailservice/ktelnetservice binaries to kmailservice5/ktelnetservice5

2014-01-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115100/ --- (Updated Jan. 19, 2014, 9:49 a.m.) Status -- This change has been

Re: kate5 won't build with latest ktexteditor

2014-01-19 Thread Treeve Jelbert
On Sunday 19 January 2014 10:33:25 Christoph Cullmann wrote: Hi, build.kde.org says it builds, perhaps your ktexteditor.git is too old ;) my mistake, I was still using scratch/cullmann/ktexteditor.git Greetings Christoph - Ursprüngliche Mail - I have been unable to build

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Alex Merry
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 19, 2014, 10:56 a.m.) Review request for KDE Frameworks,

Review Request 115120: Clean up the CMake files (and a couple of other bits)

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/ --- Review request for KDE Frameworks. Repository: kimageformats

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/ --- (Updated Jan. 19, 2014, 12:23 p.m.) Review request for KDE Frameworks.

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47675 --- docs/kde5options/man-kde5options.7.docbook

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread David Faure
On Jan. 19, 2014, 12:39 a.m., Luigi Toscano wrote: The patch looks ago, I have two remarks: - I think that kde5options should be kf5options (as it happened with kde4-config - kf5-config) - I'm not sure if the content of those manpages still applies. The special options described

Re: KDE Frameworks: Looking for maintainers

2014-01-19 Thread Kevin Ottens
Hello, I thought it'd be interesting to some to get updated stats since my last call to arms. On Monday 13 January 2014 19:40:54 Kevin Ottens wrote: This is a reminder that we're still looking for maintainers for our frameworks. Out of the 57 existing frameworks 25 have no maintainer (yes,

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

2014-01-19 Thread Valentin Rusu
On Wednesday, January 15, 2014 11:15:54 AM Alex Merry wrote: On 15/01/14 07:36, Valentin Rusu wrote: On 01/15/2014 07:16 AM, Ben Cooksley wrote: It seems you are relying on D-Bus auto-launching. Is this the case? Yes, the kwallet API uses DBus activation to get kwalletd up un running.

Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- Review request for KDE Frameworks and Stephen Kelly. Repository:

Re: Review Request 114897: Make KDE_ENABLE_EXCEPTIONS a list

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114897/ --- (Updated Jan. 19, 2014, 1:20 p.m.) Review request for Build System,

Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System,

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System,

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review47698 --- Makes a lot of sense to me, yep. cmake/FindOpenEXR.cmake

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 19, 2014, 3:39 p.m.) Review request for KDE Frameworks and

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 19, 2014, 3:49 p.m.) Review request for KDE Frameworks and

Jenkins build became unstable: ktexteditor_master_qt5 #50

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/50/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
On Jan. 19, 2014, 2:34 p.m., Stephen Kelly wrote: cmake/FindOpenEXR.cmake, line 110 https://git.reviewboard.kde.org/r/115123/diff/1/?file=234689#file234689line110 I would simply add a fatal_error if cmake version is VERSION_LESS 2.8.12, and remove the rest of this version stuff.

Jenkins build is back to stable : ktexteditor_master_qt5 #51

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/51/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #53

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/53/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-19 Thread David Faure
On Jan. 18, 2014, 2:52 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, line 12 https://git.reviewboard.kde.org/r/115099/diff/1/?file=234571#file234571line12 What if this was TARGET target and you extracted the interface defines etc. from that target? That,

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-19 Thread Friedrich W. H. Kossebau
On Jan. 18, 2014, 8:58 a.m., David Faure wrote: Why does this remove some forwarding headers? Friedrich W. H. Kossebau wrote: Because they are installed from the KParts module itself already, with the same forwarding include path. So no need to duplicate them in KDE4Support, or?

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review47714 --- cmake/FindOpenEXR.cmake

Re: Review Request 115099: Add function ecm_generate_pri_file() to provide qmake support. Make ECMSetupVersion set PROJECT_VERSION_*

2014-01-19 Thread Alex Merry
On Jan. 18, 2014, 2:52 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, line 12 https://git.reviewboard.kde.org/r/115099/diff/1/?file=234571#file234571line12 What if this was TARGET target and you extracted the interface defines etc. from that target? That,

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-19 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/ --- (Updated Jan. 19, 2014, 5:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
On Jan. 19, 2014, 5:21 p.m., Stephen Kelly wrote: cmake/FindOpenEXR.cmake, line 26 https://git.reviewboard.kde.org/r/115123/diff/3/?file=234694#file234694line26 What is in PC_OpenEXR_CFLAGS_OTHER ? INTERFACE_COMPILE_DEFINITIONS is only suitable for compile definitions,

KCrash

2014-01-19 Thread David Faure
KCrash automatically initializes itself with the use of Q_COREAPP_STARTUP_FUNCTION, provided that apps link to that lib. This works OK, except for one thing: it gives no chance for KCrash to add --nocrashhandler to QCommandLineParser (in the case where the app uses that). Which makes me

Jenkins build is back to stable : ktexteditor_master_qt5 #58

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/58/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/#review47725 --- Ship it! Ship It! - David Faure On Jan. 19, 2014, 5:30

Re: KCrash

2014-01-19 Thread Kevin Ottens
Hello, On Sunday 19 January 2014 18:43:01 David Faure wrote: KCrash automatically initializes itself with the use of Q_COREAPP_STARTUP_FUNCTION, provided that apps link to that lib. This works OK, except for one thing: it gives no chance for KCrash to add --nocrashhandler to

Re: KCrash

2014-01-19 Thread David Faure
On Sunday 19 January 2014 20:44:48 Kevin Ottens wrote: What about KCRASH_NO_CRASH_HANDLER ? It's long but it makes it at least descriptive. Except that it's not technically correct, a crash handler (= a function called upon crashing) is still called, to handle autorestart functionality (when

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

2014-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115120/#review47727 --- src/imageformats/CMakeLists.txt

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

2014-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/#review47736 --- Looks good to me. (i.e. wait a bit in case of objections,

Re: Review Request 115097: KParts: Move each class into its own header/source file pair

2014-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115097/#review47737 --- This review has been submitted with commit

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/#review47738 --- This review has been submitted with commit

Re: Review Request 115098: Adapt KParts compat-forwarding headers to new one-header-per-class policy in KParts

2014-01-19 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115098/ --- (Updated Jan. 19, 2014, 9:55 p.m.) Status -- This change has been

CI environment, kwallet tests that pop windows

2014-01-19 Thread Valentin Rusu
Hello, kwallet-framework tests now (correctly) work when launched from a KF5 session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!). I also added SKIP for the case where there's no graphical session, thinking that the CI does not have such an environment, but I was wrong :o) QTest

Jenkins build became unstable: ktexteditor_master_qt5 #61

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/61/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: ktexteditor_master_qt5 #61

2014-01-19 Thread Valentin Rusu
On Sunday, January 19, 2014 10:07:36 PM KDE CI System wrote: See http://build.kde.org/job/ktexteditor_master_qt5/61/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Jenkins build is back to stable : ktexteditor_master_qt5 #62

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/62/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115132: Append 5 to preparetips script manpage

2014-01-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

2014-01-19 Thread Luigi Toscano
On Jan. 19, 2014, 12:39 a.m., Luigi Toscano wrote: The patch looks ago, I have two remarks: - I think that kde5options should be kf5options (as it happened with kde4-config - kf5-config) - I'm not sure if the content of those manpages still applies. The special options described

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

2014-01-19 Thread Luigi Toscano
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47746 --- autotests/kmessagewidgetautotest.cpp

Review Request 115134: Append 5 to kjscmd it's manpage

2014-01-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- Review request for KDE Frameworks. Repository: kjsembed Description

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47749 --- autotests/kmessagewidgetautotest.cpp

Re: CI environment, kwallet tests that pop windows

2014-01-19 Thread Ben Cooksley
On Mon, Jan 20, 2014 at 11:02 AM, Valentin Rusu k...@rusu.info wrote: Hello, Hi, kwallet-framework tests now (correctly) work when launched from a KF5 session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!). I also added SKIP for the case where there's no graphical session,

Jenkins build became unstable: ktexteditor_master_qt5 #70

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/70/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #72

2014-01-19 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/72/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-19 Thread Martin Tobias Holmedahl Sandsmark
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote:

KF5 Update Meeting 2014-w4 Reminder

2014-01-19 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed