Re: Review Request 115480: Never use an -apidocs suffix with kgenframeworksapidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115480/#review49003 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 4, 2014, 6:38

Re: Review Request 115483: Improve kmediaplayer dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115483/#review49005 --- This review has been submitted with commit

Re: Review Request 115483: Improve kmediaplayer dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115483/ --- (Updated Feb. 5, 2014, 10:24 a.m.) Status -- This change has been

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/ --- (Updated Feb. 5, 2014, 10:48 a.m.) Review request for KDE Frameworks and

Re: Review Request 115480: Never use an -apidocs suffix with kgenframeworksapidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115480/#review49007 --- This review has been submitted with commit

Build failed in Jenkins: kapidox_master_qt5 #5

See http://build.kde.org/job/kapidox_master_qt5/5/changes Changes: [kde] Never use an -apidocs suffix with kgenframeworksapidox -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/#review49009 --- QX11Extras is found unconditionally on non-win32 platforms.

Re: kf5 alpha 1 : modules, versions

On 02/03/2014 08:17 PM, David Faure wrote: Any new module that should be added to this release, compared to TP1? Should I include attica? Any version number that should be upgraded in the modules themselves? I realize now that it's all called 5.0.0 everywhere already. The packages are

Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository:

Re: Review Request 115477: Remove commands that just set variables to their defaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/ --- (Updated Feb. 5, 2014, 11:56 a.m.) Status -- This change has been

Re: Review Request 115477: Remove commands that just set variables to their defaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/#review49016 --- This review has been submitted with commit

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/#review49017 --- tests/CMakeLists.txt

Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- Review request for KDE Frameworks. Repository: kjs Description ---

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/ --- (Updated Feb. 5, 2014, 1:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 115481: Improve knotifyconfig dependencies

On Feb. 5, 2014, 11:58 a.m., Alex Merry wrote: tests/CMakeLists.txt, lines 7-20 https://git.reviewboard.kde.org/r/115481/diff/2/?file=241988#file241988line7 These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should have its PURPOSE set as well. It looks like there's a

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/#review49019 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 5, 2014,

Re: Review Request 115476: Defer to CMake's find_dependency macro if it exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115476/ --- (Updated Feb. 5, 2014, 1:26 p.m.) Status -- This change has been

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 1:42 p.m.) Review request for KDE Frameworks and

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49027 --- src/kjs/ConfigureChecks.cmake

Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115495/ --- Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau.

Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 5, 2014, 3:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49034 --- Looks good, just an inline nitpick. I would also suggest

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 4:46 p.m.) Review request for KDE Frameworks,

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- (Updated Feb. 5, 2014, 3:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. Martin Gräßlin wrote: see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49045 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 5, 2014, 4:50

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 4:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49046 --- This review has been submitted with commit

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Review request for KDE Frameworks and

Jenkins build is back to normal : kapidox_master_qt5 #6

See http://build.kde.org/job/kapidox_master_qt5/6/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Status -- This change has been

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Thanks :) Good to hear that it works properly, I guess

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/ --- (Updated Feb. 5, 2014, 4:44 p.m.) Status -- This change has been

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/#review49052 --- This review has been submitted with commit

Re: kf5 alpha 1 : attica?

I can do the changes if needed. It just needs the changes here: http://community.kde.org/Frameworks/Porting_Notes under Build System ? I believe attica currently builds with both qt4 or qt5 based on cmake options (if QT4_BUILD is set it builds with qt4). Is the qt4 branch supposed to not use ECM

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 5:55 p.m.) Review request for KDE Frameworks,

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review49054 --- Ship it! Ship It! - Alex Merry On Jan. 29, 2014, 4:27

Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/ --- Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49051 --- Nope, still breaks on Linux. I think it's because cmath

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/ --- (Updated Feb. 5, 2014, 5:16 p.m.) Status -- This change has been

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review49056 --- This review has been submitted with commit

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- (Updated Feb. 5, 2014, 5:26 p.m.) Review request for Build System, Extra

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/#review49059 --- This review has been submitted with commit

Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- Review request for KDE Frameworks. Repository: kimageformats

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/ --- (Updated Feb. 5, 2014, 5:27 p.m.) Status -- This change has been

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read. Martin Gräßlin wrote: see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I

Re: Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review49066 --- CMakeLists.txt

Re: kf5 alpha 1 : attica?

On Tuesday 4. February 2014 23.40.22 David Faure wrote: On Monday 03 February 2014 11:34:44 Kevin Ottens wrote: On Monday 03 February 2014 10:17:49 David Faure wrote: Any new module that should be added to this release, compared to TP1? Should I include attica? Since this question

Re: Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49067 --- Ship it! Ship It! - Bernd Buschinski On Feb. 5, 2014,

Re: Review Request 115494: Build on Mac OS X

On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote: Nope, still breaks on Linux. I think it's because cmath undefs the signbit macro. I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part of your request. I would also prefer

Re: Review Request 115502: Fix math function checks

On Feb. 5, 2014, 7:37 p.m., Bernd Buschinski wrote: Ship It! and btw good catch for the math vs. cmake undef, seems like I overlooked it :) - Bernd --- This is an automatically generated e-mail. To reply, visit:

Re: kf5 alpha 1 : attica?

On Wednesday 05 February 2014 18:39:51 David Faure wrote: On Wednesday 05 February 2014 09:55:08 Jeremy Whiting wrote: I can do the changes if needed. It just needs the changes here: http://community.kde.org/Frameworks/Porting_Notes under Build System ? No, it should follow all the

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/#review49071 --- This review has been submitted with commit

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/ --- (Updated Feb. 5, 2014, 8:10 p.m.) Status -- This change has been

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Feb. 5, 2014, 8:10 p.m.) Status -- This change has been

Re: Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49074 --- Ship it! Fixes the signbit issue also on Mac OS X :) -

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 8:38 p.m.) Status -- This change has been

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

On Wednesday 05 February 2014 22:18:54 Chusslove Illich wrote: I don't see significant benefit in ki18n being tier 1 Maybe not significant, but looking at ever-appearing difficulties with providing proper translations of Qt applications in KDE repositories, the porting effort is worth it.

Build failed in Jenkins: knewstuff_master_qt5 #23

See http://build.kde.org/job/knewstuff_master_qt5/23/changes Changes: [faure] Port to attica-as-a-proper-kf5-framework. Needs current attica master. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in

Build failed in Jenkins: knewstuff_master_qt5 #24

See http://build.kde.org/job/knewstuff_master_qt5/24/ -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/knewstuff_master_qt5/ws/ Running Prebuild steps [knewstuff_master_qt5] $ /bin/sh -xe

Re: kf5 alpha 1 : attica?

Frederik wrote: From my point of view, please just go ahead and change it as you think is sensible. OK, thanks for the green lights, I went ahead: * Qt4 support for attica is now in the qt4 branch * Attica master is now qt5 only, and requires ECM. * It gained all the bells and whistles of

Build failed in Jenkins: knewstuff_master_qt5 #25

See http://build.kde.org/job/knewstuff_master_qt5/25/changes Changes: [faure] Port to attica-as-a-proper-kf5-framework. Needs current attica master. -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 in workspace

Re: kf5 alpha 1 : attica?

On Thursday 6. February 2014 00.29.45 David Faure wrote: Frederik wrote: From my point of view, please just go ahead and change it as you think is sensible. OK, thanks for the green lights, I went ahead: * Qt4 support for attica is now in the qt4 branch * Attica master is now qt5

Re: kf5 alpha 1 : attica?

On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote: On Thursday 6. February 2014 00.29.45 David Faure wrote: Frederik wrote: From my point of view, please just go ahead and change it as you think is sensible. OK, thanks for the green lights, I went ahead: * Qt4

Build failed in Jenkins: knewstuff_master_qt5 #26

See http://build.kde.org/job/knewstuff_master_qt5/26/ -- Started by user dfaure Building remotely on LinuxSlave - 4 in workspace http://build.kde.org/job/knewstuff_master_qt5/ws/ Running Prebuild steps [knewstuff_master_qt5] $ /bin/sh -xe

Jenkins build is back to normal : knewstuff_master_qt5 #27

See http://build.kde.org/job/knewstuff_master_qt5/27/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5 alpha 1 : attica?

[resent with Frederik's correct email address] On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote: Thanks a lot, I really appreciate it. Some issues left: - who do we write down as maintainer for attica? - can I run astyle on the code to make it consistent with all other frameworks?

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: src/kwindowsystem.cpp, line 342 https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342 The non-MSVC macro has a return statement, I think this one needs it as well Andrius da Costa Ribas wrote: