KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 36 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/36/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 02:51:17 + Build duration: 4 min 46 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests build.log Description: Binary data
D7194: Detach before setting the d pointer
apol updated this revision to Diff 17863. apol added a comment. Add missing detach() REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7194?vs=17844=17863 BRANCH detach REVISION DETAIL https://phabricator.kde.org/D7194 AFFECTED FILES src/core/entryinternal.cpp To: apol, leinir Cc: broulik, #frameworks
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
apol updated this revision to Diff 17862. apol added a comment. Make sure there's such a button REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7196?vs=17860=17862 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks
D7196: Fix accepting dialogs with ctrl+return when buttons are renamed
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY QAbstractButton::setText will call setShortcut(mnemonic), making this little hack unusable. This patch puts the shortcut into a separate object. TEST PLAN Improved the test to reproduce the issue I had Now we can use it with KDE Connect send reply dialogs REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D7196 AFFECTED FILES src/kstyle/kstyle.cpp tests/kstyletest.cpp To: apol, #frameworks
KDE CI: Frameworks kio kf5-qt5 WindowsQt5.7 - Build # 57 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsQt5.7/57/ Project: Frameworks kio kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 02:51:03 + Build duration: 25 min and counting CONSOLE OUTPUT [...truncated 372.77 KB...]Generating MOC source KF5KIOFileWidgets_autogen/include/kdiroperator.mocGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kdiroperator.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kdirsortfilterproxymodel.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kencodingfiledialog.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfilebookmarkhandler_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfilefiltercombo.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfileplacesitem_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfileplacesmodel.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/kfileplacesview.mocGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfileplacesview.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfileplacesview_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfilepreviewgenerator.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kfilewidget.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kimagefilepreview.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_knameandurlinputdialog.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_knewfilemenu.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kpreviewwidgetbase.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kstatusbarofflineindicator.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigator.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatorbutton_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatorbuttonbase_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatordropdownbutton_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatormenu_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatorplacesselector_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatorprotocolcombo_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/include/moc_kurlnavigatortogglebutton_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_defaultviewadapter_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_kdiroperatordetailview_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_kfilecopytomenu.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_kfilecopytomenu_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_kfilemetapreview_p.cppGenerating MOC source KF5KIOFileWidgets_autogen/EWIEGA46WW/moc_kfileplaceeditdialog.cppGenerating MOC compilation KF5KIOFileWidgets_autogen/moc_compilation.cpp[ 22%] Built target KF5KIOFileWidgets_autogen[ 22%] Built target kcookiejar5Generating MOC source KF5KIOWidgets_autogen/include/delegateanimationhandler.mocGenerating MOC source KF5KIOWidgets_autogen/include/moc_delegateanimationhandler_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_dropjob.cppGenerating MOC source KF5KIOWidgets_autogen/include/fileundomanager.mocGenerating MOC source KF5KIOWidgets_autogen/include/moc_fileundomanager.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_fileundomanager_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/jobuidelegate.mocGenerating MOC source KF5KIOWidgets_autogen/include/moc_joburlcache_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kacleditwidget.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kacleditwidget_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kdirlister.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kdirmodel.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kdynamicjobtracker_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kfile.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kopenwithdialog.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kopenwithdialog_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/koverlayiconplugin.mocGenerating MOC source KF5KIOWidgets_autogen/include/moc_kpropertiesdialog.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kpropertiesdialog_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/krun.mocGenerating MOC source KF5KIOWidgets_autogen/include/moc_krun.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_krun_p.cppGenerating MOC source KF5KIOWidgets_autogen/include/moc_kurlcombobox.cppGenerating MOC source KF5KIOWidgets_autogen/include/kurlcompletion.mocGenerating MOC source
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 49 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/49/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 02:52:32 + Build duration: 24 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
KDE CI: Frameworks frameworkintegration kf5-qt5 WindowsQt5.7 - Build # 19 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20WindowsQt5.7/19/ Project: Frameworks frameworkintegration kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 02:50:22 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) build.log Description: Binary data
KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 02:52:17 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.runnercontexttest build.log Description: Binary data
D7094: Include a module for finding qml imports as runtime dependencies
apol added a comment. In https://phabricator.kde.org/D7094#133579, @dfaure wrote: > Would that help with doing things right for the issue in https://phabricator.kde.org/D6466 as well? No, I don't think so. This is mostly for packagers who need to document dependencies. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 26 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/26/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 02:51:52 + Build duration: 8 min 15 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream build.log Description: Binary data
KDE CI: Frameworks kconfigwidgets kf5-qt5 WindowsQt5.7 - Build # 23 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20WindowsQt5.7/23/ Project: Frameworks kconfigwidgets kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 02:50:42 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) build.log Description: Binary data
KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Tue, 08 Aug 2017 02:51:52 + Build duration: 5 min 0 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)96% (22/23)96% (22/23)73% (1498/2064)50% (1033/2054)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (10/10)100% (10/10)100% (500/502)52% (277/532)autotests.mockdepresolver100% (1/1)100% (1/1)78% (14/18)58% (7/12)src.kpackage75% (3/4)75% (3/4)73% (538/739)62% (524/840)src.kpackage.private100% (6/6)100% (6/6)79% (290/367)53% (113/212)src.kpackagetool100% (2/2)100% (2/2)36% (156/438)24% (112/458) build.log Description: Binary data
KDE CI: Frameworks breeze-icons kf5-qt5 WindowsQt5.7 - Build # 27 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsQt5.7/27/ Project: Frameworks breeze-icons kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 02:50:12 + Build duration: 8 min 57 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.dupe build.log Description: Binary data
D6830: Make use of kauth helper in copy method of file ioslave
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file_unix.cpp:244
> #endif
> -dest_file.remove(); // don't keep partly copied file
> +if (!!QFile::remove(dest)) { // don't keep partly copied file
> +execWithElevatedPrivilege(DEL, _dest);
Double negation, looks like one too many.
> file_unix.cpp:290
> #endif
> -dest_file.remove(); // don't keep partly copied file
> +if (!!QFile::remove(dest)) { // don't keep partly copied file
> +execWithElevatedPrivilege(DEL, _dest);
same
> file_unix.cpp:327
> } else {
> -qCWarning(KIO_FILE) << QStringLiteral("Couldn't preserve group for
> '%1'").arg(dest);
> +if (!execWithElevatedPrivilege(CHOWN, _dest, buff_src.st_uid,
> buff_src.st_gid))
> +qCWarning(KIO_FILE) << QStringLiteral("Couldn't preserve group
> for '%1'").arg(dest);
Can you test copying a file onto a FAT partition mounted as another uid? The
ownership and permissions cannot be applied due to FAT limitations. Does that
then trigger a kauth prompt, with this patch? That would be annoying, and wrong
since root can't do better anyway.
If I'm right (please test it) then I think this method should remember "I
needed root permissions for the main operation" and only in that case use
elevated privileges for the small operations at the end like chmod, chown or
utime.
Please review whether other methods need the same kind of change.
REVISION DETAIL
https://phabricator.kde.org/D6830
To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk added a comment. Guys... no one gave me an "Accepted' yet :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kossebau added a comment. +1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not `set target_link_libraries(... Qt5::Tests)` separately, but only pass as args in the macro *cough*kdevelop*cough*) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7156: Qt5DBus is only required with HAVE_XSCREENSAVER
This revision was automatically updated to reflect the committed changes. Closed by commit R274:93a2acfe2e66: Qt5DBus is only required with HAVE_XSCREENSAVER (authored by asturmlechner). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7156?vs=17763=17852#toc REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7156?vs=17763=17852 REVISION DETAIL https://phabricator.kde.org/D7156 AFFECTED FILES CMakeLists.txt To: asturmlechner, #frameworks, kfunk Cc: #frameworks
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk added a comment. In https://phabricator.kde.org/D7187#133497, @kossebau wrote: > +1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not set `target_link_libraries(... Qt5::Tests)` separately, but only pass as args in the macro *cough*kdevelop*cough*) Will do. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7118: Add KPeople recipe
cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R868 Yocto: KDE Frameworks Packaging BRANCH kpeople REVISION DETAIL https://phabricator.kde.org/D7118 To: vkrause, cordlandwehr Cc: #frameworks
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk, vkrause Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7195: KUndoActions: use actionCollection to set the shortcut
ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Resolve the following warning printed out when the undo/redo actions are added through KUndoActions: KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut for action "edit_undo" "Undo" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead. TEST PLAN The undo/redo actions still work and the warning is gone. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7195 AFFECTED FILES src/kundoactions.cpp To: ltoscano Cc: #frameworks
KDE CI: Frameworks kxmlgui kf5-qt5 WindowsQt5.7 - Build # 29 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20WindowsQt5.7/29/ Project: Frameworks kxmlgui kf5-qt5 WindowsQt5.7 Date of build: Mon, 07 Aug 2017 21:32:55 + Build duration: 3 min 36 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ktoolbar_unittest build.log Description: Binary data
KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/44/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 07 Aug 2017 20:26:26 + Build duration: 1 min 35 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 49 test(s)Failed: TestSuite.KDEInstallDirsTest.relative_or_absolute build.log Description: Binary data
D7094: Include a module for finding qml imports as runtime dependencies
dfaure added a comment. Would that help with doing things right for the issue in https://phabricator.kde.org/D6466 as well? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid
D7194: Detach before setting the d pointer
broulik added inline comments.
INLINE COMMENTS
> entryinternal.cpp:169
> {
> d->mCategory = category;
> }
Detach here also
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7194
To: apol, leinir
Cc: broulik, #frameworks
D7195: KUndoActions: use actionCollection to set the shortcut
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7195 To: ltoscano, aacid Cc: #frameworks
KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 35 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/35/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Mon, 07 Aug 2017 20:26:26 + Build duration: 2 min 0 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 49 test(s)Failed: TestSuite.ECMPoQmToolsTest Cobertura Report Project Coverage Summary Name Cobertura Coverage Report build.log Description: Binary data
D7142: Fix proxy KCM not loading manual proxies correctly.
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7142 To: dfaure, dmariano, davidedmundson Cc: #frameworks
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7187?vs=17835=17858#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17835=17858 REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES modules/ECMAddTests.cmake To: kfunk, vkrause Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7195: KUndoActions: use actionCollection to set the shortcut
This revision was automatically updated to reflect the committed changes. Closed by commit R263:f2b5114d8b90: KUndoActions: use actionCollection to set the shortcut (authored by ltoscano). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7195?vs=17857=17859 REVISION DETAIL https://phabricator.kde.org/D7195 AFFECTED FILES src/kundoactions.cpp To: ltoscano, aacid Cc: #frameworks
D7175: Redesign CMake syntax
turbov added a comment. In https://phabricator.kde.org/D7175#133152, @dhaumann wrote: > I see seveal issues that imo should be addressed: > > 1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?) no, I don't run tests yet (it is too complicated to build the repo for me nowadays) > > > 2. How does it work, are we supposed to run this command from time to time manually? If so, then I'd be ok with that. it work pretty simple: 1. reading YAML (as a Python's `dict`) 2. prepare (rename keys, & etc) data for renderer 3. render data (a `dict`) into the Jinja template as I said the previous generator became unstable -- parsing the output of `cmake --help` is not reliable, so this generator uses "static" YAML file, which should be updated manually > > > 3. How high is the maintenance burden over time: I understand that this should this, but given we have a yaml file that needs to be maintained manually, I wonder whether we simply move the maintenance from one place to another and additionally introduce complexity (in terms of additional tooling) one first needs to understand before being able to fix things. the point w/ the current generator: I'm far from sure it "parse" everything correct... moreover, I know exactly that it "parses" `cmake --help` output incorrectly (and one have to fix the generated syntax manually after the generator) and there is really hard to make the generator right cuz the informal/irregular nature of help screens. in contrast, the new approach offers a full control over the generated syntax, yeah, by the cost of "manual" maintenance of the YAML file (I tried to make it as simple as possible, and I'm sure it shouldn't be a problem to anyone to add anything to it %) Usually, I read CMake's ChangeLog carefully after any new release, spotting new commands/variables/properties/etc and this is the time to update syntax (YAML file)... > > > 4. The kateversion is back to 2.4 and hard-coded colors are used again. Previously, it was set to 5.0, and used already the newly introduced default styles. I strongly suggest to keep the new default styles - we purposefully changed this some time ago, and I dislike that fact that we go a step back here. previous cmake.xml do not use anything from modern kate, this syntax works fine w/ KDE4 version of kate. anyway, it would be easy to fix it and remove hardcoded colors anyway... the hardest part is to realize would this approach be accepted or not REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_hightlighting, vkrause Cc: cullmann, #frameworks
D7136: Don't use find_file for finding files in our own source dir
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:81
>
> -find_file(kwallet_xml org.kde.KWallet.xml HINTS
> ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet)
> +set(kwallet_xml
> ${CMAKE_CURRENT_SOURCE_DIR}/../../api/KWallet/org.kde.KWallet.xml)
>
How about `${CMAKE_SOURCE_DIR}/src/api/KWallet/org.kde.KWallet.xml`?
Making it relative isn't doing much anyway.
REPOSITORY
R311 KWallet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7136
To: vkrause, #frameworks, kfunk
Cc: apol, kfunk
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk updated this revision to Diff 17835. kfunk added a comment. Fix typo. "no-top" is something else. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17830=17835 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES modules/ECMAddTests.cmake To: kfunk Cc: apol, #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
elvisangelaccio added a comment. In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable the target if `BUILD_TESTING` is false, why is that not enough? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk added a comment. In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote: > In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable the target if `BUILD_TESTING` is false, why is that not enough? Good question. I didn't explain that in the commit message: `ecm_add_test` also invokes `target_link_libraries(...)` which may pull in additionally dependencies if `BUILD_TESTING=ON`. Example: ecm_add_test(test_svnrecursiveadd.cpp LINK_LIBRARIES Qt5::Test Qt5::Gui ) - If `BUILD_TESTING=OFF` & without this patch: We still need Qt5::Test around. - If `BUILD_TESTING=OFF` & with this patch: We no longer need Qt5::Test at all. This patch actually makes it pretty easy to get rid off the Qt5::Test dependency in a whole KDE project without touching lots of CMake code. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
elvisangelaccio added a comment. Oh, I see. +1 then! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D6047: Support XDG v6
davidedmundson updated this revision to Diff 17813. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Unbind global Add a test for transientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15889=17813 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_xdg_shell.cpp autotests/client/test_xdg_shell.h autotests/client/test_xdg_shell_v5.cpp autotests/client/test_xdg_shell_v6.cpp src/client/CMakeLists.txt src/client/protocols/xdg-shell-unstable-v6.xml src/client/registry.cpp src/client/registry.h src/client/xdgshell.cpp src/client/xdgshell.h src/client/xdgshell_p.h src/client/xdgshell_v5.cpp src/client/xdgshell_v6.cpp src/server/CMakeLists.txt src/server/display.cpp src/server/xdgshell_interface.cpp src/server/xdgshell_interface.h src/server/xdgshell_interface_p.h src/server/xdgshell_v5_interface.cpp src/server/xdgshell_v5_interface_p.h src/server/xdgshell_v6_interface.cpp src/server/xdgshell_v6_interface_p.h src/tools/mapping.txt tests/CMakeLists.txt tests/xdgtest.cpp To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
D7127: ignore spurious resize events to empty sizes
mart updated this revision to Diff 17832. mart added a comment. more comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17712=17832 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES src/plasmaquick/dialog.cpp To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7127: ignore spurious resize events to empty sizes
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c27df529d80: ignore spurious resize events to empty sizes (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17832=17834 REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES src/plasmaquick/dialog.cpp To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
apol added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: apol, #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk updated this revision to Diff 17830. kfunk added a comment. Remove unrelated hunks REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17829=17830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES modules/ECMAddTests.cmake To: kfunk Cc: #frameworks, #build_system
D7127: ignore spurious resize events to empty sizes
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks! add some code comments. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7127: ignore spurious resize events to empty sizes
mart added a comment. finally figured out where this event is generated: it's a spontaneous event generated in qguiapplication.cpp QGuiApplicationPrivate::processWindowScreenChangedEvent around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent gce(window, QHighDpi::fromNativePixels(window->handle()->geometry(), window), QRect()); this happens even before the first show event, right after the window has been created, the window is still 0x0, but the resize event gets delivered with 0x0 again and executed with all the bad side effects this seems to happen for every window when there are multiple screens, so something we have probably to watch out for in the future REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Use-case: Make building unit tests optional, by just following the CMake BUILD_TESTING option. The usual approach to conditionally build tests is to do: if (BUILD_TESTING) add_executable(TestOne TestOne.cpp) target_link_libraries(TestOne my_library) endif() or: if (BUILD_TESTING) add_subdirectory(tests) endif() This patch just turns all calls to ecm_add_test(...) into no-ops if BUILD_TESTING=OFF. See: https://cmake.org/cmake/help/v3.6/module/CTest.html REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES modules/ECMAddTests.cmake modules/ECMEnableSanitizers.cmake To: kfunk Cc: #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
kfunk added a comment. It's not possible to easily disable tests at the moment, is it? I might be missing something. Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=627242 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: #frameworks, #build_system
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
asturmlechner added a comment. In https://phabricator.kde.org/D7187#11, @kfunk wrote: > Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo: Much appreciated if we can drop those. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
D7130: KMoreTools: Update and fix desktopfiles
elvisangelaccio added a comment. In https://phabricator.kde.org/D7130#132809, @gregormi wrote: > Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an application is installed by passing the desktop filename (without extension), i.e. "org.kde.filelight" or "org.kde.partitionmanager" (KService::serviceByDesktopName(desktopEntryName)). I did not fully understand how it works internally. It uses some caching mechanism. Could you run kbuildsycoca5 or relogin and try again? I have no idea how I should reproduce it here on my machine because it works here. When dealing with KService I got the impression that it is hard to find out why a particular service (desktop file) is _not_ found. Right, worked after a kbuildsycoca5 run. I guess +1 from my side, but this will break again as soon as one of the desktop files changes upstream. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7156: Qt5DBus is only required with HAVE_XSCREENSAVER
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D7156 To: asturmlechner, #frameworks, kfunk Cc: #frameworks
KDE CI: Frameworks kdbusaddons kf5-qt5 WindowsQt5.7 - Build # 22 - Still unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20WindowsQt5.7/22/ Project: Frameworks kdbusaddons kf5-qt5 WindowsQt5.7 Date of build: Mon, 07 Aug 2017 07:19:33 + Build duration: 1 min 30 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kdbusinterprocesslocktestFailed: TestSuite.kdbusservicetest build.log Description: Binary data
D7175: Redesign CMake syntax
dhaumann added a comment. I see two issues that imo should be addressed: 1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?) 2. How does it work, are we supposed to run this command from time to time manually? If so, then I'd be ok with that. 3. How high is the maintenance burden over time: I understand that this should this, but given we have a yaml file that needs to be maintained manually, I wonder whether we simply move the maintenance from one place to another and additionally introduce complexity (in terms of additional tooling) one first needs to understand before being able to fix things. 4. The kateversion is back to 2.4 and hard-coded colors are used again. Previously, it was set to 5.0, and used already the newly introduced default styles. I strongly suggest to keep the new default styles - we purposefully changed this some time ago, and I dislike that fact that we go a step back here. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_hightlighting, vkrause Cc: cullmann, #frameworks
D7175: Redesign CMake syntax
turbov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake syntax has been redesigned to pursue the following goals: - the former generator has used an output of `cmake --help` (and friends) commands, which is quite informal (not a well formed) and error prune - the current syntax was really out of date The new approach is to use a trivial Python script, which uses a prepared YAML data file and Jinja template to render the resulting syntax file. Key features of the new implementation are: - every command highlight only related named parameters -- e.g. `add_library` do not have `TARGET` named option, so it doesn't highlighted in this context - new highlight classes has introduced to distinct property names, aliased (imported) targets, special non-named arguments... - reuse RST syntax for comments - input data now in VCS and trackable there is still some work to do, but I've just want to know is there any interest in this approach... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh data/generators/cmake.xml.tpl data/generators/cmake.yaml data/generators/generate-cmake-syntax.py data/syntax/cmake.xml To: turbov Cc: #frameworks
KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Mon, 07 Aug 2017 07:37:56 + Build duration: 1 min 22 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (5/5)96% (22/23)96% (22/23)73% (1498/2064)50% (1033/2054)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (10/10)100% (10/10)100% (500/502)52% (277/532)autotests.mockdepresolver100% (1/1)100% (1/1)78% (14/18)58% (7/12)src.kpackage75% (3/4)75% (3/4)73% (538/739)62% (524/840)src.kpackage.private100% (6/6)100% (6/6)79% (290/367)53% (113/212)src.kpackagetool100% (2/2)100% (2/2)36% (156/438)24% (112/458) build.log Description: Binary data
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 25 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/25/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 07 Aug 2017 07:37:56 + Build duration: 1 min 1 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream build.log Description: Binary data
D7136: Don't use find_file for finding files in our own source dir
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I don't see why `find_file` would be needed here, yep. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: kfunk
D7127: ignore spurious resize events to empty sizes
mart marked an inline comment as done. mart added a comment. not sure how to proceed in debugging this, as all i have is a resize event handler being called, which a backtrace there is useless to figure out who is resizing it REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7175: Redesign CMake syntax
cullmann added a reviewer: vkrause. cullmann added a comment. If that makes it easier to keep the syntax file up-to-date, I would have no issues with a generator build in this way. If we ever want to go away from it, we still have the generated file around as base. But Volker should give his input, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_hightlighting, vkrause Cc: cullmann, #frameworks
D7190: Don't complain the knsregistry file is not present before it's useful
apol created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Only consider it an error if the knsregistry file is present but can't be written on. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D7190 AFFECTED FILES src/core/cache.cpp To: apol, leinir Cc: #frameworks
D7136: Don't use find_file for finding files in our own source dir
kfunk accepted this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D6774: Fix labels of DeleteFile/RenameFile actions
elvisangelaccio added a comment. Ping? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D6774 To: elvisangelaccio, #frameworks Cc: cfeck
D6815: kcmtrash: fix i18n warning
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d475e74cbe59: kcmtrash: fix i18n warning (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6815?vs=16975=17847 REVISION DETAIL https://phabricator.kde.org/D6815 AFFECTED FILES src/ioslaves/trash/kcmtrash.cpp To: elvisangelaccio, dfaure, davidedmundson Cc: #frameworks
D7136: Don't use find_file for finding files in our own source dir
This revision was automatically updated to reflect the committed changes. Closed by commit R311:a14de9351608: Don't use find_file for finding files in our own source dir (authored by vkrause). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7136?vs=17843=17848 REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: vkrause, #frameworks, kfunk Cc: apol, kfunk
D7187: RFC: Make ECMAddTests respect BUILD_TESTING
vkrause added a comment. Another +1, would also help the KDE Yocto recipes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
