D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh added a comment.


  In D11452#231277 , @smithjd wrote:
  
  > If you browse your recently committed code in Diffusion, you'll notice that 
your linespaces can be copy and pasted. This doesn't match the current style 
where the tabs are spaces and the linespaces don't contain tab spaces and thus 
won't be copyable.
  
  
  I see. Revisited my KDevelop settings. Should be fixed now.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D4716: Add some more directives to MIPS assembler highlighting

[Alex Richardson]

arichardson updated this revision to Diff 30212.
arichardson marked 2 inline comments as done.
arichardson added a comment.


  address comments
  will try to add tests soon

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4716?vs=11618=30212

BRANCH
  arcpatch-D4716

REVISION DETAIL
  https://phabricator.kde.org/D4716

AFFECTED FILES
  data/syntax/c-preprocessor.xml
  data/syntax/gnuassembler.xml
  data/syntax/mips.xml

To: arichardson, dhaumann, vkrause
Cc: #frameworks, michaelh, ngraham

D11487: optimization of TextLineData::attribute

[Milian Wolff]

mwolff added a comment.


  @jtamate looking at your screenshots, it represents closely what I see 
locally. Most notably, there are no red underlines in your screenshots which 
could arise due to spell checking. Thus I really wonder why you are seeing such 
a big hotspot there.
  
  Try perf, or try a poor mans profiler like GDB and regularly interrupt. Do 
you really end up in `TextLineData::attribute()`? Or, alternatively: Measure 
the time it takes for kate/kwrite to open the file and then go to the end. Then 
compare this before and after your patch. Do you see anything in the order of 
~75% reduction for the time then too? Note how callgrind only measure 
instructions, so a supposed reduction of 75% of instructions should certainly 
have an impact on time too - of course not 75% too... I simply cannot fathom 
why you are seeing such an impact but I cannot reproduce this at all!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/109/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Mar 2018 11:49:32 +
 Build duration:
4 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3522/13408)18%
(1954/10579)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)51%
(585/1140)27%
(406/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2243)7%
(102/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1441/3500)28%
(825/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(541/2013)17%
(298/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
   

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/84/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Mar 2018 11:49:32 +
 Build duration:
7 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D11557: remove anchors of item in a layout

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6291c4852fdf: remove anchors of item in a layout 
(authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11557?vs=30147=30220

REVISION DETAIL
  https://phabricator.kde.org/D11557

AFFECTED FILES
  src/declarativeimports/plasmastyle/ButtonStyle.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham retitled this revision from "Improve consistency of "Open With" UI" to 
"Improve consistency of "Open With" UI by always showing top app inline".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[David Edmundson]

davidedmundson added a comment.


  +1 looks good

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, 
michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Kai Uwe Broulik]

broulik added a comment.


  "Open With..." are quite memorable labels used in Windows, I fear "Open With 
Application" will take away the recognizability of "Öffnen mit …" in German to 
"Mit Anwendung öffnen". But I won't object.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Andres Betts]

abetts added a comment.


  +1 on this! Easy access to apps!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11582: Generate the rcc file every time, at install time

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11582

To: apol, #frameworks, #plasma, mart
Cc: michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/33/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Mar 2018 14:21:43 +
 Build duration:
4 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4568/15122)23%
(1933/8396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1696/1715)52%
(994/1912)src44%
(52/117)44%
(52/117)23%
(2872/12279)15%
(939/6307)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

D11569: Improve consistency of "Open With" UI

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileitemactions.cpp:654
> +// Always show the top app inline
> +QAction *act = d->createAppAction(offers.first(), menu);
> +menu->addAction(act);

Use offers.takeFirst(), it will get and remove.

> kfileitemactions.cpp:656
> +menu->addAction(act);
> +offers.removeFirst();
> +

Remove.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham updated this revision to Diff 30233.
ngraham added a comment.


  Use `takeFirst()` to avoid a separate `remove()` invocation

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11569?vs=30227=30233

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Henrik Fehlauer]

rkflx added a comment.


  @ngraham Thanks for setting me as a reviewer, I try to have a look before 
Frameworks string freeze on saturday. Focussing on on Apps string freeze today 
;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham retitled this revision from "Improve usability of "Open With" UI" to 
"Improve consistency of "Open With" UI".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Nathaniel Graham]

ngraham updated this revision to Diff 30227.
ngraham added a comment.


  Add a separator to the top menu when there's a submenu

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11569?vs=30226=30227

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

D11566: KCapacityBar: set QStyle::State_Horizontal state

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:e489bebd3df0: KCapacityBar: set QStyle::State_Horizontal 
state (authored by zzag).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11566?vs=30171=30228

REVISION DETAIL
  https://phabricator.kde.org/D11566

AFFECTED FILES
  src/kcapacitybar.cpp

To: zzag, cfeck, elvisangelaccio
Cc: #frameworks, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

[Anthony Fieroni]

anthonyfieroni added reviewers: dfaure, elvisangelaccio.
anthonyfieroni added subscribers: elvisangelaccio, dfaure.
anthonyfieroni added a comment.


  +1
  @dfaure and @elvisangelaccio can have other objections.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11487: optimization of TextLineData::attribute

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katetextline.cpp:214-216
> Use operator->, it's faster than operator* and operator.
> 
>   first->offset

sorry, but that's simply not true at all.

Stylistic wise I agree, but an optimizing compiler will generate the same code 
for both.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

D11487: optimization of TextLineData::attribute

[Jaime Torres Amate]

jtamate added a comment.


  In D11487#231522 , @mwolff wrote:
  
  > @jtamate looking at your screenshots, it represents closely what I see 
locally. Most notably, there are no red underlines in your screenshots which 
could arise due to spell checking. Thus I really wonder why you are seeing such 
a big hotspot there.
  >
  > Try perf, or try a poor mans profiler like GDB and regularly interrupt. Do 
you really end up in `TextLineData::attribute()`? Or, alternatively: Measure 
the time it takes for kate/kwrite to open the file and then go to the end. Then 
compare this before and after your patch. Do you see anything in the order of 
~75% reduction for the time then too? Note how callgrind only measure 
instructions, so a supposed reduction of 75% of instructions should certainly 
have an impact on time too - of course not 75% too... I simply cannot fathom 
why you are seeing such an impact but I cannot reproduce this at all!
  
  
  I've done some measurements, as the times are so big, with a stopwatch 2 
times each test.
  With "Enable autodetection of Language" and "Automatic spell checking enabled 
by default" enabled,
  the test as before: since pressing "Temporarily raise limit and reload file", 
press Ctrl+end and finish the scroll to the end of the document.
  
  without any version of the patch:
  1 min 25 seconds 
  With @mwolf solution, used only in spellCheckWrtHighlightingRanges.
  38 seconds
  With the binary search:
  34 seconds

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

D11569: Improve usability of "Open With" UI

[Nathaniel Graham]

ngraham updated this revision to Diff 30226.
ngraham added a comment.


  Always show top app inline, and others in the sub-menu

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11569?vs=30182=30226

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: anthonyfieroni, abetts, michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Mar 2018 14:21:43 +
 Build duration:
3 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.ktooltipwidgettest

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/8/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 14:21:43 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: TestSuite.ktooltipwidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4568/15122)23%
(1934/8396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1696/1715)52%
(994/1912)src44%
(52/117)44%
(52/117)23%
(2872/12279)15%
(940/6307)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

D11582: Generate the rcc file every time, at install time

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  In the case of bundles, installing consists of putting all the files in the 
rcc
  and put this file on the right place.
  Instead of juggling cmake to remove the file and create it every time, do it
  explicitly at installation time.

TEST PLAN
  Now I can build plasma-desktop, instead of having it build the rcc file and
  then remove it before installing

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11582

AFFECTED FILES
  KF5PackageMacros.cmake

To: apol, #frameworks, #plasma
Cc: michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham added a comment.


  In D11569#231663 , @mmustac wrote:
  
  > I have two questions regarding this "open with" topic.
  >  Is the displayed app the one which is also set as default for this file 
type or the first alternative (2nd app) ? If it's the default one why should 
someone make a right click on a file to open it with his/her default app 
instead of making a single/double click on it?
  
  
  It's rather odd that there's no Open item in Dolphin's context menu in the 
first place, and this patch remedies that. Also, this is a general API, so 
other clients can potentially benefit from it even when it's not used in a 
context menu. (e.g. Gwenview could adopt this to make it easier to open images 
in other apps, where currently the only option is to use a sub-menu)
  
  > The second point: Shouldn't the "Open with" stuff be at the very beginning 
of the menu when we have a file selected for quick access? (1. opening, 2. 
create new files (for folders), 3. direct file operations, 4. additional file 
operations, 5. everything else)
  
  I would approve of that. It's what macOS does, FWIW:
  
  F5762927: finder menu.png 
  
  As you can see from the above image, macOS doesn't tell you what app will 
launch in response to the Open action, so this patch would actually represent a 
usability improvement over that. However, re-ordering the menu would need to be 
changed in Dolphin, not here in KIO. That change (if we do it) should go into 
18.08.0, to make sure that it can rely on this change (if it's accepted).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

Re: Experimental class in baloo

[Ivan Čukić]

p.s. It is common for the pimpl classes in Qt and KF5 to be named
ClassName::Private or ClassNamePrivate and for the pointer to be named
`d` - not ClassNameImpl and m_pimpl.

p.p.s. I've seen that the DatabaseSanitizer is exported in
libKF5BalooEngine.so.5 - if this is a library meant for 3rd party
plugins or applications to be linked against, then David's comment was
right.



On Thu, Mar 22, 2018 at 6:49 PM, Ivan Čukić  wrote:
> Hi,
>
> Is this a class that is supposed to be available in the library (.so
> file) - to be used in applications that use baloo, or is it only a
> class in the backend?
>
> If it is the second case (which I guess it is since I don't see the
> symbols exported in libKF5Baloo.so), then this should not be a problem
> - it is not a part of the API nor the ABI.
>
> Cheers,
> Ivan
>
>
> On Wed, Mar 21, 2018 at 3:03 PM, Michael Heidelbach  wrote:
>> On 21.03.2018 01:16, David Edmundson wrote:
>>
>>
>>
>> On Tue, Mar 20, 2018 at 9:43 AM, Michael Heidelbach 
>> wrote:
>>>
>>> Hi!
>>>
>>> I've recently introduced a new class for baloo. It is mainly for
>>> debugging. As it is accompanied with a command line tool it may be useful
>>> for users too.
>>>
>>> It is still in an experimental state and it's likely I'll wish to change
>>> the public interface.
>>>
>>> 1) Is it possible to mark that class as experimental for some time and
>>> have the allowance to chance the interface?
>>
>>
>> Once you've exported symbols in the same library as baloo...not really.
>>>
>>> 2) If so, what is the best way to communicate that?
>>
>> If it's purely for debugging, stick it behind some optional CMake definition
>> so only users who explicitly enable it have the header installed.
>>
>>
>> David
>>
>> Thank you for your reply, David.
>> In this case I would like to hide it (and the command line tool) at least
>> until 5.46.
>> I'm not very knowledgeable with CMake. I guess sticking it 'behind some
>> optional CMake definition' will also account for it not being part of the
>> library. I've never done this before can you some help or an example please.
>>
>> Michael
>>
>>
>
>
>
> --
> KDE, ivan.cu...@kde.org, http://cukic.co/
> gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A



-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A

Re: Experimental class in baloo

[Ivan Čukić]

Hi,

Is this a class that is supposed to be available in the library (.so
file) - to be used in applications that use baloo, or is it only a
class in the backend?

If it is the second case (which I guess it is since I don't see the
symbols exported in libKF5Baloo.so), then this should not be a problem
- it is not a part of the API nor the ABI.

Cheers,
Ivan


On Wed, Mar 21, 2018 at 3:03 PM, Michael Heidelbach  wrote:
> On 21.03.2018 01:16, David Edmundson wrote:
>
>
>
> On Tue, Mar 20, 2018 at 9:43 AM, Michael Heidelbach 
> wrote:
>>
>> Hi!
>>
>> I've recently introduced a new class for baloo. It is mainly for
>> debugging. As it is accompanied with a command line tool it may be useful
>> for users too.
>>
>> It is still in an experimental state and it's likely I'll wish to change
>> the public interface.
>>
>> 1) Is it possible to mark that class as experimental for some time and
>> have the allowance to chance the interface?
>
>
> Once you've exported symbols in the same library as baloo...not really.
>>
>> 2) If so, what is the best way to communicate that?
>
> If it's purely for debugging, stick it behind some optional CMake definition
> so only users who explicitly enable it have the header installed.
>
>
> David
>
> Thank you for your reply, David.
> In this case I would like to hide it (and the command line tool) at least
> until 5.46.
> I'm not very knowledgeable with CMake. I guess sticking it 'behind some
> optional CMake definition' will also account for it not being part of the
> library. I've never done this before can you some help or an example please.
>
> Michael
>
>



-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A

D1231: Add Remote Access interface to KWayland

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:430
> +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui 
> KF5::WaylandClient KF5::WaylandServer)
> +add_test(kwayland-testRemoteAccess testRemoteAccess)
> +ecm_mark_as_test(testRemoteAccess)

`add_test(NAME kwayland-testRemoteAccess COMMAND testRemoteAccess)`

otherwise ctest doesn't find the test.

> remote_access_interface.cpp:206
> +// clients don't necessarily bind outputs
> +if (boundScreens.isEmpty())
> +return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11583: Add platform detection and adjustment to kded

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma, apol.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.

REVISION SUMMARY
  Current Plasma/master branch does no longer set the QT_QPA_PLATFORM env
  variable on Wayland. As kded is a process tightly connected to the
  workspace it also needs to pick wayland QPA in a Wayland session. This
  change brings in the adjustment from plasma-workspace and ensures that
  kded works correctly on any Wayland desktop environment, being it
  Plasma, GNOME or Weston.

TEST PLAN
  Restarted session, kscreen got layout correctly

REPOSITORY
  R297 KDED

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D11583

AFFECTED FILES
  src/kded.cpp

To: graesslin, #frameworks, #plasma, apol
Cc: michaelh, ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/20/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 20:20:45 +
 Build duration:
4 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11238: filemetadatawidgettest: Enforce en_US locale

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:469037b96b20: filemetadatawidgettest: Enforce en_US 
locale (authored by michaelh).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11238?vs=29833=30255

REVISION DETAIL
  https://phabricator.kde.org/D11238

AFFECTED FILES
  autotests/filemetadatawidgettest.cpp

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: broulik, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Marijo Mustac]

mmustac added a comment.


  I have two questions regarding this "open with" topic.
  Is the displayed app the one which is also set as default for this file type 
or the first alternative (2nd app) ? If it's the default one why should someone 
make a right click on a file to open it with his/her default app instead of 
making a single/double click on it?
  The second point: Shouldn't the "Open with" stuff be at the very beginning of 
the menu when we have a file selected for quick access? (1. opening, 2. create 
new files (for folders), 3. direct file operations, 4. additional file 
operations, 5. everything else)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 52 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/52/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Mar 2018 20:20:45 +
 Build duration:
6 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  This test is essentially a duplication of `TermGeneratorTest` which could not 
be extended by chinese characters due to its iso-8859-15 encoding.
  git recognized it as a binary file.

REPOSITORY
  R293 Baloo

BRANCH
  termgeneratortest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11587

AFFECTED FILES
  autotests/unit/engine/CMakeLists.txt
  autotests/unit/engine/termgeneratortestutf.cpp
  autotests/unit/engine/termgeneratortestutf.h
  src/engine/document.h

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, 
alexeymin

D11552: [WIP] Handle CJK characters

[Michael Heidelbach]

michaelh updated this revision to Diff 30252.
michaelh edited the test plan for this revision.
michaelh added a comment.


  - Base on D11587 
  - Make tests pass
  - Use QChar.script() and  QChar.isLetter()

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11552?vs=30125=30252

BRANCH
  cjk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11552

AFFECTED FILES
  autotests/unit/engine/termgeneratortestutf.cpp
  src/engine/CMakeLists.txt
  src/engine/characterrangescjk.cpp
  src/engine/characterrangescjk.h
  src/engine/queryparser.cpp
  src/engine/termgenerator.cpp

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

[Michael Heidelbach]

michaelh added a dependent revision: D11552: [WIP] Handle CJK characters.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11587

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, 
alexeymin

D11552: [WIP] Handle CJK characters

[Michael Heidelbach]

michaelh edited the summary of this revision.
michaelh edited the test plan for this revision.
michaelh added a dependency: D11587: [WIP] autotests: Introduce 
TermGeneratorTestUTF.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11506: baloodb: Add experimental message

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a49cac4781ad: baloodb: Add experimental message (authored 
by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11506?vs=29984=30254

REVISION DETAIL
  https://phabricator.kde.org/D11506

AFFECTED FILES
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks, ngraham
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11552: [WIP] Handle CJK characters

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> characterrangescjk.cpp:35
> +for (int i = 0; i < text.length(); i++) {
> +const QChar& c = text.at(i);
> +if (m_graphemeWords.contains(c.script()) && c.isLetter()) {

Add surrogate pair handling. Basic outline:

  uint c = text.at(i);
  if (QChar::isSurrogate(c)) {
  c = QChar::surrogateToUcs4(c, text.at(++i));
  }
  if (QChar::isLetter(c) ...

You would need to add 'i' bounds checking, and verifying that you are indeed 
seeing a valid pair.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11552: [WIP] Handle CJK characters

[Michael Heidelbach]

michaelh added a comment.


  In D11552#231784 , @bruns wrote:
  
  > In D11552#231330 , @hein wrote:
  >
  > > For the record though - a better way to do this is to use 
QTextBoundaryFinder which will operate e.g. on grapheme cluster boundaries. 
This still isn't super great for Chinese though. If you want to really-properly 
do it you'll end up depending on ICU and using its BreakIterator combined with 
dict-based support for Chinese, which isn't terribly fast however.
  >
  >
  > There are a few implications here:
  >
  > - splitting to much generates to unspecific terms, especially in case of 
full text indexing (Think of splitting a western language at character level, 
most texts likely contain almost the full alphabet. Same likely applies to 
Katakana with its about ~100 graphemes)
  > - term generation at query and index time have to agree about what a term 
is, otherwise a search will likely return nothing. Changing the splitting at a 
later time will require reindexing all affected files
  > - better splitting will cost some more time at index generation, but likely 
makes searching faster (additional time for term generation will be neglegible, 
but the search terms are less complex - e.g. "abc" instead of "a" AND "b" AND 
"c").
  
  
  Currently `termgenerator` uses `QTextBoundaryFinder 
bf(QTextBoundaryFinder::Word, text);`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11552: [WIP] Handle CJK characters

[Michael Heidelbach]

michaelh updated this revision to Diff 30257.
michaelh added a comment.


  - Add surrogate pair handling
  - Remove obsolete #include

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11552?vs=30252=30257

BRANCH
  cjk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11552

AFFECTED FILES
  autotests/unit/engine/termgeneratortestutf.cpp
  src/engine/CMakeLists.txt
  src/engine/characterrangescjk.cpp
  src/engine/characterrangescjk.h
  src/engine/queryparser.cpp
  src/engine/termgenerator.cpp

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11552: [WIP] Handle CJK characters

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> characterrangescjk.cpp:40
> +}
> +if (c.isLetter() && m_graphemeWords.contains(c.script())) {
> +result << c;

Like that? Only 60% aware of what I'm doing here.
Do you know of an example text I can incorporate into the test?
All I've got so far is tables, numbers and such, no text.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11552: [WIP] Handle CJK characters

[Stefan Brüns]

bruns added a comment.


  In D11552#231330 , @hein wrote:
  
  > For the record though - a better way to do this is to use 
QTextBoundaryFinder which will operate e.g. on grapheme cluster boundaries. 
This still isn't super great for Chinese though. If you want to really-properly 
do it you'll end up depending on ICU and using its BreakIterator combined with 
dict-based support for Chinese, which isn't terribly fast however.
  
  
  There are a few implications here:
  
  - splitting to much generates to unspecific terms, especially in case of full 
text indexing (Think of splitting a western language at character level, most 
texts likely contain almost the full alphabet. Same likely applies to Katakana 
with its about ~100 graphemes)
  - term generation at query and index time have to agree about what a term is, 
otherwise a search will likely return nothing. Changing the splitting at a 
later time will require reindexing all affected files
  - better splitting will cost some more time at index generation, but likely 
makes searching faster (additional time for term generation will be neglegible, 
but the search terms are less complex - e.g. "abc" instead of "a" AND "b" AND 
"c").

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11452: sanitizer: Improve device listing

[James Smith]

smithjd added a comment.


  In D11452#230590 , @michaelh wrote:
  
  > In D11452#230387 , @smithjd 
wrote:
  >
  > > Could you please make your tab spacing conform to the style of the
  > >  codebase? This should also be fixed in baloodb.
  >
  
  
  If you browse your recently committed code in Diffusion, you'll notice that 
your linespaces can be copy and pasted. This doesn't match the current style 
where the tabs are spaces and the linespaces don't contain tab spaces and thus 
won't be copyable.
  
  > baloo follows Kdelibs Coding Style 
 that is 4 spaces per 
tab. Please specify the places this code (or baloodb) deviates from the rules.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11487: optimization of TextLineData::attribute

[Jaime Torres Amate]

jtamate added a comment.


  In D11487#231110 , @mwolff wrote:
  
  > Considering spell checking is involved - can you show a screenshot for how 
the file looks like for you? There shouldn't be a lot of spell checking going 
on, or so I hope...
  
  
  F5762231: fake_first.png  opening the 
file and accepting to extend the line limit.
  F5762233: fake_last.png  after pressing 
ctrl+end

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11487

To: jtamate, #frameworks, #kate
Cc: anthonyfieroni, dhaumann, mwolff, cullmann, michaelh, kevinapavew, ngraham, 
demsking, sars

D11570: Introduce GamingInputBattery type

[Fabian Vogt]

fvogt edited reviewers, added: lbeltrame; removed: fvogt.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11570

To: broulik, #frameworks, apol, dollinger, lbeltrame
Cc: michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/28/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Mar 2018 23:44:42 +
 Build duration:
53 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 23:44:42 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/34/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Mar 2018 23:44:42 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testjsonmetadatapackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackagesdep-appstreamFailed: TestSuite.testpackagesdepinvalid-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1624/2219)51%
(1277/2501)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(329/642)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)40%
(210/526)27%
(154/564)

D11552: [WIP] Handle CJK characters

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> characterrangescjk.cpp:41
> +if (c.isLetter() && m_graphemeWords.contains(c.script())) {
> +result << c;
> +}

To add a uint to a QStringList, convert the uint character to a QString. Either 
manually compose the surrogates (faster, but uglier code), or use 
QString::fromUcs4() (slower, but nicer to read).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein, cfeck
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11582: Generate the rcc file every time, at install time

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:afa1fc1aa49e: Generate the rcc file every time, at 
install time (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11582?vs=30237=30262#toc

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11582?vs=30237=30262

REVISION DETAIL
  https://phabricator.kde.org/D11582

AFFECTED FILES
  KF5PackageMacros.cmake

To: apol, #frameworks, #plasma, mart
Cc: michaelh, ngraham

D11552: [WIP] Handle CJK characters

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> characterrangescjk.cpp:38
> +if (i < length - 1 && c.isHighSurrogate() && 
> text.at(i+1).isLowSurrogate()) {
> +c = c.surrogateToUcs4(c, text.at(++i));
> +}

You need to use uint to store the full character. QChar is *not* a character, 
it is just one UTF-16 codeword.

Additionally, use the QChar::name(uint) static methods to operate on uint 
characters.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein, cfeck
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11553: Adding Battery Devices Enum

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:619d7a492b18: Adding Battery Devices EnumAdding Battery 
Devices Enum (authored by dollinger, committed by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11553?vs=30129=30194

REVISION DETAIL
  https://phabricator.kde.org/D11553

AFFECTED FILES
  src/solid/devices/backends/upower/upower.h

To: dollinger, broulik
Cc: #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

broulik added a comment.


  Thanks a lot for yout patience and sorry it had to go through that many 
revisions.
  
  I took the liberty of altering it to check each value explicitly, so when a 
new one is added it isn't forgotten to evaluate whether it makes sense to 
support or not, I hope that's okay.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11552: [WIP] Handle CJK characters

[Eike Hein]

hein added a comment.


  For the record though - a better way to do this is to use QTextBoundaryFinder 
which will operate e.g. on grapheme cluster boundaries. This still isn't super 
great for Chinese though. If you want to really-properly do it you'll end up 
depending on ICU and using its BreakIterator combined with dict-based support 
for Chinese, which isn't terribly fast however.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11557: remove anchors of item in a layout

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11557

To: davidedmundson, #plasma, broulik
Cc: #frameworks, michaelh, ngraham

D11552: [WIP] Handle CJK characters

[Eike Hein]

hein added a comment.


  If you're going to loop over a QString and break it down into QChars anyway, 
why don't you just use QChar::script?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

D11331: add gaming_input devices and others to Battery

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:12dc9354e598: add gaming_input devices and others to 
Battery (authored by dollinger, committed by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11331?vs=30141=30195#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11331?vs=30141=30195

REVISION DETAIL
  https://phabricator.kde.org/D11331

AFFECTED FILES
  src/solid/devices/backends/upower/upowerdevice.cpp

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

D11570: Introduce GamingInputBattery type

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, apol, fvogt, dollinger.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  This is for e.g. wireless gamepads and joysticks

TEST PLAN
  Compiles, Don't have the upower version that supports it

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11570

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakebattery.cpp
  src/solid/devices/backends/upower/upowerbattery.cpp
  src/solid/devices/frontend/battery.h

To: broulik, #frameworks, apol, fvogt, dollinger
Cc: michaelh, ngraham