D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. > Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted. Whoa, thanks for the notice. Not cool, forgot about it. Probably need to add some checks in IndexCleaner, about the device. But how does it wo

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. Sorry, I should have written this more clearly, but you got it right. It's for the new formats. For the most common tags, taglib directly provides the implementation for all its supported tag formats and one can call e.g. tag->artist(). For the others, one has to i

D15939: Perform checks for unindexed files and stale index entries on startup

smithjd added a comment. Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: smithjd, bruns, ngraha

D11529: Balooctl: Deindex unfound files with check command.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/161/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 23:29:32 + Build duration: 7 min 2 sec and counting JUnit Tests Name: (root

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns updated this revision to Diff 43176. bruns added a comment. make (introduction of) error message translatable REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15826?vs=42547&id=43176 BRANCH oob REVISION DETAIL https://phabricator.kde.org/D15826 AFF

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/160/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 23:21:58 + Build duration: 7 min 33 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 236 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/236/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 23:24:41 + Build duration: 1 min 49 sec and counting JUnit Tests Name: (r

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 235 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/235/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 23:21:58 + Build duration: 2 min 42 sec and counting JUnit Tests Name: (r

D15970: Properly look for fallback themes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8c18054a0de3: Properly look for fallback themes (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15970?vs=42938&id=43175 REVIS

D15970: Properly look for fallback themes

hein accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D15970 To: apol, #plasma, davidedmundson, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14530: Fix crash when save a QImage to the eps format file

kossebau abandoned this revision. kossebau added a comment. Closing this review request as the author has not reacted. D15405 should be serving already as more proper fix for the referenced bug. REPOSITORY R287 KImageFormats REVISION DETAIL https://p

D15970: Properly look for fallback themes

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D15970 To: apol, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14530: Fix crash when save a QImage to the eps format file

kossebau commandeered this revision. kossebau edited reviewers, added: zccrs; removed: kossebau. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D14530 To: kossebau, mlaurent, dfaure, zccrs Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15582: Reference product "KF5" in widget metadata, instead of "KDE"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R298:9c34333131b8: Reference product "KF5" in widget metadata, instead of "KDE" (authored by kossebau). REPOSITORY R298 K

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. > Hah, looks like you pushed a commit for it last year! > > I'm not wedded to symlink support, but if we're not going to do it, we should close the bug with some good reasons. Well, I remembered that I did something on that, but I totally forgot what exactly

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns added a comment. In D15826#339367 , @poboiko wrote: > BTW, does it also wipe tags and other user-provided metadata? Tags and comments are store in XAttrs, i.e. with the file. REPOSITORY R293 Baloo REVISION DETAIL https://phabri

D15959: Wait for the extraction process to finish before scheduling

bruns added a comment. This works for me: void FileIndexScheduler::scheduleIndexing() { -if (m_threadPool.activeThreadCount() || m_indexerState == Suspended) { +if (m_indexerState == Suspended) { return; } REPOSITORY R293 Baloo REVISION DET

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko closed this revision. REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15943: [balooctl] Monitor also for state changes

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo, ngraham Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15944: [balooctl] Fix "index" command with already indexed, but moved file

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15944 To: poboiko, #baloo, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15934: Add battery and bluetooth icons for other DE compatibility

ngraham added a comment. Yeah, I'd be happy about that! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added inline comments. INLINE COMMENTS > bruns wrote in main.cpp:211 > but you are not allowed to access `word[2]` if `word.length() < 3`. We don't access it directly, and `indexOf` performs internal checks. For example, `QStringLiteral("ab").indexOf('c', 5)` seem to be perfectly valid

D11828: Simplify orPostingIterator and make it faster

bruns added a comment. In D11828#339379 , @poboiko wrote: > Looks fine to me. But do we really need to optimize it? I mean, I didn't see it running more than ~20 ms, and with this patch for small queries it runs like ~16 ms. Worst case is when u

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 269 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/269/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 21:17:08 + Build duration: 5 min 37 sec and counting JUnit Tests Name: (root) Failed: 0 t

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns added inline comments. INLINE COMMENTS > poboiko wrote in main.cpp:211 > But still, if the term is short (namely, length < 4), we will either won't > have "-" (this corresponds to `posOfNonNumeric < 0`, and that's > `X`), or it will be the last symbol (something like `X1-` - which is > `

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 268 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/268/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 20:42:27 + Build duration: 34 min and counting JUnit Tests Name: (root) Failed: 1 test(s

D15988: Add 'Mount' option to context menu of unmounted device in Places

This revision was automatically updated to reflect the committed changes. Closed by commit R241:57f0d33d8e9a: Add 'Mount' option to context menu of unmounted device in Places (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15988?vs=42979&id=43165#toc REPOSITORY R

D15973: Add a 'Properties' entry in the places panel context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6bbb80c2f9f2: Add a 'Properties' entry in the places panel context menu (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=43071&id=43164

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/32/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 19:43:06 + Build duration: 6 min 20 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/44/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 19:43:06 + Build duration: 2 min 6 sec and counting JUnit Tests Name: (root)

D15932: [UDisks2] Power down drive on remove if supported

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R245:867f53608d3a: [UDisks2] Power down drive on remove if supported (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde

D16044: [Timeline] Use categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2530d160781d: [Timeline] Use categorized logging (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16044?vs=43127&id=43160 REVISION DETAIL https:

D16043: Clean up unused QDebug/baloodebug.h includes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5e3871aa030b: Clean up unused QDebug/baloodebug.h includes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16043?vs=43121&id=43159 REVISION DETAI

D16049: Added missing Icons to Places Panel code from KIO

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16049 To: alexde, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16049: Added missing Icons to Places Panel code from KIO

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16049 To: alexde, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11828: Simplify orPostingIterator and make it faster

poboiko added a comment. Looks fine to me. But do we really need to optimize it? I mean, I didn't see it running more than ~20 ms, and with this patch for small queries it runs like ~16 ms. Worst case is when user types something in KRunner, but again, the lag is negligible there. INLINE CO

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. Maybe we should print also a suggestion to user, something like (maybe rephrase it better) WARNING: Looks like your index is corrupted. We suggest you to run `balooctl disable && balooctl disable` to wipe it and rebuild from scratch so they won't h

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

bruns added a comment. In D15825#338218 , @astippich wrote: > In D15825#334087 , @bruns wrote: > > > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - an

D15833: extend test coverage to all supported mimetypes for taglibextractor

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thx! REPOSITORY R286 KFileMetaData BRANCH taglib_extractor_additional_tests REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-framewo

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/31/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 18:22:02 + Build duration: 6 min 5 sec and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/43/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 18:22:02 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root)

D16049: Added missing Icons to Places Panel code from KIO

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/78/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 17:52:22 + Build duration: 4 min 22 sec and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/56/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 17:52:22 + Build duration: 2 min 2 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 422 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/422/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 17:48:07 + Build duration: 6 min 15 sec and counting JUnit Tests Name: (root) Failed: 0

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

This revision was automatically updated to reflect the committed changes. Closed by commit R320:aaa1edbb74c4: [mtp] Move MTP device handling from kioslave to kiod-module (authored by akrutzler). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15277?vs=43074&

D16043: Clean up unused QDebug/baloodebug.h includes

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16043 To: bruns, #baloo, #frameworks, broulik, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15934: Add battery and bluetooth icons for other DE compatibility

ndavis added a comment. In D15934#339276 , @ngraham wrote: > I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon setting

D15934: Add battery and bluetooth icons for other DE compatibility

ngraham added a comment. I have no objection to the concept, but I like to test patches before I approve them, and I'm still not sure how I would satisfactorily test this without taking up an afternoon setting up a dev environment in an XFCE-using distro in a VM, which unfortunately is time

D16043: Clean up unused QDebug/baloodebug.h includes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16043 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngr

D16044: [Timeline] Use categorized logging

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16044 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngr

D15934: Add battery and bluetooth icons for other DE compatibility

ndavis added a comment. @ngraham @broulik Do you have any objections or questions about this commit? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

jtamate added a comment. Just in case, I'm subscribed now to the RSS https://build.kde.org/job/Frameworks/job/kio/rssFailed REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan added a comment. RE: In D15999#338724 , @filipf wrote: > Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) > > F6310672: image.png

D15999: Add icons with added background to system.svgz

pstefan added a comment. RE: In D15999#338724 , @filipf wrote: > Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) > > F6310672: image.png

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

This revision was automatically updated to reflect the committed changes. Closed by commit R320:44f2852fb299: [Thumbnails] Paint larger "one thumbnail" tile only when needed (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15402?vs=4138

D15510: Introduce HKDF

volkov added a comment. BTW, should I create a review request to reformat code with astyle-kdelibs? REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D16044: [Timeline] Use categorized logging

bruns created this revision. bruns added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Set all messages in regular execution paths to Debug (off by default), and

D15510: Introduce HKDF

volkov updated this revision to Diff 43125. volkov added a comment. more reinterpret_casts REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=43123&id=43125 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES in

D15510: Introduce HKDF

volkov updated this revision to Diff 43123. volkov added a comment. fixed REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=41656&id=43123 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES include/QtCrypto/qc

D15510: Introduce HKDF

volkov added inline comments. INLINE COMMENTS > dfaure wrote in qca-botan.cpp:250 > override? it still supports build with Qt 4 and without C++ 11 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D16043: Clean up unused QDebug/baloodebug.h includes

bruns created this revision. bruns added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The code does not use qDebug(), qWarning() or similar, so remove it. TEST P

D15098: make push/pop part of ConfigModule API

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH arcpatch-D15098 REVISION DETAIL https://phabricator.kde.org/D15098 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bru

D14580: support for multi pages kcms

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D14580 To: mart, #plasma, #frameworks, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham,

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

This revision was automatically updated to reflect the committed changes. Closed by commit R320:a26de31a5dfb: Distinguish between file and directory delete request in debug output. (authored by madcatx). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15873?

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

This revision was automatically updated to reflect the committed changes. Closed by commit R320:75ee4dfb4042: Add a specific error string for ENOTEMPTY return code. (authored by madcatx). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15871?vs=42807&id=4311

D15328: kfilewidget: convert connect syntax

jtamate planned changes to this revision. jtamate added a comment. QTest::qWaitForWindowActive fails because I use kwin Focus stealing prevention High, therefore the windows doesn't become active until I click on them in the task bar or switch to them. And qWaitForWindowExposed doesn't help

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 08:16:32 + Build duration: 8 min 12 sec and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 62 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 08:16:32 + Build duration: 7 min 46 sec and counting JUnit Tests Name: (root) Failed:

D15912: Don't silently error if damage is sent before buffer

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b4cd89ea4977: Don't silently error if damage is sent before buffer (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15912?vs=42820&id=4

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 421 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/421/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Oct 2018 07:43:32 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed: 1 test

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 266 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/266/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 08 Oct 2018 07:43:32 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed: 0 test(s)

D15328: kfilewidget: convert connect syntax

jtamate updated this revision to Diff 43106. jtamate added a comment. Fix a crash ,caused by a still connected signal, after running again the unittests. kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails for me. Don't accept this revision until kfilewidgettes

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. I am really, really sorry. I have no excuses to not have run the autotests (that I usually run after my first fiasco). Hopefully, after my second fiasco, I'll run them before creating any