D27080: Don't warn for invalid plugin metata

ngraham created this revision. ngraham added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY See explanation in https://bugs.kde.org/show_bug.cgi?id=412464 BUG: 412464

D27075: Fixed tooltip corners and removed useless color attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f7b4bbf86177: Fixed tooltip corners and removed useless color attributes (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

ndavis added a comment. In D26758#601718 , @gvgeo wrote: > Plasma theme explorer is fine. The difference is that it uses plasmaComponents, while D26271 uses plasmaComponents**3**. > > About

D27075: Fixed tooltip corners and removed useless color attributes

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27075 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh,

D27075: Fixed tooltip corners and removed useless color attributes

niccolove added a reviewer: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27075 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27075: Fixed tooltip corners and removed useless color attributes

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27075 AFFECTED FILES

D22477: With auto completion don't show completions that don't match from beginning of typed word

mwolff added a comment. I agree, this is a feature, not a bug. If people are annoyed, they are usually annoyed by other issues like the one shown by Sven REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann,

D23848: Add Breeze icons for Jupyter Notebook files

alexde abandoned this revision. alexde added a comment. I unfortunately no longer have time for this. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23848 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. Something like this: F8059669: Screenshot_20200131_163146.PNG REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: cfeck, dhaumann, ngraham,

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi updated this revision to Diff 74799. crossi added a comment. code style REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27059?vs=74756=74799 REVISION DETAIL https://phabricator.kde.org/D27059 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

D25682: add initial wsdiscovery support

sitter added inline comments. INLINE COMMENTS > ngraham wrote in .gitignore:1 > shouldn't you be doing out-of-source builds lol an unrelated subdir is still technically out-of-source from a cmake pov ;) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To:

D27067: Change "AutoSkip" to "Skip All"

ngraham added a comment. Sure, in another patch. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9b77746a6b1e: QApplication::globalStrut() will be removed in qt6. Its deprecated in qt5.15… (authored by mlaurent). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH remove_globalStrut (branched from master) REVISION DETAIL https://phabricator.kde.org/D27010 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

mlaurent added a comment. ping ?:) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27010 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27067: Change "AutoSkip" to "Skip All"

broulik added a comment. +1 (also for considering the string freeze :) I think we should add some mnemonics, i.e. "" and "Skip " REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure Cc: broulik, kde-frameworks-devel,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. In D27035#604026 , @ngraham wrote: > Uh-oh, now it looks like this in Konsole: F8056116: Screenshot_20200131_064332.png > > Compare to the current appearance: F8056130:

D27067: Change "AutoSkip" to "Skip All"

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY "AutoSkip" is not a word and makes it unclear what the button

D26931: Introduce SPDX license headers

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Uh-oh, now it looks like this in Konsole: F8056116: Screenshot_20200131_064332.png Compare to the current appearance: F8056130:

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Sorry, couple of further style fixes I missed on the previous run INLINE COMMENTS > kcoreconfigskeleton.cpp:1616 > + > +void KConfigCompilerSignallingItem::setGroup(const

D26841: hardware tool: define syntax via syntax arg

sitter updated this revision to Diff 74780. sitter added a comment. set HidenFromHelp flag on legacy option so it doesn't even show up anymore REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26841?vs=74112=74780 BRANCH master REVISION DETAIL

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R236:16385f0b6926: API dox: tell default values of KMessageWidgets wordWrap/closeButtonVisible (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES

D26841: hardware tool: define syntax via syntax arg

sitter added a comment. Splendid idea! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26841 To: sitter Cc: broulik, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH mentiondefaults REVISION DETAIL https://phabricator.kde.org/D27064 To: kossebau, davidre Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

kossebau updated this revision to Diff 74778. kossebau added a comment. fix default visible=true REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27064?vs=74771=74778 BRANCH mentiondefaults REVISION DETAIL https://phabricator.kde.org/D27064

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

kossebau added inline comments. INLINE COMMENTS > davidre wrote in kmessagewidget.h:258 > I think the close button is visible by default, isn't it? Good catch. I fooled myself with having qt designer showing me still the file version with false where I though it was the clean

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

davidre added inline comments. INLINE COMMENTS > kmessagewidget.h:258 > * > + * By default the close button is set to be invisible. > + * I think the close button is visible by default, isn't it? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a reviewer: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mwolff requested review of this revision. REVISION SUMMARY Reading through the code, I realized that the isRemovable check returned true when the

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

kossebau added a comment. @davidre: looking at the setter methods, I am also tempted to add early returns in case of no change. but I do not want to get in the way with your qpainter patch (good work), so waiting :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

kossebau created this revision. kossebau added a reviewer: davidre. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R236 KWidgetsAddons BRANCH mentiondefaults REVISION

D25682: add initial wsdiscovery support

ngraham accepted this revision as: ngraham. ngraham added a comment. Works great, super cool to have this. Since `kdsoap-ws-discovery-client` is upstream now, do we still need to duplicate it here? INLINE COMMENTS > .gitignore:1 > +build/ shouldn't you be doing out-of-source builds

D26841: hardware tool: define syntax via syntax arg

broulik added a comment. Oh god yes. Since it's only for compat and superfluous, how about setting `HiddenFromHelp` on the `QCommandLineOption` then? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26841 To: sitter Cc: broulik, bruns, kde-frameworks-devel,

D26931: Introduce SPDX license headers

cordlandwehr updated this revision to Diff 74768. cordlandwehr added a comment. Unify copyright header format REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26931?vs=74452=74768 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26931

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added a comment. In D27035#603619 , @dhaumann wrote: > Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre updated this revision to Diff 74766. davidre marked an inline comment as done. davidre added a comment. Use parentWidget() REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=74714=74766 BRANCH no-css (branched from master) REVISION

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

davidre added inline comments. INLINE COMMENTS > kmessagewidget.cpp:317 > +constexpr float alpha = 0.2; > +const auto parentWidget = qobject_cast(parent()); > +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() > : qApp->palette()).color(QPalette::Window); I

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi updated this revision to Diff 74756. crossi added a comment. code style REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27059?vs=74754=74756 REVISION DETAIL https://phabricator.kde.org/D27059 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:86 > +/** > + * Set config file group bu giving the KConfigGroup. > + * Allow the item to be in nested groups. s/bu/but/ > kcoreconfigskeleton.h:97 > + */ > +KConfigGroup configGroup(KConfig* config)

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi created this revision. crossi added a reviewer: ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. crossi requested review of this revision. REVISION SUMMARY Currently KConfgiSkeleton cannot manage item entry in subgroup. REPOSITORY R237

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

ervin added inline comments. INLINE COMMENTS > KConfigHeaderGenerator.cpp:267 > + > +for (const auto signal : qAsConst(parseResult.signalList)) { > +stream() << whitespace() << " " << signalEnumName(signal.name) << " > = 0x" << hexValue << val << ",\n"; You use "const Signal &" a

D26368: Add an isImmutable to know if a property is immutable

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH arcpatch-D26368 REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74749. gvgeo edited the test plan for this revision. gvgeo added a comment. This revision is now accepted and ready to land. The last index is incorrect, and I can't find a way to get the proper one. Restoring first revision, which keeps the functionality