D29050: KRunner fix prepare/teardown signals

[Kai Uwe Broulik]

broulik added a comment.


  I now have runner queries never "finish". I type "plasmashell", get the 
results I expect, and the busy indicator keeps spinning forever.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D29050

To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, 
ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29814: Fix segfault on no restart args

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R285 KCrash

BRANCH
  for-upstream

REVISION DETAIL
  https://phabricator.kde.org/D29814

To: jpalecek, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

[David Faure]

dfaure closed this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29814

To: jpalecek, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

[David Faure]

dfaure closed this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks, dfaure
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 07 Jun 2020 09:24:53 +
 Build duration:
15 sec and counting
   CONSOLE OUTPUT
  [...truncated 189 lines...][2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-06-07T09:25:05.900Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-06-07T09:25:05.900Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components: doxygen dot [2020-06-07T09:25:06.162Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2020-06-07T09:25:06.162Z] -- The following features have been enabled:[2020-06-07T09:25:06.162Z] [2020-06-07T09:25:06.163Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-06-07T09:25:06.163Z]  * Core Pattern Raising, Raising signals to kernel core patterns (iff the pattern is a process). You may wish to not install drkonqi if this can cause a UI conflict. [2020-06-07T09:25:06.163Z] [2020-06-07T09:25:06.163Z] -- The following OPTIONAL packages have been found:[2020-06-07T09:25:06.163Z] [2020-06-07T09:25:06.163Z]  * X11[2020-06-07T09:25:06.163Z] [2020-06-07T09:25:06.163Z] -- The following REQUIRED packages have been found:[2020-06-07T09:25:06.163Z] [2020-06-07T09:25:06.163Z]  * ECM (required version >= 5.71.0), Extra CMake Modules., [2020-06-07T09:25:06.163Z]  * Qt5 (required version >= 5.12.0)[2020-06-07T09:25:06.163Z]  * KF5CoreAddons (required version >= 5.71.0)[2020-06-07T09:25:06.163Z]  * Qt5Gui (required version >= 5.14.2)[2020-06-07T09:25:06.163Z]  * KF5WindowSystem (required version >= 5.71.0)[2020-06-07T09:25:06.163Z]  * Qt5X11Extras (required version >= 5.12.0)[2020-06-07T09:25:06.163Z]  * Doxygen (required version >= 1.8.13)[2020-06-07T09:25:06.163Z]Needed for API dox QCH file generation[2020-06-07T09:25:06.163Z]  * QHelpGenerator, Part of Qt5 tools[2020-06-07T09:25:06.163Z]Needed for API dox QCH file generation[2020-06-07T09:25:06.163Z]  * Qt5Core[2020-06-07T09:25:06.163Z]  * Qt5Widgets (required version >= 5.12.0)[2020-06-07T09:25:06.163Z] [2020-06-07T09:25:06.163Z] -- Configuring done[2020-06-07T09:25:06.163Z] -- Generating done[2020-06-07T09:25:06.163Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kcrash/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-06-07T09:25:06.820Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcrash --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-06-07T09:25:06.820Z] Scanning dependencies of target KF5Crash_autogen[2020-06-07T09:25:06.820Z] Scanning dependencies of target Qt5Core_QCH[2020-06-07T09:25:06.820Z] Scanning dependencies of target coreconfigtest_autogen[2020-06-07T09:25:06.820Z] [  5%] Automatic MOC for target coreconfigtest[2020-06-07T09:25:06.820Z] [ 11%] Automatic MOC for target KF5Crash[2020-06-07T09:25:06.820Z] [ 11%] Built target Qt5Core_QCH[2020-06-07T09:25:06.820Z] Scanning dependencies of target KF5Crash_QCH[2020-06-07T09:25:06.820Z] [ 16%] Generating src/KF5Crash.qch, src/KF5Crash.tags[2020-06-07T09:25:07.078Z] [ 16%] Built target KF5Crash_autogen[2020-06-07T09:25:07.078Z] Scanning dependencies of target KF5Crash[2020-06-07T09:25:07.078Z] [ 22%] Building CXX object src/CMakeFiles/KF5Crash.dir/KF5Crash_autogen/mocs_compilation.cpp.o[2020-06-07T09:25:07.078Z] [ 27%] Building CXX object src/CMakeFiles/KF5Crash.dir/coreconfig.cpp.o[2020-06-07T09:25:07.078Z] [ 33%] Building CXX object src/CMakeFiles/KF5Crash.dir/kcrash.cpp.o[2020-06-07T09:25:07.642Z] [ 33%] Built target coreconfigtest_autogen[2020-06-07T09:25:07.642Z] Scanning dependencies of target coreconfigtest[2020-06-07T09:25:07.642Z] [ 38%] Building CXX object autotests/CMakeFiles/coreconfigtest.dir/coreconfigtest.cpp.o[2020-06-07T09:25:07.642Z] [ 44%] Building CXX object autotests/CMakeFiles/coreconfigtest.dir/coreconfigtest_autogen/mocs_compilation.cpp.o[2020-06-07T09:25:07.642Z] Building up file structure...[2020-06-07T09:25:07.642Z] Insert custom filters...[2020-06-07T09:25:07.642Z] Insert help data for filter section (1 of 1)...[2020-06-07T09:25:07.642Z] Insert files...[2020-06-07T09:25:07.642Z] Insert contents...[2020-06-07T09:25:07.642Z] Insert indices...[2020-06-07T09:25:07.642Z] Documentation successfully generated.[2020-06-07T09:25:07.642Z] [ 44%] Built target KF5Crash_QCH[2020-06-07T09:25:08.208Z] /usr/home/j

D29810: Don't use the setenv function after fork

[David Faure]

dfaure added a comment.


  This breaks FreeBSD compilation. Please check: 
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks, dfaure
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

[Christoph Cullmann]

On 2020-05-25 16:34, Christoph Cullmann wrote:

On 2020-05-25 16:29, David Faure wrote:

Isn't this fixed by
https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911
?

(This fix happened because I reported this ktexteditor CI ASAN failure 
to

Simon Haussman, who fixed qtdeclarative)

IIUC all that's missing is a backport of the fix to 5.14.x, right?
I just left a note in the above gerrit MR to suggest such a backport.


See the comment there.

I think we should skip Qt 5.14 in the CI and just go to the "final"
Qt 5.15 release.

Would that be feasible?

Greetings
Christoph



Hi,

that could be, I did miss that report and did only find the one below.
(https://bugreports.qt.io/browse/QTBUG-84363)

From the backtrace, QTBUG-84363 looks a lot like our crash reports we 
got

in our bugs, too.

I have at the moment here no 5.15 compile/install to test that out.

Greetings
Christoph



Cheers,
David.

On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote:

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for
KTextEditor/Kate/KWrite/.

I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to 
investigate

that more.

Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>https://build.kde.org/job/Frameworks/job/ktexteditor/

job/kf5-qt5%20SUSEQ

>t5.14/19/>
> Project:
>kf5-qt5 SUSEQt5.14
>
> Date of build:
>Thu, 21 May 2020 10:51:54 +
>
> Build duration:
>17 min and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.71.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.71.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s),

Skipped: 0

>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59

test(s), Skipped: 0

>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s),

Passed: 5

>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>87% (260/298)
>87% (260/298)
>67% (32994/49195)
>49% (14791/30094)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4785/5127)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5526/5568)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1082/1472)
>
>src.completion
>100% (11/11)
>100% (11/11)
>57% (1785/3131)
>42% (1008/2423)
>
>src.completion.expandingtree
>100% (3/3)
>100% (3/3)
>40% (182/457)
>21% (73/340)
>
>src.dialogs
>0% (0/4)
>0% (0/4)
>0% (0/858)
>0% (0/180)
>
>src.document
>100% (4/4)
>100% (4/4)
>61% (1934/3176)
>48% (1417/2977)
>
>src.export
>0% (0/4)
>0% (0/4)
>0% (0/121)
>0% (0/156)
>
>src.include.ktexteditor
>93% (14/15)
>93% (14/15)
>84% (187/222)
>55% (125/226)
>
>src.inputmode
>100% (8/8)
>100% (8/8)
>63% (192/304)
>51% (39/77)
>
>src.mode
>88% (7/8)
>88% (7/8)
>36% (378/1050)
>16% (146/897)
>
>src.part
>0% (0/1)
>0% (0/1)
>0% (0/7)
>100% (0/0)
>
>src.printing
>0% (0/4)
>0% (0/4)
>0% (0/862)
>0% (0/278)
>
>src.render
>100% (7/7)
>100% (7/7)
>77% (949/1226)
> 

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/27/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 07 Jun 2020 13:29:24 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kdirwatch_stat_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D29810: Don't use the setenv function after fork

[Jiří Paleček]

jpalecek added a comment.


  In D29810#674815 , @dfaure wrote:
  
  > This breaks FreeBSD compilation. Please check: 
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/
  
  
  I see. It needs the declaration of `environ`, which is only provided on GNU. 
Should I amend it here?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks, dfaure
Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  In D28745#674711 , @meven wrote:
  
  >
  
  
  
  
  > Solid does not provide straight `folder => StorageVolume` yet, but I think 
Solid could have such a utility feature added.
  >  Something like `Solid::Device::findByPath()`, it would need to canonically 
and recursively resolves the path parent to pay attention to symlinks.
  >  This would also help D26407 
  
  No recursion needed, `stat` provides the device.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D29810: Don't use the setenv function after fork

[Ahmad Samir]

ahmadsamir added a comment.


  In D29810#674824 , @jpalecek wrote:
  
  > In D29810#674815 , @dfaure wrote:
  >
  > > This breaks FreeBSD compilation. Please check: 
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/
  >
  >
  > I see. It needs the declaration of `environ`, which is only provided on 
GNU. Should I amend it here?
  
  
  This has been committed already, create a new review request. (Note that KDE 
has moved to Gitlab at https://invent.kde.org, best if you create a merge 
request there; Phabricator still works, but it's planned to become read-only). 
:)

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D29810

To: jpalecek, #frameworks, dfaure
Cc: ahmadsamir, bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  And can you please use arc to upload the patch - it is nearly impossible to 
do a review with the missing context

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns requested changes to this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov

D29017: WIP: Introduce three new methods that return all "entries" in a folder

[Ahmad Samir]

ahmadsamir abandoned this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29017

To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

[Ahmad Samir]

ahmadsamir reopened this revision.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  Move to gitlab https://invent.kde.org/frameworks/kwallet/-/merge_requests/2

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29017

To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27034: Fix message box when passing a remote url that includes a file

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  This is wrong, isn't it? The logic was: if setDirectory is passed something 
that _isn't_ a directory, try to strip the filename.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27034

To: apol, #frameworks, ngraham
Cc: sandsmark, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » ki18n » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20FreeBSDQt5.14/12/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 07 Jun 2020 19:26:06 +
 Build duration:
42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.ki18n_klocalizedstringtest

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.14 - Build # 13 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.14/13/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sun, 07 Jun 2020 19:26:07 +
 Build duration:
2 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5I18n-5.71.0.xmlcompat_reports/KF5I18n_compat_report.htmllogs/KF5I18n/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.ki18n_klocalizedstringtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(17/17)100%
(17/17)66%
(1986/3022)46%
(882/1929)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)87%
(402/461)47%
(177/376)src100%
(12/12)100%
(12/12)62%
(1584/2561)45%
(705/1553)

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 96 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 07 Jun 2020 19:26:06 +
 Build duration:
2 min 5 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5I18n-5.71.0.xmlcompat_reports/KF5I18n_compat_report.htmllogs/KF5I18n/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.ki18n_klocalizedstringtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(17/17)100%
(17/17)66%
(1986/3022)46%
(882/1929)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(5/5)100%
(5/5)87%
(402/461)47%
(177/376)src100%
(12/12)100%
(12/12)62%
(1584/2561)45%
(705/1553)

D29525: Make Previews devicePixelRatio aware

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29525

REVISION DETAIL
  https://phabricator.kde.org/D29525

To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov

D29258: Don't use notifybysnore.h on MSYS2

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> CMakeLists.txt:75
>  if (WIN32)
> -find_package(LibSnoreToast REQUIRED)
> -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED

please maintain the REQUIRED call for normal Windows builds. 
You can use the OS specific build variables..

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29258

To: wojnilowicz, broulik, brute4s99, vonreth
Cc: vonreth, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Add loop device interface to Solid framework

[Kwon-Young Choi]

Hello,

I have recently made a plugin for dolphin to mount and unmount iso
files: https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/1

This plugin uses DBus calls to directly communicate with UDisks2 to
attach and detach a loop device backed by an iso file.
While writing the plugin, I used to Solid framework to do some hardware
query and realized that there was no concept of loop device in Solid.
I would like to know if there is interest to add a loop device interface
to Solid and the ability to attach and detach such device?

I'm starting to understand the architecture of Solid and I think I would
be able to add:

* an abstract Loop DeviceInterface
* a backend Loop DeviceInterface backed by UDisks2
* a frontend Loop DeviceInterface
* the ability for the DeviceManager to create a Loop DeviceInterface
(I'm not sure this is possible...)

However, I am not sure if this fit in the score of the Solid framework.

Thank you for your advice!

Kwon-Young Choi

D28745: Skip caching thumbnails on encrypted filesystems

[Méven Car]

meven added a comment.


  In D28745#674827 , @bruns wrote:
  
  > In D28745#674711 , @meven wrote:
  >
  > >
  >
  >
  >
  >
  > > Solid does not provide straight `folder => StorageVolume` yet, but I 
think Solid could have such a utility feature added.
  > >  Something like `Solid::Device::findByPath()`, it would need to 
canonically and recursively resolves the path parent to pay attention to 
symlinks.
  > >  This would also help D26407 
  >
  > No recursion needed, `stat` provides the device.
  
  
  Only when the file is not a symlink, if so we need to check the symlink 
target recursively, that's what I meant.
  
  > And can you please use arc to upload the patch - it is nearly impossible to 
do a review with the missing context
  
  Or pushing it to https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov