Re: KHTML Icons
On Monday 28 October 2013 19:20:36 David Edmundson wrote: KHtml tries to install icons in src/java/images and src/pics of the khtml src directory. As far as I can tell this has been broken throughout all of KDE4. kde4_install_icons simply ignores .xpm files, so they're just skipped. My main KDE4 install does not have these files. Given it's been broken for all of KDE4, rather than adding in support for something really legacy, can I just remove the folders? Fine by me. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/ --- (Updated Oct. 29, 2013, 8:03 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax Conversion was performed using a clang based tool I wrote (https://github.com/a-richardson/convert2qt5signalslot). Manual changes required were mostly reverting to the old syntax for Q_PRIVATE_SLOTS since not all of them use the _k_ function name prefix. Also one case where disconnect was used (kcursor.cpp). Command to perform this was: find tier1/kwidgetsaddons/ -iname *.cpp -print0 | xargs -0 convert2qt5signalslot -skip-prefix=_k_ -p ~/devel/build/kdelibsprint0 | xargs -0 convert2qt5signalslot -skip-prefix=_k_ -p ~/devel/build/kdelibs Diffs - tier1/kwidgetsaddons/src/kacceleratormanager.cpp f50057e8899b30ea2a5dfbe430e82a090299addb tier1/kwidgetsaddons/src/kactionmenu.cpp dd1dce144aa028af41fb073a5d3636f4c9e8901b tier1/kwidgetsaddons/src/kactionselector.cpp 879bb4918d85ee8360e72fab9b5750196c29ad6f tier1/kwidgetsaddons/src/kassistantdialog.cpp 81d3828e48df6e8e09f91ce8d2056cc8294411ea tier1/kwidgetsaddons/src/kcursor.cpp 9b0fe01358650a5a82cb9f9cd50edf9506034d4c tier1/kwidgetsaddons/src/keditlistwidget.cpp 23637a5b60f3582097fb136dfa9adedb44e157e9 tier1/kwidgetsaddons/src/kmessagebox.cpp 1fff72f1df4703b0893396c097b05ebefebbc362 tier1/kwidgetsaddons/src/kmessagewidget.cpp a4f9975297a0177dfd5bf50ee480b240d60c1d47 tier1/kwidgetsaddons/src/kpageview_p.cpp 4e236f11dea25e280f5b5bf0040424cdb5e934a6 tier1/kwidgetsaddons/src/kpagewidget.cpp 2931623c5a176f1013d5dc15e59df0c6a7a26fb7 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/src/kpassworddialog.cpp dfab3e9ead7d48b8941e4a44d17565c2ea7d4ddb tier1/kwidgetsaddons/src/kpixmapregionselectordialog.cpp 76a52b56190079510e99bd056f7602499f015399 tier1/kwidgetsaddons/src/kselectaction.cpp b388df94baa042e8230f2795f35dd378117c6ab6 tier1/kwidgetsaddons/src/ktoggleaction.cpp 79616dbb37a18b08e9f8a316489cbc8aed8242ba tier1/kwidgetsaddons/src/ktoolbarpopupaction.cpp af1fc2a9470444ba035d8babd9d6aad6a7c05e67 tier1/kwidgetsaddons/tests/kassistantdialogtest.cpp f6be3ef4376dff4f57ac62442e6c55e3a26e12ea tier1/kwidgetsaddons/tests/kcolorcombotest.cpp 825f3a8ab273cbb43c03001d9eb158ad9211e034 tier1/kwidgetsaddons/tests/keditlistwidgettest.cpp 0a0a46b3139eab6441e685e12bd86ec4c8ac5f54 tier1/kwidgetsaddons/tests/kledtest.cpp ee45ab3ab82129f03c8b4a3ce7bda69d0c060dc0 tier1/kwidgetsaddons/tests/kmessagewidgettest.cpp 2d8ab453ebaa736fa7dbf04b10d80ca89ca8bd1b tier1/kwidgetsaddons/tests/kpagewidgettest.cpp 3a10f73a8c481302863cbff52a17a56e167bc2f1 tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 tier1/kwidgetsaddons/tests/kselectactiontest.cpp f57f6c53098093d0056a1ba4ccfe9fb49338d186 tier1/kwidgetsaddons/tests/ktoolbarlabelactiontest.cpp 8e8cdf06cdaaa684f4659f63fec87d304837746a Diff: http://git.reviewboard.kde.org/r/112032/diff/ Testing --- Compiles and autotests work File Attachments Manual changes performed after tool run http://git.reviewboard.kde.org/media/uploaded/files/2013/08/12/manualChanges_1.diff Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112367: Include the icon's theme in the cache key
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- (Updated Oct. 29, 2013, 8:04 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs and Michael Pyne. Repository: kdelibs Description --- If we make no difference between an icon from oxygen and an icon from gnome, when we change themes for example from oxygen to gnome, the icon will be found in the cache and won't be upgraded. Diffs - kdeui/icons/kiconloader.cpp ce6aeea Diff: http://git.reviewboard.kde.org/r/112367/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113155: Port all kde4_add_unit_test uses
On Oct. 21, 2013, 11:23 a.m., Kevin Ottens wrote: Any chance to see Alexander comments addressed? Any news? Is it abandoned? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/#review42070 --- On Oct. 10, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 6:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113328: Fix standalone build of kdoctools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42576 --- Ship it! Ship It! - Kevin Ottens On Oct. 21, 2013, 1:32 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 21, 2013, 1:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - superbuild/CMakeLists.txt 5cdec94 tier2/kdoctools/CMakeLists.txt 53fd0e9 tier2/kdoctools/src/CMakeLists.txt 8b726a8 Diff: http://git.reviewboard.kde.org/r/113328/diff/ Testing --- Builds within kdelibs and using superbuild. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/#review42578 --- Wouldn't moving this class in KNotifications and from there use KWindowSystem be a better fix then? - Kevin Ottens On Oct. 22, 2013, 9:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/ --- (Updated Oct. 22, 2013, 9:21 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Get KPassivePopup positioning in a semi-working state Since we cannot use the NETWM stuff from KWindowSystems, we are forced to either rely on what Qt can give us or hack in window-system-specific code. This does the former, using QDesktopWidget to calculate the default placement of the popup, QWidget to place the popup next to our own windows and QWindow for foreign windows. Caveats: * the docs claim the popup will be placed next to taskbar entries; this is not possible using only what Qt gives us * Qt does not provide foreign window geometry on X11, so if you pass a foreign window id you will just get the default placement Diffs - tier1/kwidgetsaddons/CMakeLists.txt ea6654d83acb265a87ed21c913a7f799b457ca71 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 Diff: http://git.reviewboard.kde.org/r/113393/diff/ Testing --- Builds. Test application seems to work as expected (on X11, at least). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113398: Make KNotifications build standalone
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/#review42579 --- Ship it! Ship It! - Kevin Ottens On Oct. 23, 2013, 10:24 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/ --- (Updated Oct. 23, 2013, 10:24 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Was missing a call to find KWindowSystem Diffs - superbuild/CMakeLists.txt 5cdec94 tier2/knotifications/CMakeLists.txt 11f8aeb Diff: http://git.reviewboard.kde.org/r/113398/diff/ Testing --- Builds within kdelibs and standalone. Tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113399: Fix KAuthActionReply copy constructor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/#review42581 --- Ship it! Ship It! - Kevin Ottens On Oct. 23, 2013, 10:41 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/ --- (Updated Oct. 23, 2013, 10:41 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KAuthActionReply copy constructor It was intialising some fields from their own (uninitialised) values, instead of the values of the other object. Diffs - tier2/kauth/src/kauthactionreply.cpp 5a0032c3304fa3cea6a6f1316722ad513d1d5bb1 Diff: http://git.reviewboard.kde.org/r/113399/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/#review42582 --- Ship it! Ship It! - Kevin Ottens On Oct. 24, 2013, 9:54 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 24, 2013, 9:54 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: createNew method -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::createNew() and prefer newTheme() instead, as it appears in KEmoticonsTheme. That way, we have loadTheme(), saveTheme() and newTheme(). -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::createNew(), which was empty. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonsprovider.h 2ec0de8d1dfb846188bd458b49a4028fee115431 staging/kemoticons/src/core/kemoticonsprovider.cpp 7374966c65922c3e7a5be881c198a8f8f52fee29 staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 staging/kemoticons/src/core/kemoticonstheme.cpp e54d015e7f0f866d199d8eed7863fafd28576c13 staging/kemoticons/src/providers/adium/adium_emoticons.h 01d89e13834c345765e696d66560071dc10291af staging/kemoticons/src/providers/adium/adium_emoticons.cpp e6719d112a14478bdfd7f8c47633c18108a5633a staging/kemoticons/src/providers/kde/kde_emoticons.h 0738b79dcf734b7904e061b5eb41807ccaf443ff staging/kemoticons/src/providers/kde/kde_emoticons.cpp a99c6d84f5ab7e0e2f41027c37a97f170333dca8 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h a51b736f7702d7af1f1367dd1f13271647212fee staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 7596e30e8e5153185a3dd365858567c69477ff4a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 4ba706f519cebedaa6c9c3f2f02331e85745e89a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809 Diff: http://git.reviewboard.kde.org/r/113426/diff/ Testing --- Builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42583 --- Ship it! Looks good to me too. The owner id issue can be fixed later anyway so giving the ship it. - Kevin Ottens On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113436: Deprecate KEmoticonsTheme methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/#review42585 --- Ship it! Ship It! - Kevin Ottens On Oct. 25, 2013, 8:39 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- (Updated Oct. 25, 2013, 8:39 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Deprecate KEmoticonsTheme methods Before the initial cleanup, the loadTheme(), removeEmoticon() and addEmoticon methods of KEmoticonsTheme called the KEmoticonsProvider methods of the same name, which were either empty or useless. Now the KEmoticonsProvider methods are pure virtual and therefore those KEmoticonsTheme methods are deprecated and a subclassing of KEmoticonsProvider is advised. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 Diff: http://git.reviewboard.kde.org/r/113436/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113480: Move KnotifyConfig to tier 3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/#review42586 --- Ship it! Ship It! - Kevin Ottens On Oct. 28, 2013, 2:21 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/ --- (Updated Oct. 28, 2013, 2:21 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move KnotifyConfig to tier 3 Diffs - staging/CMakeLists.txt 8444b4c staging/knotifyconfig/CMakeLists.txt staging/knotifyconfig/KNotifyConfigConfig.cmake.in staging/knotifyconfig/src/CMakeLists.txt staging/knotifyconfig/src/knotify-config.h.cmake staging/knotifyconfig/src/knotifyconfigactionswidget.h staging/knotifyconfig/src/knotifyconfigactionswidget.cpp staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui staging/knotifyconfig/src/knotifyconfigelement.h staging/knotifyconfig/src/knotifyconfigelement.cpp staging/knotifyconfig/src/knotifyconfigwidget.h staging/knotifyconfig/src/knotifyconfigwidget.cpp staging/knotifyconfig/src/knotifyeventlist.h staging/knotifyconfig/src/knotifyeventlist.cpp staging/knotifyconfig/tests/CMakeLists.txt staging/knotifyconfig/tests/knotifytest.notifyrc staging/knotifyconfig/tests/knotifytestui.rc staging/knotifyconfig/tests/knotifytestview.ui staging/knotifyconfig/tests/knotifytestwindow.h staging/knotifyconfig/tests/knotifytestwindow.cpp staging/knotifyconfig/tests/main.cpp tier3/CMakeLists.txt 2ad3f61 Diff: http://git.reviewboard.kde.org/r/113480/diff/ Testing --- Went through checklist. Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/#review42587 --- Ship it! Looks fine to me and is aligned with prior discussions. - Kevin Ottens On Oct. 28, 2013, 6:26 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/ --- (Updated Oct. 28, 2013, 6:26 p.m.) Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Copy KDE4 macro to install all icons in the current source dir Diffs - modules/ECMInstallIcons.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113483/diff/ Testing --- Tried using it from within khtml. It all compiled successfully however I could not test icon installation as khtml was already broken (see other email to KF ML) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/#review42589 --- This review has been submitted with commit 4be8dbfedb9d8865730cd72c68409d8342296e47 by David Edmundson to branch master. - Commit Hook On Oct. 28, 2013, 6:26 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/ --- (Updated Oct. 28, 2013, 6:26 p.m.) Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Copy KDE4 macro to install all icons in the current source dir Diffs - modules/ECMInstallIcons.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113483/diff/ Testing --- Tried using it from within khtml. It all compiled successfully however I could not test icon installation as khtml was already broken (see other email to KF ML) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/ --- (Updated Oct. 29, 2013, 8:28 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Copy KDE4 macro to install all icons in the current source dir Diffs - modules/ECMInstallIcons.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113483/diff/ Testing --- Tried using it from within khtml. It all compiled successfully however I could not test icon installation as khtml was already broken (see other email to KF ML) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 32 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32 I recommend not putting this in the API of the function, and instead users should use install(DIRECTORY) to install the generated files. Aleix Pol Gonzalez wrote: Why? Stephen Kelly wrote: I think it's better API. It's what all existing functions which generate headers do. Aleix Pol Gonzalez wrote: Then it's weird because we'll need to have a separate call for installing all the headers as well, so we will have them all listed twice. Stephen Kelly wrote: Are you sure? You wouldn't just have a single install(DIRECTORY), as I wrote before? See the KParts patch I attached. We want to install the actual header, not the forward header, right? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- On Oct. 29, 2013, 12:32 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:32 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments example of how KParts would change http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113155: Port all kde4_add_unit_test uses
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 29, 2013, 8:46 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- Stop using kde4_add_unit_test. One step less towards no kde4_* uses. Diffs - kded/tests/CMakeLists.txt ca392d2 kfile/tests/CMakeLists.txt d28d642 khtml/tests/CMakeLists.txt 59a0a56 kio/tests/CMakeLists.txt a60eac0 kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 kioslave/http/tests/CMakeLists.txt 000c488 Diff: http://git.reviewboard.kde.org/r/113155/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113399: Fix KAuthActionReply copy constructor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/#review42592 --- This review has been submitted with commit a49f9e12cae8e576ec80ea77145f44cfff9527dd by Alex Merry to branch frameworks. - Commit Hook On Oct. 23, 2013, 10:41 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/ --- (Updated Oct. 23, 2013, 10:41 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KAuthActionReply copy constructor It was intialising some fields from their own (uninitialised) values, instead of the values of the other object. Diffs - tier2/kauth/src/kauthactionreply.cpp 5a0032c3304fa3cea6a6f1316722ad513d1d5bb1 Diff: http://git.reviewboard.kde.org/r/113399/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113399: Fix KAuthActionReply copy constructor
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/ --- (Updated Oct. 29, 2013, 8:52 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KAuthActionReply copy constructor It was intialising some fields from their own (uninitialised) values, instead of the values of the other object. Diffs - tier2/kauth/src/kauthactionreply.cpp 5a0032c3304fa3cea6a6f1316722ad513d1d5bb1 Diff: http://git.reviewboard.kde.org/r/113399/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42593 --- This review has been submitted with commit 2e3cf98a87484946948962acd66a5fff269b5a51 by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 25, 2013, 2:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42594 --- This review has been submitted with commit df8269544cafbe4a31b81b990ae0f4d3b50707d5 by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 25, 2013, 2:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42595 --- This review has been submitted with commit 339363c4ef02f1f64fe39218537d3b179bdd8fdd by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 25, 2013, 2:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42597 --- This review has been submitted with commit f2359ab49fa3311f36a6898f55d0d122c2018240 by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 25, 2013, 2:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113430: More warnings fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42596 --- This review has been submitted with commit 73048bfeb8df80146975561c9100d40ccd13cd1d by Alex Merry to branch frameworks. - Commit Hook On Oct. 25, 2013, 2:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 25, 2013, 2:08 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a series of commits: warnings--: parentheses around '' within '||' Fix a couple of warnings inadventently caused by 139a09da Use a better hack for dealing with gperf's unhelpful inlining gperf (in ANSI-C mode) attempts to inline functions in gnu90 mode, which *only* generates inline versions. This causes linker errors if the compiler decides not to use inlining. Previously, there was a hack (claiming to prevent warnings) that disabled __inline keyword, which fixed the linking issue but caused another warning (about ignored attributes) to be emitted because the __gnu_inline__ attribute was still there, and that doesn't work without one of the normal inline keywords. This version leaves __inline alone, but prevents the use of __gnu_inline__. Use KHTML_NO_EXPORT on the decl (not def) of tagPriorityArray Visibility attributes only work on declarations, not on definitions. Remove virtual modifier from signal A virtual signal makes no sense. Diffs - khtml/src/html/dtd.cpp 9cfa345af618861a9b8ddf9a93dd180c9a15c6d7 khtml/src/html/dtd.h 1e04e58b356c5d0ece23f8fc78cffdc6cf64817c khtml/src/css/parser.y e24d5f46e27c686fa855feee27dbe2dbf39108cb khtml/src/html/htmlparser.cpp 6c23dd5b5a2a1e567adc8cfa0233e10838cf3451 khtml/src/rendering/render_canvasimage.cpp 346a65491e459c3d8f1c731340ff5a6ae33b35f1 khtml/src/rendering/render_inline.cpp 84e07eab5604e4882fd816826b6e59c317c53805 tier1/itemmodels/src/kselectionproxymodel.cpp c7ded3f8c54eba0afa1974ddb67972eddf7d7f1a tier1/solid/src/solid/backends/udev/udevbutton.h 39eb6683fc611dfff5b6fef69e66ab709238e889 Diff: http://git.reviewboard.kde.org/r/113430/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state
On Oct. 29, 2013, 8:09 a.m., Kevin Ottens wrote: Wouldn't moving this class in KNotifications and from there use KWindowSystem be a better fix then? That would certainly be the easiest way to get a correct implementation, and it would fit conceptually. The only downside I see is that KPassivePopup acts as a kind of lightweight notification mechanism: putting it in KNotifications would prevent anyone from getting the lightweight KPassivePopup without also getting the heavyweight knotification system. Either way, I think these changes should be useful for non-X11 systems. But I can do them as part of a move to knotifications an implement properly thing as well. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/#review42578 --- On Oct. 22, 2013, 9:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/ --- (Updated Oct. 22, 2013, 9:21 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Get KPassivePopup positioning in a semi-working state Since we cannot use the NETWM stuff from KWindowSystems, we are forced to either rely on what Qt can give us or hack in window-system-specific code. This does the former, using QDesktopWidget to calculate the default placement of the popup, QWidget to place the popup next to our own windows and QWindow for foreign windows. Caveats: * the docs claim the popup will be placed next to taskbar entries; this is not possible using only what Qt gives us * Qt does not provide foreign window geometry on X11, so if you pass a foreign window id you will just get the default placement Diffs - tier1/kwidgetsaddons/CMakeLists.txt ea6654d83acb265a87ed21c913a7f799b457ca71 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 Diff: http://git.reviewboard.kde.org/r/113393/diff/ Testing --- Builds. Test application seems to work as expected (on X11, at least). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts ? It
contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking me.
Yes, you want to install the actual headers.
- Stephen
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 12:32 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 12:32 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
example of how KParts would change
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113480: Move KnotifyConfig to tier 3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/ --- (Updated Oct. 29, 2013, 9:44 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Move KnotifyConfig to tier 3 Diffs - staging/CMakeLists.txt 8444b4c staging/knotifyconfig/CMakeLists.txt staging/knotifyconfig/KNotifyConfigConfig.cmake.in staging/knotifyconfig/src/CMakeLists.txt staging/knotifyconfig/src/knotify-config.h.cmake staging/knotifyconfig/src/knotifyconfigactionswidget.h staging/knotifyconfig/src/knotifyconfigactionswidget.cpp staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui staging/knotifyconfig/src/knotifyconfigelement.h staging/knotifyconfig/src/knotifyconfigelement.cpp staging/knotifyconfig/src/knotifyconfigwidget.h staging/knotifyconfig/src/knotifyconfigwidget.cpp staging/knotifyconfig/src/knotifyeventlist.h staging/knotifyconfig/src/knotifyeventlist.cpp staging/knotifyconfig/tests/CMakeLists.txt staging/knotifyconfig/tests/knotifytest.notifyrc staging/knotifyconfig/tests/knotifytestui.rc staging/knotifyconfig/tests/knotifytestview.ui staging/knotifyconfig/tests/knotifytestwindow.h staging/knotifyconfig/tests/knotifytestwindow.cpp staging/knotifyconfig/tests/main.cpp tier3/CMakeLists.txt 2ad3f61 Diff: http://git.reviewboard.kde.org/r/113480/diff/ Testing --- Went through checklist. Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113480: Move KnotifyConfig to tier 3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/#review42602 --- This review has been submitted with commit 0689af56dca6b57c580e51f8ef6a9aa3f1fcda98 by David Edmundson to branch frameworks. - Commit Hook On Oct. 28, 2013, 2:21 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/ --- (Updated Oct. 28, 2013, 2:21 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move KnotifyConfig to tier 3 Diffs - staging/CMakeLists.txt 8444b4c staging/knotifyconfig/CMakeLists.txt staging/knotifyconfig/KNotifyConfigConfig.cmake.in staging/knotifyconfig/src/CMakeLists.txt staging/knotifyconfig/src/knotify-config.h.cmake staging/knotifyconfig/src/knotifyconfigactionswidget.h staging/knotifyconfig/src/knotifyconfigactionswidget.cpp staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui staging/knotifyconfig/src/knotifyconfigelement.h staging/knotifyconfig/src/knotifyconfigelement.cpp staging/knotifyconfig/src/knotifyconfigwidget.h staging/knotifyconfig/src/knotifyconfigwidget.cpp staging/knotifyconfig/src/knotifyeventlist.h staging/knotifyconfig/src/knotifyeventlist.cpp staging/knotifyconfig/tests/CMakeLists.txt staging/knotifyconfig/tests/knotifytest.notifyrc staging/knotifyconfig/tests/knotifytestui.rc staging/knotifyconfig/tests/knotifytestview.ui staging/knotifyconfig/tests/knotifytestwindow.h staging/knotifyconfig/tests/knotifytestwindow.cpp staging/knotifyconfig/tests/main.cpp tier3/CMakeLists.txt 2ad3f61 Diff: http://git.reviewboard.kde.org/r/113480/diff/ Testing --- Went through checklist. Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state
On Oct. 29, 2013, 8:09 a.m., Kevin Ottens wrote: Wouldn't moving this class in KNotifications and from there use KWindowSystem be a better fix then? Alex Merry wrote: That would certainly be the easiest way to get a correct implementation, and it would fit conceptually. The only downside I see is that KPassivePopup acts as a kind of lightweight notification mechanism: putting it in KNotifications would prevent anyone from getting the lightweight KPassivePopup without also getting the heavyweight knotification system. Either way, I think these changes should be useful for non-X11 systems. But I can do them as part of a move to knotifications an implement properly thing as well. I agree with your downside, still probably makes more sense. Please work on a move to knotifications an implement properly then. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/#review42578 --- On Oct. 22, 2013, 9:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/ --- (Updated Oct. 22, 2013, 9:21 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Get KPassivePopup positioning in a semi-working state Since we cannot use the NETWM stuff from KWindowSystems, we are forced to either rely on what Qt can give us or hack in window-system-specific code. This does the former, using QDesktopWidget to calculate the default placement of the popup, QWidget to place the popup next to our own windows and QWindow for foreign windows. Caveats: * the docs claim the popup will be placed next to taskbar entries; this is not possible using only what Qt gives us * Qt does not provide foreign window geometry on X11, so if you pass a foreign window id you will just get the default placement Diffs - tier1/kwidgetsaddons/CMakeLists.txt ea6654d83acb265a87ed21c913a7f799b457ca71 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 Diff: http://git.reviewboard.kde.org/r/113393/diff/ Testing --- Builds. Test application seems to work as expected (on X11, at least). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 10:52 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Changes --- updated example Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments (updated) kparts changes example http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Stephen Kelly wrote:
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts
? It contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking
me. Yes, you want to install the actual headers.
Yes, so we can install the headers either from the macro or from the
CMakeLists.txt. If we do it from the CMakeLists.txt files, we'll end up having
to list the headers twice.
See updated diff.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 10:52 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Stephen Kelly wrote:
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts
? It contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking
me. Yes, you want to install the actual headers.
Aleix Pol Gonzalez wrote:
Yes, so we can install the headers either from the macro or from the
CMakeLists.txt. If we do it from the CMakeLists.txt files, we'll end up
having to list the headers twice.
See updated diff.
You can also populate an out-list. See for example what QT4_EXTRACT_OPTIONS
does with _qt4_files.
- Stephen
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 10:52 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Undefined reference to udevqt::*
Hello. I've been trying to compile the Frameworks using kdesrc-build for ~a week, but everytime it fails because it cannot ld to UdevQt::somestuff[1]. I tried to cleanly build everything several times with no success. It could be a problem with my env vars[2], but I did just what I was told by the wiki[3], so I don't know what could possibly go wrong here. Maybe I'm missing something stupid? Anyway, I'm running Fedora 19 with everything up to date, if that matters. Thanks in advance. [1] [ 47%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/kpassworddialogtest.dir/kpassworddialogtest_automoc.cpp.o Linking CXX executable kpassworddialogtest CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o: In function `Solid::Backends::UDisks2::OpticalDisc::OpticalDisc(Solid::Backends::UDisks2::Device*)': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:334: undefined reference to `UdevQt::Device::Device()' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:336: undefined reference to `UdevQt::Client::Client(QObject*)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Client::deviceByDeviceFile(QString const)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Device::operator=(UdevQt::Device const)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Device::~Device()' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:339: undefined reference to `UdevQt::Device::deviceProperties() const' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:341: undefined reference to `UdevQt::Client::~Client()' CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o: In function `Solid::Backends::UDisks2::OpticalDisc::OpticalDisc(Solid::Backends::UDisks2::Device*)': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:334: undefined reference to `UdevQt::Device::Device()' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:336: undefined reference to `UdevQt::Client::Client(QObject*)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Client::deviceByDeviceFile(QString const)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Device::operator=(UdevQt::Device const)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:337: undefined reference to `UdevQt::Device::~Device()' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:339: undefined reference to `UdevQt::Device::deviceProperties() const' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:341: undefined reference to `UdevQt::Client::~Client()' CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o: In function `Solid::Backends::UDisks2::OpticalDisc::~OpticalDisc()': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:344: undefined reference to `UdevQt::Device::~Device()' CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o: In function `Solid::Backends::UDisks2::OpticalDisc::~OpticalDisc()': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:344: undefined reference to `UdevQt::Device::~Device()' CMakeFiles/Solid.dir/backends/udisks2/udisksopticaldisc.cpp.o: In function `Solid::Backends::UDisks2::OpticalDisc::isAppendable() const': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp:371: undefined reference to `UdevQt::Device::deviceProperty(QString const) const' CMakeFiles/Solid.dir/backends/udisks2/udisksstoragedrive.cpp.o: In function `Solid::Backends::UDisks2::StorageDrive::StorageDrive(Solid::Backends::UDisks2::Device*)': /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksstoragedrive.cpp:32: undefined reference to `UdevQt::Device::Device()' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksstoragedrive.cpp:34: undefined reference to `UdevQt::Client::Client(QObject*)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksstoragedrive.cpp:35: undefined reference to `UdevQt::Client::deviceByDeviceFile(QString const)' /home/kf5/kf5-src/kdelibs-frameworks/tier1/solid/src/solid/backends/udisks2/udisksstoragedrive.cpp:35: undefined reference to `UdevQt::Device::operator=(UdevQt::Device
Re: Review Request 113371: Kross: Remove the KJs backened
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/ --- (Updated Oct. 29, 2013, 11:13 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Kross: Remove the KJs backened The unit tests currently segfault, and according to the maintainer (Sebastian Sauer) the kjs backend never reached a quality state and should be removed. Diffs - staging/kross/Mainpage.dox c17e1a2 staging/kross/autotests/CMakeLists.txt c5b4a05 staging/kross/autotests/testkross.js e8e7729 staging/kross/autotests/unittest.js 0d7b141 staging/kross/src/CMakeLists.txt 0279846 staging/kross/src/core/action.h e818a51 staging/kross/src/core/interpreter.h d8b1168 staging/kross/src/core/interpreter.cpp 937ca60 staging/kross/src/core/krossconfig.h 0243a53 staging/kross/src/core/manager.h 982817b staging/kross/src/core/manager.cpp 88e312d staging/kross/src/kjs/CMakeLists.txt 32ba00b staging/kross/src/kjs/kjsinterpreter.h be2d61a staging/kross/src/kjs/kjsinterpreter.cpp d89e42b staging/kross/src/kjs/kjsscript.h f760327 staging/kross/src/kjs/kjsscript.cpp 541caf2 Diff: http://git.reviewboard.kde.org/r/113371/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113371: Kross: Remove the KJs backened
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/#review42618 --- This review has been submitted with commit 636c8c614bca05d05a38f75158c70fab05532897 by Vishesh Handa to branch frameworks. - Commit Hook On Oct. 21, 2013, 4:03 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/ --- (Updated Oct. 21, 2013, 4:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Kross: Remove the KJs backened The unit tests currently segfault, and according to the maintainer (Sebastian Sauer) the kjs backend never reached a quality state and should be removed. Diffs - staging/kross/Mainpage.dox c17e1a2 staging/kross/autotests/CMakeLists.txt c5b4a05 staging/kross/autotests/testkross.js e8e7729 staging/kross/autotests/unittest.js 0d7b141 staging/kross/src/CMakeLists.txt 0279846 staging/kross/src/core/action.h e818a51 staging/kross/src/core/interpreter.h d8b1168 staging/kross/src/core/interpreter.cpp 937ca60 staging/kross/src/core/krossconfig.h 0243a53 staging/kross/src/core/manager.h 982817b staging/kross/src/core/manager.cpp 88e312d staging/kross/src/kjs/CMakeLists.txt 32ba00b staging/kross/src/kjs/kjsinterpreter.h be2d61a staging/kross/src/kjs/kjsinterpreter.cpp d89e42b staging/kross/src/kjs/kjsscript.h f760327 staging/kross/src/kjs/kjsscript.cpp 541caf2 Diff: http://git.reviewboard.kde.org/r/113371/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote:
modules/ECMGenerateHeaders.cmake, line 32
http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32
I recommend not putting this in the API of the function, and instead
users should use
install(DIRECTORY) to install the generated files.
Aleix Pol Gonzalez wrote:
Why?
Stephen Kelly wrote:
I think it's better API. It's what all existing functions which generate
headers do.
Aleix Pol Gonzalez wrote:
Then it's weird because we'll need to have a separate call for installing
all the headers as well, so we will have them all listed twice.
Stephen Kelly wrote:
Are you sure? You wouldn't just have a single install(DIRECTORY), as I
wrote before?
Aleix Pol Gonzalez wrote:
See the KParts patch I attached. We want to install the actual header,
not the forward header, right?
Stephen Kelly wrote:
Your kparts patch contains this:
+#still need to see what to do with these...
+# install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/kparts DESTINATION
${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Why would you install the contents of ${CMAKE_CURRENT_BINARY_DIR}/kparts
? It contains hardcoded source dir paths. They don't need to though. If
srcdir/part.h exists, then write include 'part.h' to that file, not
'srcdir/part.h'. The source dir is already part of the -I passed to the
compiler (recall that I wrote before I think that because the source dir is
already in the INTERFACE_INCLUDE_DIRECTORIES of the target), so no need to
hardcode it at all.
Actually reading your message again, I think that's what you are asking
me. Yes, you want to install the actual headers.
Aleix Pol Gonzalez wrote:
Yes, so we can install the headers either from the macro or from the
CMakeLists.txt. If we do it from the CMakeLists.txt files, we'll end up
having to list the headers twice.
See updated diff.
Stephen Kelly wrote:
You can also populate an out-list. See for example what
QT4_EXTRACT_OPTIONS does with _qt4_files.
I prefer installing from the macro than having an output list.
The macro can be used to standardize the installation of headers, whereas if
we're returning a list we can barely help developers.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
---
On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
---
(Updated Oct. 29, 2013, 10:52 a.m.)
Review request for Build System, KDE Frameworks and Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Create a macro that will generate the forward headers like we used to, in
cmake configure time.
Here's an example of how we'd port KParts to that macro:
http://paste.opensuse.org/9880051
After the change, these are the installed headers:
http://paste.opensuse.org/90980400
Diffs
-
modules/ECMGenerateHeaders.cmake PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113406/diff/
Testing
---
Ported KParts and still everything works.
File Attachments
kparts changes example
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113496: Move Kross from staging to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Move Kross from staging to tier3. Diffs - staging/CMakeLists.txt 808ee92 staging/kross/CMakeLists.txt staging/kross/KrossConfig.cmake.in staging/kross/Mainpage.dox staging/kross/autotests/CMakeLists.txt staging/kross/autotests/main.cpp staging/kross/autotests/profile.py staging/kross/autotests/testguiform.py staging/kross/autotests/testguiform.rb staging/kross/autotests/testguiform.ui staging/kross/autotests/testguiqt.py staging/kross/autotests/testguiqt.rb staging/kross/autotests/testguitk.py staging/kross/autotests/testkross.py staging/kross/autotests/testobject.h staging/kross/autotests/testobject.cpp staging/kross/autotests/unittest.es staging/kross/autotests/unittest.py staging/kross/autotests/unittest.rb staging/kross/docs/CHANGES staging/kross/src/CMakeLists.txt staging/kross/src/console/CMakeLists.txt staging/kross/src/console/main.cpp staging/kross/src/core/CMakeLists.txt staging/kross/src/core/action.h staging/kross/src/core/action.cpp staging/kross/src/core/actioncollection.h staging/kross/src/core/actioncollection.cpp staging/kross/src/core/childreninterface.h staging/kross/src/core/errorinterface.h staging/kross/src/core/interpreter.h staging/kross/src/core/interpreter.cpp staging/kross/src/core/krossconfig.h staging/kross/src/core/krossconfig.cpp staging/kross/src/core/manager.h staging/kross/src/core/manager.cpp staging/kross/src/core/metafunction.h staging/kross/src/core/metatype.h staging/kross/src/core/object.h staging/kross/src/core/object.cpp staging/kross/src/core/script.h staging/kross/src/core/script.cpp staging/kross/src/core/wrapperinterface.h staging/kross/src/modules/CMakeLists.txt staging/kross/src/modules/form.h staging/kross/src/modules/form.cpp staging/kross/src/modules/translation.h staging/kross/src/modules/translation.cpp staging/kross/src/qts/CMakeLists.txt staging/kross/src/qts/interpreter.h staging/kross/src/qts/interpreter.cpp staging/kross/src/qts/main.cpp staging/kross/src/qts/plugin.h staging/kross/src/qts/plugin.cpp staging/kross/src/qts/script.h staging/kross/src/qts/script.cpp staging/kross/src/qts/test.es staging/kross/src/qts/values_p.h staging/kross/src/ui/CMakeLists.txt staging/kross/src/ui/model.h staging/kross/src/ui/model.cpp staging/kross/src/ui/plugin.h staging/kross/src/ui/plugin.cpp staging/kross/src/ui/view.h staging/kross/src/ui/view.cpp tier3/CMakeLists.txt 249a60b Diff: http://git.reviewboard.kde.org/r/113496/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113497: Install kiofilewidgets_export.h in /kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Install kiofilewidgets_export.h in /kio Many files in there do #include kio/kiofilewidgets_export.h This fixes build of kde-workspace. Diffs - staging/kio/src/filewidgets/CMakeLists.txt fee8bed Diff: http://git.reviewboard.kde.org/r/113497/diff/ Testing --- kdelibs and kde-workspace build. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113497: Install kiofilewidgets_export.h in /kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/#review42628 --- This fixes the kde-workspace build for me, which has been otherwise broken since last week. If it's a correct solution expediting the review of this would be lovely :). - Eike Hein On Oct. 29, 2013, 12:24 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- (Updated Oct. 29, 2013, 12:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Install kiofilewidgets_export.h in /kio Many files in there do #include kio/kiofilewidgets_export.h This fixes build of kde-workspace. Diffs - staging/kio/src/filewidgets/CMakeLists.txt fee8bed Diff: http://git.reviewboard.kde.org/r/113497/diff/ Testing --- kdelibs and kde-workspace build. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 29, 2013, 12:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113395: Enable KConfig on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42630 --- This review has been submitted with commit e91aa4ba3e6e5f3ca934f648197f513b6ccec0cd by Alex Richardson on behalf of Alexander Richardson to branch frameworks. - Commit Hook On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 23, 2013, 12:03 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- KConfig now also compiles on Windows the qt3support function QDir::convertSeparators no longer exists remove dependency on unistd.h on Windows fix linking of KSharedConfig on MSVC2012 Without disabling the copy constructor we get an undefined referece to KConfig::KConfig(const KConfig) Diffs - tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f tier1/kconfig/autotests/kconfigtest.cpp 022809e9b9ec700206d472ed4cfa5ed82058bc34 tier1/kconfig/src/core/kauthorized.cpp c814b729dc9b6e9efd9b3922fa02249abf460989 tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 tier1/kconfig/src/core/kconfiggroup.cpp b42ca12e02af1cf173cee97d338cc895b4c822ed tier1/kconfig/src/core/kconfigini.cpp 5a7702a76f70d97fe48de8bb16f2a052e993d907 tier1/kconfig/src/core/kdesktopfile.cpp 7518994ac7a72dc782d9df394e5b466a0cbac5fc tier1/kconfig/src/core/ksharedconfig.h b461999b29a6c966c6a8734b316dbbee11ecdc6c Diff: http://git.reviewboard.kde.org/r/113395/diff/ Testing --- This is a series of 4 small commits as one patch. I can squash them into one commit if that is preferred. Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate the tests I had to add the Qt 5.2 beta binaries dir to PATH since that contains QtCore.dll, etc. Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the necessary libraries are not found. I see two possible solutions: -CMake sets $PATH to include the needed libraries (have to make sure the newly compiled ones are before the installed ones) -A wrapper executable sets the DLL search paths and then launches the tests I don't have the time to solve that problem now, if anyone does: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113370: move KDED to Tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/ --- (Updated Oct. 29, 2013, 1:10 p.m.) Review request for KDE Frameworks. Changes --- Only the kcookiejar issue is left to be fixed, otherwise kded should be Framework policy compilant Repository: kdelibs Description --- Moves KDED to tier3. I have removed any use of X11/Properties used to communicate with KSplash since we want to use either DBus or Wayland but certainly not X11. I plan to work on session startup in a few weeks so I will fix (if nobody else does before me) KSplash --- KDED communication by then. Diffs (updated) - CMakeLists.txt 6afb8e6 kded/CMakeLists.txt a06ed09 kded/DESIGN kded/HOWTO kded/Info.plist.template kded/Mainpage.dox kded/README.kded 05fec85 kded/config-kded.h.cmake 21210ab kded/kded.h kded/kded.cpp aab548b kded/kdedadaptor.h kded/kdedadaptor.cpp kded/kdedmodule.desktop kded/org.kde.kded5.service.in kioslave/http/kcookiejar/CMakeLists.txt 8d61c01 tier3/CMakeLists.txt 249a60b tier3/kded/CMakeLists.txt PRE-CREATION tier3/kded/KDEDConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113370/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113328: Fix standalone build of kdoctools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 29, 2013, 1:12 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - superbuild/CMakeLists.txt 5cdec94 tier2/kdoctools/CMakeLists.txt 53fd0e9 tier2/kdoctools/src/CMakeLists.txt 8b726a8 Diff: http://git.reviewboard.kde.org/r/113328/diff/ Testing --- Builds within kdelibs and using superbuild. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113328: Fix standalone build of kdoctools
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42632 --- This review has been submitted with commit 7582c2b341c97362aab0b8f832d1fe7c0836aeb6 by Aurélien Gâteau to branch frameworks. - Commit Hook On Oct. 21, 2013, 1:32 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 21, 2013, 1:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kdoctools: it was not looking for KArchive. This patch also aligns the top-level CMakeLists.txt with template/CMakeLists.txt. Diffs - superbuild/CMakeLists.txt 5cdec94 tier2/kdoctools/CMakeLists.txt 53fd0e9 tier2/kdoctools/src/CMakeLists.txt 8b726a8 Diff: http://git.reviewboard.kde.org/r/113328/diff/ Testing --- Builds within kdelibs and using superbuild. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113497: Install kiofilewidgets_export.h in /kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- (Updated Oct. 29, 2013, 1:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Install kiofilewidgets_export.h in /kio Many files in there do #include kio/kiofilewidgets_export.h This fixes build of kde-workspace. Diffs - staging/kio/src/filewidgets/CMakeLists.txt fee8bed Diff: http://git.reviewboard.kde.org/r/113497/diff/ Testing --- kdelibs and kde-workspace build. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113497: Install kiofilewidgets_export.h in /kio
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/#review42633 --- This review has been submitted with commit b3f1919205946fc72de055432f8a77516b0713fe by Aurélien Gâteau to branch frameworks. - Commit Hook On Oct. 29, 2013, 12:24 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- (Updated Oct. 29, 2013, 12:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Install kiofilewidgets_export.h in /kio Many files in there do #include kio/kiofilewidgets_export.h This fixes build of kde-workspace. Diffs - staging/kio/src/filewidgets/CMakeLists.txt fee8bed Diff: http://git.reviewboard.kde.org/r/113497/diff/ Testing --- kdelibs and kde-workspace build. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1531
See http://build.kde.org/job/kdelibs_frameworks_qt5/1531/changes Changes: [kde] KTHML: Remove unused icons -- [...truncated 8693 lines...] Building CXX object khtml/src/CMakeFiles/KHtml.dir/JSHTMLVideoElement.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/xmlhttprequest.cpp.o [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/xmlserializer.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/domparser.cpp.o [ 93%] [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_context2d.cpp.o [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_audio.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_xpath.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_scriptable.cpp.o [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_data.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_arraybuffer.cpp.o [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_arraybufferview.cpp.o [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_arraytyped.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/ecma/kjs_clientrect.cpp.o [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_misc.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_block.cpp.o [ 93%] [ 93%] In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/src/css/parser.cpp:133:0: cssproperties.gperf:167:62: warning: ‘__gnu_inline__’ attribute ignored [-Wattributes] In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/src/css/parser.cpp:134:0: cssvalues.gperf:152:63: warning: ‘__gnu_inline__’ attribute ignored [-Wattributes] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_inline.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/css_rule.cpp.o [ 93%] [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_node.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_document.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_list.cpp.o [ 93%] [ 93%] [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/css_stylesheet.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_string.cpp.o [ 93%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_element.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_misc.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/css_value.cpp.o [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_text.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_object.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_doc.cpp.o [ 94%] [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_xml.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_head.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_base.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom_element.cpp.o [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_image.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_form.cpp.o [ 94%] [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom2_range.cpp.o [ 94%] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/src/dom/dom_element.cpp: In static member function ‘static bool DOM::Element::khtmlMalformedQualifiedName(const DOM::DOMString)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/src/dom/dom_element.cpp:431:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/html_table.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom2_traversal.cpp.o [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom2_events.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom2_views.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/QualifiedName.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/dom/dom3_xpath.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/imageplane.cpp.o [ 94%] [ 94%] [ 94%] [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/rawimageplane.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/scaledimageplane.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/pixmapplane.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/animprovider.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/imagepainter.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/updater.cpp.o Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/image.cpp.o [ 94%] Building CXX object khtml/src/CMakeFiles/KHtml.dir/imload/imagemanager.cpp.o [ 94%] [ 94%] [ 94%] [ 94%]
Using KSSLSettings from KHTML
Currently KHTMLPart uses KSSLSettings from KIOCore It uses the methods: warnOnUnencrypted setWarnOnUnencrypted This class does not have the header exported in KIOCore, so whilst it builds now it will fail when we split. The CMakeLists.txt file of KIOCore has a comment kssl/ksslsettings.cpp # temporary (used by tcpslavebase) which implies there's a plan to remove it? I assume it's being replaced by qsslconfiguration, but this doesn't cover this particular function. How should I proceed? My options are: - install ksslsettings.h in kiocore - move this method into a different SSL part of KIOCore that is exposed such as ksslcertmanager. - replace the code in khtml with kconfig, load the same file and read/set the value - just delete the bit of code in khtmlpart. It can't be a big feature in a kpart that isn't very used anyway. - something else David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113498: Fix KCompletion standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- This is a 2-commit patches: - CMakeLists.txt: Format according to CMake template, add QtXml to the dependencies - kcomboboxtest: Remove dependency on KF5::KIconThemes, it is tier3 Diffs - superbuild/CMakeLists.txt 3c82e8d tier2/kcompletion/CMakeLists.txt 75e5c52 tier2/kcompletion/tests/CMakeLists.txt 8a696c6 tier2/kcompletion/tests/kcomboboxtest.cpp e8d068a Diff: http://git.reviewboard.kde.org/r/113498/diff/ Testing --- Builds within kdelibs and standalone, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113370: move KDED to Tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/#review42638 --- Ship it! kded/CMakeLists.txt http://git.reviewboard.kde.org/r/113370/#comment30885 this comment is still wrong - David Faure On Oct. 29, 2013, 1:10 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/ --- (Updated Oct. 29, 2013, 1:10 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDED to tier3. I have removed any use of X11/Properties used to communicate with KSplash since we want to use either DBus or Wayland but certainly not X11. I plan to work on session startup in a few weeks so I will fix (if nobody else does before me) KSplash --- KDED communication by then. Diffs - CMakeLists.txt 6afb8e6 kded/CMakeLists.txt a06ed09 kded/DESIGN kded/HOWTO kded/Info.plist.template kded/Mainpage.dox kded/README.kded 05fec85 kded/config-kded.h.cmake 21210ab kded/kded.h kded/kded.cpp aab548b kded/kdedadaptor.h kded/kdedadaptor.cpp kded/kdedmodule.desktop kded/org.kde.kded5.service.in kioslave/http/kcookiejar/CMakeLists.txt 8d61c01 tier3/CMakeLists.txt 249a60b tier3/kded/CMakeLists.txt PRE-CREATION tier3/kded/KDEDConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113370/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdelibs_frameworks_qt5 #1532
See http://build.kde.org/job/kdelibs_frameworks_qt5/1532/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2013-w44
Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, arichardson, d_ed, dfaure, dMaggot, jpwhiting, sebas, svuorela, teo, vHanda and myself. Announcement: * dfaure's and my sponsoring dried out, thanks to Blue Systems and KDAB for the support; * we'll now contribute from our spare time only; * we're almost to the let's split repos point, we need a final push, please people finish your pending tasks ASAP so that we start splitting work mid- November; Topics discussed: * afiestas finished the kded move, pending review and push; * he's still working on the new Solid::PowerManagement async API; * agateau is very active on the building standalone front; * ki18n, knotifications and kdoctools build standalone now; * effort is tracked there (might move): https://community.kde.org/Frameworks/Modularization * he's also been working on various fixes (KCompletion, libdbusmenu-qt, workspace); * apol has been working on ecm_generate_headers, it still requires some polishing; * he also did a port attempt of kalgebra on KF5 which just worked; * arichardson has been working on having kconfig in proper shape on windows; * kconf_update still needs work; * d_ed moved knotifyconfig in place; * he still has some blockers around khtml; * dfaure is making progress toward killing libkio; * he's waiting on mck182 to deal with KImageIO; * he's also fixed bugs in KDirWatch and KArchive; * he also adjusted the code to some CI changes; * dMaggot is helping agateau with tier 2 standalone builds; * he's working on kwallet ATM; * jpwhiting ported knewstuff away from KImageIO; * he plans further cleanups in there; * sebas has been fixing the build; * he's also working on the system tray; * and he's trying to figure out a race condition in kservice_desktop_to_json; * svuorela has been working on the windows support (thanks a million!); * he recommends people to get dirty and help there, exhibits interesting issues (like KRandom being not really well seeded, or KSharedDataCache being a KNonSharedDataNonCache); * he got karchive to work at least with zlib (bz2 and xz are not tested yet); * he's also looking for a windows machine usable by the CI system, if anyone has that please get in touch; * teo is working on ksmserver; * vHanda moved kross to tier 3; * ervin moved some pieces out of staging, it's soon to be empty; * he also worked on moving kdewidgets in its own place (tier 3); * we need solutions for interfaces/ and doc/ help and feedback on how to modularize that is welcome. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113370: move KDED to Tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/#review42645 --- This review has been submitted with commit 43d5b1724f490cf31bf783781215410f56ccbc58 by Àlex Fiestas to branch frameworks. - Commit Hook On Oct. 29, 2013, 1:10 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/ --- (Updated Oct. 29, 2013, 1:10 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDED to tier3. I have removed any use of X11/Properties used to communicate with KSplash since we want to use either DBus or Wayland but certainly not X11. I plan to work on session startup in a few weeks so I will fix (if nobody else does before me) KSplash --- KDED communication by then. Diffs - CMakeLists.txt 6afb8e6 kded/CMakeLists.txt a06ed09 kded/DESIGN kded/HOWTO kded/Info.plist.template kded/Mainpage.dox kded/README.kded 05fec85 kded/config-kded.h.cmake 21210ab kded/kded.h kded/kded.cpp aab548b kded/kdedadaptor.h kded/kdedadaptor.cpp kded/kdedmodule.desktop kded/org.kde.kded5.service.in kioslave/http/kcookiejar/CMakeLists.txt 8d61c01 tier3/CMakeLists.txt 249a60b tier3/kded/CMakeLists.txt PRE-CREATION tier3/kded/KDEDConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113370/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #863
See http://build.kde.org/job/plasma-framework_master_qt5/863/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
On Tuesday 29 October 2013, Stephen Kelly wrote: Kevin Ottens wrote: Ship it! Looks fine to me and is aligned with prior discussions. Note that it is named ECM_foo, but it contains hardcoded KDE icon theme names. Good point. As it is, IMO for being ECM, it needs way more documentation. It needs to be documented so that it can be used by people who know nothing about KDE or KDE's icon scheme. Or should that be in the framework which deals with icon loading ? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
On Tuesday 29 October 2013 18:36:03 Alexander Neundorf wrote: On Tuesday 29 October 2013, Stephen Kelly wrote: Kevin Ottens wrote: Ship it! Looks fine to me and is aligned with prior discussions. Note that it is named ECM_foo, but it contains hardcoded KDE icon theme names. Good point. As it is, IMO for being ECM, it needs way more documentation. Agreed. And we should try to get it to work with no oxygen and crystalsvg hard coded, even if that means having to port the caller to specify the missing information. locolor and hicolor can stay though. It needs to be documented so that it can be used by people who know nothing about KDE or KDE's icon scheme. XDG icon scheme actually (that's why hicolor and locolor are OK, they're in the standard). It's really about XDG icons now, but the macro doesn't show it fully yet. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113373: Enable C++11 support by default.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/#review42649 --- Ship it! As discussed earlier today on IRC. This patch will do for now. - Kevin Ottens On Oct. 21, 2013, 6:51 p.m., Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/ --- (Updated Oct. 21, 2013, 6:51 p.m.) Review request for Extra Cmake Modules, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Enable C++11 support by default. Diffs - kde-modules/KDECompilerSettings.cmake b745ec3c52fe66b3cfb89a334c99a5ea8ef71d4d Diff: http://git.reviewboard.kde.org/r/113373/diff/ Testing --- Compiles, all required fixes have been integrated into the frameworks branch by now (at least for the subset I have the required dependencies for). Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113496: Move Kross from staging to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/#review42650 --- Ship it! Ship It! - Kevin Ottens On Oct. 29, 2013, 11:25 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/ --- (Updated Oct. 29, 2013, 11:25 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Move Kross from staging to tier3. Diffs - staging/CMakeLists.txt 808ee92 staging/kross/CMakeLists.txt staging/kross/KrossConfig.cmake.in staging/kross/Mainpage.dox staging/kross/autotests/CMakeLists.txt staging/kross/autotests/main.cpp staging/kross/autotests/profile.py staging/kross/autotests/testguiform.py staging/kross/autotests/testguiform.rb staging/kross/autotests/testguiform.ui staging/kross/autotests/testguiqt.py staging/kross/autotests/testguiqt.rb staging/kross/autotests/testguitk.py staging/kross/autotests/testkross.py staging/kross/autotests/testobject.h staging/kross/autotests/testobject.cpp staging/kross/autotests/unittest.es staging/kross/autotests/unittest.py staging/kross/autotests/unittest.rb staging/kross/docs/CHANGES staging/kross/src/CMakeLists.txt staging/kross/src/console/CMakeLists.txt staging/kross/src/console/main.cpp staging/kross/src/core/CMakeLists.txt staging/kross/src/core/action.h staging/kross/src/core/action.cpp staging/kross/src/core/actioncollection.h staging/kross/src/core/actioncollection.cpp staging/kross/src/core/childreninterface.h staging/kross/src/core/errorinterface.h staging/kross/src/core/interpreter.h staging/kross/src/core/interpreter.cpp staging/kross/src/core/krossconfig.h staging/kross/src/core/krossconfig.cpp staging/kross/src/core/manager.h staging/kross/src/core/manager.cpp staging/kross/src/core/metafunction.h staging/kross/src/core/metatype.h staging/kross/src/core/object.h staging/kross/src/core/object.cpp staging/kross/src/core/script.h staging/kross/src/core/script.cpp staging/kross/src/core/wrapperinterface.h staging/kross/src/modules/CMakeLists.txt staging/kross/src/modules/form.h staging/kross/src/modules/form.cpp staging/kross/src/modules/translation.h staging/kross/src/modules/translation.cpp staging/kross/src/qts/CMakeLists.txt staging/kross/src/qts/interpreter.h staging/kross/src/qts/interpreter.cpp staging/kross/src/qts/main.cpp staging/kross/src/qts/plugin.h staging/kross/src/qts/plugin.cpp staging/kross/src/qts/script.h staging/kross/src/qts/script.cpp staging/kross/src/qts/test.es staging/kross/src/qts/values_p.h staging/kross/src/ui/CMakeLists.txt staging/kross/src/ui/model.h staging/kross/src/ui/model.cpp staging/kross/src/ui/plugin.h staging/kross/src/ui/plugin.cpp staging/kross/src/ui/view.h staging/kross/src/ui/view.cpp tier3/CMakeLists.txt 249a60b Diff: http://git.reviewboard.kde.org/r/113496/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113498: Fix KCompletion standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/#review42651 --- Ship it! Ship It! - Kevin Ottens On Oct. 29, 2013, 2:37 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/ --- (Updated Oct. 29, 2013, 2:37 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a 2-commit patches: - CMakeLists.txt: Format according to CMake template, add QtXml to the dependencies - kcomboboxtest: Remove dependency on KF5::KIconThemes, it is tier3 Diffs - superbuild/CMakeLists.txt 3c82e8d tier2/kcompletion/CMakeLists.txt 75e5c52 tier2/kcompletion/tests/CMakeLists.txt 8a696c6 tier2/kcompletion/tests/kcomboboxtest.cpp e8d068a Diff: http://git.reviewboard.kde.org/r/113498/diff/ Testing --- Builds within kdelibs and standalone, tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/#review42659 --- This review has been submitted with commit 89d2b298dfe4b97b2e51d55bb85f96a1e803714e by David Gil to branch frameworks. - Commit Hook On Oct. 24, 2013, 9:54 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 24, 2013, 9:54 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: createNew method -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::createNew() and prefer newTheme() instead, as it appears in KEmoticonsTheme. That way, we have loadTheme(), saveTheme() and newTheme(). -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::createNew(), which was empty. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonsprovider.h 2ec0de8d1dfb846188bd458b49a4028fee115431 staging/kemoticons/src/core/kemoticonsprovider.cpp 7374966c65922c3e7a5be881c198a8f8f52fee29 staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 staging/kemoticons/src/core/kemoticonstheme.cpp e54d015e7f0f866d199d8eed7863fafd28576c13 staging/kemoticons/src/providers/adium/adium_emoticons.h 01d89e13834c345765e696d66560071dc10291af staging/kemoticons/src/providers/adium/adium_emoticons.cpp e6719d112a14478bdfd7f8c47633c18108a5633a staging/kemoticons/src/providers/kde/kde_emoticons.h 0738b79dcf734b7904e061b5eb41807ccaf443ff staging/kemoticons/src/providers/kde/kde_emoticons.cpp a99c6d84f5ab7e0e2f41027c37a97f170333dca8 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h a51b736f7702d7af1f1367dd1f13271647212fee staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 7596e30e8e5153185a3dd365858567c69477ff4a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 4ba706f519cebedaa6c9c3f2f02331e85745e89a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809 Diff: http://git.reviewboard.kde.org/r/113426/diff/ Testing --- Builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 29, 2013, 7:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: createNew method -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::createNew() and prefer newTheme() instead, as it appears in KEmoticonsTheme. That way, we have loadTheme(), saveTheme() and newTheme(). -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::createNew(), which was empty. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonsprovider.h 2ec0de8d1dfb846188bd458b49a4028fee115431 staging/kemoticons/src/core/kemoticonsprovider.cpp 7374966c65922c3e7a5be881c198a8f8f52fee29 staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 staging/kemoticons/src/core/kemoticonstheme.cpp e54d015e7f0f866d199d8eed7863fafd28576c13 staging/kemoticons/src/providers/adium/adium_emoticons.h 01d89e13834c345765e696d66560071dc10291af staging/kemoticons/src/providers/adium/adium_emoticons.cpp e6719d112a14478bdfd7f8c47633c18108a5633a staging/kemoticons/src/providers/kde/kde_emoticons.h 0738b79dcf734b7904e061b5eb41807ccaf443ff staging/kemoticons/src/providers/kde/kde_emoticons.cpp a99c6d84f5ab7e0e2f41027c37a97f170333dca8 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h a51b736f7702d7af1f1367dd1f13271647212fee staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 7596e30e8e5153185a3dd365858567c69477ff4a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 4ba706f519cebedaa6c9c3f2f02331e85745e89a staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp afb07b207407b00bbe0d38e0ca6d9e2bf2ccd809 Diff: http://git.reviewboard.kde.org/r/113426/diff/ Testing --- Builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113436: Deprecate KEmoticonsTheme methods
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- (Updated Oct. 29, 2013, 7:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Deprecate KEmoticonsTheme methods Before the initial cleanup, the loadTheme(), removeEmoticon() and addEmoticon methods of KEmoticonsTheme called the KEmoticonsProvider methods of the same name, which were either empty or useless. Now the KEmoticonsProvider methods are pure virtual and therefore those KEmoticonsTheme methods are deprecated and a subclassing of KEmoticonsProvider is advised. Diffs - KDE5PORTING.html ceff2fa13e4a666939dd0a1bb63e967504c31c07 staging/kemoticons/src/core/kemoticons.cpp 43dac6517b77a0d0040912958fe76687b475d85c staging/kemoticons/src/core/kemoticonstheme.h 25fc29453535d7e73f4e2d0752ce3f989c83fa96 Diff: http://git.reviewboard.kde.org/r/113436/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w44
On Tue, Oct 29, 2013 at 4:59 PM, Kevin Ottens er...@kde.org wrote: snip * dfaure is making progress toward killing libkio; * he's waiting on mck182 to deal with KImageIO; That's probably not me, I've not been doing anything around KImageIO :) Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113500: make KNewStuff build on its own
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- With these changes, KNewStuff can build on it's own and as part of kdelibs. Diffs - tier3/knewstuff/CMakeLists.txt 0e2136d07261f992022ecff3fa5948c34202585d tier3/knewstuff/src/CMakeLists.txt ec9a44a4c3535157d05375ab9a13b247702444dd Diff: http://git.reviewboard.kde.org/r/113500/diff/ Testing --- Builds by itself and as part of kdelibs. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir
On 2013-10-29, Alexander Neundorf neund...@kde.org wrote: Good point. As it is, IMO for being ECM, it needs way more documentation. It needs to be documented so that it can be used by people who know nothing about KDE or KDE's icon scheme. Or should that be in the framework which deals with icon loading ? It is not about icon loading, so no. Installing icons in the right places is a good generic task that everybody[tm] needs. There is also nothing about KDE's icon scheme in it, except maybe the two words crystal and oxygen. The rest is (supposedly) adhering to the icon naming spec. including the word hicolor. In general, apps should install icons into a app specific directory in hicolor and then let the more specialized icon themes override them as needed. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113503: make dbus dependency optional in JobWidgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ --- Review request for KDE Frameworks, kdelibs and Stephen Kelly. Repository: kdelibs Description --- Make dbus dependency optional in JobWidgets Many don't have dbus available on all platforms, especially windows, but JobWidgets is very much useful without it. Diffs - tier2/kjobwidgets/CMakeLists.txt ca53024 tier2/kjobwidgets/src/CMakeLists.txt 0a575a6 tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 Diff: http://git.reviewboard.kde.org/r/113503/diff/ Testing --- build tested on windows without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
