Re: C++11 & friends

On Sunday, September 11, 2016 3:21:21 AM CEST Dominik Haumann wrote: > Hi all, > > I just saw a commit by Volker turning nullptr into Q_NULLPTR with the > comment that Visual Studio 2012 does not support nullptr. > > While this change is trivial for obvious reasons, do we really need to do > that

Re: C++11 & friends

On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote: > Hi all, > > I just saw a commit by Volker turning nullptr into Q_NULLPTR with the > comment that Visual Studio 2012 does not support nullptr. > > While this change is trivial for obvious reasons, do we really need to do > that?

Re: Taking over maintainership of Baloo

Hi, > Hey Boudhayan, > > It's nice that you are stepping up for maintaining baloo. I have no > objections to that and will try to help you out whenever needed :) I triaged the bugs a lot today, we are now down to < 70: https://bugs.kde.org/buglist.cgi?bug_severity=critical&bug_severity=grave&bug

Re: Taking over maintainership of Baloo

Hey Boudhayan, It's nice that you are stepping up for maintaining baloo. I have no objections to that and will try to help you out whenever needed :) Cheers, Pinak -- Thanks Pinak Ahuja On 11 September 2016 at 19:40, Boudhayan Gupta wrote: > Hi, > > On 11 September 2016 at 22:59, Christoph Cu

Re: Taking over maintainership of Baloo

Am Sonntag, 11. September 2016, 20:07:36 CEST schrieb Dominik Haumann: > indeed I also did take a look at the bug list, and out of the 200 > bugs, without much exaggeration almost all of them are crashes. > > In fact, I believe it's important to CC the plasma-devel mailing list > here: Given we ar

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/ --- (Updated Sept. 12, 2016, 12:39 a.m.) Status -- This change has been

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. Lets hope it is awesome correct. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#re

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- Ship it! This is awesome. Ship it. - Vishesh Handa On S

Re: Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/ --- (Updated Sept. 11, 2016, 4:40 p.m.) Status -- This change has been m

Re: Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/#review99113 --- Ship it! Looks good to me. - Dominik Haumann On Sept. 1

Re: Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/ --- (Updated Sept. 11, 2016, 8:35 p.m.) Review request for KDE Frameworks and

Re: Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/ --- (Updated Sept. 11, 2016, 8:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/ --- (Updated Sept. 11, 2016, 8:27 p.m.) Review request for KDE Frameworks and

Review Request 128893: Fix sorted insert (aka flat_map like insert).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128893/ --- Review request for KDE Frameworks and Boudhayan Gupta. Repository: baloo

Re: Taking over maintainership of Baloo

Hi, > Hi, > > indeed I also did take a look at the bug list, and out of the 200 > bugs, without much exaggeration almost all of them are crashes. > > In fact, I believe it's important to CC the plasma-devel mailing list > here: Given we are about to release a LTS Plasma 5.8, and baloo is > tight

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

> On Sept. 11, 2016, 7:19 p.m., Boudhayan Gupta wrote: > > Can you add Vishesh and poke him if possible? This seems like a gigantic > > patch and I'm not sure I understand all of it right now. Hi, I can poke him, sure. Given there is no documentation what the things shall do, I am not 100% sure

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99110 --- Can you add Vishesh and poke him if possible? This seems like

Re: Review Request 128891: Transaction not created => don't try to abort them

> On Sept. 12, 2016, 12:25 a.m., Boudhayan Gupta wrote: > > LGTM. > > > > Long term I plan to replace all of this with liblmdb++, but that may or may > > not happen soon-ish. > > Christoph Cullmann wrote: > Hi, lmdb++ is IMHO no good idea, look at their commits, last one 7 months > ago, o

Re: Review Request 128891: Transaction not created => don't try to abort them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128891/ --- (Updated Sept. 11, 2016, 7:13 p.m.) Status -- This change has been m

Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/ --- Review request for KDE Frameworks, Plasma and Boudhayan Gupta. Repository

Re: Review Request 128891: Transaction not created => don't try to abort them

> On Sept. 11, 2016, 6:55 p.m., Boudhayan Gupta wrote: > > LGTM. > > > > Long term I plan to replace all of this with liblmdb++, but that may or may > > not happen soon-ish. Hi, lmdb++ is IMHO no good idea, look at their commits, last one 7 months ago, only 2 people ever did anything. https:/

Re: Review Request 128891: Transaction not created => don't try to abort them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128891/#review99107 --- Ship it! LGTM. Long term I plan to replace all of this wi

Review Request 128891: Transaction not created => don't try to abort them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128891/ --- Review request for KDE Frameworks and Boudhayan Gupta. Repository: baloo

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

> On Sept. 11, 2016, 6:32 p.m., Anthony Fieroni wrote: > > src/engine/database.cpp, line 128 > > > > > > It's needed *m_env = 0;* > > Or you can add method close to call it in all way. > > Christoph Cullmann

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

> On Септ. 11, 2016, 9:32 след обяд, Anthony Fieroni wrote: > > src/engine/database.cpp, line 128 > > > > > > It's needed *m_env = 0;* > > Or you can add method close to call it in all way. > > Christoph Cul

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

> On Sept. 11, 2016, 6:32 p.m., Anthony Fieroni wrote: > > src/engine/database.cpp, line 128 > > > > > > It's needed *m_env = 0;* > > Or you can add method close to call it in all way. I don't understand the

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99103 --- src/engine/database.cpp (line 128)

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99102 --- src/engine/database.h (line 60)

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/ --- (Updated Sept. 11, 2016, 9:27 p.m.) Status -- This change has been m

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99101 --- Ship it! Ship It! - Boudhayan Gupta On Sept. 11, 2016,

Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/ --- Review request for KDE Frameworks, Plasma and Boudhayan Gupta. Repository

Re: Taking over maintainership of Baloo

Hi, indeed I also did take a look at the bug list, and out of the 200 bugs, without much exaggeration almost all of them are crashes. In fact, I believe it's important to CC the plasma-devel mailing list here: Given we are about to release a LTS Plasma 5.8, and baloo is tightly integrated into Pl

Re: Taking over maintainership of Baloo

Hi, On 11 September 2016 at 22:59, Christoph Cullmann wrote: > I think the main issue is: There is no need to reproduce them, it is clear, > that baloo will crash > on any problem with lmdb, as "no" errors are handled (or lets say 99% of the > errors are not handled). > > The code is full of Q_

Re: Taking over maintainership of Baloo

Hi, > Hi, > > On 11 September 2016 at 22:44, Christoph Cullmann wrote: >> Hi, >> >> it would be very nice to have some active maintainership there, >> given a lot of VERY major crash bugs pile up there since > 1 year. > > The issue is that neither Pinak nor I can reproduce much of the bugs, > m

Re: Taking over maintainership of Baloo

Hi, On 11 September 2016 at 22:44, Christoph Cullmann wrote: > Hi, > > it would be very nice to have some active maintainership there, > given a lot of VERY major crash bugs pile up there since > 1 year. The issue is that neither Pinak nor I can reproduce much of the bugs, making solving them di

Re: Review Request 128888: Improve epub extractor, less segfaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Sept. 11, 2016, 7:17 p.m.) Status -- This change has been m

Re: Taking over maintainership of Baloo

Hi, it would be very nice to have some active maintainership there, given a lot of VERY major crash bugs pile up there since > 1 year. Beside that, could we get some baloo-b...@kde.org list as default assignee for all baloo bugs instead of "one" person? Greetings Christoph - Am 11. Sep 2016

Re: Review Request 128888: Improve epub extractor, less segfaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review99100 --- Ship it! It looks sane enough to me. I'm going to assume y

Taking over maintainership of Baloo

Hi all, Since Vishesh effectively stopped maintaining Baloo full-time, mostly Pinak and to some extent I have been looking over bugs and reviewing RRs pertaining to Baloo. If there are no objections to the same (including if Pinak declines to either co-maintain it or would rather maintain it alone

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

> On Sept. 11, 2016, 4:50 p.m., Boudhayan Gupta wrote: > > src/engine/database.cpp, line 107 > > > > > > This is clever, but I had to read it thrice to figure out what exactly > > it does. Maybe use this: > >

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128885/ --- (Updated Sept. 11, 2016, 4:58 p.m.) Status -- This change has been m

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

> On Sept. 11, 2016, 10:20 p.m., Boudhayan Gupta wrote: > > src/engine/database.cpp, line 107 > > > > > > This is clever, but I had to read it thrice to figure out what exactly > > it does. Maybe use this: > >

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

> On Sept. 11, 2016, 3:05 p.m., Sune Vuorela wrote: > > Looks good to me. I would though appreciate a unit test if ever possible. > > It would be an easy bug to reintroduce. > > Christoph Cullmann wrote: > I can try to create one ;=) Added unit test + pushed - Christoph --

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/ --- (Updated Sept. 11, 2016, 6:52 p.m.) Status -- This change has been m

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128885/#review99096 --- Fix it, then Ship it! Ship It! src/engine/database.cpp (

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Sept. 11, 2016, 12:17 p.m.) Review request for KDE Frameworks, G

Re: Review Request 128889: Fix KFileItem::overlays returning empty string values

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128889/ --- (Updated Sept. 11, 2016, 4:16 p.m.) Status -- This change has been m

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

> On Sept. 11, 2016, 3:05 p.m., Sune Vuorela wrote: > > Looks good to me. I would though appreciate a unit test if ever possible. > > It would be an easy bug to reintroduce. I can try to create one ;=) - Christoph --- This is an autom

Re: Review Request 128889: Fix KFileItem::overlays returning empty string values

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128889/#review99094 --- Ship it! Ship It! - David Faure On sep. 11, 2016, 3:40

Review Request 128889: Fix KFileItem::overlays returning empty string values

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128889/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/#review99092 --- Looks good to me. I would though appreciate a unit test if ev

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128885/#review99093 --- Just checked that the engine.h is not installed, so no proble

Re: Review Request 128886: odf files with no content.xml crash indexer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128886/ --- (Updated Sept. 11, 2016, 1:08 p.m.) Status -- This change has been m

Review Request 128888: Improve epub extractor, less segfaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- Review request for KDE Frameworks and Pinak Ahuja. Repository: kfilemetad

Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/ --- Review request for KDE Frameworks. Repository: baloo Description --

Re: Review Request 128886: odf files with no content.xml crash indexer

> On Sept. 11, 2016, 11:22 a.m., Kai Uwe Broulik wrote: > > autotests/odfextractortest.cpp, line 103 > > > > > > Either set a parent or use QScopedPointer? Can change that, just copied the boiler plate from the

Re: Review Request 128886: odf files with no content.xml crash indexer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128886/#review99085 --- lgtm autotests/odfextractortest.cpp (line 103)

Re: Review Request 128886: odf files with no content.xml crash indexer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128886/ --- (Updated Sept. 11, 2016, 11:18 a.m.) Review request for KDE Frameworks, B

Review Request 128886: odf files with no content.xml crash indexer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128886/ --- Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak

Review Request 128885: Increase size limit of baloo index for 64-bit machines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128885/ --- Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak

Re: Review Request/New Framework: KF5::SyntaxHighlighting

On Sunday 11 September 2016 05:33:29 Michael Palimaka wrote: > On 11/09/16 01:47, Volker Krause wrote: > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > > becoming a framework :) > > Thanks a lot for working on this. > > I noticed that KF5SyntaxHighlightingConfig.cmake.