Re: Review Request 128790: Call utempter manually

[Oswald Buddenhagen]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/#review99479
---



a bit of delay due to vacation ...


cmake/FindUTEMPTER.cmake 


i suppose it would make sense to keep it, but with the executable.


- Oswald Buddenhagen


On Sept. 9, 2016, 4:50 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128790/
> ---
> 
> (Updated Sept. 9, 2016, 4:50 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Oswald 
> Buddenhagen, Rex Dieter, and Thiago Macieira.
> 
> 
> Bugs: 364779
> https://bugs.kde.org/show_bug.cgi?id=364779
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 
> utempter does stuff in a way that isn't compatible with 
> QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child 
> process).
> 
> So instead we invoke it manually with QProcess.
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake a3ea06a 
>   src/CMakeLists.txt caab96f 
>   src/kpty.cpp 15c3b81 
>   src/kpty_p.h 192bf1c 
> 
> Diff: https://git.reviewboard.kde.org/r/128790/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 128989: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128989/
---

(Updated Sept. 23, 2016, 12:52 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 5fdcdff6e387b5f6285a6eb5ad0c7f7a99b8bd1a by Heiko Becker 
to branch master.


Repository: kimageformats


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/imageformats/eps.cpp e566cc41d70ff66e38d7915ef5c9d561a2c23349 

Diff: https://git.reviewboard.kde.org/r/128989/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128983: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128983/
---

(Updated Sept. 23, 2016, 12:51 vorm.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Michael Pyne.


Repository: kcoreaddons


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 

Diff: https://git.reviewboard.kde.org/r/128983/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128994: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128994/
---

(Updated Sept. 23, 2016, 12:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Gräßlin.


Changes
---

Submitted with commit f2f0b2722e2cf53d982c5ebb52425e84278140e1 by Heiko Becker 
to branch master.


Repository: kglobalaccel


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c 

Diff: https://git.reviewboard.kde.org/r/128994/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128991: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128991/
---

(Updated Sept. 22, 2016, 11:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Ivan Čukić.


Changes
---

Submitted with commit 40077d52b554d5903aa53fffaba46912aa55918a by Heiko Becker 
to branch master.


Repository: kactivities


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 

Diff: https://git.reviewboard.kde.org/r/128991/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128990: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128990/
---

(Updated Sept. 23, 2016, 12:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 36142ace3236517180a3ccbcb3e692beebe53498 by Heiko Becker 
to branch master.


Repository: kjobwidgets


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/debug.cpp 445b7ee4b40560577488b6a3fcd15f593693fbb3 

Diff: https://git.reviewboard.kde.org/r/128990/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128987: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128987/
---

(Updated Sept. 22, 2016, 6:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 61c63d6b8e08c60f3336604f45a647691c32cf91 by Heiko Becker 
to branch master.


Repository: kauth


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/backends/dbus/DBusHelperProxy.cpp 
decc2676a005def1cb6feea0670f3eb981c4519d 
  src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa 
  src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 

Diff: https://git.reviewboard.kde.org/r/128987/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128986: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128986/
---

(Updated Sept. 23, 2016, 12:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit c55f73557ca7ab09caaa593d951297cc551c6d72 by Heiko Becker 
to branch master.


Repository: sonnet


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/plugins/hunspell/hunspelldebug.cpp 
5f9aebe0821cffb44adfe2b82595bce724dc53d7 
  src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 

Diff: https://git.reviewboard.kde.org/r/128986/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128985: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128985/
---

(Updated Sept. 22, 2016, 4:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit ed9e2553a92844567f76e7ce468a5d3128e9fb51 by Heiko Becker 
to branch master.


Repository: kitemmodels


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/klinkitemselectionmodeltest.cpp 
1399700cf58dec0ca9f661b7bc2c361e0df2349e 
  autotests/kselectionproxymodeltest.cpp 
fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 
  src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 
  src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 

Diff: https://git.reviewboard.kde.org/r/128985/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128984: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128984/
---

(Updated Sept. 23, 2016, 12:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8c58398b4cafe22ce1cf28fdaf9fb62948425d36 by Heiko Becker 
to branch master.


Repository: kidletime


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 

Diff: https://git.reviewboard.kde.org/r/128984/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/
---

(Updated Sept. 22, 2016, 10:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker 
to branch master.


Repository: kcrash


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 

Diff: https://git.reviewboard.kde.org/r/128988/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/
---

(Updated Sept. 22, 2016, 4:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 21d992d40a83f1b0c67f9274d6d66ae973545f9c by Heiko Becker 
to branch master.


Repository: kcrash


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 

Diff: https://git.reviewboard.kde.org/r/128988/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128988: Drop obsolete version check

[David Faure]

> On Sept. 22, 2016, 7:12 p.m., David Faure wrote:
> > src/kcrash.cpp, line 62
> > 
> >
> > While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or 
> > review 128232).
> 
> Heiko Becker wrote:
> I'd rather put that in a separate commit.
> Also, I've seen that in quite a number of other frameworks. Should I mail 
> kde-frameworks one time instead of posting another round of review requests?

Agreed about separate commit. You can push the change to QtInfoMsg to all 
frameworks without another round of RR indeed. The difference is academic 
currently, we're not using qInfo() much, if at all. But I like the idea of 
being able to. And of making things consistent in terms of the default category 
level ;) Thanks!


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99438
---


On Sept. 21, 2016, 5:11 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> ---
> 
> (Updated Sept. 21, 2016, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128988: Drop obsolete version check

[Heiko Becker]

> On Sept. 22, 2016, 9:12 nachm., David Faure wrote:
> > src/kcrash.cpp, line 62
> > 
> >
> > While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or 
> > review 128232).

I'd rather put that in a separate commit.
Also, I've seen that in quite a number of other frameworks. Should I mail 
kde-frameworks one time instead of posting another round of review requests?


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99438
---


On Sept. 21, 2016, 7:11 nachm., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> ---
> 
> (Updated Sept. 21, 2016, 7:11 nachm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 120306: Exclude X11 when building for Wayland

[Pier Luigi Fiorini]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120306/
---

(Updated Sept. 22, 2016, 8:43 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Exclude X11 when building for Wayland


Diffs
-

  CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 
  src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c 

Diff: https://git.reviewboard.kde.org/r/120306/diff/


Testing
---


Thanks,

Pier Luigi Fiorini

Re: Review Request 120306: Exclude X11 when building for Wayland

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120306/#review99474
---



Closing as this review request is more than 2 years old.

If it still applies to current Plasma please reopen this review request. Thanks

- David Edmundson


On Sept. 21, 2014, 2:50 p.m., Pier Luigi Fiorini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120306/
> ---
> 
> (Updated Sept. 21, 2014, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Exclude X11 when building for Wayland
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d9c78cf4ccc0ba8a37a2b43840a6867a9092d646 
>   src/plasma/config-plasma.h.cmake ed14e7aa28835599f3a40ea1aff32d347f33a16c 
> 
> Diff: https://git.reviewboard.kde.org/r/120306/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pier Luigi Fiorini
> 
>

Re: Scrap baloo?

[Christoph Cullmann]

Hi,

>> Anyway, enough rambling. I should have something in a few days.
> sure, take your time to look at it, its nothing we need to decide in a few 
> days.
> 
> Just as prove of concept that tracker can do a lot of stuff and
> we still can keep the public API we have (perhaps beside the indexerconfig
> stuff,
> beside if we start to query tracker configs, too) I hacked a bit more on
> my tracker baloo variant.
> 
> https://quickgit.kde.org/?p=clones%2Fbaloo%2Fcullmann%2Ftbaloo.git
> 
> Stuff like:
> 
> baloosearch "type:Audio modified<=2016-12-12" -d /home/cullmann/data
> 
> works now again, still missing is handling of generic properties (which then
> need to be mapped to the matching sparql names and tags) and the filling
> of the KFileMedaData from the tracker DB.
> 
> But I think I will only invest time in that after we all came to some
> consensus what to do at all, just wanted to show that tracker stuff is 
> feasible
> without a great amount of work with even keeping the API intact enough
> that we would have some transition possibility without breaking BC/SC.
> (modulo query string conversion glitches)
anyone had some time to take a look at Baloo and Co.?

Greetings
Christoph

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234

Re: Review Request 128988: Drop obsolete version check

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99438
---




src/kcrash.cpp (line 61)


While you're here, this should now be QtInfoMsg, see 413eb26 in ECM (or 
review 128232).


- David Faure


On Sept. 21, 2016, 5:11 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> ---
> 
> (Updated Sept. 21, 2016, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128988: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/#review99437
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:11 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128988/
> ---
> 
> (Updated Sept. 21, 2016, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 
> 
> Diff: https://git.reviewboard.kde.org/r/128988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128994: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128994/#review99435
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:39 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128994/
> ---
> 
> (Updated Sept. 21, 2016, 5:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c 
> 
> Diff: https://git.reviewboard.kde.org/r/128994/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128989: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128989/#review99436
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:13 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128989/
> ---
> 
> (Updated Sept. 21, 2016, 5:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/imageformats/eps.cpp e566cc41d70ff66e38d7915ef5c9d561a2c23349 
> 
> Diff: https://git.reviewboard.kde.org/r/128989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128995: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128995/#review99434
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:45 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128995/
> ---
> 
> (Updated Sept. 21, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 
> 
> Diff: https://git.reviewboard.kde.org/r/128995/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128991: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128991/#review99433
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:17 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128991/
> ---
> 
> (Updated Sept. 21, 2016, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 
> 
> Diff: https://git.reviewboard.kde.org/r/128991/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128990: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128990/#review99432
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:15 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128990/
> ---
> 
> (Updated Sept. 21, 2016, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/debug.cpp 445b7ee4b40560577488b6a3fcd15f593693fbb3 
> 
> Diff: https://git.reviewboard.kde.org/r/128990/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128987: Drop obsolete version checks

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128987/#review99431
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5:04 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128987/
> ---
> 
> (Updated Sept. 21, 2016, 5:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/backends/dbus/DBusHelperProxy.cpp 
> decc2676a005def1cb6feea0670f3eb981c4519d 
>   src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa 
>   src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 
> 
> Diff: https://git.reviewboard.kde.org/r/128987/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128985: Drop obsolete version checks

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128985/#review99429
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 4:32 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128985/
> ---
> 
> (Updated Sept. 21, 2016, 4:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   autotests/klinkitemselectionmodeltest.cpp 
> 1399700cf58dec0ca9f661b7bc2c361e0df2349e 
>   autotests/kselectionproxymodeltest.cpp 
> fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 
>   src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 
>   src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 
> 
> Diff: https://git.reviewboard.kde.org/r/128985/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128986: Drop obsolete version checks

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128986/#review99430
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 5 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128986/
> ---
> 
> (Updated Sept. 21, 2016, 5 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/plugins/hunspell/hunspelldebug.cpp 
> 5f9aebe0821cffb44adfe2b82595bce724dc53d7 
>   src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 
> 
> Diff: https://git.reviewboard.kde.org/r/128986/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128984: Drop obsolete version check

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128984/#review99428
---


Ship it!




Ship It!

- David Edmundson


On Sept. 21, 2016, 4:27 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128984/
> ---
> 
> (Updated Sept. 21, 2016, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 
> 
> Diff: https://git.reviewboard.kde.org/r/128984/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128993: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128993/
---

(Updated Sept. 22, 2016, 3:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 1536ab6c8996d5f21d7a59089bf99de675faee18 by Heiko Becker 
to branch master.


Repository: kdesignerplugin


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 
  autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c 

Diff: https://git.reviewboard.kde.org/r/128993/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 126086: [OS X] backend ported from KDE4

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126086/
---

(Updated Sept. 22, 2016, 4 p.m.)


Review request for KDE Software on Mac OS X, KDE Frameworks and Valentin Rusu.


Changes
---

A slightly different version that's seen more testing.

Is it to be expected that the privileged helper also requests authorisation 
after the "client"?


Repository: kauth


Description
---

This revision adds a port of the OS X backend improvements I implemented for 
KDE4 2 years ago, plus a few additional changes (some just to spark some 
debate).

kauth-policy-gen still should not be built as an app bundle on OS X.
This can be achieved by using `ecm_mark_nongui-executable`; there appear to be 
no contra-indications on other platforms.


Diffs (updated)
-

  cmake/KF5AuthMacros.cmake 15f05c7 
  src/CMakeLists.txt 1b6930d 
  src/backends/dbus/DBusHelperProxy.cpp decc267 
  src/backends/mac/AuthServicesBackend.h 8f51eba 
  src/backends/mac/AuthServicesBackend.cpp e832bfe 
  src/backends/mac/kauth-policy-gen-mac.cpp b51d217 
  src/kauthhelpersupport.cpp 318d3a0 

Diff: https://git.reviewboard.kde.org/r/126086/diff/


Testing
---

On OS X 10.9 with Qt 5.6.1 and Frameworks 5.24.0

There is an issue with one of the autotests:

```
build/autotests/KAuthHelperTest -vb -v1
* Start testing of HelperTest *
Config: Using QtTest library 5.6.1, Qt 5.6.1 (x86_64-little_endian-lp64 shared 
(dynamic) release build; by Clang 6.0 (clang-600.0.57) (Apple))
INFO   : HelperTest::initTestCase() entering
QDEBUG : HelperTest::initTestCase() Test backend loaded
QDEBUG : HelperTest::initTestCase() Waiting for HelperHandler to be initialized
QDEBUG : HelperTest::initTestCase() Initializing helper handler
QDEBUG : HelperTest::initTestCase() Adding proxy for thread 
QThread(0x7fab38e11e50)
PASS   : HelperTest::initTestCase()
INFO   : HelperTest::testBasicActionExecution() entering
QDEBUG : HelperTest::testBasicActionExecution() Capabilities changing
QDEBUG : HelperTest::testBasicActionExecution() Checking if action  
"org.kde.kf5auth.autotest.standardaction" exists
QDEBUG : HelperTest::testBasicActionExecution() Caller ID: "a random caller Id"
QDEBUG : HelperTest::testBasicActionExecution() Standard action running
PASS   : HelperTest::testBasicActionExecution()
INFO   : HelperTest::testExecuteJobSignals() entering
QDEBUG : HelperTest::testExecuteJobSignals() Checking if action  
"org.kde.kf5auth.autotest.longaction" exists
QDEBUG : HelperTest::testExecuteJobSignals() Caller ID: "a random caller Id"
QDEBUG : HelperTest::testExecuteJobSignals() Long action running. Don't be 
scared, this action takes 2 seconds to complete
PASS   : HelperTest::testExecuteJobSignals()
INFO   : HelperTest::testActionData() entering
QDEBUG : HelperTest::testActionData() Checking if action  
"org.kde.kf5auth.autotest.echoaction" exists
QDEBUG : HelperTest::testActionData() Caller ID: "a random caller Id"
QDEBUG : HelperTest::testActionData() Echo action running
QWARN  : HelperTest::testActionData() QSocketNotifier: Socket notifiers cannot 
be enabled or disabled from another thread
^CQFATAL : HelperTest::testActionData() Received signal 2
 Function time: 3563ms Total time: 5657ms
FAIL!  : HelperTest::testActionData() Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted
* Finished testing of HelperTest *
```
I don't know if this is a structural error or if it's just the test that should 
be rewritten or skipped on OS X.

Also, I've noticed that applications like ksysguard5 that rely on a helper will 
authorise correctly in the main app, and then post an error:

```
DBus Backend error: connection to helper failed: "Not connected to D-Bus server"
```

Does this mean those applications are not written to comply with platforms 
where authorisation takes place in the host, or in a helper process they 
activate in a different way via DBus?


Thanks,

René J.V. Bertin

KIO, proxies, libproxy and OS X/MSWin

[René J . V . Bertin]

Hi,

Can someone provide a synthetic resume of how KIO handles proxies on systems 
other than Linux/Plasma5?

I observe that
- KIO doesn't link to libproxy and doesn't require its presence in order to 
build
- libproxy is capable of detecting the system settings on OS X
- Qt can build against libproxy but doesn't appear to use it on OS X
- kcm_kio.so is at least partly effective on OS X, when testing with konqueror5:
-- manual proxy configuration is taken into account
-- the direct/no proxy setting is respected
-- auto-detection of the system proxy configuration doesn't fill in the dialog 
form, but connections *are* routed through the proxy
-- automatic proxy detection doesn't work correctly and leads to using direct 
connections.

Thanks,
René

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/
---

(Updated Sept. 22, 2016, 2:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit 6d1485bece7ad3dbe4c64f517643c50076c68e7d by Ralf Habacker 
to branch master.


Repository: kdoctools


Description
---

Convert checkxml5 into a qt executable for cross plattform support.


Diffs
-

  CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
  checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
  src/checkXML5.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128968/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker