Re: Differential e-mail subject re-arrangement

2017-03-02 Thread Ben Cooksley
On Fri, Mar 3, 2017 at 10:41 AM, Jan Kundrát wrote: > On čtvrtek 2. března 2017 9:08:25 CET, Ben Cooksley wrote: >> >> In regards to the way email subjects are treated, I've now customised >> the metamta.differential.subject-prefix preference on our installation >> to be blank, to

D4911: add Baloo DBus signals for moved or removed files

2017-03-02 Thread Matthieu Gallien
mgallien added a reviewer: kde-frameworks-devel. View RevisionREPOSITORYR293 BalooREVISION DETAILhttps://phabricator.kde.org/D4911EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mgallien, kde-frameworks-develCc: Frameworks

D4911: add Baloo DBus signals for moved or removed files

2017-03-02 Thread Matthieu Gallien
mgallien created this revision.Restricted Application added a project: Frameworks.Restricted Application added a subscriber: Frameworks. View RevisionREVISION SUMMARYAdd new DBus signals sent by Baloo indexer for removed or moved files. I still need to extend existing automatic tests with checks

D4906: Fix kactivities-stats into tier3

2017-03-02 Thread Ivan Čukić
ivan added a comment. View RevisionKActivities is tier 1 even if the metainfo.yaml says otherwise. It only requires boost. So, this should be changed in KActivities, not in KActivitiesStatsREPOSITORYR159 KActivities StatisticsREVISION DETAILhttps://phabricator.kde.org/D4906EMAIL

D4906: Fix kactivities-stats into tier3

2017-03-02 Thread Aleix Pol Gonzalez
apol created this revision.Restricted Application added a project: Frameworks. View RevisionREVISION SUMMARYIt depends on kactivities, which is also tier3REPOSITORYR159 KActivities StatisticsBRANCHmasterREVISION DETAILhttps://phabricator.kde.org/D4906AFFECTED FILESmetainfo.yamlEMAIL

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread Luigi Toscano
ltoscano marked 3 inline comments as done.ltoscano added inline comments. View RevisionINLINE COMMENTSView Inlinedfaure wrote in docbookxslt_p.h:1 missing copyright header This is not exported, can I fix it later with the other files?REPOSITORYR238 KDocToolsREVISION

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread Luigi Toscano
ltoscano added a comment. View RevisionEyes bleeding after digging into the history back to the cvs2svn conversion. At least I will be able to finally update the copyright of the other files (even if apparently originally kdoctools was BSD-like, need to investigate more). Anyway, if this is

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread Luigi Toscano
ltoscano updated this revision to Diff 12097.ltoscano added a comment. View RevisionAdd descriptions and copyrights Copyrights from the people who touched the signature from this file and its ancestors.REPOSITORYR238 KDocToolsCHANGES SINCE LAST

Re: Differential e-mail subject re-arrangement

2017-03-02 Thread Jan Kundrát
On čtvrtek 2. března 2017 9:08:25 CET, Ben Cooksley wrote: In regards to the way email subjects are treated, I've now customised the metamta.differential.subject-prefix preference on our installation to be blank, to the "[Differential]" part should no longer be present. Roughly at the time you

D4867: [Menu] Improved available space correction for openRelative

2017-03-02 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes.Closed by commit R242:daee27f0962d: [Menu] Improve available space correction for openRelative (authored by subdiff). View RevisionCHANGED PRIOR TO COMMIThttps://phabricator.kde.org/D4867?vs=12015=12094#tocREPOSITORYR242

D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny updated this revision to Diff 12084.martinkostolny added a comment. View RevisionAfter reading though bug mentioned by Luigi and this QT bug (https://bugreports.qt.io/browse/QTBUG-56366) I'm not so convinced that we want to directly write to file in order to maintain owner, because

[Diff] D4891: Port away from setRoleNames where easily possible

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4891EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: broulik, Plasma, martCc: plasma-devel,

[Diff] D4867: [Menu] Improved available space correction for openRelative

2017-03-02 Thread Eike Hein
hein accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4867EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: subdiff, Plasma, heinCc: plasma-devel,

D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny added a comment. View RevisionI think that leaving it as it is is not a solution In that case, I favour the second option (direct write to file).REPOSITORYR39 KTextEditorREVISION DETAILhttps://phabricator.kde.org/D4847EMAIL

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Luigi Toscano
ltoscano added a comment. View Revision In D4847#91810, @martinkostolny wrote: This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is) already happening before my patch when user has the permission to write the file and is not

D4891: Port away from setRoleNames where easily possible

2017-03-02 Thread Kai Uwe Broulik
broulik created this revision.Restricted Application added projects: Plasma, Frameworks.Restricted Application added subscribers: Frameworks, plasma-devel. View RevisionREVISION SUMMARYIt is deprecated. Instead re-implement roleNames(). Done in places where only static roles were used.TEST

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny updated this revision to Diff 12058.martinkostolny added a comment. View RevisionNext iteration, still without autotests, I need to study them more. This diff includes preserving owner and group when file is saved with elevated privileges. Actually loosing owner was (and is)

D4799: Delay notifications until desktop session has loaded

2017-03-02 Thread Valerio Pilo
vpilo added a comment. View Revision In D4799#91246, @davidedmundson wrote: There is another solution that would work without any changes to KNotification. DBus has a solution to buffer messages and wait for a name to become available, it happens in DBus activation. If plasmashell was DBus

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread Luigi Toscano
ltoscano added inline comments. View RevisionINLINE COMMENTSView Inlinedfaure wrote in docbookxslt.h:1 copyright header missing For this and all the other notes about missing copyright: I did not write the original code, just reshuffled it in this header (ok, apart one function), so I guess I

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny marked 2 inline comments as done. View RevisionREPOSITORYR39 KTextEditorREVISION DETAILhttps://phabricator.kde.org/D4847EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: martinkostolny, dhaumann, KTextEditorCc: dhaumann, graesslin, davidedmundson,

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread David Faure
dfaure added inline comments. View RevisionINLINE COMMENTSView Inlineltoscano wrote in docbookxslt.h:1 For this and all the other notes about missing copyright: I did not write the original code, just reshuffled it in this header (ok, apart one function), so I guess I should find the copyright of

[Diff] D4847: KAuth integration in document saving

2017-03-02 Thread Martin Kostolný
martinkostolny updated this revision to Diff 12054.martinkostolny added a comment. View RevisionThanks for all the feedback! I'm updating the diff to reflect most Dominik's points. I'll learn from them next time :). Anyway I was unable to remove the KAuth namespace. It doesn't work without it,

D4849: Export a proper shared library for KDocTools

2017-03-02 Thread David Faure
dfaure added inline comments. View RevisionINLINE COMMENTSView Inlinedocbookxslt.h:1 #ifndef _KDOCTOOLS_XSLT_H_ #define _KDOCTOOLS_XSLT_H_ copyright header missingView Inlinedocbookxslt.h:13 KDOCTOOLS_EXPORT QString transform(const QString &file, const QString &stylesheet,

D4850: Use the new shared library exported by KDocTools

2017-03-02 Thread David Faure
dfaure accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR241 KIOBRANCHuse-kdoctools-sharedREVISION DETAILhttps://phabricator.kde.org/D4850EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: ltoscano, dfaureCc: Frameworks

D4851: Implement FadingMaterial frag/vert shaders on core profile

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)BRANCHmasterREVISION DETAILhttps://phabricator.kde.org/D4851EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma,

[Diff] D4848: Split frag and vert code of FadingNode into separate files

2017-03-02 Thread Marco Martin
mart accepted this revision.This revision is now accepted and ready to land. View RevisionREPOSITORYR242 Plasma Framework (Library)REVISION DETAILhttps://phabricator.kde.org/D4848EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: davidedmundson, Plasma, martCc: mart,

Re: Differential e-mail subject re-arrangement

2017-03-02 Thread Ben Cooksley
On Thu, Mar 2, 2017 at 10:08 AM, Dominik Haumann wrote: > Hi, Hi all, > > On Wed, Mar 1, 2017 at 4:16 PM, David Faure wrote: >> On mercredi 1 mars 2017 13:35:47 CET Kevin Funk wrote: >>> On Tuesday, 28 February 2017 21:31:44 CET Michael Pyne wrote: >>> > On