D11610: clang-tidy: modernize-use-default-member-init run

2018-03-30 Thread Dominik Haumann
dhaumann added a comment. Btw, I messed up the dates. Tag is next Saturday after today... REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sar

D11825: Fix unitialized value warning, nullptr access

2018-03-30 Thread Stefan Brüns
bruns added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11825 To: bruns, michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

2018-03-30 Thread James Smith
smithjd marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

2018-03-30 Thread Stefan Brüns
bruns added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11828: Simplify orPostingIterator and make it faster

2018-03-30 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Trivial searches (e.g. baloosearch foo) are expanded to a large l

D11827: Do not retrieve mtime from database repeatedly when sorting

2018-03-30 Thread Stefan Brüns
bruns updated this revision to Diff 31007. bruns added a comment. - Do not retrieve document ID for skipped result entries REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11827?vs=31006&id=31007 BRANCH searchstore_speedup_2 REVISION DETAIL https://phabri

D11827: Do not retrieve mtime from database repeatedly when sorting

2018-03-30 Thread Stefan Brüns
bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11827 To: bruns, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11827: Do not retrieve mtime from database repeatedly when sorting

2018-03-30 Thread Stefan Brüns
bruns created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY For larger result sets, querying the mtime (once for lhs and rhs each) on each sorting step co

D11826: Simplify Term operator&& and ||

2018-03-30 Thread Stefan Brüns
bruns created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The Term(Term, Operator, Term) constructor is identical to the three separate calls, but saves

D11825: Fix unitialized value warning, nullptr access

2018-03-30 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY getVarint32Ptr may return a nullptr (in case of an error), and

D11753: baloodb: Add clean command

2018-03-30 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:113 > info.url = url; > -info.accessible = !url.isEmpty() && QFileInfo::exists(url); > +info.accessible = !url.isEmpty() && fileInfo.exists(url); > +info.symlink = fileInfo.isSymL

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-03-30 Thread Christoph Roick
croick updated this revision to Diff 30980. croick added a comment. - change socket file location and delete file after use REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=29248&id=30980 BRANCH ptracer REVISION DETAIL https://phabricator.kde.or

D11235: [DrKonqi] Request change of ptrace scope from KCrash

2018-03-30 Thread Christoph Roick
croick updated this revision to Diff 30979. croick added a comment. - update socket file location REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29249&id=30979 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11822: Make the word/char count a global preference

2018-03-30 Thread Wojciech Stachurski
wsdfhjxc created this revision. wsdfhjxc added reviewers: KTextEditor, Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. wsdfhjxc requested review of this revision. REVISION SUMMARY This is an attempt to make the word/char count

D11820: Handle properties with multiple values

2018-03-30 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R824 Baloo Widgets BRANCH string-list (branched from master) REVISION DETAIL https://pha

D11820: Handle properties with multiple values

2018-03-30 Thread Michael Heidelbach
michaelh edited the summary of this revision. michaelh added a dependency: D10694: epubextractor: Handle multiple subjects better. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11820 To: michaelh, #baloo, #frameworks Cc: astippich, mgallien, elvisangelaccio, ash

D10694: epubextractor: Handle multiple subjects better

2018-03-30 Thread Michael Heidelbach
michaelh added a dependent revision: D11820: Handle properties with multiple values. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, nicol

D10694: epubextractor: Handle multiple subjects better

2018-03-30 Thread Michael Heidelbach
michaelh updated this revision to Diff 30972. michaelh added a comment. - Additionally use keywords property This way the value-type of subject can be preserved REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10694?vs=30858&id=30972 BRANCH mult

D11365: also test for value types in taglibextractortest and fix errors

2018-03-30 Thread Alexander Stippich
astippich planned changes to this revision. astippich added a comment. In D11365#236274 , @michaelh wrote: > This patch should be split. > > 1. Test more properties > 2. Change return types of ... > > Also 'fix errors' in the title is

D10747: Implement zwp_linux_dmabuf_v1

2018-03-30 Thread Roman Gilg
romangg added a comment. Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a dummy only on non-Linunx systems? This way we could use the system one on Linux.

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

2018-03-30 Thread Burkhard Lück
lueck retitled this revision from "Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities" to "Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities". REVISION DETAIL https://phabricator.kde.org/D11810 To: lueck, ltoscano, #documentation Cc: #frame

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

2018-03-30 Thread Burkhard Lück
lueck updated this revision to Diff 30968. lueck added a comment. add entity for sddm CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11810?vs=30949&id=30968 REVISION DETAIL https://phabricator.kde.org/D11810 AFFECTED FILES src/customization/entities/general.entities To: lueck,

D10803: handle more tags in taglibextractor

2018-03-30 Thread Michael Heidelbach
michaelh accepted this revision. michaelh added a comment. This revision is now accepted and ready to land. Thank you. REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure,

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich updated this revision to Diff 30956. astippich added a comment. - remove duplicate genre property for mp3 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30955&id=30956 BRANCH enhance_taglib REVISION DETAIL https://phabricator.

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich updated this revision to Diff 30955. astippich marked an inline comment as done. astippich added a comment. - fix formatting issues during rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30951&id=30955 BRANCH enhance_taglib

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich marked 3 inline comments as done. astippich added a comment. In D10803#237133 , @michaelh wrote: > Except for the white space stuff I'm still fine with this. Oops, sorry, messed that up during rebase. INLINE COMMENTS > michaelh

D10803: handle more tags in taglibextractor

2018-03-30 Thread Michael Heidelbach
michaelh requested changes to this revision. michaelh added a comment. This revision now requires changes to proceed. Except for the white space stuff I'm still fine with this. INLINE COMMENTS > taglibextractor.cpp:237 > data.discNumber = itDiscNumber->second.toInt(); > +}

D11811: avoid Asan runtime error: shift exponent -1 is negative

2018-03-30 Thread Sven Brauch
brauch added a comment. Change looks good (the previous code definitely looks like nonsense), but what does this mean for existing settings, saved previously? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11811 To: jtamate, #kate, #frameworks Cc: brauch, michae

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Nathaniel Graham
ngraham added a comment. Sure, I'll check that out later today. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davide

D11811: avoid Asan runtime error: shift exponent -1 is negative

2018-03-30 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Kate, Frameworks. Restricted Application added projects: Kate, Frameworks. jtamate requested review of this revision. REVISION SUMMARY Avoid doing a 1<<-1. TEST PLAN Before: frameworks/ktexteditor/src/completion/katecompletionconfig.cpp

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich added a comment. Okay, I changed my mind, I rebased on top of master. Since the other revision needs more time and the new properties behave like the old ones, I'd like to end this long journey and land this revision if no-one objects :) REPOSITORY R286 KFileMetaData BRANCH en

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich updated this revision to Diff 30951. astippich added a comment. - update value types REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=30950&id=30951 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 AFFEC

D10803: handle more tags in taglibextractor

2018-03-30 Thread Alexander Stippich
astippich updated this revision to Diff 30950. astippich added a comment. - rebase on top of master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10803?vs=28467&id=30950 BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

2018-03-30 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: ltoscano, Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Frameworks. lueck requested review of this revision. REVISION SUMMARY Falkon new browser X11 17 hits in l10n

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Looks good to me. Can you just make sure that kde/applications/konqueror/libkonq/autotests/konqpopupmenutest.cpp still passes after these changes? REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAI

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Andres Betts
abetts accepted this revision. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmustac, davidedmundson, broulik, dfaure, elvisangel

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 194 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/194/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 13:41:05 + Build duration: 37 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/44/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 13:41:05 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Nathaniel Graham
ngraham added a comment. Any remaining objections, or can I land this? REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davided

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 173 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/173/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 13:41:05 + Build duration: 11 min and counting JUnit Tests Name: (root)

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Nathaniel Graham
ngraham marked an inline comment as done. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisan

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Nathaniel Graham
ngraham updated this revision to Diff 30940. ngraham added a comment. Implement review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30584&id=30940 BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kd

Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-03-30 Thread Allen Winter
krop already fixed that On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer bein

D11733: Allow opening items from the open/save dialogs

2018-03-30 Thread Nathaniel Graham
ngraham added a comment. In D11733#236903 , @gregormi wrote: > I come from Windows where the Open item is also available. Not having it feels like a lack of flexibility. I think having it in the context menu will not affect the "normal" user. Y

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

2018-03-30 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R238:3496d899181f: Add entities for Elisa, Markdown, KParts, DOT, SVG to general.entities (authored by lueck). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11619?vs=

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

2018-03-30 Thread Luigi Toscano
ltoscano accepted this revision as: ltoscano. ltoscano added a comment. This revision is now accepted and ready to land. Uh, sorry, thanks, looks good. REVISION DETAIL https://phabricator.kde.org/D11619 To: lueck, #documentation, ltoscano Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

2018-03-30 Thread Burkhard Lück
lueck added a reviewer: ltoscano. REVISION DETAIL https://phabricator.kde.org/D11619 To: lueck, #documentation, ltoscano Cc: #frameworks, michaelh, ngraham, skadinna

D11732: Improve protocols documentation

2018-03-30 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice.xml:67 > earlier you changed all the "compositor" to "server" The usage of terms compositor and server is not clearly regulated in the Wayland world besides that these terms describe the same "application" (fo

D11732: Improve protocols documentation

2018-03-30 Thread Roman Gilg
romangg updated this revision to Diff 30925. romangg marked an inline comment as done. romangg added a comment. - Say properties REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30673&id=30925 BRANCH improveOutputManagementDoc REVISION DETAIL

D11733: Allow opening items from the open/save dialogs

2018-03-30 Thread gregormi
gregormi added a comment. In D11733#235208 , @rkflx wrote: > and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing [F11] preview feature and perhaps a better preview feature in the web app

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Michael Heidelbach
michaelh added a comment. In D11740#236892 , @cfeck wrote: > You made CI happy, merci :) I've been watching it 'live'. I'm happy too. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, el

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Christoph Feck
cfeck added a comment. You made CI happy, merci :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, elvisangelaccio Cc: #frameworks, elvisangelaccio, cfeck, michaelh, ngraham

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin
mart added a dependent revision: D11801: remove m_desktopContainments. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11361 To: mart, #plasma, davidedmundson Cc: davidedmundson, #frameworks, michaelh, ngraham

D11365: also test for value types in taglibextractortest and fix errors

2018-03-30 Thread Michael Heidelbach
michaelh added a comment. Since we're struggling with the same issues: T8196 and D10694 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin
mart added a comment. so, i tried to remove m_desktopContainments in D11801 , using the new query functions i added here. all seems to keep working, hopefully makes things a bit more robust REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10694: epubextractor: Handle multiple subjects better

2018-03-30 Thread Michael Heidelbach
michaelh added a comment. The semicolons problem is fixed now. See T8196 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, nava

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin
mart updated this revision to Diff 30915. mart added a comment. - only consider desktop containments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11361?vs=30914&id=30915 BRANCH arcpatch-D11361 REVISION DETAIL https://phabricator.k

D11361: add a version containmentForScreen with activity

2018-03-30 Thread Marco Martin
mart updated this revision to Diff 30914. mart added a comment. - Merge branch 'master' into arcpatch-D11361 - add containmentsForActivity and containmentsForScreen REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11361?vs=29622&id=30914

D11569: Improve consistency of "Open With" UI by always showing top app inline

2018-03-30 Thread Elvis Angelaccio
elvisangelaccio added a comment. +1 from me, other than the inline comment. INLINE COMMENTS > kfileitemactions.cpp:654 > +// Always show the top app inline > +QAction *act = d->createAppAction(offers.takeFirst(), menu); > +menu->addAction(act); Please use

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 37 - Fixed!

2018-03-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 09:36:59 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 12 - Fixed!

2018-03-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 09:36:59 + Build duration: 7 min 44 sec and counting JUnit Test

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

2018-03-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 09:36:59 + Build duration: 4 min 30 sec and counting JUni

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R236:309c92215e35: ktooltipwidget: Subtract margins from available size (authored by michaelh). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11740?vs=30903&id=3

Re: KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

2018-03-30 Thread Ben Cooksley
On Fri, Mar 30, 2018 at 9:36 PM, Michael Heidelbach wrote: > On 30.03.2018 09:51, CI System wrote: > > *BUILD UNSTABLE* > Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5% > 20SUSEQt5.9/22/ > Project: Frameworks baloo kf5-qt5 SUSEQt5.9 > Date of build: Fri, 30 Mar 2018 07:45:09 +0

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-30 Thread Eike Hein
hein added a comment. I also prefer the "Before" images. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, davidedmundson, plasma-

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Elvis Angelaccio
elvisangelaccio accepted this revision as: elvisangelaccio. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, #frameworks, elvisangelaccio Cc: elvisangelaccio, cfeck, michaelh, ngraham

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Elvis Angelaccio
elvisangelaccio removed a reviewer: Frameworks. This revision is now accepted and ready to land. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH restrict_size REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, elvisangelaccio Cc:

Re: KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

2018-03-30 Thread Michael Heidelbach
On 30.03.2018 09:51, CI System wrote: *BUILD UNSTABLE* Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/22/ Project:Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 07:45:09 + Build duration: 5 min 51 sec and counting

D11768: Add Desktop and Downloads to the default list of Places

2018-03-30 Thread Julian Wolff
progwolff accepted this revision. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 172 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/172/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 07:52:39 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 193 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/193/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 07:52:39 + Build duration: 17 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/43/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 07:52:39 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 54 - Fixed!

2018-03-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 07:45:09 + Build duration: 13 min and counting JUnit Tests Name: (root) F

D11643: Fix crash when device emits ready read after job is finished

2018-03-30 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R241:63ef72e8ac54: Fix crash when device emits ready read after job is finished (authored by aacid). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11643?vs=30387&id=30905

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

2018-03-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 07:45:09 + Build duration: 5 min 51 sec and counting JUnit Tests Name: (ro

D11657: Do not export databasesanitizer by default

2018-03-30 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. Closed by commit R293:1d977a7d49c5: Do not export databasesanitizer by default (authored by michaelh). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11657?vs=30424&id=30904#toc REPOSITORY R293 Baloo CHANGES SIN

D11740: ktooltipwidget: Subtract margins from available size

2018-03-30 Thread Michael Heidelbach
michaelh updated this revision to Diff 30903. michaelh added a comment. - Demonstrate respect to old school ;-) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11740?vs=30888&id=30903 BRANCH restrict_size REVISION DETAIL https://phabricator.kde.