D12320: add ability to read embedded cover files

mgallien added a comment. Thanks a lot to continue to push this work. In D12320#249433 , @bruns wrote: > Baloos DBs should only contain searchable data. So until someone teaches baloo how to compare images, it should be kept separate.

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 05:47:12 + Build duration: 1 min 9 sec and counting JUnit Tests

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: anemeth, #frameworks, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: anemeth, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: anemeth, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham added a dependent revision: D12337: Give the file dialogs a "Sort by" menu button on the toolbar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: anemeth, rkflx, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. ngraham added a dependency: D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does. Restricted Application added a p

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham updated this revision to Diff 32533. ngraham added a comment. Improve a comment CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=32532&id=32533 BRANCH move-sort-order-chooser-to-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12337 AF

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG, rkflx. ngraham requested review of this revision. REVISION SUMMARY This patch moves the sort order chooser and options out of the somewhat hidden Settings menu and onto the main toolbar, in conjunction with a few

D12077: Show view mode buttons in the open/save dialog's toolbar

abetts added a comment. In D12077#249447 , @ngraham wrote: > In D12077#249446 , @abetts wrote: > > > Somewhat related, why does the Size header have a number of items listed and not the size in bytes

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. In D12077#249446 , @abetts wrote: > Somewhat related, why does the Size header have a number of items listed and not the size in bytes for all the items inside the folder? > > size > > 0 items > 2 items > >

D12077: Show view mode buttons in the open/save dialog's toolbar

abetts added a comment. Somewhat related, why does the Size header have a number of items listed and not the size in bytes for all the items inside the folder? size 0 items 2 items Shouldn't it be: size 1 kb 3 Mb ?? REPOSITORY R241 KIO REVISION DETAIL https

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/134/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 19 Apr 2018 03:18:21 + Build duration: 4 min 50 sec and counting JU

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/109/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 03:18:21 + Build duration: 2 min 54 sec and counting

D12321: Hide file preview when icon is too small

ngraham added a reviewer: Dolphin. ngraham added a subscriber: sharvey. ngraham added a comment. In D12321#249367 , @rkflx wrote: > The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but onc

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 220 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/220/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 19 Apr 2018 02:18:41 + Build duration: 16 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 199 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/199/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 02:18:41 + Build duration: 15 min and counting JUnit Tests Name: (root)

D12328: Enable preview by default in the filepicker dialog

ngraham added a comment. This depends on D12321 and enables D12326 ; there are a lot of changes in flight here. But the overall goal here is explained in T8552 : we want to make Short

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham updated this revision to Diff 32531. ngraham added a comment. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12326?vs=32508&id=32531 BRANCH short-view-has-icons-on-top-by-default (branched from master) REVISION DETAIL http

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/69/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 19 Apr 2018 02:18:41 + Build duration: 7 min 4 sec and counting JUnit Tests Name: (root) F

D12320: add ability to read embedded cover files

bruns added a comment. Baloos DBs should only contain searchable data. So until someone teaches baloo how to compare images, it should be kept separate. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #framewo

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. Asking around on IRC and Telegram, I haven't found anyone who objects to this. Landing it. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: sharvey, rkflx, mmustac,

D12197: autotests: Test for multiple values

bruns added inline comments. INLINE COMMENTS > multivaluetest.cpp:90 > +<< QStringLiteral("application/epub+zip") > +<< Property::Subject > +<< QVariantList{QVariant(QStringLiteral("Baloo KFileMetaData"))} Here you use the property value directly, while in other places yo

D12336: Replace several Q_ASSERTs with proper checks

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The code has some preconditions on supplied values when

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Some users apparently have DBs which contain infinite lo

D12251: Integrate with androiddeployqt dependencies files

apol added a comment. I don't really see why we need a special path for parts. > I understand you're doing it to be able to just get everything from that folder and then put it on the apk > > Now without knowing anything about cmake, wouldn't it make more sense put on the apk every

D12328: Enable preview by default in the filepicker dialog

abetts added a comment. What would it look like if it was enabled by default? Screenshot? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. > This also enables it for users who previously disabled it. Hm, normally changing a default is allowed, while overriding custom user settings is discouraged. However, for a `bo

D12321: Hide file preview when icon is too small

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when sh

D12077: Show view mode buttons in the open/save dialog's toolbar

sharvey added a comment. +1 for making things easier and prettier. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: sharvey, rkflx, mmustac, broulik, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

rkflx added a comment. Please add a mockup of how your final vision of the dialog looks like after all changes in T8552 are done, in particular "Move the File Name field to the top of the window" and any toolbar additions. Otherwise it's really hard to ju

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: anemeth, rkflx, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch adopts Dolphin's location for the toolbar: above all other widgets. This improves consiste

D11685: Implement single click on line number to select line of text

ngraham added a subscriber: dhaumann. ngraham added a comment. @cullmann @dhaumann ping? I'm quite fond of this, myself. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolf

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. In D12311#249270 , @sharvey wrote: > F5812033: Screenshot_20180418_161500.png > The good news is that it still behaves properly with a scaled display. > > The bad news is that

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812033: Screenshot_20180418_161500.png The good news is that it still behaves properly with a scaled display. The bad news is that, due to the `minimumSize` we configured for System Settings, I can't get back to the bott

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. I think it would be worth it! It's definitely not a crown jewel of polished UI design, that's for sure. To test scaling, try setting a systemwide scale factor in System Settings > Display and Monitor > Displays > Scale Display, then logging out and back in, then

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. F5812014: Screenshot_20180418_155156.png The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a separate process?). I don't have a HiDPI display to test on. I tried different fonts up to 15pt and all

D12108: ffmpegextractor: Silence deprecation warnings

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks. I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ? REPOSITORY R286 KFi

D12251: Integrate with androiddeployqt dependencies files

aacid added inline comments. INLINE COMMENTS > part.h:69 > + * This KPart will be exported as a plugin. It requires a desktop file that > + * needs to be installed to be installed to ${KDE_INSTALL_KSERVICES5DIR} with > + * its exposed interfaces (e.g. > X-KDE-ServiceTypes=KParts/ReadOnlyPart,KPa

D12156: implement reading of rating tag

mgallien requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12156: implement reading of rating tag

mgallien added a comment. Thanks. Fix one issue and we should be good to go. Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere else. INLINE COMMENTS > taglibextractor.cpp:222-234 > +if (temp == 0) { > +

D12327: [WIP/open dependencies] Show Detailed Tree View by default

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: #frameworks, michaelh, bruns

D11489: Make concatenated strings wrappable

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. You could even push directly for this kind of changes. REPOSITORY R286 KFileMetaData BRANCH wrappable REVISION DETAIL https://phabricator.kde.org/D11489 To: michaelh, mgallien,

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D12240 To: ngraham, #frameworks, davidedmundson Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks Cc: dhaumann, rkflx, michaelh, bruns

D12227: Save the dialog view settings even when canceling

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry, that was a local problem. REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgal

D12328: Enable preview by default in the filepicker dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

ngraham added a dependent revision: D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham edited the summary of this revision. ngraham added a dependency: D12328: Enable preview by default in the filepicker dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: anemeth, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. anemeth added a dependency: D12321: Hide file preview when icon is too small. REPOSITORY R241 KIO REVISION DETAIL https:/

D12321: Hide file preview when icon is too small

anemeth added a dependent revision: D12328: Enable preview by default in the filepicker dialog. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12197: autotests: Test for multiple values

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. The test for mp3 is failing to complete. I am investigating. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frame

D12311: Align lock icon with bold message text; reduce overall size of dialog

broulik added a comment. I think there's something severly wrong with the dialog's size hints if we need to add arbitrary numbers all over the place. Can you make sure this doesn't break with - different font - larger font - screen scaling - different widget style - ... REPOSITO

D12328: Enable preview by default in the filepicker dialog

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12328 AFFECTED FILES src/fi

D12327: [WIP/open dependencies] Show Detailed Tree View by default

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: #frameworks, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Show Detailed Tree View by default in KDirOperator. This primarily affects the file open/save dia

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham added inline comments. INLINE COMMENTS > anemeth wrote in kdiroperator.cpp:2605 > What is the relation between 43 and 64px? > Does this hardcoded number also work when scaled? The number is a 0-100 scale, with 0 corresponding to 16px, and 100 corresponding to 128px, and all other number

D10694: epubextractor: Handle multiple subjects better

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-subject REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks, as

D12197: autotests: Test for multiple values

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R286 KFileMetaData BRANCH multi-value-test REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhni

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

anemeth added inline comments. INLINE COMMENTS > kdiroperator.cpp:2605 > +// "43" Corresponds to a default size of 64px > +return configGroup->readEntry("listViewIconSize", 43); > } else { What is the relation between 43 and 64px? Does this hardcoded number also work when sc

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham edited the summary of this revision. ngraham added a dependency: D12306: Filepicker dialog proper grid icon layout. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

ngraham added a dependent revision: D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham Cc: abetts, rkflx, ngraham, #framew

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: #frameworks, michaelh, bruns

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch increases the default size of the icons in Short View to 64px, to facilitate using the

D12321: Hide file preview when icon is too small

ngraham added a comment. (BTW the visible flickering when you resize the icons using the slider is a pre-existing issue. We should fix that though. Something else to add to the workboard...) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 To: ane

D12321: Hide file preview when icon is too small

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

ngraham accepted this revision. ngraham added a reviewer: rkflx. ngraham added a subscriber: rkflx. ngraham added a comment. This revision is now accepted and ready to land. Very nice, works great for me. Once this goes in, I think we can safely turn on previews by default, because we won't re

D12306: Filepicker dialog proper grid icon layout

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

anemeth added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:2253 > Why is this needed? Without this the icon grid gets only updated when the zoom slider is moved, and it needs to get updated when the window is resized as well. REPOSITORY R241 KIO REVISION DETAIL htt

D12306: Filepicker dialog proper grid icon layout

ngraham added a comment. This is great! Much better than my patch. I tested it six ways to Sunday and couldn't break it. One comment: INLINE COMMENTS > kdiroperator.cpp:2253 > + > +d->updateListViewGrid(); > } Why is this needed? REPOSITORY R241 KIO REVISION DETAIL https://phabri

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a reviewer: Frameworks. ngraham accepted this revision. ngraham added a comment. Much better! I'd still prefer less whitespace, but this is already an improvement. But now that I'm staring at this dialog over and over again, I'm wondering if we even need the non-bold caption tex

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32500. anemeth added a comment. Apply to all type of views REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32495&id=32500 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 AFFECTED FILES src/

D12321: Hide file preview when icon is too small

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: VDG, Frameworks. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks Cc: ngraham, #fram

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32495. anemeth added a comment. Remove accidental white space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32494&id=32495 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 AFFECTED FILES s

D12321: Hide file preview when icon is too small

anemeth created this revision. anemeth added a project: Frameworks. anemeth requested review of this revision. REVISION SUMMARY file preview REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12321 AFFECTED FILES src/filewidgets/kdiroperator.cpp To: aneme

D12320: add ability to read embedded cover files

astippich added a comment. This revision is only one possibility and is mainly there to start the discussion again on how to read the embedded picture data from e.g. audio files. Before this can land, Baloo has to be patched in order to cope with binary data. I think for Baloo there are tw

D12320: add ability to read embedded cover files

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY read the embedded image of audio files as

D12306: Filepicker dialog proper grid icon layout

anemeth added a comment. F5811818: a1.PNG REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32488. anemeth added a comment. Reduced vertical spacing. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12306?vs=32472&id=32488 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12306 AFFECTED FILES src/f

D12283: Allow to load dictionaries form a rcc

mlaurent added inline comments. INLINE COMMENTS > hunspelldict.cpp:104 > delete m_speller; > +if (m_tempDir) { > +delete m_tempDir; not necessary to check pointer here. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth,

D12306: Filepicker dialog proper grid icon layout

ngraham added a comment. In D12306#248869 , @abetts wrote: > I also vote for a little more vertical spacing. Maybe in similar ways to what Marco Martin did recently for spacing in System Settings. Did you mean a little less? @rkflx is obj

D12306: Filepicker dialog proper grid icon layout

abetts added a comment. I also vote for a little more vertical spacing. Maybe in similar ways to what Marco Martin did recently for spacing in System Settings. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: abetts, rkflx, ngraha

D12306: Filepicker dialog proper grid icon layout

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

rkflx added a comment. Cool! Can you also tweak the vertical spacing a bit? Currently Nate displays 2 rows of text (left), while your patch shows 3 (right), resulting in fewer items visible at once. Of course the best course of action would be to make this adapt dynamically to the filename l

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham abandoned this revision. ngraham added a subscriber: anemeth. ngraham added a comment. Abandoning this revision in favor of the superior one that @anemeth submitted: D12306 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. Ping. Any objections from #frameworks people? REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik

D12306: Filepicker dialog proper grid icon layout

anemeth added a comment. F5811675: tiny_icons.webm REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32472. anemeth added a comment. Fixed icon spacing when icons are small. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12306?vs=32470&id=32472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12306 AFFECTE

D12306: Filepicker dialog proper grid icon layout

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg Cc: rkflx, ngraham, #frameworks, michaelh, bruns

  1   2   >