KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/23/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 22 Oct 2019 03:10:21 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  [...truncated 1045 lines...][2019-10-22T03:40:15.864Z] QDEBUG : KMoreToolsTest::test_MenuStructureDto_sortListBySection() 'Uninstalled' first, p1[2019-10-22T03:40:15.864Z] QDEBUG : KMoreToolsTest::test_MenuStructureDto_sortListBySection() 'Uninstalled' first, p2[2019-10-22T03:40:15.864Z] QDEBUG : KMoreToolsTest::test_MenuStructureDto_sortListBySection() 'Uninstalled' first, p3[2019-10-22T03:40:15.864Z] QDEBUG : KMoreToolsTest::test_MenuStructureDto_sortListBySection() 'Uninstalled' first, p4[2019-10-22T03:40:15.864Z] PASS   : KMoreToolsTest::test_MenuStructureDto_sortListBySection()[2019-10-22T03:40:15.864Z] PASS   : KMoreToolsTest::test_MenuStructureDto_serialize()[2019-10-22T03:40:15.864Z] PASS   : KMoreToolsTest::test_MenuStructureDto_deserialize()[2019-10-22T03:40:15.864Z] FAIL!  : KMoreToolsTest::test_KmtUrlUtil_localFileAbsoluteDir() Compared values are not the same[2019-10-22T03:40:15.864Z]Actual   (urlOut.toString()): "file:///C:/etc"[2019-10-22T03:40:15.864Z]Expected (QString(_("file:///etc"))): "file:///etc"[2019-10-22T03:40:15.864Z] C:\CI\workspace\Frameworks\knewstuff\kf5-qt5 WindowsMSVCQt5.13\autotests\kmoretools\kmoretoolstest.cpp(397) : failure location[2019-10-22T03:40:15.864Z] PASS   : KMoreToolsTest::cleanupTestCase()[2019-10-22T03:40:15.864Z] Totals: 19 passed, 1 failed, 0 skipped, 0 blacklisted, 3347ms[2019-10-22T03:40:15.864Z] * Finished testing of KMoreToolsTest *[2019-10-22T03:40:15.864Z] [2019-10-22T03:40:15.864Z] [2019-10-22T03:40:15.864Z] 67% tests passed, 1 tests failed out of 3[2019-10-22T03:40:15.864Z] [2019-10-22T03:40:15.864Z] Total Test time (real) =  12.56 sec[2019-10-22T03:40:15.864Z] [2019-10-22T03:40:15.864Z] The following tests FAILED:[2019-10-22T03:40:15.864Z] 	  3 - kmoretoolstest (Failed)[2019-10-22T03:40:15.864Z] Errors while running CTest[2019-10-22T03:40:16.476Z] ERROR: The process "kded5.exe" not found.[2019-10-22T03:40:16.476Z] ERROR: The process "klauncher.exe" not found.[2019-10-22T03:40:16.476Z] ERROR: The process "kdeinit5.exe" not found.[2019-10-22T03:40:16.476Z] ERROR: The process "test_crasher.exe" not found.[2019-10-22T03:40:16.476Z] ERROR: The process "dbus-daemon.exe" not found.[2019-10-22T03:41:17.827Z] ERROR: The process "kioslave.exe" not found.[2019-10-22T03:41:17.827Z] ERROR: The process "vctip.exe" not found.[Pipeline] junit[2019-10-22T03:41:18.351Z] Recording test results[2019-10-22T03:41:20.582Z] Remote call on JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-22T03:41:21.297Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from kil-oss-2.ITS.Dal.Ca/192.75.96.253:59975[2019-10-22T03:41:21.297Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-22T03:41:21.297Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-22T03:41:21.297Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-22T03:41:21.297Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-10-22T03:41:21.297Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-10-22T03:41:21.297Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-10-22T03:41:21.297Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-10-22T03:41:21.297Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-10-22T03:41:21.297Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-10-22T03:41:21.297Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-10-22T03:41:21.297Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-22T03:41:21.297Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-22T03:41:21.297Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-10-22T03:41:21.297Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)[2019-10-22T03:41:21.297Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)[2019-10-22T03:41:21.297Z] 		at java.lang.Thread.run(Thread.java:748)[2019-10-22T03:41:21.297Z] java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins[2019-10-22T03:41:21.297Z] 	at hudson.ExtensionList.lookup(ExtensionList.java:433)[2019-10-22T03:41:21.297Z] 	at hudson.tasks.junit.TestNameTransformer.all(TestNameTransformer.java:40)[2019-10-22T03:41:21.297Z] 	at 

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth updated this revision to Diff 68488.
vonreth added a comment.


  - Raise CMake requirements to 3.5

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68486=68488

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  CMakeLists.txt
  kde-modules/KDECompilerSettings.cmake
  tests/ECMAddAppIconTest/CMakeLists.txt
  tests/ECMAddTests/multi_tests/CMakeLists.txt
  tests/ECMAddTests/single_tests/CMakeLists.txt
  tests/ECMInstallIconsTest/CMakeLists.txt
  tests/ECMPoQmToolsTest/CMakeLists.txt
  tests/ECMQMLModules/CMakeLists.txt
  tests/ECMQtDeclareLoggingCategoryTest/CMakeLists.txt
  tests/ECMSetupVersionTest/old_header/CMakeLists.txt
  tests/ECMSetupVersionTest/old_header_abspath/CMakeLists.txt
  tests/ECMSetupVersionTest/old_simple/CMakeLists.txt
  tests/ECMSetupVersionTest/old_soversion/CMakeLists.txt
  tests/ECMSetupVersionTest/old_version_file/CMakeLists.txt
  tests/ECMSetupVersionTest/old_version_file_abspath/CMakeLists.txt
  tests/ECMSetupVersionTest/old_version_file_anynewer/CMakeLists.txt
  tests/ECMSetupVersionTest/old_version_file_exact/CMakeLists.txt
  tests/ECMSetupVersionTest/old_version_file_samemajor/CMakeLists.txt
  tests/ExecuteCoreModules/CMakeLists.txt
  tests/ExecuteKDEModules/CMakeLists.txt
  tests/FindModules/CMakeLists.txt
  tests/KDEFetchTranslations/CMakeLists.txt
  tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt
  tests/KDEInstallDirsTest/vars_in_sync/CMakeLists.txt
  tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt
  tests/UseFindModules/CMakeLists.txt

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[David Faure]

dfaure added a comment.


  Dunno, it's harder to justify in a standalone review :)
  "Increase dependency, just because" ;)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth added a comment.


  I guess we should do that in a separate review?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[David Faure]

dfaure added a comment.


  Works for me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth updated this revision to Diff 68486.
vonreth added a comment.


  Fix

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68478=68486

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/50/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 21 Oct 2019 18:26:06 +
 Build duration:
2 hr 2 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D24841: Use modern way to set the C/CXX standad

[Albert Astals Cid]

aacid added a comment.


  If you want to increase cmake dependency, we should at least increase it to 
3.5
  
  https://repology.org/project/cmake/badges

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: aacid, chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> KDECompilerSettings.cmake:208
> +set(CMAKE_C_STANDARD 90)
> +set(CMAKE_CXX_STANDARD_REQUIRED 11)
>  

That's not how it works.
You want

  set(CMAKE_CXX_STANDARD 11)
  set(CMAKE_CXX_STANDARD_REQUIRED TRUE)

Note however that these require CMake >= 3.1, while ECM says 
`cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)`. I do however thing that 
ECM *should* require 3.1.
I doubt it's been tested on 2.8.x in ages, and 3.1 is really a common 
requirement these days.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/126/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 19:53:24 +
 Build duration:
9 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 125 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/125/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 19:33:00 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 124 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/124/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 19:25:55 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka added a comment.


  Moved to D24843 

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 123 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/123/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 19:19:23 +
 Build duration:
6 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.messagetestName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 122 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/122/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 19:07:17 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

[Ralf Habacker]

This revision was automatically updated to reflect the committed changes.
Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a 
predefined QPrinter instance (authored by habacker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19504?vs=67894=68479#toc

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=67894=68479

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth updated this revision to Diff 68478.
vonreth added a comment.


  CMAKE_CXX_STANDARD_REQUIRED

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68475=68478

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth, dfaure, cullmann
Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth added a comment.


  In D24841#551653 , @chehrlic wrote:
  
  > I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler 
actually *can* c++11, otherwise the flag is only added when the compiler 
supports it. Should not make much difference nowadays but since it's in ECM...
  
  
  Good point.
  I also tried to investigate the supported C standard by msvc, they say C99 is 
there but still incomplete.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 121 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/121/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 18:46:56 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

D24841: Use modern way to set the C/CXX standad

[Christian Ehrlicher]

chehrlic added a comment.


  I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler 
actually *can* c++11, otherwise the flag is only added when the compiler 
supports it. Should not make much difference nowadays but since it's in ECM...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: chehrlic, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth updated this revision to Diff 68475.
vonreth added a comment.


  Change message

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24841?vs=68473=68475

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth, dfaure, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth added reviewers: dfaure, cullmann.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24841

To: vonreth, dfaure, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24841: Use modern way to set the C/CXX standad

[Hannah von Reth]

vonreth created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vonreth requested review of this revision.

REVISION SUMMARY
  Raise C from C89 ti C90 as C89 is not supported by the CMAKE flag
  
  
https://cmake.org/cmake/help/v3.16/prop_tgt/C_STANDARD.html#prop_tgt:C_STANDARD

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  cmake_c_standard

REVISION DETAIL
  https://phabricator.kde.org/D24841

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: vonreth
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas updated this revision to Diff 68472.
hallas added a comment.


  Reorder functions to make diff smaller

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21235?vs=68324=68472

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas marked an inline comment as done.
hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabhandling.cpp:301
> Please keep these functions at their current position, just adds unnecessary 
> noise in the diff.

Good point :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:49
>  if(KIO_ASSERT_SLAVE_STATES AND NOT CMAKE_BUILD_TYPE MATCHES "[Dd]ebug$")
> -message(FATAL_ERROR "KIO_ASSERT_SLAVE_STATES option enabled but not a 
> Debug build. This makes no sense!")
> +# ECM_SOURCE_UNDER_VERSION_CONTROL also auto-enables Debug, so this
> +# should generally not happen:

It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or 
RelWithDebInfo (as I do for profiling).

Won't this give them the warning below then, even if they don't set the 
KIO_ASSERT_SLAVE_STATES option)?

I would just set ASSERT_SLAVE_STATES_DEFAULT to OFF when the build type isn't 
Debug.
(i.e. checking for that as part of the condition on line 42)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a51651fd91a2: Update elisa icon (authored by astippich).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=68192=68470

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24593: Modified breeze shadows

[Nathaniel Graham]

ngraham added a comment.


  Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bbe0148db5d1: Improve panel options menu entries 
(authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=68467=68469

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D23951

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 removed a dependent revision: D24162: Hide "Lock Widgets" button from 
panel edit mode toolbar.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 updated this revision to Diff 68467.
GB_2 added a comment.


  Don't hide lock action here

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=8=68467

BRANCH
  arcpatch-D23951

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve panel options menu entries

[Björn Feber]

GB_2 retitled this revision from "Improve and clean up panel options menu 
entries" to "Improve panel options menu entries".
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 marked an inline comment as done.
GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  >  apart from that, it looks good
  
  
  Wait, doesn't that mean you won't be able to unlock it anymore?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Nathaniel Graham]

ngraham added a comment.


  In D24773#551245 , @meven wrote:
  
  > I would argue that "Disk space usage" and "Size" might be confusing to 
users. A folder size is the size of his content idiomatically.
  >  That is our current usage of Size field for folders that is weird : My 
Image folder Size is "42 elements".
  >  That is a paper cut that all new Plasma users have to learn "Size for 
folders is a content description" : not very intuitive.
  >  We may want to in fact rename this field for folders to "Content" and keep 
Size for actual disk usage size (except in details view Size column of course).
  
  
  Personally I would prefer it if we could actually calculate the total of a 
folder's contents: https://bugs.kde.org/show_bug.cgi?id=158090
  
  I tried to do this once and found that it was possible, but would need a lot 
of work to ensure adequate performance, and probably a lot of caching. I come 
from the macOS world where this is implemented and has no appreciable 
performance penalty whatsoever so I know it's possible.
  
  However this is probably unrelated to the current patch.
  
  Regarding this patch, I think the "Size" field for the trash should always 
show the total on-disk size of what's in the trash, regardless of the above, 
because the question that the user is looking to answer is, "How much space am 
I going to get back if I empty the trash right now?" For that, we need to 
always show the on-disk size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve and clean up panel options menu entries

[Marco Martin]

mart added a comment.


  probably some special casing for that action will still be needed in the 
panel, but should be ok

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24676

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24799: Port away from deprecated SmallIcon method

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3b082be3acdd: Port away from deprecated SmallIcon method 
(authored by vkrause).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24799?vs=68347=68454

REVISION DETAIL
  https://phabricator.kde.org/D24799

AFFECTED FILES
  src/ksettings/componentsdialog.cpp

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24676

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 added a comment.


  In D23951#551472 , @mart wrote:
  
  > i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in 
the UI (hide "Lock Widgets" from the UI)  i would try to go from the context 
menu plugin instead and not adding the action there by default (but still 
possible to add it)
  
  
  Ok, will do that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Marco Martin]

mart requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Marco Martin]

mart added a comment.


  i'm not sure i would hardcode the behavior Only show "Unlock Widgets" in the 
UI (hide "Lock Widgets" from the UI)  i would try to go from the context menu 
plugin instead and not adding the action there by default (but still possible 
to add it)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[David Edmundson]

davidedmundson added a comment.


  > Ping.
  
  It's already accepted by Marco isn't it?

INLINE COMMENTS

> containment.cpp:126
> +if (d->type == Types::PanelContainment || d->type == 
> Types::CustomPanelContainment) {
> +configAction->setText(i18nc("%1 is the name of the applet", 
> "Edit %1...", title()));
> +
> configAction->setIcon(QIcon::fromTheme(QStringLiteral("document-edit")));

"name of the containment" surely?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, 
GB_2, michaelh, bruns

D23951: Improve and clean up panel options menu entries

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23537: extend state verification to open connection commands

[Harald Sitter]

sitter added a comment.


  I've actually started work on a more general system for this. Will update 
soon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23537

To: sitter, dfaure
Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23537: extend state verification to open connection commands

[Harald Sitter]

sitter planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23537

To: sitter, dfaure
Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka added a comment.


  > First, it will not have memory leaks, we take ownership on parentless menu, 
on menu that has a parent, it will destroy it by parent-child cleanups.
  
  Yes, eventually menu will be deleted. I'm thinking about the situation when 
someone has:
  
if (configuration-trayIconEnabled) {
   m_sni = new KStatusNotifierItem();
   m_sni->setContextMenu(new QMenu(**this**));
} else {
  delete m_sni;
}
  
  and user is playing with this setting and changes it 100 times during one 
session. It will create 100 QMenu instances.
  
  > I want to be more clear why SystemTrayMenu is not destroyed on hide, the 
idea behind that code is to be created a new try menu. On updateMenu you call 
it by same object that's why it's not destroyed, did you have stack strace, 
that's not normal to me.
  
  That's how QSystemTrayIcon works, I checked the source code. 
QSystemTrayIcon::show() and QSystemTrayIcon::hide will create and destroy 
KDEPlatformSystemTrayIcon (this is a little bit more complicated, because there 
are also two additional methods involved: init and cleanup). 
  For menu, QSystemTrayIcon uses:
  
QPlatformMenu* KDEPlatformSystemTrayIcon::createMenu()
  
  which is kept alive until QSystemTrayIcon instance exist.
  So something like this:
  
QSystemTrayIcon *sysTray = new QSystemTrayIcon(this);
sysTray->setContextMenu(new QMenu()); // create QPlatformMenu (AFAIR it is 
postponed, but you get the idea)
sysTray->show(); // create QPlatformSystemTrayIcon
sysTray->hide(); // delete QPlatformSystemTrayIcon
sysTray->show(); // create second QPlatformSystemTrayIcon and reuse 
QPlatformMenu
  
  Will create two instances of KDEPlatformSystemTrayIcon 
(QPlatformSystemTrayIcon) and only one of SystemTrayMenu (QPlatformMenu).
  
  Anyway, this whole "do not take ownership" is a dead end. Even if menu is not 
deleted, it won't work, there is another issue in dbusmenu-qt library... I 
abandon this idea, sorry for taking your time. I have another solution, in:
  
void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu)
{
if (SystemTrayMenu *ourMenu = qobject_cast(menu)) {
m_sni->setContextMenu(ourMenu->menu());
}
}
  
  SystemTrayMenu::menu() will return new QMenu and keep track of changes.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka abandoned this revision.
kmaterka added a comment.


  This is a dead end, I will implement different solution in QPA 
(KDEPlatformSystemTrayIcon) plugin.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Re: Quick Charts in KDE Review

[Alexander Potashev]

Hi Arjen,

1. I don't see any checks in the autotests. Would it be easy to
compare the displayed chart against a reference screenshot image, in
each of the tests?

The same screenshots could also help developers understand what kind
of charts kquickcharts is good for.

2. How to add a grid, ticks and labels to a line chart?

пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra :
>
> On 21-10-2019 15:22, Arjen Hiemstra wrote:
> > Hi,
> >
> > Quick Charts has been moved to KDE review. The intent is to make it a
> > Tier 1 framework.
> >
> > Quick Charts is a QML module that implements a set of
> > high-performance, GPU accelerated
> > charts. Currently the main user of it is a new KSysGuard UI I have
> > been working on, but
> > once it is part of Frameworks I also hope to convert several bits of
> > Plasma to using it.
>
> And of course, a link would be useful:
>
> https://invent.kde.org/kde/kquickcharts
>
> >
> > - Arjen



-- 
Alexander Potashev

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D24755#551320 , @kmaterka wrote:
  
  > In D24755#550415 , 
@anthonyfieroni wrote:
  >
  > > That should be fine, in QPA we have a tray icon per sni, update menu 
should be on same object which will not be a problem, check it.
  >
  >
  > There are two objects in QPA that live independently:
  >
  > - KDEPlatformSystemTrayIcon (QPlatformSystemTrayIcon), with KSNI instance, 
KSNI and KDEPlatformSystemTrayIcon **are** destroyed on QSystemTrayIcon->hide() 
and new instance (with new KSNI) is created on QSystemTrayIcon->show()
  > - SystemTrayMenu (QPlatformMenu) is **not** destroyed on 
QSystemTrayIcon->hide() and will be reused later on QSystemTrayIcon->show()
  >
  >   kdeplatformsystemtrayicon.cpp#L339 

  >
  >   ``` void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu) { 
//... if (SystemTrayMenu *ourMenu = qobject_cast(menu)) { 
m_sni->setContextMenu(ourMenu->menu()); } } ```
  >
  >   About you patch: I understand your idea, but it changes API contract and 
is not backward-compatible. Current documentation says:
  >
  > > The KStatusNotifierItem instance takes ownership of the menu, and will 
delete it upon its destruction.
  >
  > This is quite clear, I want to be really careful here - I don't want to be 
blamed for memory leaks :) I think that we need to keep:
  
  
  First, it will not have memory leaks, we take ownership on parentless menu, 
on menu that has a parent, it will destroy it by parent-child cleanups.
  I want to be more clear why SystemTrayMenu is not destroyed on hide, the idea 
behind that code is to be created a new try menu. On updateMenu you call it by 
same object that's why it's not destroyed, did you have stack strace, that's 
not normal to me.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Re: Quick Charts in KDE Review

[Arjen Hiemstra]

On 21-10-2019 15:22, Arjen Hiemstra wrote:

Hi,

Quick Charts has been moved to KDE review. The intent is to make it a
Tier 1 framework.

Quick Charts is a QML module that implements a set of
high-performance, GPU accelerated
charts. Currently the main user of it is a new KSysGuard UI I have
been working on, but
once it is part of Frameworks I also hope to convert several bits of
Plasma to using it.


And of course, a link would be useful:

https://invent.kde.org/kde/kquickcharts



- Arjen

Quick Charts in KDE Review

[Arjen Hiemstra]

Hi,

Quick Charts has been moved to KDE review. The intent is to make it a 
Tier 1 framework.


Quick Charts is a QML module that implements a set of high-performance, 
GPU accelerated
charts. Currently the main user of it is a new KSysGuard UI I have been 
working on, but
once it is part of Frameworks I also hope to convert several bits of 
Plasma to using it.


- Arjen

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 283 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/283/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 21 Oct 2019 13:24:03 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)57%
(34834/61638)41%
(17628/43520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9656/10118)47%
(4504/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8803/14531)52%
(4576/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(522/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1800/4291)36%
(1309/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D24821: Add ManagedConfigModule

[Nathaniel Graham]

ngraham added a dependent revision: D24822: Port the desktoptheme kcm to 
ManagedConfigModule.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/152/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 13:24:03 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24824: Remove outdated comment about [$e] expansion

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:4eddf7a469e1: Remove outdated comment about [$e] 
expansion (authored by davidedmundson).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24824?vs=68415=68432

REVISION DETAIL
  https://phabricator.kde.org/D24824

AFFECTED FILES
  src/quickaddons/configmodule.h

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka added a comment.


  In D24755#550415 , @anthonyfieroni 
wrote:
  
  > That should be fine, in QPA we have a tray icon per sni, update menu should 
be on same object which will not be a problem, check it.
  
  
  There are two objects in QPA that live independently:
  
  - KDEPlatformSystemTrayIcon (QPlatformSystemTrayIcon), with KSNI instance, 
KSNI and KDEPlatformSystemTrayIcon **are** destroyed on QSystemTrayIcon->hide() 
and new instance (with new KSNI) is created on QSystemTrayIcon->show()
  - SystemTrayMenu (QPlatformMenu) is **not** destroyed on 
QSystemTrayIcon->hide() and will be reused later on QSystemTrayIcon->show()
  
  kdeplatformsystemtrayicon.cpp#L339 

  
void KDEPlatformSystemTrayIcon::updateMenu(QPlatformMenu *menu)
{
//...
if (SystemTrayMenu *ourMenu = qobject_cast(menu)) {
m_sni->setContextMenu(ourMenu->menu());
}
}
  
  About you patch: I understand your idea, but it changes API contract and is 
not backward-compatible. Current documentation says:
  
  > The KStatusNotifierItem instance takes ownership of the menu, and will 
delete it upon its destruction.
  
  This is quite clear, I want to be really careful here - I don't want to be 
blamed for memory leaks :) I think that we need to keep:
  
  > d->menu->setParent(nullptr);
  
  in setContextMenu.
  
  Then, to prevent menu deletion, developer needs to explicitly retake 
ownership, for example:
  
QMenu *menu = ourMenu->menu()
QWidget *parent = menu->parent();
m_sni->setContextMenu(menu);
menu->setParent(parent);
  
  The problem is that SystemTrayMenu->menu() has no parent and there is no 
QWidget to use...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/49/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 21 Oct 2019 07:43:11 +
 Build duration:
5 hr 41 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeStill waiting to schedule taskWaiting for next available executor on ‘WindowsMSVCQt5.13’Running on Windows Builder 1 in C:\CI\workspace\Frameworks\breeze-icons\kf5-qt5 WindowsMSVCQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2019-10-21T13:14:20.340Z] [2019-10-21T13:14:20.341Z] C:\CI\workspace\Frameworks\breeze-icons\kf5-qt5 WindowsMSVCQt5.13>if exist "C:\CI\Software Installs\breeze-icons" rmdir /s /q "C:\CI\Software Installs\breeze-icons" [Pipeline] checkout[2019-10-21T13:14:21.574Z] No credentials specified[2019-10-21T13:14:21.580Z] Cloning the remote Git repository[2019-10-21T13:14:22.486Z] Cloning repository git://anongit.kde.org/breeze-icons[2019-10-21T13:14:22.486Z]  > git init C:\CI\workspace\Frameworks\breeze-icons\kf5-qt5 WindowsMSVCQt5.13 # timeout=10[2019-10-21T13:14:24.274Z] Fetching upstream changes from git://anongit.kde.org/breeze-icons[2019-10-21T13:14:24.274Z]  > git --version # timeout=10[2019-10-21T13:14:24.427Z]  > git fetch --tags --progress git://anongit.kde.org/breeze-icons +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-21T13:14:50.277Z]  > git config remote.origin.url git://anongit.kde.org/breeze-icons # timeout=10[2019-10-21T13:14:50.538Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-21T13:14:50.858Z]  > git config remote.origin.url git://anongit.kde.org/breeze-icons # timeout=10[2019-10-21T13:14:51.252Z] Fetching upstream changes from git://anongit.kde.org/breeze-icons[2019-10-21T13:14:51.252Z]  > git fetch --tags --progress git://anongit.kde.org/breeze-icons +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-21T13:14:59.903Z] Checking out Revision d1b0f7d9044902a2faf14845e533dea1736ac6eb (origin/master)[2019-10-21T13:15:00.575Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-10-21T13:15:00.805Z]  > git config core.sparsecheckout # timeout=10[2019-10-21T13:15:00.988Z]  > git checkout -f d1b0f7d9044902a2faf14845e533dea1736ac6eb # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-10-21T13:25:01.481Z] hudson.plugins.git.GitException: Command "git checkout -f d1b0f7d9044902a2faf14845e533dea1736ac6eb" returned status code -1073741510:[2019-10-21T13:25:01.482Z] stdout: [2019-10-21T13:25:01.482Z] stderr: [2019-10-21T13:25:01.482Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-10-21T13:25:01.482Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$900(CliGitAPIImpl.java:81)[2019-10-21T13:25:01.482Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2627)[2019-10-21T13:25:01.482Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from aranea.kde.org/195.201.167.114:49354[2019-10-21T13:25:01.482Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-10-21T13:25:01.482Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-10-21T13:25:01.482Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)[2019-10-21T13:25:01.482Z] 		at sun.reflect.GeneratedMethodAccessor349.invoke(Unknown Source)[2019-10-21T13:25:01.482Z] 		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[2019-10-21T13:25:01.482Z] 		at java.lang.reflect.Method.invoke(Method.java:498)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)[2019-10-21T13:25:01.482Z] 		at com.sun.proxy.$Proxy96.execute(Unknown Source)[2019-10-21T13:25:01.482Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1228)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:124)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)[2019-10-21T13:25:01.482Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-10-21T13:25:01.482Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-10-21T13:25:01.482Z] 		at 

D24826: Enforce 100 chars line width

[Christoph Cullmann]

cullmann added a comment.


  See the other task: columnlimit 0 leads to endless long lines and is a 
unusable default.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

[Allen Winter]

winterz added a comment.


  I am a long-time advocate of columnLimits; however, in our modern world of 
programming I think 100 is too short.
  
  240 may be a bit too long: in my personal coding style scripts I try to limit 
to 120.   even 120 is hard to achieve sometimes.
  I feel that 240 is a fair compromise.
  
  -1 for this patch

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

[Vlad Zahorodnii]

zzag added a comment.


  I suggest to set ColumnLimit to 0 by default and allow projects to override 
it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

Heads-up for developers working _on_ KF modules: how to mark deprecated API from now on

[Friedrich W. H. Kossebau]

Hi,

tldr; For deprecated API of KDE Frameworks modules please use 
ECMGenerateExportHeader and the respective macros to mark & wrap deprecated 
API, otherwise the whole effort breaks down. Question: where would you expect 
the documentation for how to do this?


The introduction of ECMGenerateExportHeader to KDE Frameworks has been 
completed now, all 34 KF modules having deprecated C++ API have been adapted 
to use the CMake macro ecm_generate_export_header as well as the new C++ 
macros available from the respective generated export header.

So whenever there is some API to be deprecated, its declaration would now be 
decorated like this:

#if KFOO_ENABLE_DEPRECATED_SINCE(5, x)
/**
 * @deprecated Since 5.x. Use bar(). // Sadly doxygen needs data duplicated
 */
KFOO_DEPRECATED_VERSION(5, x, "Use bar()")
void foo();
#endif

The version 5.x needs to be listed with the DEPRECATION_VERSIONS argument of 
the ecm_generate_export_header, otherwise at least KFOO_DEPRECATED_VERSION(5, 
x, "") will fail to build (you will run into this for sure as I did, just 
needs remembering, so start now :) ).

A perfect programming language would not need all this fragile duplication, 
but with current C++ this seems the closest we can do to support users of our 
libraries to control visibility of deprecated API and warnings about it, as 
well as help ourselves during ABI breaks to do smoother porting and see the 
legacy API that can be dropped.


There are some more details around all this (like when not to use the #if 
wrapper because building-against-library compiler needs to always see virtual 
methods or enum values, or disabling deprecated API from the library build 
itself using KFOO_BUILD_DEPRECATED_SINCE), my question now is where this is 
best documented in detail. I already added small snippets in some places, but 
still search for a place documenting all known cases and pitfalls.

So, if in need of guidance how to use the new deprecation mechanisms, where 
would you expect to find the help? Many answers wanted here.

Cheers
Friedrich

D24826: Enforce 100 chars line width

[Christoph Cullmann]

cullmann added a comment.


  Perhaps easiest way to see what happens: apply it to one of your things and 
vary the value.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  > Indeed the alternative is registerSettings(), I went for the less explicit 
"children settings" mechanism mostly because it was closer to the older system 
around KCModule which was very much working by convention.
  
  Having similarity to the KCModule is a perfectly good reason. Ship it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport, davidedmundson
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin added a comment.


  In D24821#551179 , @davidedmundson 
wrote:
  
  > Nice!
  >
  > I'm not super sold on magically doing findChildren to get the config 
skeletons over an explicit
  >  registerSettings(KCoreConfigSkeleton*).
  >
  > I'm not against it either, but could you expand on the rationale.
  
  
  You mean here to sell it to you or in the doc or something else?
  
  Indeed the alternative is registerSettings(), I went for the less explicit 
"children settings" mechanism mostly because it was closer to the older system 
around KCModule which was very much working by convention.

INLINE COMMENTS

> bport wrote in managedconfigmodule.h:210
> I think we need to set this value to true by default, because if we don't 
> override it we assume value are not the default one

Right, makes sense for the future code.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24826: Enforce 100 chars line width

[Roman Gilg]

romangg added a comment.


  In D24826#551280 , @cullmann wrote:
  
  > As explained in the thread on https://phabricator.kde.org/T11214, this will 
make the formatting ugly as hell, as if you have long method names, stuff is 
broken in arbitrary bad ways.
  >  I don't want to change that, if nobody can avoid the resulting breakage.
  
  
  Does it brutalize the line breaks always or only when the code line does not 
comply with the 100 chars limit? Or from the other side does `ColumnLimit: 240` 
mean that all "unnecessary" manual line breaks will be removed such that there 
are >200 chars lines now where before a document was only with <200? This would 
be even worse.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag removed a dependent revision: D24660: [x11] Add support for 
_GTK_FRAME_EXTENTS.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

[Christoph Cullmann]

cullmann added a comment.


  As explained in the thread on https://phabricator.kde.org/T11214, this will 
make the formatting ugly as hell, as if you have long method names, stuff is 
broken in arbitrary bad ways.
  I don't want to change that, if nobody can avoid the resulting breakage.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  KRun unconditionally opened files with mimetype text/html (and co.) with
  the browser application set in kdeglobals, BrowserApplication=, and if it's
  not set, it fells back to mimeapps.list (x-scheme-handler/http*).
  
  IMHO, there are two distinctive use cases here, opening http*:// links
  with a web browser (which is what the user wants most of the time); and
  opening local '.*html' files on the user's machine, usually with the
  intention to edit them; the two cases can/should be mutually exclusive.
  
  This gives the choice back to the user, as he can set his preferred app
  to open local .html files, be it a web browser or a text editor.
  
  This won't impact new user accounts because most browsers .desktop files
  have Mimetype entries that cover most of the .html and co. types. So it'll
  either be the default app already or the user can select his favourite browser
  from the open-with list.
  
  Thanks to broulik for pin-pointing the location in the code that caused
  this behaviour first.
  
  BUG: 399020
  FIXED-IN: 5.64

TEST PLAN
  - Set some web browser as the default in the component chooser kcm
  - Open Dolphin and using any .html file set the default app to, say, kwrite
  - Try to open a local .html file, notice that it opens in the web browser you 
set
  - Apply the patch, then try again, it should be opened with kwrite

REPOSITORY
  R241 KIO

BRANCH
  ahmad/separate-browser-html (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24828

AFFECTED FILES
  src/widgets/krun.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  testing high level functionality of a bunch of relevant slaves yielded no
  obvious problems, so let's enable slave state assertion for all builds from
  git repos now. this should give much wider testing coverage
  
  print a warning when having slave assertion but without debug build instead
  of a fatal error, outside CI that is a valid thing to do albeit still not
  making too much sense as we want people to have state assertion enabled

TEST PLAN
  cmake with .git enables the option, without it doesn't, with .git and type 
set to Release a warning is printed

REPOSITORY
  R241 KIO

BRANCH
  assert-for-git

REVISION DETAIL
  https://phabricator.kde.org/D24827

AFFECTED FILES
  CMakeLists.txt

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 282 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/282/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 21 Oct 2019 10:48:14 +
 Build duration:
43 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(265/405)65%
(265/405)55%
(33794/61611)39%
(16900/43520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9558/10118)47%
(4461/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8681/14518)51%
(4516/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2023/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(677/1208)40%
(384/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1804/4291)36%
(1319/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%

D24826: Enforce 100 chars line width

[Roman Gilg]

romangg created this revision.
romangg added reviewers: Frameworks, cullmann.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The KDE Frameworks style recommended a 100 chars line limit but did not 
enforce
  it. Now with the clang-format file currently a somewhat arbitrary limit of 240
  chars is enforced.
  
  Instead enforce the recommendation of 100 chars per line.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  columnLimit

REVISION DETAIL
  https://phabricator.kde.org/D24826

AFFECTED FILES
  kde-modules/clang-format.cmake

To: romangg, #frameworks, cullmann
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

[Konrad Materka]

kmaterka added a comment.


  This is a first step to solve 401016 
:
  "Touchpad plasmoid [confirmation dialog] remains open when losing focus, I 
think that it is inconsistent since other elements of tray close themselves 
after switching away."
  
  AFAIK PlasmaComponents 2 are deprecated. Is there newer QueryDialog 
replacement?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

[Konrad Materka]

kmaterka edited the summary of this revision.
kmaterka added reviewers: Plasma, Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24825

To: kmaterka, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven marked 2 inline comments as done.
meven added a comment.


  In D24773#551087 , @dfaure wrote:
  
  > I meant in the Dolphin view. RMB / Properties and calculating the size is 
available for trash:/. See 
http://www.davidfaure.fr/2019/dolphin_properties_dialog_for_trash.png
  
  
  This works from the folder view, but not from the places context menu where I 
tried it before.
  This is another issue.
  
  > I don't like abusing UDS_SIZE for this, because KIO is a virtual 
filesystem, trying to work like a normal filesystem. When you ::stat() a local 
directory, you get the size used by the directory entry, NOT the recursive size 
of all of its contents. There are ways to ask for that, by recursing, but 
explicitly, not as part of normal directory listing.
  >  I'm also concerned that now UDS_SIZE would have different meanings 
depending on the URL (sometimes the size of the directory entry, sometimes the 
full recursive size). This is how bad architecture starts, and unsolvable bugs 
- or ugly workarounds - tend to appear.
  
  Maybe we should add another fileld to UDSEntry like UDS_CONTENT_SIZE for this 
use case then to keep the two use cases clearly separate ?
  
  > There is indeed a fast way to get this particular one
  
  The way that exists necessitates two clicks and a load ; and it is available 
from only a particular place as mentioned up but that is not the issue here. 
But the value is in cache in fact for trash:/ we can shortcut the load.
  It is inconvenient and not what users would expect, some may just not find it.
  
  > , but I'm worried that this creates a precedent where the information panel 
starts expecting that all kioslaves fill UDS_SIZE with the full recursive size 
rather than just the size of the directory entry. And users expect to see the 
full recursive size there. I mean, after this goes in, the user goes to his 
~/Music folder, the information panel still says `Size: 4123 items`, they'll 
report a bug that it should instead show the full disk usage of that folder, 
right?
  
  Concerning recursive dir size, it is already a feature wish, that I would 
argue we should implement in some way sometimes (not default, not everywhere 
but still we would need something along this line). This is a legitimate 
feature in 2019 IMO :
  https://bugs.kde.org/show_bug.cgi?id=48434
  https://forum.kde.org/viewtopic.php?f=22=87452
  https://bugs.kde.org/show_bug.cgi?id=158090
  So I would argue that we need a way to surface directories content size to 
users.
  
  But here this does not concern size of dirs in general but only the size of 
trash:/ that will only be displayed in the information panel.
  So it might acceptable here.
  
  > To fix this issue, I would much rather that the information panel uses 
DirectorySizeJob (possibly on demand, like the Properties dialog); that class 
could have a fast path for trash: (e.g. making a special() call to the ioslave) 
Or if you don't want a button in that panel, special-case trash, call 
DirectorySizeJob only for trash, implement the fast path there - and change the 
label in the information panel to "Disk space usage" so it's not confused with 
the usual Size field.
  
  I would argue that "Disk space usage" and "Size" might be confusing to users. 
A folder size is the size of his content idiomatically.
  That is our current usage of Size field for folders that is weird : My Image 
folder Size is "42 elements".
  That is a paper cut that all new Plasma users have to learn "Size for folders 
is a content description" : not very intuitive.
  We may want to in fact rename this field for folders to "Content" and keep 
Size for actual disk usage size (except in details view Size column of course).
  
  The fast path in the information panel is completely viable here.
  
  I would appreciate some feedback from #vdg 
 as to what course of action is 
recommendable for a user experience perspective. @ngraham ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

[Konrad Materka]

kmaterka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  When using Dialog or QueryDialog it should be possible to set 
hideOnWindowDeactivate flag.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24825

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Dialog.qml

To: kmaterka
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:acbb200ac2cc: edit mode action (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24263?vs=68224=68422#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24263?vs=68224=68422

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24824: Remove outdated comment about [$e] expansion

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24824

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 151 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/151/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 21 Oct 2019 10:48:19 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24350: [src/kpac/*] replace deprecated foreach with range for

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:103e13c2765e: [src/kpac/*] replace deprecated foreach 
with range for (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24350?vs=68395=68419

REVISION DETAIL
  https://phabricator.kde.org/D24350

AFFECTED FILES
  src/kpac/script.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> managedconfigmodule.h:116
> + *
> + * If you want to make the ConfigModule available only conditionally (i.e. 
> show in
> + * the list of available modules only if some test succeeds) then you can use

I know this is just copy paste, but can you delete this paragraph as per 
https://phabricator.kde.org/D24824

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24824: Remove outdated comment about [$e] expansion

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This was dropped in KConfig due to security reasons a while
  ago.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24824

AFFECTED FILES
  src/quickaddons/configmodule.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[Benjamin Port]

bport accepted this revision.
bport added a comment.
This revision is now accepted and ready to land.


  Ok for me, when David remarks are addressed

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24821: Add ManagedConfigModule

[David Edmundson]

davidedmundson added a comment.


  Nice!
  
  I'm not super sold on magically doing findChildren to get the config 
skeletons over an explicit
  registerSettings(KCoreConfigSkeleton*).
  
  I'm not against it either, but could you expand on the rationale.

INLINE COMMENTS

> managedconfigmodule.cpp:131
> +needsSave |= skeleton->isSaveNeeded();
> +if (needsSave)
> +break;

Coding style {} is needed for single lines

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: davidedmundson, bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/27/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 20 Oct 2019 20:26:51 +
 Build duration:
13 hr and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin updated this revision to Diff 68411.
ervin added a comment.


  Addresses bport's comment

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24821?vs=68408=68411

REVISION DETAIL
  https://phabricator.kde.org/D24821

AFFECTED FILES
  src/quickaddons/CMakeLists.txt
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: ervin, #plasma, #frameworks, mart, bport
Cc: bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[Benjamin Port]

bport requested changes to this revision.
bport added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> managedconfigmodule.cpp:96
> +{
> +return false;
> +}

Like above I think we need to set it to true

> managedconfigmodule.h:210
> + *
> + * By default this returns false, it needs to be overriden only
> + * if the module has state outside of the settings declared in

I think we need to set this value to true by default, because if we don't 
override it we assume value are not the default one

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

To: ervin, #plasma, #frameworks, mart, bport
Cc: bport, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: Plasma, Frameworks, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  This is a new type of ConfigModule which will manage the state of
  "apply" and "defaults" by itself depending on the state of the KConfigXT
  objects used within the module.
  
  This is sligthly uncomplete on the "defaults" side due to missing
  facilities in ConfigModule, but at least it shows the approach works.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24821

AFFECTED FILES
  src/quickaddons/CMakeLists.txt
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: ervin, #plasma, #frameworks, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added a comment.


  In D24663#549764 , @kossebau wrote:
  
  > @zzag Hi. Any chance you can have time to review this today/the WE? One of 
the last ECMGenerateExportHeader patches.
  
  
  Hi, sorry for the late response. Yes, I think this change is/was good to go.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I meant in the Dolphin view. RMB / Properties and calculating the size is 
available for trash:/. See 
http://www.davidfaure.fr/2019/dolphin_properties_dialog_for_trash.png
  
  I don't like abusing UDS_SIZE for this, because KIO is a virtual filesystem, 
trying to work like a normal filesystem. When you ::stat() a local directory, 
you get the size used by the directory entry, NOT the recursive size of all of 
its contents. There are ways to ask for that, by recursing, but explicitly, not 
as part of normal directory listing.
  
  There is indeed a fast way to get this particular one, but I'm worried that 
this creates a precedent where the information panel starts expecting that all 
kioslaves fill UDS_SIZE with the full recursive size rather than just the size 
of the directory entry. And users expect to see the full recursive size there. 
I mean, after this goes in, the user goes to his ~/Music folder, the 
information panel still says `Size: 4123 items`, they'll report a bug that it 
should instead show the full disk usage of that folder, right?
  
  I'm also concerned that now UDS_SIZE would have different meanings depending 
on the URL (sometimes the size of the directory entry, sometimes the full 
recursive size). This is how bad architecture starts, and unsolvable bugs - or 
ugly workarounds - tend to appear.
  
  To fix this issue, I would much rather that the information panel uses 
DirectorySizeJob (possibly on demand, like the Properties dialog); that class 
could have a fast path for trash: (e.g. making a special() call to the 
ioslave). Or if you don't want a button in that panel, special-case trash, call 
DirectorySizeJob only for trash, implement the fast path there - and change the 
label in the information panel to "Disk space usage" so it's not confused with 
the usual Size field.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:8977627cab85: Fix KNSCore::Cache fetching when 
initialising Engine (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24754?vs=68284=68404

REVISION DETAIL
  https://phabricator.kde.org/D24754

AFFECTED FILES
  src/core/engine.cpp

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24350: [src/kpac/*] replace deprecated foreach with range for

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-kpac (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24350

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

[Méven Car]

meven added a comment.


  In D24686#550567 , 
@elvisangelaccio wrote:
  
  > It's always ok to bump the KF5 version as long as you do it before the 
dependency freeze day set by the release team.
  
  
  So I guess it is the case here : Apps 19.12 is still in a few months, we can 
bump KF5 deps I think.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24686

To: meven, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven marked 3 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in trashimpl.cpp:1088
> This method could be const, right?

No becauseof the call to `list()` that cannot be const.

> dfaure wrote in trashimpl.cpp:1104
> This looks very slow. We have a cache for the size usage. See 
> `TrashImpl::trashSpaceInfo`.
> 
> But anyway, we never return recursive directory size in the UDS_SIZE field, 
> in no ioslave.
> If someone wants to know the size of a directory, they can use the properties 
> dialog, which has a calculate button.

I missed the feature of trashSpaceInfo, thank you for pointing it out.

We need to add the UDS_SIZE field here : this is a missing feature for a 
special common use case : Finding out what amount of space is occupied by the 
trashed files ?
The trash size should be easy to find out for users. Plus we have a cache file 
to get this information cheaply.

UDS_SIZE may not be used that way currently but it is semantically correct 
nonetheless.
In most other cases directory size calculation is not used because it is too 
resource intensive but here we have the value pre-computed.

And by the way the trash:/ has not `Properties` entry in its context menu, so 
it is not even possible to get the trash size currently.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven updated this revision to Diff 68402.
meven added a comment.


  Use TrashSizeCache to file directory size, do not add creation date to the 
UDSEntry, better use UDSEntry reserve/clear

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=68281=68402

BRANCH
  arcpatch-D24773

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns