Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 9, 2015, 1:03 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateGenerator.cmake, line 59 > > <https://git.reviewboard.kde.org/r/126185/diff/3/?file=421456#file421456line59> > > > > Naming them .zip on windows, won't make it a zip file, if y

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

in the repository. > > Regarding this patch, I don't see it as appropriate, since it would > basically allow for broken treatment of translations when building release > tarballs. Better just add it to be applied in your build setup. I know, not > nice when something changes a

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment60983> You might want to add documentation. You can get inspired with `kde-modules/KDEFrameworkCompilerSettings.cmake` or `modules/ECMInstallIcons.cmake`. Note it's also lacking the copyright header. - Aleix Pol Gonzalez On Dec. 3, 2015, 1:

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 64bf23c85bb86e8e1a15bc7baf875ab0b6a8 by Aleix Pol to branch master. Repository: kcoreaddons Description --- Loads the json file upon construction. Simplifies adoption of json metadata

Review Request 126348: Make it possible to provide the metadata in json

/ Testing --- Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez

Re: Review Request 126400: [GCI] Fix some Clazy warnings

tps://git.reviewboard.kde.org/r/126400/#comment61400> Don't comment it, just remove it. - Aleix Pol Gonzalez On Dec. 17, 2015, 3:34 p.m., Imran Tatriev wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126400: [GCI] Fix some Clazy warnings

. Tested locally and tests still pass. - Aleix Pol Gonzalez On Dec. 17, 2015, 4 p.m., Imran Tatriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

. - Aleix Pol Gonzalez On Dec. 18, 2015, 4:33 a.m., Andrey Cygankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a

Re: Review Request 126384: better description of qmlmodule cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126384/#review89600 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2015

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:38 p.m., Aleix Pol Gonzalez wrote: > > I ran the tests locally and I can confirm that clazy warnings are gone and > > all tests still pass. +1, waiting for maintainer appr

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

are gone and all tests still pass. - Aleix Pol Gonzalez On Dec. 14, 2015, 7:37 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

> On April 7, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote: > > src/widgets/jobuidelegate.cpp, line 391 > > <https://git.reviewboard.kde.org/r/123229/diff/2/?file=360351#file360351line391> > > > > This is not correct, it's too early to figure out if it's

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

y, visit: https://git.reviewboard.kde.org/r/123229/#review89239 ----------- On Dec. 7, 2015, 2:29 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically gener

Review Request 126366: Make KPluginMetaData constructible from a json path.

pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126348: Make it possible to provide the metadata in json

,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 126348: Make it possible to provide the metadata in json

ext file. I can commit separately if you want. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89499 --- On De

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

3674360 Diff: https://git.reviewboard.kde.org/r/126366/diff/ Testing --- Tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

. Is it accepted to have c++11-style connects in KF5? For the rest, +1. - Aleix Pol Gonzalez On Jan. 3, 2016, 10:09 p.m., Artur Puzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 126348: Make it possible to provide the metadata in json

=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` >

Re: Review Request 126494: Add cross compile support for desktoptojson.

tps://git.reviewboard.kde.org/r/126494/#comment61894> What's that property supposed to do? `IMPORTED_LOCATION_NONE` - Aleix Pol Gonzalez On Dec. 23, 2015, 11:46 p.m., Ralf Habacker wrote: > > --- > This is an automatically generated e

Re: Review Request 126494: Add cross compile support for desktoptojson.

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote: > > KF5CoreAddonsConfig.cmake.in, line 12 > > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12> > > > > What's that property supposed to do? `IMPORTED_LOCATION_NONE` >

Re: Review Request 126587: Add option to build with gcov support

` in ECM, and included by `KDECompilerSettings.cmake`. If anything, the proper fix would be to remove this kind of code from elsewhere. - Aleix Pol Gonzalez On Dec. 31, 2015, 10:13 p.m., Dāvis Mosāns wrote: > > --- > This is an auto

Re: Review Request 126587: Add option to build with gcov support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- That's provided by ecm, isn't it? - Aleix Pol Gonzalez

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90655 --- +1 makes sense to me. - Aleix Pol Gonzalez On Jan. 5, 2016

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

, but besides compilation, you should have checked if tests still pass and specified so in the testing field. The change looks, good. Thanks! - Aleix Pol Gonzalez On Jan. 8, 2016, 2:15 a.m., Andrey Cygankov wrote

Re: Review Request 126665: [GCI] Fix clazy's issues in tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126665/#review90783 --- Ship it! Do you have push rights? - Aleix Pol Gonzalez

Re: Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126664/#review90782 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016, 7

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

tps://git.reviewboard.kde.org/r/126661/#comment62050> this should be `endsWith(QLatin1Char('/'))` - Aleix Pol Gonzalez On Jan. 7, 2016, 4:41 p.m., Mihail Ivchenko wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

> On Jan. 7, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 351 > > <https://git.reviewboard.kde.org/r/126662/diff/1/?file=428750#file428750line351> > > > > Why's this change? > > Mihail Ivchenko wrote: >

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90504 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 3, 2016, 1

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

351) <https://git.reviewboard.kde.org/r/126662/#comment62054> Why's this change? src/kpackagetool/kpackagetool.cpp (line 516) <https://git.reviewboard.kde.org/r/126662/#comment62053> I would just change for Q_FOREACH. - Aleix Pol Gonzalez On Jan. 7, 2016, 4:42 p.m

Review Request 126476: Make it possible to use doubles as index for i18np*() calls

s - autotests/ki18ndeclarativetest.cpp cf8e778 autotests/test.qml 314b516 src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

9950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89992 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 15, 2015

Re: Review Request 126400: [GCI] Fix some Clazy warnings

> On Dec. 23, 2015, 3:46 p.m., Aleix Pol Gonzalez wrote: > > Can you commit? > > Imran Tatriev wrote: > Done! ;) Next time, add a `REVIEW: 126400` statement after the commit message to link it d

Re: Review Request 126489: Reduce unwanted type changes

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit 7215389f1307c2049201f967dbde187a197eb31f by Aleix Pol to branch master. Repository: ki18n Description --- Makes sure we don't cast string types on some occasions. Diffs

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

org/r/126392/ > --- > > (Updated Dec. 18, 2015, 8:32 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > --- > > Fix some Clazy warnings: > - unneeded heap allocation with QString

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89993 --- Ship it! Can you commit? - Aleix Pol Gonzalez On Dec. 17

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

g/r/126429/#comment61676> Why do we keep all this code? src/k7zip.cpp (line 2029) <https://git.reviewboard.kde.org/r/126429/#comment61677> I wouldn't get this all in. Is that suggested by `-Wclazy-reserve-candidates`? - Aleix Pol Gonzalez On Dec. 19, 2015, 4:56 p.m., Artur

Review Request 126489: Reduce unwanted type changes

still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126509: Silence Coverity warning about risk of buffer overflow by shrinking source buffer and using qstrncpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126509/#review90079 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 25, 2015

Re: Review Request 126508: kdesu: Fix fd leaks.

`... - Aleix Pol Gonzalez On Dec. 25, 2015, 1:19 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

- > > (Updated Dec. 24, 2015, 12:58 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > --- > > Fix some Clazy warnings: > - unneeded heap allocation with Q

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

for that... - Aleix Pol Gonzalez On Dec. 25, 2015, 1:12 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126416: MetaFunction doesn't need to be exported

file? - Aleix Pol Gonzalez On Dec. 18, 2015, 3:05 p.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126417: don't rely on char* to QString implicit conversion

> On Dec. 18, 2015, 3:35 p.m., Kai Uwe Broulik wrote: > > i'm wondering whether those are still needed Well, it's still being called. +1 on the patch, it can be further fixed later. - Aleix --- This is an automatically generated

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

tps://git.reviewboard.kde.org/r/126392/#comment61462> That's still wrong. it should be: `return !m_clients.isEmpty() || !m_entries.isEmpty();` - Aleix Pol Gonzalez On Dec. 18, 2015, 5:57 p.m., Andrey Cygankov wrote: > > --- > This is a

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

moticons.cpp (line 180) <https://git.reviewboard.kde.org/r/126531/#comment61742> Use QLatin1String when comparing, same for the next one. Are you sure you used clazy properly? It usually detects those warnings correctly. - Aleix Pol Gonzalez On Dec. 27, 2015, 6:50 p.m., And

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90161 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 26, 2015

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/#review90191 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2015

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

gankov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126531/ > --- > > (Updated Dec. 27, 2015, 9:08 p.m.) > > > Review request

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/#review89920 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 22, 2015

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environment variab

Re: Review Request 126472: Don't always load the timetracker

because it was asked not to. IIRC. Anyway, +1. - Aleix Pol Gonzalez On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Dec. 23, 2015, 3:49 p.m., Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > <https://git.reviewboard.kde.org/r/126429/diff/1/?file=424823#file424823line2029> > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-rese

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

sts/test.qml 314b516 src/klocalizedcontext.cpp 3bc42dd src/klocalizedstring.cpp 69950d2 Diff: https://git.reviewboard.kde.org/r/126476/diff/ Testing --- Added new tests, which now pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-de

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

) <https://git.reviewboard.kde.org/r/126455/#comment61574> Get both variables in this scope? - Aleix Pol Gonzalez On Dec. 21, 2015, 5:22 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/#review90275 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2015

Re: Review Request 125536: Remove unused variable warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/#review90277 --- Related: https://git.reviewboard.kde.org/r/126429/ - Aleix

Re: Review Request 126161: OS X housekeeping

tps://git.reviewboard.kde.org/r/126161/#comment60861> Just remove. For reference there's git history. +1 all in all it looks good to me. It's mostly only touching OS X code anyway though, and I am quite clueless there, so more eyes will help. - Aleix Pol Gonzalez On Nov. 25, 2015, 12:03 a.m., Re

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

/cocoa/qcocoaintegration.mm and qcocoahelpers.mm - Aleix Pol Gonzalez On Nov. 25, 2015, 6:08 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126185: Make the KAppTemplate CMake module global

://techbase.kde.org/Policies/CMake_Coding_Style - Aleix Pol Gonzalez On Nov. 27, 2015, 3:26 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0dfc7fc2cf962687ba19d145a5e4e9b1c2be819e by Aleix Pol to branch master. Repository: kdeclarative Description --- `i18n*()` bindings were moved upstream to ki18n so they can be used by a wider

Re: Review Request 126212: Do not crash if KDE platform integration is loaded but SNI is unavailable

tps://git.reviewboard.kde.org/r/126212/#comment60913> qEnvironmentVariableIsSet - Aleix Pol Gonzalez On Dec. 1, 2015, 1:53 a.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126087: Move the i18n context from KDeclarative

ther three series of calls (xi18n*, ki18n*, kxi18n*) should > > be made available as well. > > Aleix Pol Gonzalez wrote: > I don't think we want the `k*i18n*` version of the calls, as they return > KLocalizedString and we probably don't need to deal with it from QML.

Re: Review Request 126087: Move the i18n context from KDeclarative

tps://git.reviewboard.kde.org/r/126087/#review88465 ------- On Nov. 18, 2015, 1:26 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126087: Move the i18n context from KDeclarative

/klocalizedcontext.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126087/diff/ Testing --- Ported KDeclarative, everything still seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

tps://git.reviewboard.kde.org/r/126113/#comment60769> It could be useful to use qGuiApp here, so that software that doesn't use QApplication can use it as well. - Aleix Pol Gonzalez On Nov. 20, 2015, 2:27 p.m., Marco Martin

Re: Review Request 126087: Move the i18n context from KDeclarative

ocs/programmers-guide.md 13a5f9d src/CMakeLists.txt 818595e src/klocalizedcontext.h PRE-CREATION src/klocalizedcontext.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126087/diff/ Testing --- Ported KDeclarative, everything still seems to work. Thanks, Aleix Pol Gonza

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

> On Nov. 20, 2015, 1:44 p.m., Martin Gräßlin wrote: > > The need for the change surprises me. I have been using a /opt setup for > > years and udev was always found. Can you show the error you hit? > > René J.V. Bertin wrote: > Have you been using a Linux distro like Ubuntu that has

Re: Review Request 126087: Move the i18n context from KDeclarative

e a problem... I'll try if it's possible to use QVariant there instead of QString directly. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88648 ---------

Re: Review Request 126087: Move the i18n context from KDeclarative

declarative" situation has to be > > solved (maybe optional dep at build time?) > > Aleix Pol Gonzalez wrote: > Are you sure you want to consider Qt5::Qml as an optional dependency? I > don't have a problem with it, but it seems odd as a first step. > > Personal

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

> On Nov. 20, 2015, 10:06 p.m., René J.V. Bertin wrote: > > src/ioslaves/trash/trashimpl.cpp, line 947 > > > > > > These were `kDebug()` statements; I guess they should become > > `qWarning()` now that `kDebug`

Re: Review Request 126087: Move the i18n context from KDeclarative

have it, then consider it. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88612 ------- On Nov. 19, 2

Re: Review Request 126087: Move the i18n context from KDeclarative

/programmers-guide.md 13a5f9d src/CMakeLists.txt 818595e src/klocalizedcontext.h PRE-CREATION src/klocalizedcontext.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126087/diff/ Testing --- Ported KDeclarative, everything still seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 126087: Move the i18n context from KDeclarative

else? i.e. is pimpling a safer > > choice? Good point. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88697 -----------

Re: Review Request 126087: Move the i18n context from KDeclarative

13a5f9d autotests/ki18ndeclarativetest.cpp PRE-CREATION autotests/test.qml PRE-CREATION src/klocalizedcontext.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126087/diff/ Testing --- Ported KDeclarative, everything still seems to work. Thanks, Aleix Pol Gonzalez

Re: Review Request 126087: Move the i18n context from KDeclarative

marked as submitted. Review request for KDE Frameworks, Chusslove Illich and Marco Martin. Changes --- Submitted with commit 369509cc41d82b5b14f329c1ba9d40289ea672e5 by Aleix Pol to branch master. Repository: ki18n Description --- The only way to use `i18n*()` so far in QML

Re: Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126088/#review88725 --- Bump! - Aleix Pol Gonzalez On Nov. 16, 2015, 1:57 p.m

Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

started adding qDebugs... Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Changes --- Submitted with commit 9c17965a56b83b3fd34b1eefcd915823ec546f76 by Aleix Pol to branch master. Repository: ki18n Description --- They don't work and it's a pointless distinction really. Diffs

Re: Review Request 126125: [OS X] make KDE's trash use the OS X trash

tation? - Aleix Pol Gonzalez On Nov. 20, 2015, 10:09 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/#review90796 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016, 5

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

for this? - Aleix Pol Gonzalez On June 8, 2016, 6:17 a.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128139: Silence CMake policy CMP0063 warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128139/#review96328 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 9, 2016

Re: Review Request 128114: do not load and debug in the same line

decide not to execute part of the stream? - Aleix Pol Gonzalez On June 7, 2016, 10:48 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

marked as submitted. Review request for KDE Frameworks, Plasma and David Rosca. Changes --- Submitted with commit 9575b8c009d5500126cc0edb1a384ab39fd0a641 by Aleix Pol to branch master. Bugs: 60777 http://bugs.kde.org/show_bug.cgi?id=60777 Repository: plasma-framework Description

Re: Review Request 128119: Explicitly declare methods as overridden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128119/#review96259 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 7, 2016

Re: Review Request 128121: Use scoped pointer for complicated delete logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128121/#review96261 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 7, 2016

Re: Review Request 128164: Use QIcon for background icon for folder thumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128164/#review96386 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 12

Re: Review Request 128147: isolate autotests from (installed) production data

tps://git.reviewboard.kde.org/r/128147/#comment65113> This can be made a static function, not even required to change the tests common base? - Aleix Pol Gonzalez On June 10, 2016, 11:20 a.m., Harald Sitter wrote: > > --- > This is a

Re: Review Request 128019: Remove F1 as standard shortcut for Help

time I've hit it was on purpose. - Aleix Pol Gonzalez On May 26, 2016, 1:01 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128171: Fix null object QObject::connect warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128171/#review96409 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 13

Re: Review Request 127997: Extend KNS3::Entry public API

?content=168237 Shipping it. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/#review95866 ------- On May 24, 20

Re: Review Request 127997: Extend KNS3::Entry public API

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 167a0588c9fccef8994b2e06c362a8b3b341523d by Aleix Pol to branch master. Repository: knewstuff Description --- Exposes some API present in either EntryInternal or in Attica

<    11   12   13   14   15   16   17   18   19   20   >