D22708: [WIP] Add a kded module infra for fuse mount services

andriusr added inline comments. INLINE COMMENTS > CMakeLists.txt:19 > add_subdirectory(kcms) > +add_subdirectory(mountserviced) > should we restrict platforms here? (e.g.: NOT WIN32, NOT ANDROID). There are fuse wrappers such as winfsp's or dokany's, but possibly those should not work

D22554: Finer No-Dbus on Windows

andriusr added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > + endif() > endif() > extra `endif()` ? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

andriusr added inline comments. INLINE COMMENTS > kio_sftp.cpp:2257 > +#ifdef Q_OS_WIN > +// TODO ADD CODE FOR HANDLING FILETYPE - SYMLINK IN WIN > +#else I'm not sure what is intended to achieve here, the remote file _can_ be a symlink, and IIRC when we had sftp on dolphin in

D15739: [Places panel] Don't show Root by default

andriusr added a comment. In D15739#485978 , @fvogt wrote: > In D15739#485976 , @ngraham wrote: > > > In D15739#485975 , @fvogt wrote: > > > > > No,

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added a comment. Also, Windows does not allow filenames with either `\` or `/` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg,

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:907 > If Windows allows slashes in the filename, shouldn't they just be a part of > the filename and not create a directory tree? If so, then we don't even need > this `#ifdef` condition at all;

Re: A new tier1 for icontheme.rcc handling

+1 for the name kiconsupport as Ben suggested. Em 19 de jan de 2018 21:49, "Ben Cooksley" escreveu: On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

- Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127729/#review94797 --- On Abril 23, 2016, 11:54 p.m., Andrius

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

() as is also included and it defines a 'max' macro. Diffs - src/lib/util/kuser.h 3c9ff00 Diff: https://git.reviewboard.kde.org/r/127729/diff/ Testing --- Okular is buildable on MSVC after this patch. No further testing done. Thanks, Andrius da Costa Ribas

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

marked as submitted. Review request for KDE Frameworks and kdewin. Changes --- Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da Costa Ribas to branch master. Repository: kio-extras Description --- These had been disabled when moving into frameworks

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

-9f7163b7433f__dolphin_wresico2.png Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127714: Enable ICO and EXE thumbnails again.

MSVC 2015 64bit. Also, faked a non-win32 setup to ensure the icoutils version is also working (with wrestool binary from (**aaargh!!**) cygwin). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Problem using Vc with CMake 3.0 and kf5

I'm not sure if I understood the issue. If we need to pass the -I parameters to vc_compile_for_all_implementations, then something like https://git.reviewboard.kde.org/r/115110/diff/1/ might work. Em 23/05/2015 09:07, Aleix Pol aleix...@kde.org escreveu: On Sat, May 23, 2015 at 11:51 AM,

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

On Nov. 10, 2014, 9:41 p.m., David Faure wrote: lib/konq/src/konq_historyentry.h, line 57 https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57 const ref, no? Andrius da Costa Ribas wrote: before I try to fix the pending issues: what are we going

Re: Review Request 121079: Fix building dolphin tests on MSVC

://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121079: Fix building dolphin tests on MSVC

-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

--- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080

Re: Review Request 120648: Encode the URIs which end up in DTD files

://git.reviewboard.kde.org/r/120648/#comment53670 I've tried changing this to: execute_process(COMMAND perl -MURI::Escape -e print uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\); (...) it works here, but I'm not sure if it'd be the proper fix. - Andrius da Costa Ribas

Re: Review Request 120648: Encode the URIs which end up in DTD files

On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20 It's already committed (but there's been a long time since I hadn't build anything), but now I see

Re: Review Request 120648: Encode the URIs which end up in DTD files

/customization/dtd/kdedbx45.dtd:102: warning: failed to load external ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd %DocBookDTD; - Andrius da Costa Ribas On Fev. 28, 2015, 10:02 p.m., Luigi Toscano

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

--- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 121081: QT_WA

://git.reviewboard.kde.org/r/121081/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Supporting MSVC2010 in ktexteditor framework

+1 for VC12 (I'm using msvc 2013) -- Andrius. 2015-01-29 6:49 GMT-02:00 Ivan Čukić ivan.cu...@kde.org: Hi all, So, the thread died out again. Who is in favour of the following: - Require MSVC10 like (aka status quo) - Require MSVC11 - Require MSVC12 (it would be nice to get the input

Re: Review Request 120878: Remove unused header

://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120878: Remove unused header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote

Re: OSX/CI: QSP patch ( was KF5 Update Meeting Minutes 2014-w28 )

correctly that you set Oxygen as the default style? Does it work correctly on Ms Windows? On 28 Dec 2014, at 01:24, Andrius da Costa Ribas andrius...@gmail.com wrote: In our Windows Emerge scripts QStandardPaths is already being patched for a while: http://quickgit.kde.org/?p=emerge.gita

Re: OSX/CI: QSP patch ( was KF5 Update Meeting Minutes 2014-w28 )

In our Windows Emerge scripts QStandardPaths is already being patched for a while: http://quickgit.kde.org/?p=emerge.gita=blobh=e716bf675669139059a96db6be76cc3470487d64hb=b64cc189fa1918894653f185068e1786b31bd02ef=portage%2Flibs%2Fqt5%2Fqtbase%2Fqtbase-20130714.patch 2014-12-15 19:12 GMT-02:00

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121076: Do not require KF5::Su on Windows

and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121078: Fix exports.

(missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 121076: Do not require KF5::Su on Windows

/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks

Re: Review Request 121076: Do not require KF5::Su on Windows

Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121077: Check before using -Wno-deprecated-declarations.

today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121078: Fix exports.

://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121079: Fix building dolphin tests on MSVC

this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

(MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 121081: QT_WA

other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 120878: Remove unused header

Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: platforms

It can be cleaned up ... other WinCE specifics had already been cleaned up in frameworks. 2014-10-13 20:59 GMT-03:00 Jeremy Whiting jpwhit...@kde.org: Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

). This is not allowed in a case-insensitive filesystem, causing the install step to fail on Windows. Diffs - src/kjsembed/CMakeLists.txt e0ab74c Diff: https://git.reviewboard.kde.org/r/117012/diff/ Testing --- Tested using MSVC 2013 Thanks, Andrius da Costa Ribas

Re: Review Request 117011: Use bin/../share on Windows as a workaround

Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

? Anyhow I'd be fine with that, especially if you can find any documentation of this outside of kde (to explain the reasoning in the Qt change request). Andrius da Costa Ribas wrote: As far as I can see: 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: Until now we had no problems with the data installed to bin/../share and this setup would make it impossible to have multiple independent kde setups on one system. Alexander Richardson wrote: I know. The problem is

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

/r/117012/diff/ Testing --- Tested using MSVC 2013 Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

--- On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- (Updated March

Review Request 117011: Use bin/../share on Windows as a workaround

MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

- src/kjsembed/CMakeLists.txt e0ab74c Diff: https://git.reviewboard.kde.org/r/117012/diff/ Testing --- Tested using MSVC 2013 Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

/KDECompilerSettings.cmake https://git.reviewboard.kde.org/r/115378/#comment34310 if(MSVC) is used everywhere else - Andrius da Costa Ribas On Jan. 29, 2014, 1:39 p.m., Alex Merry wrote: --- This is an automatically generated e-mail

Re: C standard

MSVC (at least vc2010) is C89 for C code, changing it to C99 on GCC may lead to changes that break MSVC build (since almost everything is mostly tested on linux/gcc only). -- Andrius 2014-01-28 Alex Merry k...@randomguy3.me.uk Currently, KDECompilerSettings.cmake in ECM sets -std=iso9899:1990

Re: Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)

raises none of them for these, so these can be done for MSVC only. - Andrius da Costa Ribas On Jan. 28, 2014, 11:22 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

file may use it). - Andrius da Costa Ribas On Jan. 27, 2014, 9:32 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115344

Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43271 --- Please use X11 stuff conditionally (Q_WS_X11). - Andrius da

Re: Review Request 113395: Enable KConfig on Windows

On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: tier1/kconfig/src/core/kconfigini.cpp, line 425 http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would

Re: Review Request 113395: Enable KConfig on Windows

on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would do kdewin's getuid, so here we probably should follow the if part, not the else one. - Andrius da Costa Ribas On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote

Re: Review Request 113395: Enable KConfig on Windows

On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote: tier1/kconfig/src/core/kconfigini.cpp, line 425 http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425 Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on Windows and so would

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: Small question: by replacing KFileDialog by QFileDialog do we still provide the settings to choose whether to use Native or KDE dialog on Windows? I use the KDE one here because of the places panel where I have lots of SFTP/FTP/SMB places

Re: Review Request: KF5 - Q_OS_* not defined

before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: KF5 - Q_OS_* not defined

before the fix. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: libinqt5 - Windows fixes

://git.reviewboard.kde.org/r/105867/diff/ Testing --- Build OK with MSVC. No further tests because of other issues with other parts of KF5 build. Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org