This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8f926e459622: Use correct variable type for returned
value from read/sendfile (authored by davidedmundson).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17051?vs=4589
davidedmundson updated this revision to Diff 45947.
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
davidedmundson added a comment.
Squash
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17071?vs=45942&i
davidedmundson abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17070
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a dependent revision: D17071: Don't include any directory
sizes in DirectorySizeJob.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17070
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a dependency: D17070: Don't double-count size of
directories in DirectorySizeJob.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17071
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17071
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17070
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Running stat on a directory gives a size of on ext3 gives a size of
4096. Running stat on a directory
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Running "stat" on a directory gives a size of on ext3 gives a size of
"4096".
DirectorySizeJob has
davidedmundson added inline comments.
INLINE COMMENTS
> loh.tar wrote in loader.cpp:273
> Probably, yes. But Qt docu always says, "thanks to implicit sharing copying a
> container is very fast"
>
> Is copy previous into a const var a benefit (as I have seen recently)? Don't
> think so. Or woul
davidedmundson added a comment.
It should be faster.
It'll go from reading a file into a buffer in userspace and writing it back
to it all being handled automagically.
I'm not sure you can really blog about it, the code existed since 2003.
REPOSITORY
R241 KIO
REVISION DETAIL
ht
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
n stores the read/transferred bytes. This returns a ssize_t.
We were casting to an int, which theoretica
davidedmundson updated this revision to Diff 45889.
davidedmundson added a comment.
Fixup cpp
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17048?vs=45886&id=45889
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17048
AFFECTED FILES
src/ios
davidedmundson edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17048
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Somehow in the kdelibs -> framework port the cmake checks for
HAVE_SENDFILE got lost.
That removes
davidedmundson added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17048
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a comment.
> .I have now done a search for more Q_FOREACH/foreach. Please let me know if
you want each as own diff or all in once
Can be all at once, but still go via review. There are some foreach / for
differences and pitfalls to be wary of.
REPOSITORY
R246 Sonn
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4f5b4fd218ca: [ioslaves/trash] Handle broken symlinks in
deleted subdirectories (authored by davidedmundson).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17021?vs=45
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D17028
To: loh.tar, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson edited the summary of this revision.
davidedmundson added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17021
To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
The trash ioslave currently handles:
- working symlinks at the toplevel
- broken symlinks at the to
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
When previewing files in a KIOslave KIO will copy the file out to a
temporary directory and then run the
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16250
To: volkov, #kwin, davidedmundson
Cc: bruns, davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D16108
To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
Don't thank me yet, I locked up one of the build jobs, sorry.
https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.9/380/console
>Pipeline kf5-qt5 SUSEQt5.9
Output isn't too helpful, though I am surprised to see
kf5.kinit.klauncher in the logs when I'm supposedly invoking the
davidedmundson added a comment.
CI seems to be frozen again. :(
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D16919
To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: hindenburg, konsole-devel, ngraham, maximilianocuria
davidedmundson created this revision.
davidedmundson added reviewers: Konsole, Frameworks.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Ported from KProcess::startDetached to a QProcess we can kill s
A running KJob would not show in a backtrace.
Update at https://phabricator.kde.org/D16919
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f1c8b16a0026: Update PlasmaWindowModel test to reflect
VirtualDesktop changes (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16880?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:98b0ad34b68f: Add VirtualDesktops to PlasmaWindowModel
(authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16883?vs=45483&id=45512
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:06c18f5869f3: Cleanup windowInterface in tests before
windowManagement is destroyed (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:f25eadc92c47: Delete the correct item in removeDesktop
(authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16885?vs=45488&id=45504
REVISI
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
QList::erase will move the data underneath where the iterator is
davidedmundson retitled this revision from "Update PlasmaWindowManagementTest
for VirtualDesktop changes" to "Update PlasmaWindowModel test to reflect
VirtualDesktop changes".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16880
To: davidedmundson, #kwin
Cc: kde-fram
davidedmundson added inline comments.
INLINE COMMENTS
> runnermanager.cpp:274
>
> +if (runners.isEmpty() && !deadRunners.isEmpty()) {
> +// protection against broken category data (e.g. from different
> locale)
what does deadRunners have to do with this?
REPOSITORY
R308
davidedmundson updated this revision to Diff 45483.
davidedmundson added a comment.
update the plasma virtual desktop test at the same time
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16883?vs=45480&id=45483
BRANCH
master
REVISION DETAIL
https://p
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
VirtualDesktops with the new plurality was added PlasmaWindowManage
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Before we send the data we don't know what desktop a client is on.
davidedmundson added a subscriber: mart.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16877
To: davidedmundson, #kwin
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
TEST PLAN
Valgrind was quieter on the virtual desktop test
REPOSITORY
R127 KWayla
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a167548830fb: Cleanup Virtual Desktop Manager list entry
in PlasmaVirtualDesktop destructor (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde
I don't think application CI jobs run with workspace available. I also
can't think of anything that's been merged in workspace.
---
quitOnLastWindowClosed is also blocked if a QEventLoopLocker is placed on
the main application.
All KJobs do this and a Kjob existing and hanging seems plausible, bu
I ran the test locally which passed, then left it for someone else as:
- I can't reproduce locally.
- There are absolutely no logs on build.k.o to give a clue.
- I have no access to build.k.o to do anything (AFAIK).
- Even the phab ticket cited in the commit that disables the test is not
access
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2db50b2be381: Correct version of newly added
PlasmaVirtualDesktop interface (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16701?vs=4
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:451b1785e8d0: Capture package metadata before install
start (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16733?vs=45026&id=45028#toc
REPOSITORY
R290 KPackage
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
KPackage (despite being supposedly internally shared) is not kept as a
strong reference inside PackageJo
davidedmundson marked an inline comment as done.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16701
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 44977.
davidedmundson added a comment.
update
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16701?vs=44953&id=44977
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16701
AFFECTED FILES
src/c
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
textInputActivateEnable
REVISION DETAIL
https://phabricator.kde.org/D16676
To: romangg, #kwin, #frameworks, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngra
davidedmundson added a comment.
> Could the renaming be problematic in regards to binary compatibility
It's fine here.
As a general rule, if the class isn't defined in an installed header you can
do whatever.
REPOSITORY
R127 KWayland
BRANCH
textInputSurroundingTextCallback
REV
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:2da8aed41663: Add context to kcmodule connection to
lambdas (authored by davidedmundson).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16594?vs=44659&id=44915
R
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Current code contains a path to cleanup
PlasmaVirtualDesktopManag
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
textInputRestructure
REVISION DETAIL
https://phabricator.kde.org/D16673
To: romangg, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, brun
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16305
To: fvogt, #frameworks, davidedmundson
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added inline comments.
INLINE COMMENTS
> bruns wrote in kcmoduleqml.cpp:74
> `this` is desctructed after `d` has been deleted, so the signal may be still
> connected after d is deleted.
>
> Does `disconnect(configModule, 0, this, 0)` work, when called in the
> destructor?
Techn
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
configModule outlives KCModuleQML.
BUG: 397894
TEST PLAN
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
touchDrag
REVISION DETAIL
https://phabricator.kde.org/D15464
To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8fe4a2756cdb: Guard data source being deleted before
processing dataoffer receive event (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:55ebeda6d5b3: Add unit test for subsurface input mask
detection (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15900?vs=42731&id=4442
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
A data source can disappear at any moment, it's plausible a client
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16403
To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
If it's not a requirement for it to be set (and it isn't) I agree it's not a
useful warning. But it's also not remotely useful debug.
It's easy to see when something is
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16405
To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
db_fix_2
REVISION DETAIL
https://phabricator.kde.org/D16402
To: bruns, #frameworks, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
refactorSeatTouch
REVISION DETAIL
https://phabricator.kde.org/D15443
To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:99d8548a1c8c: [test/xdgtest] Create/destroy popup on
click (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16294?vs=43855&id=43976#toc
REPOSITORY
R127 KWayland
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:706ec10c7172: [xdgshell] Add positioner constraint
adjustment flag operators (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16318?vs=
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
TEST PLAN
Used in kwin
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
++
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D16295
To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, kde-fram
davidedmundson edited the summary of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16294
To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This allows a user to move the windoow before creating the popup wh
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D16291
To: broulik, dfaure, cfeck, ngraham, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a comment.
> Use lambdas instead of std::bind()
Why?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D16250
To: volkov, #kwin
Cc: davidedmundson, ivan, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
mart/plasmavirtualdesktop
REVISION DETAIL
https://phabricator.kde.org/D12820
To: mart, #kwin, #plasma, graesslin, hein, davidedmundson
Cc: davidedmundson, zzag, bshah, r
davidedmundson added a comment.
> sorry, I dont understand what explicitly means
As in "void setAlwaysShowAllBorders(bool)" (or whatever) that a user calls.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
dockBorders
REVISION DETAIL
https://phabricator.kde.org/D15814
To: mvourl
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> It is based on the assumption that by design plasma panels do not use mask()
It's a big assumption. It seems more based on what the two windows happen to
currently do
davidedmundson added a comment.
Thanks, resolved.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D13034
To: davidedmundson, broulik, dfaure
Cc: bcooksley, dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham,
bruns
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in framesvg.cpp:967
> Can we assume `references` always contains `svg`?
if we're calling deref without it being paired with ref then we have bigger
problems.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REV
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16060
To: apol, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:8e5608346337: Expose getter method for
KConfig::addConfigSources (authored by davidedmundson).
REPOSITORY
R237 KConf
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R237:8579ec54838b: Add mechanism to notify other clients of
config changes over DBus (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabrica
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15970
To: apol, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
arcpatch-D15098
REVISION DETAIL
https://phabricator.kde.org/D15098
To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bru
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R295 KCMUtils
BRANCH
mart/multipageKCM
REVISION DETAIL
https://phabricator.kde.org/D14580
To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b4cd89ea4977: Don't silently error if damage is sent
before buffer (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15912?vs=42820&id=4
davidedmundson added a comment.
Seems ok, I need to re-read it in the context of the other patches that I'm
getting through.
INLINE COMMENTS
> surface_interface.h:268
> + * Setting a data proxy is only allowed when the client owning this
> surface
> + * has not creted a data device
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
0selectionChangeXwl
REVISION DETAIL
https://phabricator.kde.org/D15023
To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a comment.
This is in frameworks, recentdocuments is in kio-extras.
Are you sure you can do this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: svenmauch, kde-f
davidedmundson updated this revision to Diff 42820.
davidedmundson added a comment.
Leave useless code in
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15912?vs=42766&id=42820
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15912
AFFECTE
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Firefox sends
wl_surface@37.damage(0, 0, 808, 622)
wl_surfac
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> surface_interface.cpp:450
> +typedef OutputInterface::Transform Tr;
> +const Tr tr = target->transform;
davidedmundson added a comment.
I think maybe it should, but it should be changed with surfaceAt
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasm
davidedmundson accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: romangg, #frameworks, graesslin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasma-devel,
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngrah
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15900
AFFE
davidedmundson resigned from this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15739
To: ngraham, #dolphin, #vdg
Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik,
acrouthamel, kde-frameworks-devel, michaelh, ngraham
davidedmundson added inline comments.
INLINE COMMENTS
> dialog.cpp:209
> +QWindow *parentWindow = q->transientParent();
> +bool inDock = parentWindow && !parentWindow->mask().isNull() &&
> KWindowSystem::compositingActive();
> +
How does parentWindow->mask relate to being a dock or not?
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R307 KPeople
BRANCH
person-remove (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15812
To: poboiko, #frameworks, dvratil, apol, davidedmundson
Cc: kde-frameworks-devel,
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I've written you a unit test.
I can either take over this or upload as a separate review that you can merge
in.
INLINE COMMENTS
> zzag wrote in surface_inter
davidedmundson added a comment.
No idea.
It isn't the same as adding root as it adds every drive quite deliberately.
There is a solid windows device back end, but it needs asking someone.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15739
To: ngraham, #dolph
901 - 1000 of 2832 matches
Mail list logo
