Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread David Edmundson
WE NEED A FIX IN THIS RELEASE OTHERWISE ALL PLASMA SESSIONS WILL COMPLETELY BREAK AS SOON AS Qt 5.4 COMES OUT.** Diffs - src/kstatusnotifieritem.cpp 767537d Diff: https://git.reviewboard.kde.org/r/120449/diff/ Testing --- Logged in successfully. Thanks, David Edmundson

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/#review67853 --- Ship it! Ship It! - David Edmundson On Sept. 30, 2014, 11

Re: Review Request 120480: decide at build time where the home of KDE4 is

2014-10-03 Thread David Edmundson
mpty string as kdeHome was unset. - David Edmundson On Oct. 3, 2014, 3:01 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 120480: decide at build time where the home of KDE4 is

2014-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120480/#review67864 --- Ship it! Ship It! - David Edmundson On Oct. 3, 2014, 3:34

Re: Review Request 120514: Add snippet extractor comments.

2014-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120514/#review68202 --- Ship it! Ship It! - David Edmundson On Oct. 6, 2014, 2:49

Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread David Edmundson
goes through the define_relatve define_absolute macros. Diffs - src/BackendsConfig.h.cmake 9b82fb8 Diff: https://git.reviewboard.kde.org/r/120603/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread David Edmundson
normally it's absolute. By using the CMAKE_INSTALL_FULL path we avoid that problem as it goes through the define_relatve define_absolute macros. Diffs - src/BackendsConfig.h.cmake 9b82fb8 Diff: https://git.reviewboard.kde.org/r/120603/diff/ Testing --- Thanks, David Edmu

Review Request 120621: Add atlas support into ImagesTexturesCache

2014-10-17 Thread David Edmundson
Description --- Add atlas support into ImagesTexturesCache Diffs - src/quickaddons/imagetexturescache.h 599e234 src/quickaddons/imagetexturescache.cpp 2771753 Diff: https://git.reviewboard.kde.org/r/120621/diff/ Testing --- Thanks, David Edmundson

Review Request 120622: Update QIconItem on resize

2014-10-17 Thread David Edmundson
test. Previously clicking the button visibly did nothing. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120622: Update QIconItem on resize

2014-10-17 Thread David Edmundson
/qiconitem.h 1970fda Diff: https://git.reviewboard.kde.org/r/120622/diff/ Testing --- Added a test. Previously clicking the button visibly did nothing. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-10-30 Thread David Edmundson
> On Oct. 30, 2014, 2:04 p.m., David Edmundson wrote: > > src/kratingpainter.cpp, line 231 > > <https://git.reviewboard.kde.org/r/120902/diff/1/?file=323593#file323593line231> > > > > this was previously only turned into an image to do the toGrayScale &

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-10-30 Thread David Edmundson
oo, as it's still just taking the full potentially grey icon and greyscaling it. - David Edmundson On Oct. 29, 2014, 11:30 p.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120902/#review69898 --- Ship it! - David Edmundson On Oct. 29, 2014, 11:30 p.m

Re: Review Request 121021: reverse ShowIconsOnPushButtons default

2014-11-08 Thread David Edmundson
, frankly his opinion outranks everyone else combined. - David Edmundson On Nov. 6, 2014, 9:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-13 Thread David Edmundson
++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstrac

Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread David Edmundson
Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks,

Re: Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121115/#review70351 --- Ship it! Ship It! - David Edmundson On Nov. 13, 2014, 8

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-19 Thread David Edmundson
orona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-20 Thread David Edmundson
> > > > > I'm not a fan of the propertiesChanged() method making it into the > > > > public > > > > API which we see in most classes, it's very much an implementation > > > > detail > > > > for QDBusAbstractInterface being rubbish. > > > > > Should we move it to private classes? > > I would. Or ma

Re: pkexec vs kdesu

2014-11-23 Thread David Edmundson
You will probably get massively different behaviour regarding your env. pkexec won't copy anything, sudo will. Without $DISPLAY graphical apps are out. That said, polkit is totally the way forward and anything using kdesu should be ported. What does still use it? David __

Re: Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)

2014-11-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121289/#review71089 --- Ship it! Ship It! - David Edmundson On Nov. 29, 2014, 7

Re: Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec

2014-11-29 Thread David Edmundson
, but I don't really know this code or X startup src/kioexec/main.cpp <https://git.reviewboard.kde.org/r/121230/#comment49660> where do you use this? - David Edmundson On Nov. 24, 2014, 5:52 p.m., Martin Gräßlin wrote: > > -

Re: Review Request 120878: Remove unused header

2014-11-29 Thread David Edmundson
. Ship it - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2

2014-11-29 Thread David Edmundson
> On June 26, 2014, 7:29 a.m., Thomas Lübking wrote: > > this is however not ABI relevant, so depending on schedules one *could* > > wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop > > symbol: removing it from the enum is oc. not API stable, thus not possible) > > a

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71379 --- Ship it! Ship It! - David Edmundson On Dec. 4, 2014, 9:12

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
. To reply, visit: > https://git.reviewboard.kde.org/r/121356/ > --- > > (Updated Dec. 4, 2014, 9:12 p.m.) > > > Review request for KDE Frameworks and David Edmundson. > > > Repository: knotifications > > > Des

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
st be removed > > altogether..don't know why it's still around :O > > David Edmundson wrote: > so the entire page about choosing an external player in plasma-desktop is > invalid? > > Martin Klapetek wrote: > Seems like it. If we still want that, I t

Re: Review Request 121090: Move kio-mtp to kio-extras

2014-12-08 Thread David Edmundson
, if so who deletes it? It's not being done in this scope. - David Edmundson On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. T

Re: New framework to review: KPackage

2014-12-10 Thread David Edmundson
​The binary is called kpackagetool. Given the complications we've had with frameworks co-installability does it make sense to call it kpackagetool5? The class name in kpackagetool/kpackagetool.cpp should probably be renamed Documentation at the top of PackageLoader should avoid saying Plasma quit

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-10 Thread David Edmundson
o have animated > transition from a scaled icon to the actual correct size icon. > > David Edmundson wrote: > Icon size changes may be infrequent but they do happen. It's important > that when we resize the panel we don't re-render a tonne of SVGs constantly, > we

Re: Review Request 121090: Move kio-mtp to kio-extras

2014-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review71732 --- Ship it! Ship It! - David Edmundson On Dec. 8, 2014, 2:34

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-12-11 Thread David Edmundson
I'm happy with it now. +1 from me. ​ David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread David Edmundson
o have animated > transition from a scaled icon to the actual correct size icon. > > David Edmundson wrote: > Icon size changes may be infrequent but they do happen. It's important > that when we resize the panel we don't re-render a tonne of SVGs constantly, > we

Re: KF 5.6 and Plasma 5.2

2014-12-13 Thread David Edmundson
That's the plan. Plasma releases have already been shifted to account for that. Plasma 5.2 Beta is being tagged on the 8th of Jan, releasing on the 13th. Frameworks are released in the first week of every month. I believe we're going to do this for all releases from now on; i.e Plasma 5.3 beta wi

Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
://git.reviewboard.kde.org/r/121536/diff/ Testing --- Opened systemsettings5 changed my colour scheme and had it work immediately. Breeze seems to have an issue updating tabview widgets on the fly but that's a separate issue. Thanks, David Edmu

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
t.reviewboard.kde.org/r/121536/#review72074 --- On Dec. 15, 2014, 4:51 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
/platformtheme/khintssettings.cpp 8799216 Diff: https://git.reviewboard.kde.org/r/121536/diff/ Testing --- Opened systemsettings5 changed my colour scheme and had it work immediately. Breeze seems to have an issue updating tabview widgets on the fly but that's a separate issue. Thanks,

Re: Baloo Framework - License Exception

2014-12-15 Thread David Edmundson
On Mon, Dec 15, 2014 at 12:21 PM, Ivan Čukić wrote: > > > Albert is right, Baloo is LGPL but the resulting binaries will be GPL. > > Again, this serves no purpose other than 'we are using LGPL' since > libbaloo clients can not be non-free - they will have to link to the GPL > binary. > > I'd rathe

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
but that's a separate issue. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121562: Fix build with Qt 5.5/dev branch in release mode

2014-12-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121562/#review72131 --- +1 - David Edmundson On Dec. 16, 2014, 5:42 p.m., Hrvoje

Re: Review Request 121581: Plotter in kdeclarative

2014-12-18 Thread David Edmundson
comment50399> Either I was very drunk, or this is a lie. - David Edmundson On Dec. 17, 2014, 4:20 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Review Request 121595: Always return absolute paths in Kdelibs4Migration

2014-12-19 Thread David Edmundson
kconf_update writing a kdeglobals file in the wrong directory. Diffs - src/lib/util/kdelibs4migration.cpp 4a6ba0d Diff: https://git.reviewboard.kde.org/r/121595/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing

Re: Review Request 121595: Always return absolute paths in Kdelibs4Migration

2014-12-19 Thread David Edmundson
, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KPackage framework

2014-12-22 Thread David Edmundson
No objections from me ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: qca-qt5 package name

2014-12-24 Thread David Edmundson
On Wed, Dec 17, 2014 at 12:47 PM, Harald Sitter wrote: > alohas. > > recently the QCA maintainer and I got into a discussion [1] whether a > qca-qt5 library should be a different config inside the same cmake > package or an independent one (detailed discussion in the longest > comment thread of t

Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

2015-01-01 Thread David Edmundson
sting --- Triggered a notification. It all still worked. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

2015-01-01 Thread David Edmundson
src/notifybypopup.cpp 66e593b Diff: https://git.reviewboard.kde.org/r/121786/diff/ Testing --- Triggered a notification. It all still worked. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Baloo Framework - License Exception

2015-01-05 Thread David Edmundson
On Mon, Jan 5, 2015 at 3:04 PM, Sebastian Kügler wrote: > On Monday, January 05, 2015 14:32:32 Vishesh Handa wrote: > > On Mon, Jan 5, 2015 at 1:58 PM, Sebastian Kügler wrote: > > > > Are we going to shoot ourselves in the foot (= making our lives more > > > > complicated, by having a dependency

Re: Review Request 121885: Properly check for systray being available

2015-01-06 Thread David Edmundson
tps://git.reviewboard.kde.org/r/121885/#comment50966> the statusnotifierwatcher is a kded module, which means if another kded module tries to create an SNI (and at least one does) we're going to deadlock I think? - David Edmundson On Jan. 6, 2015, 6:16 p.m., Martin Kla

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Edmundson
> On Jan. 6, 2015, 6:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > <https://git.reviewboard.kde.org/r/121885/diff/1/?file=338653#file338653line330> > > > > the statusnotifierwatcher is a kded module, which

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Edmundson
> On Jan. 6, 2015, 6:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > <https://git.reviewboard.kde.org/r/121885/diff/1/?file=338653#file338653line330> > > > > the statusnotifierwatcher is a kded module, which

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread David Edmundson
lly do that. I'd prefer making a template qtlogging.ini if the file doesn't exist; as that still allows apps to override libs on/off if they prefer and allows people to set a logging_conf if they prefer. - David Edmundson On Jan. 7, 2015, 5:57 p.m., Ale

Re: Review Request 121885: Properly check for systray being available

2015-01-08 Thread David Edmundson
> On Jan. 8, 2015, 8:06 a.m., David Faure wrote: > > I don't know the whole design around this, but this patch looks ... hackish > > (and possibly slow) to me. > > > > It looks very implementation-dependent... > > > > Is the absence of a well-known dbus name because there could be more than >

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2015-01-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review73572 --- do you have commit access? - David Edmundson On Nov. 9

Re: Review Request 120878: Remove unused header

2015-01-09 Thread David Edmundson
someone to merge this? - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121581: Plotter in kdeclarative

2015-01-12 Thread David Edmundson
lled from another thread. - David Edmundson On Dec. 29, 2014, 12:17 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

2015-01-12 Thread David Edmundson
any XCB results in a crash. This patch adds a guard around that. Diffs - src/runtime/kglobalaccel_x11.cpp dfb03b5 Diff: https://git.reviewboard.kde.org/r/122019/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing

Re: Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

2015-01-12 Thread David Edmundson
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122019/#review73872 --- On Jan. 12, 2015, 3:26 p.m., David Edmundson wrote: > >

Re: Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

2015-01-13 Thread David Edmundson
not being > > a valid connection any more if the connection is broken. > > > > I'm wondering whether there are other ways - I expect that Qt quits due > > to an XIO error? Maybe we could install a handler for it? > > David Edmundson wrote: > th

Re: Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

2015-01-13 Thread David Edmundson
grabs, since the X connection has gone any XCB results in a crash. This patch adds a guard around that. Diffs (updated) - src/runtime/kglobalaccel_x11.cpp dfb03b5 Diff: https://git.reviewboard.kde.org/r/122019/diff/ Testing --- Thanks, David Edmundson

Re: Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

2015-01-13 Thread David Edmundson
--- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122029: Fix generation of KAuth DBus helper service file

2015-01-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122029/#review73919 --- +1 - David Edmundson On Jan. 13, 2015, 11 a.m., Daniel

Re: Review Request 121885: Properly check for systray being available

2015-01-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/#review74014 --- Ship it! Ship It! - David Edmundson On Jan. 8, 2015, 11

Re: Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

2015-01-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122072/#review74074 --- +1 from me - David Edmundson On Jan. 15, 2015, 1:24 p.m

Re: Review Request 122086: Add new method KWindowSystem::icons

2015-01-16 Thread David Edmundson
either this won't work, or the one in pixmap can be simplified in the same way. (I suspect the latter) - David Edmundson On Jan. 16, 2015, 10:01 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e

Re: Review Request 122177: some minor fixes for windows

2015-01-20 Thread David Edmundson
g/r/122177/#comment51637> qunsetenv instead? - David Edmundson On Jan. 20, 2015, 9:11 p.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Review Request 122194: Initialise all member variables

2015-01-21 Thread David Edmundson
/r/122194/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122181: [KUnitConversion] UnitCategory convert: Call UnitCategoryPrivate instead of duplicating it

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122181/#review74529 --- Ship it! Ship It! - David Edmundson On Jan. 21, 2015, 2

Re: Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

2015-01-22 Thread David Edmundson
x27;s slightly out of date. - David Edmundson On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-22 Thread David Edmundson
> On Jan. 7, 2015, 6:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > <https://git.reviewboard.kde.org/r/121903/diff/1/?file=338977#file338977line12> > > > > Order of evaluation: > > QtProject/q

Re: Review Request 120621: Add atlas support into ImagesTexturesCache

2015-01-25 Thread David Edmundson
://git.reviewboard.kde.org/r/120621/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

2015-01-28 Thread David Edmundson
runtime Diffs - src/kstyle/kstyle.cpp b5f7363 Diff: https://git.reviewboard.kde.org/r/122293/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

2015-01-28 Thread David Edmundson
This removes duplicating the lookup and also means we now update the setting if it changes at runtime Diffs - src/kstyle/kstyle.cpp b5f7363 Diff: https://git.reviewboard.kde.org/r/122293/diff/ Testing --- Thanks, David Edmundson ___ Kde

Re: Review Request 122383: Remove internal copy of KXmlRpcClient

2015-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122383/#review75229 --- +1 as soon as it's a framework - David Edmundson On F

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
hanged, otherwise every binding is going to be recalculated every frame. - David Edmundson On Feb. 3, 2015, 7:52 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
hes. So we'll always be one frame out. I think we might have to move lines 115-150 to a separate method and call it from setSource, setFillMode and geomtryChanged then cache the destRect instead of these paintedWidth/Heights as a member variable. - David Edmundson On Feb. 3, 2015, 8:33

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread David Edmundson
nt52179> so if you're not in auto range and you set max to be the same as min we'd see the data is just the raw values, not even scaled to the height of the plot. Is that what we intend? - David Edmundson On Feb.

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/#review75432 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 5:46

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread David Edmundson
tps://git.reviewboard.kde.org/r/122432/#comment52183> I am so pro at reviewing. copy and paste typo. - David Edmundson On Feb. 4, 2015, 7:29 p.m., Luca Beltrame wrote: > > --- > This is an automatically generated e

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/#review75439 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 7:52

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

2015-02-06 Thread David Edmundson
tps://git.reviewboard.kde.org/r/122459/#comment52246> bit enthusiastic once will suffice. +1 - David Edmundson On Feb. 6, 2015, 5:42 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 122478: KConfigWidgets: Remove leftover uses of tr() for translation

2015-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122478/#review75600 --- Ship it! Ship It! - David Edmundson On Feb. 8, 2015, 1:11

Review Request 122482: Restore KCModule::setAuthAction

2015-02-08 Thread David Edmundson
/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/#review75847 --- +1 - David Edmundson On Feb. 11, 2015, 12:11 p.m., Aleix

Review Request 122549: Avoid code path that leaves local config files locked

2015-02-12 Thread David Edmundson
k for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing lis

Re: Review Request 122194: Initialise all member variables

2015-02-12 Thread David Edmundson
/qmlcontrols/draganddrop/DeclarativeMimeData.cpp fc96c83 Diff: https://git.reviewboard.kde.org/r/122194/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread David Edmundson
g/r/122590/#comment52518> can you do setParent(this); instead of a manual delete? I know QWidget requires another QWidget in the ctor, but setParent from QObject should allow any. - David Edmundson On Feb. 16, 2015, 11:45 a.m., Kai Uwe Broulik

Re: Review Request 122549: Avoid code path that leaves local config files locked

2015-02-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76212 --- bump? - David Edmundson On Feb. 12, 2015, 9:34 p.m., David

Re: Review Request 122549: Avoid code path that leaves local config files locked

2015-02-19 Thread David Edmundson
ot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks,

Review Request 122651: Allow users to configure how many horizontal lines are drawn

2015-02-20 Thread David Edmundson
Diff: https://git.reviewboard.kde.org/r/122651/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122651: Allow users to configure how many horizontal lines are drawn

2015-02-21 Thread David Edmundson
/kquickcontrolsaddons/plotter.h 1620446 src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 7c19a34 Diff: https://git.reviewboard.kde.org/r/122651/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Split kde-baseapps?

2015-02-25 Thread David Edmundson
On Tue, Feb 24, 2015 at 9:02 PM, Emmanuel Pescosta < emmanuelpescosta...@gmail.com> wrote: > > Hope you don't want to do this before tomorrow, do you? > > If moving Dolphin to a new repo is still possible then yes, because I > would prefer a KF5 based version of Dolphin in 15.04 :) > Seems worth

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread David Edmundson
d.kde.org/r/122590/ > --- > > (Updated Feb. 16, 2015, 12:25 p.m.) > > > Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. > > > Repository: kglobalaccel > > > Description > --- > > KGlobalAccelPrivate uses a QWidget for some magi

Re: Review Request 122482: Restore KCModule::setAuthAction

2015-02-27 Thread David Edmundson
/kcmodule.h 4fb5e0d src/kcmodule.cpp 3c43649 Diff: https://git.reviewboard.kde.org/r/122482/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 122706: A KCModule base for QML based KCMs

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122706/#review76873 --- +1 - David Edmundson On Feb. 25, 2015, 5:40 p.m., Marco

Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread David Edmundson
8c06146 Diff: https://git.reviewboard.kde.org/r/122774/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122775: Only nativeWidth/heights need updating.

2015-03-02 Thread David Edmundson
/122775/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122776: Add test for qimageitem

2015-03-02 Thread David Edmundson
--- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread David Edmundson
/qimageitem.cpp ed735b5 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 Diff: https://git.reviewboard.kde.org/r/122775/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

<    1   2   3   4   5   6   7   8   9   10   >