Re: Frameworks 6.0.0 is out!

On mercredi 28 février 2024 11:30:27 CET Jonathan Riddell wrote: > David Faure: we talked about having KF5 releases on a less frequent > release, maybe every 2 or 3 months. Do you have an opinion here? I agree, at this point monthly seems pointless. Given the low activity, let's say 3

Re: KDE Frameworks with failing CI (kf5) (29 January 2024)

hanged with the others. Big whoops. I'll clean up my local dir so it won't happen again. Apologies, -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

Re: KF5 release schedule

On mercredi 9 août 2023 17:24:48 CEST Volker Krause wrote: > On Samstag, 5. August 2023 16:53:58 CEST David Faure wrote: > > Hi everyone, > > > > Given the small size of the changelog these last two months (see attached) > > I suggest that we move to a 2-mont

KF5 release schedule

Hi everyone, Given the small size of the changelog these last two months (see attached) I suggest that we move to a 2-months release schedule for KF5. Maybe even 3 months? Let me know, I don't mind either way. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

These frameworks need new maintainers

In order to reflect reality, I have removed my name as maintainer for the following frameworks (in master). Don't hesitate to step up and write yours instead. kapidox karchive kcrash kdbusaddons kded kinit - but that's dead I think kio kitemmodels kparts kservice kxmlgui -- David Faure, fa

Re: Future of KParts::SelectorInterface

display HTML pages is created and it can implement the synchronous > API. > > What do you think? I'd say, just get rid of the synchronous interface for KF6. It's easy to implement async on top of sync (in case a future part can do it sync), and if you're porting the callers to async

Re: Respin request for KConfigWidgets

gt; https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/193 > > should be merged before the respin, because I used 5.106 in the @since > > tags initially. > > > > Thanks in advance > > Alex -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Little time for code reviews

don't add me as reviewer for anything that doesn't require old-timer memory, it's just noise for me and false hope (of a review) on your side. Cheers, -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: New

Linux/BSD packagers: you can skip kconfig-5.100.1, that fix is Windows-only anyway. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KWayland respin request

.1 release of kwayland would be possible though. But I'm not sure it's worth it at this point, 5.99.0 will be tagged in 3 days and released in 10 days. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Urgent: kirigami unittest broken

.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.15/job/kirigami/job/kf5-qt5%20SUSEQt5.15/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Urgent: kirigami unittest broken

src.libkirigami 80% (8/10) 80% (8/10) 56% (588/1055) 44% > (215/490) > src.scenegraph13% (1/8) 13% (1/8) 8% (26/333) 4% > (6/144) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF 5.95-rc1 delayed

57fd22a55f sources/plasma-framework-5.95.0.tar.xz > with that included, I think we'll finally be done from the > plasma-framework perspective. Phew ;-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF 5.95-rc1 delayed

On mercredi 8 juin 2022 23:01:07 CEST Luca Carlon wrote: > On Wed, Jun 8, 2022 at 11:41 AM David Faure wrote: > > > > This also seems like something we should also fix before tagging: > > > > https://bugs.kde.org/show_bug.cgi?id=454635#c11 > > > >

Re: KF 5.95-rc1 delayed

g/frameworks/kirigami/-/merge_requests/548 The "bad" commit has been reverted in c0f5583b by Marco > >> - the regression in kio (trash) is fixed > >> https://invent.kde.org/frameworks/kio/-/merge_requests/854 I just reverted the "bad" commit in e31a779486 --

KF 5.95-rc1 delayed

if there are other blocker issues. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: 5.94 respin request: Ark drag-and-drop fix

more kio v5.94.0-rc5 6ef16db5989294a28f9c341793054ee224eb1cbc 85c0bf8e49d845730d95c85c0292330a5bf03ed63a008cbf02ec9d02f990d09b sources/kio-5.94.0.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KWayland 5.94 respin request

.94.0-rc2 4657ddaf298a2ff3992bf438dbc98582a31beabd b2a4d8e1b4d81ce798c991cfb34210ba095f6406a37f4714ae3ab64abaca2636 sources/kwayland-5.94.0.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

QFileSystemWatcher fails with sockets on FreeBSD

/kwayland-test-wayland-datasource-0.lock") = 0 (0x0) This comes from QKqueueFileSystemWatcherEngine::addPaths calling qt_safe_open() on the socket. I guess it needs to do this differently, at least for sockets? Anyone with kqueue/kevent experience? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Windows unittests: KConfig

On dimanche 20 mars 2022 22:13:17 CET Christoph Cullmann (cullmann.io) wrote: > On 2022-03-20 22:07, David Faure wrote: > > The KConfig unittests rely on DBus nowadays (for change notification). > > This is turned off on Android, and is a cmake option elsewhere,

Windows unittests: KConfig

that need it? Currently the kconfig tests fail for lack of dbus: 21:55:23 ERROR: The process "dbus-daemon.exe" not found. https://build.kde.org/job/Frameworks/view/Platform%20-%20WindowsMSVCQt5.15/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.15/217/console -- David Faure, fa...@kde

Re: Unit tests all pass in Jenkins on Linux

On dimanche 13 mars 2022 17:53:13 CET Ben Cooksley wrote: > On Mon, Mar 14, 2022 at 4:40 AM David Faure wrote: > > After the recent discussions on state of CI, I fixed the last unittest > > failures (kio, purpose... + apol fixed ECM) so that > > https://build.kde.org/job/Fra

Unit tests all pass in Jenkins on Linux

Eduardo. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.15/job/krunner/job/kf5-qt5%20SUSEQt5.15/325/testReport/junit/projectroot/autotests/runnermanagertest/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Urgent Kirigami issue (Fwd: Re: 3 respins for 5.91.0)

-- Forwarded Message -- Subject: Re: 3 respins for 5.91.0 Date: samedi 12 février 2022, 12:48:15 CET From: Tobias C. Berner To: David Faure Moin moin kirigami2 seems to fail with ninja now: CMake Error: Running '/usr/local/bin/ninja' '-C' '/wrkdirs/usr/ports/x11

Re: Kirigami Respin

irigami v5.91.0-rc2 bdb5605880696b48dd7dd8bdd36699773451537a ad6a810b00a5a74ddb1598b46253abc979f526512884507106007f0c2efd4f4f sources/kirigami2-5.91.0.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KF6 meeting notes 2021-11-02

ng jobs might become a problem for D-Bus calls so better use a different thread, David will work on that. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF6 meeting notes 2021-10-19

tdeclarative. This is the existing practice in e.g. > ki18n and syntax-highlighting already. > Check with David F if his concerns on that from two years ago still stand. No concerns from me anymore, the solution used in ki18n and syntax- highlighting seems to be fine. -- David Faure, f

Re: Respin request Kirigami

On lundi 11 octobre 2021 12:46:04 CEST Carl Schwan wrote: > I don't think it is so urgent that we need a 5.87.1 version of > Kirigami. So it can't wait a month. Do you mean "it can't wait" or "it can wait"? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Respin request Kirigami

ase send respin requests to release-t...@kde.org I suppose a 5.87.1 version of kirigami is needed then? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: 5.87 respin request

s more sense, the comment was wrong in the old commit. But for users it should be all the same, so isn't 99d8dca607327e good enough for 5.87 ? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Problem with frameworks 5.86.0 and Konqueror

b) for most use cases, while the konqueror use case is different (opening things in-process rather than launching an external application, in many cases). What do you think? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Problem with frameworks 5.86.0 and Konqueror

ose > in a special way. However, given that the problem is more widespread, I > don't think this can be done. > > Please, add me as CC to any answer to this mail, as I'm not subscribed to > this list. I hope that this is the correct list for this kind of issues. I > had originally s

Re: Extending the license policy to include ODbL-1.0

; [2] https://spdx.org/licenses/ODbL-1.0.html > [3] https://invent.kde.org/pim/kitinerary/-/blob/master/src/lib/knowledgedb/ > timezonedb_data.cpp > [4] https://invent.kde.org/libraries/kpublictransport/-/blob/master/src/lib/ > knowledgedb/linemetadata_data.cpp -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Gitlab CI - Inbound

On dimanche 5 septembre 2021 12:26:50 CEST Ben Cooksley wrote: > On Sun, Sep 5, 2021 at 10:22 PM David Faure wrote: > > For frameworks, I think we should be able to write a one-time script that > > generates .kde-ci.yml files using the dependencies listed in kde-buil

Re: Gitlab CI - Inbound

er. Like this https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/135 ? For frameworks, I think we should be able to write a one-time script that generates .kde-ci.yml files using the dependencies listed in kde-build- metadata (and the platforms listed in metainfo.yaml) ? -- David

Re: Noteworthy changes when porting to C++17

us2017.info/removed-features-from-c17/ Maybe you can simply link to this document? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Task boards

, as long as overall dependencies don't change) should be tagged "Frameworks" rather than "KF6", so they go into the Frameworks board. This also means: please don't tag "Frameworks" those tasks that are specifically for the KF6 board, otherwise they appear in bot

T12567: Reduce code/effort duplication around color scheme support

dfaure removed a project: Frameworks. TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis, dfaure Cc: davidedmundson, ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, The-Feren-OS-Dev, cblack, hannahk, jraleigh, zachus, davidre, fbampaloukas, GB_2, ragreen, domson,

Re: Problem with ksycoca not being regenerated under flatpak

On dimanche 20 juin 2021 11:29:39 CEST Albert Astals Cid wrote: > El diumenge, 13 de desembre de 2020, a les 22:15:26 (CEST), Albert Astals Cid va escriure: > > El dissabte, 12 de desembre de 2020, a les 22:59:58 CET, David Faure va escriure: > > > Time flies, s

Re: KF6 meeting notes 2021-06-12

AGM time)? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Respin request for KIO

es a regression. > > Sorry for the inconvenience and thank you very much! Just in time ;) Done: kio v5.83.0-rc2 db88cf59dd46aebff4072e714dda5a5554a8d699 faa5a519e0cccb7197a4025f4b267a7683b49ad9d03e730a57969f33072f51c1 sources/kio-5.83.0.tar.xz -- David Faure, fa...@kde.org, http://www.davidfa

Re: Respin requests (plasma-framework, qqc2-desktop-style)

ks/qqc2-desktop-style/-/merge_requests/73 > inside? Done: qqc2-desktop-style v5.83.0-rc2 071366f0b7d9a9a4068b174413c85aeeb514f389 c10cbde91dc9ef1ba68d8eb8648f3b9452abdff8b38c2a6df829e2b9c8c8f3a1 sources/qqc2-desktop-style-5.83.0.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure

Re: Re KIO workers

On samedi 5 juin 2021 21:07:39 CEST Kevin Ottens wrote: > Hello, > > On Saturday, 5 June 2021 17:51:18 CEST David Faure wrote: > > On samedi 5 juin 2021 16:29:10 CEST Volker Krause wrote: > > > Do KIO slaves still need the klauncher/kinit loading mechanism? > > >

Re KIO workers

in-process KIO that would be needed anyway That would remove the separate process (kioslave5) from the equation but that's unrelated to plugin loading. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28861: Sonnet add Malayalam trigram

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Pushed in https://invent.kde.org/frameworks/sonnet/commit/6eb2c6392548772b2c594dfebf0ec53b9a8635d7 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28861 To:

Re: KF6 meeting notes 2021-04-24

> > to switch the default to 24x24 (instead of 22x22) > > https://phabricator.kde.org/T14397 > > -> people are going to look which code is potentially affected this > > change. On the Frameworks side, it only affects the "when" to switch the > > size > > > > > > For the next meetings: there are tasks which would benefit from having > > around: > > > > - Kai Uwe (https://phabricator.kde.org/T12536 , > > https://phabricator.kde.org/T11833 , https://phabricator.kde.org/T11875 , > > https://phabricator.kde.org/T12008 ) > > > > - more Davids (https://phabricator.kde.org/T12275, > > https://phabricator.kde.org/T12542, etc etc etc) > > > > so if you match the description above and read this, please try to be > > around next time! > > > > Ciao > > -- > > Luigi -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.15 - Build # 58 - Still Unstable!

nals > autotests 100% (5/5) 100% (5/5) 89% (382/427) 55% (243/438) > src 100% (12/12)100% (12/12)65% (1580/2444) 46% (717/1547) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dfaure abandoned this revision. dfaure added a comment. This has been done meanwhile. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dfaure commandeered this revision. dfaure edited reviewers, added: dvratil; removed: dfaure. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc:

Today's meeting

Hi everyone, I will not be available today for the meeting. Can someone else drive the discussions? [Or exceptionally we could move the meeting to Sunday.] Reminder: today's agenda is: - KGlobalAccel (T12063) - KPluginInfo kcmservices (T13555) - KSelectAction (T12097) -- David Faure, fa

Re: KNotifications usage

vironment variable so it points to the install prefix for KF5 (KNotifications specifically, if you installed it by hand). In other words, you want to set QMAKEPATH so that $QMAKEPATH/mkspecs/modules/qt_KNotifications.pri exists. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE F

Re: KNotifications usage

cmake way. Of course before that you need find_package(KF5Notifications CONFIG REQUIRED) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF6 sprint meeting notes 2021-04-03

On samedi 3 avril 2021 22:42:36 CEST Ben Cooksley wrote: > On Sun, Apr 4, 2021 at 2:18 AM David Faure wrote: > > Here are the notes from today's meeting (thanks Luigi ) > > > > Feature deprecation process > > = > > - when to deprecate a fe

KF6 sprint meeting notes 2021-04-03

eek! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Requiring Qt 5.15 for KDE Frameworks 5?

On samedi 27 mars 2021 17:07:14 CET Nicolás Alvarez wrote: > > El 27 mar. 2021, a la(s) 12:30, Fabian Vogt > > escribió: Moin, > > > > Am Samstag, 27. M?rz 2021, 14:11:38 CET schrieb David Faure: > >>>>> On samedi 27 mars 2021 12:51:37 CET

Re: Requiring Qt 5.15 for KDE Frameworks 5?

at? While at it, can we also get your feedback on * Requiring C++17 * Requiring CMake >= 3.16 Obviously this only matters for distributions that update KF5 every month. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D14967: Disable loading of translations for kformattest, which was not designed with translations

dfaure added a comment. CI runs things in a sandbox, there are no translations installed that are accessible to kf5 tests. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14967 To: habacker, dfaure, aacid Cc: asturmlechner, kde-frameworks-devel, LeGast00n,

Re: Should syntax-higlighting get 5.79.1 released with the control flow color fix?

month. > > I would have no issues with a .1, > guess I am just to ignorant for color changes. Done: syntax-highlighting v5.79.1 c4bb26684bd2ec8054623929f3196c6233c5e157 b2825ebee4c527f96562d18abb553195809dcc32174a4b998c71850e24527990 sources/syntax-highlighting-5.79.1.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

, all with changed & XCB_XKB_NKN_DETAIL_KEYCODES, which makes kglobalaccel ungrab+regrab all keys. Should I add another compression timer in kglobalaccel, or do you think this is fixable in setxkbmap? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: RFC: relative executables in desktop files

On dimanche 10 mai 2020 19:17:01 CET Aleix Pol wrote: > On Sun, Apr 26, 2020 at 1:36 PM David Faure wrote: > > During the review of https://phabricator.kde.org/D29170 the following > > question surfaced again: should it be possible for a desktop file to > > r

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

st option though. Now I'm thinking maybe the compression should happen in the keyboard module... ? That wouldn't fix the xmodmap issue though. Maybe we're seeing a N devices * M keys multiplication issue, i.e. it would be good to compress at both levels. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

On dimanche 31 janvier 2021 00:39:38 CET Albert Astals Cid wrote: > El dissabte, 30 de gener de 2021, a les 18:32:32 CET, David Faure va escriure: > > For years, I've noticed that when resuming a laptop from sleep, > > kglobalaccel and X11 use 100% CPU for a few minutes, ma

Need xcb/xkb help for severe kglobalaccel_x11 issue

but that would be a "fix without really understanding the code", never good. I just noticed https://phabricator.kde.org/D16434 so CC'ing Fabian :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE Frameworks 6 - Virtual Sprint setup

not before week 10 or even better not before week 13. I can do any weekend except week 9 (= March 6-7) (and weeks 16 & 17 but hopefully we'll do it much before that). European hours OK but American hours work for me too, I get up late and finish late in the evenings :-) -- D

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

dfaure added a comment. Thanks Alex, you rock. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: alex, #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, cordlandwehr,

Plasma Framework and Kirigami unittests

EQt514/autotests/tst_avatar_qml/ I think that one is for Carson Black, CC'ed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

dfaure added a comment. So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any reason against going with D29136 after all? REPOSITORY

Re: KDE review for KWeatherCore

y blowing up to 105 km/h at the very moment) :) Feel free to grab any code from qrpiweather that might be useful, BTW. The backend I ended up using was "Open Weather" (api.openweathermap.org). But well, that was 4 years ago, things might have changed since :) -- David Faure, fa...@kde.org

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

On jeudi 17 décembre 2020 00:20:41 CET Friedrich W. H. Kossebau wrote: > Hi, > > Am Samstag, 12. Dezember 2020, 22:25:32 CET schrieb David Faure: > > Just a data point on this discussion. Every time we raise the min Qt > > version, we make life easier for KDE developers, and

Re: Problem with ksycoca not being regenerated under flatpak

lly "touch" a directory after adding new files? Otherwise, the hack you have in mind could be implemented as in the attached patch. Untested, except that it compiles. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 diff --git i/src/sycoca/ksycoca.cpp w/sr

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

://github.com/osm-fr/osmose-backend/issues/555 for the curious PS: I agree with moving the dates for bumping the min req to just after a KF5 release, this makes complete sense, feel free to make that adjustment. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

e? CC'ing kde-free...@kde.org, I know it's not the same, but maybe you guys know? ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure added inline comments. INLINE COMMENTS > meven wrote in kfilewidgettest.cpp:481 > Let me know if I should relay you. I thought I did that in commit eb18397fe525d2e4bd9 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc:

Re: Merge tags in master branch?

mes when I started doing KF5 releases. But it hasn't happened for a long while so maybe there's now a git hook or something, to prevent that from happening? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D17816: Support for xattrs on kio copy/move

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > There are other parts of code that are guarded with `HAVE_POSIX_ACL`s, and > these aren't enabled ATM for FreeBSD. So, the change is needed and I'm > willing to implement it. > > I plan to move

XDG_STATE_HOME

, open files, undo history, …) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D17816: Support for xattrs on kio copy/move

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > > 1. enable the ACL stuff on systems with extattr, see the little bit of code > > in kpropertiesdialog.cpp > > By that you mean that I should edit the CMake module to define > `HAVE_POSIX_ACL` when

D17816: Support for xattrs on kio copy/move

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > > Has this been tested on a system with sys/extattr.h? > > I was working on this revision on such system all the time. FreeBSD contains > extattr bits in its `libc`, so no

D17816: Support for xattrs on kio copy/move

dfaure added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:12 > check_include_files(limits.h HAVE_LIMITS_H) > +check_include_files(sys/xattr.h HAVE_SYS_XATTR_H) > +check_include_files("sys/types.h;sys/extattr.h" HAVE_SYS_EXTATTR_H) This is already done by

Re: Dropping the moderation by default flag

core-devel and kde-frameworks-devel are similar, could you > please set that same setting for kde-core-devel too? > > Thanks. :) Done. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

/Dependency%20Build%20Extragear% > 20stable-kf5-qt5%20WindowsMSVCQt5.15/lastFailedBuild/console That looks like the usual java timeout I re-ran the exact same job and it passed. Can you re-enable normal CI service for Windows? I noticed e.g. that KIO tests were not run anymore... -- David

D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:481 > +KDirLister *dirLister = fileWidget.dirOperator()->dirLister(); > +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url))); > + For the record, this is broken, it should have been `completed(QUrl)`.

breeze-icons tests broken

in the scalable directory maybe? Please everyone, keep an eye on your own project (either via the mails sent to kde-frameworks-devel, or by visiting build.kde.org), so I don't have to be the unittest police. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. In D29299#676447 , @pino wrote: > In D29299#676446 , @dfaure wrote: > > > In D29299#676445 , @pino wrote: > > > > > > > > >

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. In D29299#676445 , @pino wrote: > I asked for actual **valid** use cases when using the new variables first would break, and I still got none. There is a limit to how much you can keep broken code working... assuming

D29136: Use non-deprecated KDEInstallDir

dfaure added a comment. (to remove some confusion: the previous comment had the wrong link and should have said "Abandoned in favour of https://phabricator.kde.org/D29299; -- but now it's reopened anyway, as an alternative to D29299 ) REPOSITORY R249

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

dfaure added a comment. @pino Other than the fact that you think D29136 is "good enough", do you have any concrete objection to this version? My own objection would simply be that "backward-compatible fallback" is a bit too strongly worded; it reads

General information for KDE Frameworks developers

d.kde.org/job/Frameworks/view/Everything/ then click on the platform you're interesting in, and then click on the "S" column twice. The yellow will propagate to the top. Happy hacking! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28745: Skip caching thumbnails on encrypted filesystems

dfaure accepted this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,

D28745: Skip caching thumbnails on encrypted filesystems

dfaure added inline comments. INLINE COMMENTS > thumbnail.cpp:741 > +bool allowCache; > +allowCache = sharesFilesystemWithThumbRoot(filePath); > +if (!allowCache) { join with previous line (this isn't C) ;) > thumbnail.h:95 > +#ifndef Q_OS_WIN >

D28745: Skip caching thumbnails on encrypted filesystems

dfaure added inline comments. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > How about I set it to -1 at start and check for that instead? I checked > definitions and it looks like dev_st is unsigned, but it shouldn't be a > problem. -1 isn't exactly a great value for an unsigned int

Re: kwayland's testRemoteAccess still flaky

Qt5.15/14/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

0% (0/108) > > > > src.view > > 88% (15/17) > > 88% (15/17) > > 57% (3794/6612) > > 43% (1663/3884) > > > > src.vimode > > 100% (30/30) > > 100% (30/30) > > 81% (1899/2333) > > 61% (979/1599) > > > > src.vimode.config > > 0% (0/1) > > 0% (0/1) > > 0% (0/120) > > 0% (0/76) > > > > src.vimode.emulatedcommandbar > > 100% (13/13) > > 100% (13/13) > > 98% (897/917) > > 90% (588/652) > > > > src.vimode.modes > > 100% (10/10) > > 100% (10/10) > > 87% (3266/3761) > > 79% (1884/2374) > > > > Links: > > -- > > [1] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/abi-compatibility-results.yaml [2] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/acc/KF5TextEditor-5.72.0.xml [3] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/compat_reports/KF5TextEditor_compat_report.html [4] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/logs/KF5TextEditor/5.72.0/log.txt -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28745: Skip caching thumbnails on encrypted filesystems

dfaure added inline comments. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > If st_dev cannot be 0 on successful call of lstat, I don't think there's need > to change anything. m_thumbnailDirDeviceId will remain zero only if lstat > returns error and as long it's zero

D28745: Skip caching thumbnails on encrypted filesystems

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > No. The m_thumbnailDirDeviceId is set to 0 and only changed if lstat executes > properly. Then it takes value of

Re: KIO on Android Failure

why I didn't notice this problem. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26448: Add KRecentFilesMenu to replace KRecentFileAction

dfaure accepted this revision. dfaure added a comment. Thanks :-) BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

dfaure added inline comments. INLINE COMMENTS > krecentfilesmenu.cpp:74 > +{ > +action = new QAction(titleWithSensibleWidth(qobject_cast *>(menu->parent(; > +QObject::connect(action, ::triggered, action, [this, menu]() > { QMenu is a QWidget. Why not just pass `menu` as

Re: Dropping the moderation by default flag

ve > the moderator password, not the owner password. > > Please owner[s], can you disable this? > > I *think* it's the "By default, should new list member postings be > moderated?" in "Privacy options..." -> "Sender filters". Done. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26448: Add KRecentFilesMenu to replace KRecentFileAction

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. A unittest would be useful too, especially if we then refactor the loading to use KIO jobs. But after 6 months, let's land this and keep working on it. Are you interested in writing

  1   2   3   4   5   6   7   8   9   10   >