for the existing plasma 5.2 to compile, but I
would also change plasma in master to use its own copy of the xml file, so that
the two xml files can be upgraded at different times, and without the need to
define a new interface every time.
- David Faure
On March 18, 2015, 11:09 a.m., David Rosca
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122937/#review77663
---
Ship it!
Ship It!
- David Faure
On March 14, 2015, 11:46
:
V2 is there intentionally for compatibility, because with V3 plasma5.2
would compile, but stop to work - kuiserver from plasma5.2 would export V2
interface but kjobwidgets would create invalid V3 interface and calls would
fail.
David Faure wrote:
I think the way V1 vs V2 is handled
://git.reviewboard.kde.org/r/122970/
---
(Updated March 18, 2015, 11:09 a.m.)
Review request for KDE Frameworks and David Faure.
Repository: kjobwidgets
Description
---
This fixes source compatibility from https
will make this unnecessary, i.e. the doc change won't get committed.
Any input?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
diff --git a/src/lib/util/kdelibs4configmigrator.cpp b/src/lib/util/kdelibs4configmigrator.cpp
index cde7ab4..c8560c1 100644
--- a/src
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/#review77921
---
Ship it!
Ship It!
- David Faure
On March 22, 2015, 5:25
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122484/#review77612
---
Ship it!
Ship It!
- David Faure
On March 17, 2015, 12:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122313/#review77724
---
Ship it!
- David Faure
On Jan. 29, 2015, 6:54 p.m., Hrvoje
.
Every bugfix (compared to the previous release, not for commits from the day
before) can matter to users of the frameworks. Having them in the changelog is
IMHO useful. So I agree, it's not every commit, but it's not major features
only either.
--
David Faure, fa...@kde.org, http
than merging the two, and
the commit log on reviewboard is outdated, it still talks about V3). But if you
make sure to review and clean up the commit, you can commit.
- David Faure
On March 18, 2015, 1:07 p.m., David Rosca wrote
On Saturday 21 March 2015 10:16:07 Mathias Kraus wrote:
Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel:
Le Saturday 07 March 2015 13:47:13 David Faure a écrit :
KdePlatformTheme::loadSetting
This code runs before the application name is set, but the fallback to
argv[0
because we didn't see that problem coming (the code doesn't
actually use KConfig).
But yeah that would be a solution, making a new class in kconfig and
deprecating the one in kcoreaddons.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
---
Ship it!
Ship It!
- David Faure
On March 17, 2015, 4:17
On March 17, 2015, 4:38 p.m., David Faure wrote:
Ship It!
Yes, both in kdelibs 4 and in the kio framework.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
On March 7, 2015, 9:04 a.m., David Faure wrote:
KService is basically ksycoca. One day I hope we can move away from that,
which means all of kservice could then be deprecated.
So it still makes sense to *use* kservice where looking up desktop files is
needed (it's our current
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122616/#review77154
---
Ship it!
Ship It!
- David Faure
On Feb. 18, 2015, 8:17
On Saturday 07 March 2015 19:32:07 šumski wrote:
On Saturday 07 of March 2015 17:24:17 David Faure wrote:
Dear packagers,
Here's KF 5.8.0
New frameworks: kpeople and kxmlrpcclient.
A few things regarding kpeople:
It requires Qt 5.3, rest of KF5 5.2;
Fixed (although I don't have
/122682/#comment53012
(I guess this should be instead of ==, the day we have more than one
field in that flag, but indeed the code currently uses == and we can always
change it later when adding the 2nd flag.)
- David Faure
On Feb. 23, 2015, 1:11 a.m., Friedrich W. H. Kossebau wrote
On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote:
autotests/deletejobtest.cpp, line 62
https://git.reviewboard.kde.org/r/122755/diff/3/?file=352496#file352496line62
This has broken the KIO build
(http://build.kde.org/job/kio_stable_qt5/123/console)
, this looks fine to me.
- David Faure
On Feb. 18, 2015, 10:05 a.m., Emmanuel Pescosta wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122620
be to put it in KNewStuff. It's the same kind of thing, viewed
from far away: offering the user to install more stuff.
- David Faure
On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply
On March 7, 2015, 9:42 a.m., David Faure wrote:
src/ioslaves/http/http.cpp, line 854
https://git.reviewboard.kde.org/r/122614/diff/1/?file=350094#file350094line854
I don't like the use of section, when we have QUrl API to do this
cleanly.
Store thisURL.adjusted
/122614/#comment53007
I don't like the use of section, when we have QUrl API to do this cleanly.
Store thisURL.adjusted(StripTrailingSlash), and use fileName() on that?
- David Faure
On March 7, 2015, 9:29 a.m., Emmanuel Pescosta wrote
/irccontextmenus.cpp.
Sounds like it should go into KIOWidgets then.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
. (On hindsight, maybe the config migrator should have been in
KConfig...)
I'm surprised that Laurent didn't hit this issue though?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde
This should not turn into ftp://u...@example.com/
- David Faure
On Feb. 18, 2015, 8:46 p.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613
/122621/#comment53010
not really a todo for this particular class then, it wouldn't change ;)
sftp/kio_sftp.cpp
https://git.reviewboard.kde.org/r/122621/#comment53011
no space before , qCDebug will add one already.
- David Faure
On Feb. 18, 2015, 11:14 a.m., Emmanuel Pescosta wrote
On Thursday 26 February 2015 01:06:40 Albert Astals Cid wrote:
El Dimecres, 25 de febrer de 2015, a les 13:23:42, David Faure va escriure:
On Wednesday 28 January 2015 20:01:45 Albert Astals Cid wrote:
El Dimecres, 28 de gener de 2015, a les 16:17:53, David Faure va
escriure:
On Monday
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122614/#review77153
---
Ship it!
Ship It!
- David Faure
On March 7, 2015, 9:29
the plasma package
...
### Buildsystem changes (extra-cmake-modules)
* Extend ecm_generate_headers macro to also support CamelCase.h headers
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel
, but for compat reasons
it's simpler to just add a setter indeed.
- David Faure
On March 12, 2015, 10:03 p.m., David Rosca wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122926
On Friday 13 March 2015 09:29:44 David Faure wrote:
Plasma framework
* Fix plasmapkg2 for translated systems
* Improve tooltip layout
* Make it possible to let plasmoids to load scripts outside the plasma
package
...
Plasma-framework developers: this ... means, please use CHANGELOG
to
implement this into the kconfig framework itself.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123101/#review78188
---
Ship it!
Ship It!
- David Faure
On March 22, 2015, 6:05
/platformtheme/kdirselectdialog_p.h (line 62)
https://git.reviewboard.kde.org/r/123111/#comment53572
red (trailing spaces)
- David Faure
On March 23, 2015, 12:30 a.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply
json metadata for
all kded modules sounds like a great idea (especially since kiod requires that,
so if some move later to kiod, it will have to be done).
- David Faure
On Feb. 26, 2015, 6:53 p.m., Alex Richardson wrote
On Feb. 27, 2015, 7:41 a.m., David Faure wrote:
Oops, what happened here? Did I forget to review this? Having json metadata
for all kded modules sounds like a great idea (especially since kiod
requires that, so if some move later to kiod, it will have to be done).
Alex Richardson
not running then this doesn't work
indeed.
We could install a .service file for kssld but ok, let's do this for now. My
idea of making this independent from the process actually hosting kssld is more
trouble than I thought.
- David Faure
On March 1, 2015, 2:29 a.m., Bartosz Sławianowski wrote
On Wednesday 28 January 2015 20:01:45 Albert Astals Cid wrote:
El Dimecres, 28 de gener de 2015, a les 16:17:53, David Faure va escriure:
On Monday 26 January 2015 15:25:34 Daniel Vrátil wrote:
Bump.
We would really love to get this to 5.7, so unless anyone objects, I'll
wait
SOVERSION 5
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
it will still show up in
dependency diagrams, making a mess with baloo being in the middle of
frameworks while it was decided that it's not.
This shouldn't be a show-stopper, even less for the Beta versions.
KF 5.x isn't a beta.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE
---
On Feb. 21, 2015, 7:58 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122232/
---
(Updated Feb. 21, 2015, 7
found. I'm not sure how to solve this
issue yet, but I'd be happy to just document the issue and strike this test.
I only get this when the configuration file does not exist before the
program executes, which may be why we missed it from the earlier patches.
David Faure wrote
the
KSharedConfig test, as using KSharedConfig can mask the problem since
KSharedConfig's pointer is cached, avoiding the KConfig constructor.
David Faure wrote:
Oh. Indeed. I can explain the test failure: that test was removing the
config file and then creating a KConfigSkeleton around
1da816faea5548d2f529755d6538a142a2193720
src/core/ksharedconfig.h d0791e461804d421010bc5f82873371a4d3bc992
Diff: https://git.reviewboard.kde.org/r/122232/diff/
Testing
---
Both tests pass and the QCoreApplication::arguments warning (because called
after qApp is destroyed) is gone.
Thanks,
David Faure
its number and its deps number automatically)
Oh and show stopper: it depends on baloo, which was refused as a
framework
Man, what a mess we're putting ourselves into.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
If it's ready, I can make that happen with two commands or so.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
On Monday 23 March 2015 00:25:14 Matthew Dawson wrote:
On March 22, 2015 06:19:46 PM David Faure wrote:
But wait, this makes me realize another solution: kdelibs4configmigrator
could load the framework integration plugin, which would take care of
this, if installed.
Patch attached
the comment in here so that if anyone uses this as the
starting point for a new job, then that person remembers to think about whether
or not to call registerJob ;-)
Thanks for pinpointing the issue!
- David Faure
On Jan. 23, 2015, 2:13 p.m., Martin Klapetek wrote
Jan. 23, 2015, 4:15 p.m.)
Review request for KDE Frameworks and David Faure.
Bugs: 342276
https://bugs.kde.org/show_bug.cgi?id=342276
Repository: kio
Description
---
PasteJob creates a copy/move job and passes its flags to it. These jobs then
register
)]
Hmm. Passes all the time for me. Maybe a matter of inotify vs FAM vs stat...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
On Jan. 29, 2015, 7:46 a.m., David Faure wrote:
Shouldn't splitArgs be fixed instead? After all a real shell would not
split on that character, would it?
Albert Astals Cid wrote:
That is indeed a good question. Bash doesn't seem to need the quotes, but
i don't know about other
to be updated when module moves...?).
No, build.kde.org uses a git url, so it doesn't matter where the module is
logically placed on projects.kde.org.
But yes, for kde-build-metadata it matters.
(there is nothing to update in release-tools, just set release to true in your
yaml file)
--
David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121599/#review79239
---
Ship it!
Ship It!
- David Faure
On Feb. 28, 2015, 10:49
user-places.xbel ?
I wonder too.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
not sure that's a fair assessment. The number of plasma2/kf5 users is much
much lower than the number of KDE SC 4 users for sure
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123500/#review79518
---
Ship it!
Ship It!
- David Faure
On April 25, 2015, 7:35
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123443/#review79517
---
Ship it!
Ship It!
- David Faure
On April 22, 2015, 4:13
a different name for
easier searching, but putIODevice or putFromIODevice isn't great.)
- David Faure
On April 22, 2015, 4:13 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
autotests/globaltest.cpp, line 96
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96
This should be (1).txt?
Ashish Bansal wrote:
imho if my any file starts with ., that's my dot file and I would
, it can return the mimetype and
even the known suffix without any iteration needed, see
QMimeDatabase::suffixForFileName.
- David Faure
On April 4, 2015, 1:15 p.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail
the URL key:
tmp.desktopGroup().readPathEntry(URL, QString())
And this should be compared with url.toDisplayString(), not url.toString(),
to match what gets written into the file (see the variable openStr in
::add()).
- David Faure
On April 18, 2015, 11:21 a.m., Anthony Vital
On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
lib/konq/src/konq_historyentry.h, line 57
https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
const ref, no?
Andrius da Costa Ribas wrote:
before I try to fix the pending issues: what are we going
backporting it (it won't be
toDisplayString() there, check what the code does and do the same). You can
push to both.
- David Faure
On April 26, 2015, 7:12 p.m., Anthony Vital wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123525/#review79627
---
Ship it!
Nice and simple :-)
- David Faure
On April 27
release process works quite well (changelog aside), so I
would not advocate this (changing it by having someone else do it
differently).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing
kdebugsettings in playground, ask
Laurent.
Well, kde_projects.xml to the rescue:
http://projects.kde.org/projects/kdereview/kdebugsettings
Now that section (How to get debug output) certainly needs an update, for
categorized logging instead of kDebug.
--
David Faure, fa...@kde.org, http
not
defeat that purpose.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
to hack on a 5.10 framework using 5.9 dependencies,
with of course the small risk that it might not compile if it already uses
some 5.10 API from a dependency.
This will still require the very latest release though, no hacking 5.10 with
5.5 installed.
--
David Faure, fa...@kde.org, http
way to have something that a human (all
humans) can wrap their head around, to avoid a complex version matrix with 75
frameworks each requiring a different version of the 1-to-20 frameworks they
depend on.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
one, and let the application
use that, and open the properties dialog from a slot.
Alternatively, the properties dialog could itself delay showing itself
until it has stat'ed the urls (using a slot, not a blocking nested event loop).
- David Faure
On April 27, 2015, 11:49 a.m
in the lambda and test them after
exec, to avoid the issue that Q_ASSERT doesn't work in release mode and isn't
as precise as QCOMPARE in case of failure, in debug mode.
- David Faure
On May 2, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123508/#review79773
---
Ship it!
Ship It!
- David Faure
On May 1, 2015, 9:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123589/#review79779
---
Ship it!
Ooops! Good find, thanks.
- David Faure
On May 2
.
- David Faure
On May 2, 2015, 8:38 a.m., Boris Egorov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123590
: no screens
available.
I think this is because they need a bundle, which can be done by adding GUI to
the
ecm_add_test call, see kxmlgui 9abace028 for an example.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde
---
Still passes on Linux, we'll see if the CI says it fixed it for Mac.
Failure before the fix:
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/
Thanks,
David Faure
On Saturday 02 May 2015 10:00:15 David Faure wrote:
(*) On the Mac, many tests fail with Cannot create window: no screens
available. I think this is because they need a bundle, which can be done
by adding GUI to the ecm_add_test call, see kxmlgui 9abace028 for an
example.
Hmm, that's
() and see that the KF5
file was created.
I can repeat the foreach() if you think it's more readable.
- David Faure
On May 2, 2015, 8:17 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit
/#comment54605
better do this comparison after the exec, to be able to use QCOMPARE. And
to make sure that slot was actually called. Right now, if it's not called,
the test still passes.
- David Faure
On April 30, 2015, 12:08 a.m., Aleix Pol Gonzalez wrote
/kusertest/
Diffs
-
autotests/kusertest.cpp d17a2d3e97d5056524281eb18766377e48a0da35
Diff: https://git.reviewboard.kde.org/r/123595/diff/
Testing
---
Still passes on Linux; should fix the CI for mac, AFAICS.
Thanks,
David Faure
___
Kde
, but I don't have a link for rebuild now anymore.
Did I lose that permission somehow, or is the functionality gone?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
signature.asc
Description: This is a digitally signed message part
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79787
---
Ship it!
Ship It!
- David Faure
On May 2, 2015, 4:46 p.m
On Saturday 02 May 2015 10:00:15 David Faure wrote:
Ben, Scarlett: did something change in the setup? Is XDG_DATA_DIRS not
pointing to the install dir of the framework anymore?
Similarly, shared-mime-info (found via XDG_DATA_DIRS on Linux) isn't found
anymore, breaking at least kparts
would
fetchMore really do?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
I wanted to release KF 5.10 today, but releasing something with broken
unittests doesn't make
me very confident. Any chance all this can be stabilized by tomorrow?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
separate this more cleanly.
Yes. Also, the code is in tests/, which is the wrong place for a unittest.
The automated part of it should be in autotests/ and the interactive part of
it should be in tests/.
Thanks for the fix :)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working
5.10.
If this is temporary code then doing it only if new-style plugins haven't been
found doesn't really matter much IMHO.
- David Faure
On April 28, 2015, 11:16 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e
On Monday 04 May 2015 12:23:32 Kevin Funk wrote:
The issue could be easily fixed by moving the myframework_version.h into
$PREFIX/include/KF5/$FRAMEWORK/, no?
Correct, this is what KArchive does.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
On Monday 04 May 2015 12:29:39 David Faure wrote:
On Monday 04 May 2015 12:23:32 Kevin Funk wrote:
The issue could be easily fixed by moving the myframework_version.h into
$PREFIX/include/KF5/$FRAMEWORK/, no?
Correct, this is what KArchive does.
Ooops, I thought we were talking about
: by using host().isNull(), but
OK, I'm not sure if the result will be more readable (it would be faster
though).
- David Faure
On May 4, 2015, 2:59 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply
it worse: the buildsystem won't complain, but very often
you end up with a compilation error, due to an enum value or method not found
in qtbase. So you only discover this after 30 minutes of compiling. Being told
before hand by the buildsystem would be an improvement...
--
David Faure, fa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123567/#review79763
---
Ship it!
Ship It!
- David Faure
On April 29, 2015, 1:21
to me that you can remove the old conditional and just use yours
instead. That works in your tests, right?
No point in keeping possibly-wrongly-ported unused code.
- David Faure
On May 1, 2015, 9:17 a.m., Lindsay Roberts wrote
mid(0, ) above. The unittest will tell you if I'm wrong by one char, but I
don't think so :)
- David Faure
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
file, when setting
things up by hand?
I think this patch mixes two things, fixing a duplication bug, and adding a
limitation to 2 entries in the list.
Maybe one day the GUI could allow more than two shortcuts, too.
- David Faure
On May 3, 2015, 2:46 p.m., Mladen Milinkovic wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123598/#review79793
---
Ship it!
Thanks!
- David Faure
On May 3, 2015, 12:05 p.m
, 2015, 6:45 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123595/
---
(Updated May 2, 2015, 6:45 p.m
this KConfig instance is created (with a non-empty name), it *is* a
file on disk (and a single one due to SimpleConfig), we know that, no need to
check it.
- David Faure
On May 11, 2015, 4:20 a.m., Stefan Becker wrote
On May 10, 2015, 10:43 p.m., David Faure wrote:
src/core/kfileitem.cpp, line 1115
https://git.reviewboard.kde.org/r/123654/diff/1/?file=366630#file366630line1115
I had the same thought as Milian... but I wonder why I wrote that
comment. m_strText is the displayName, m_strName
1 - 100 of 6554 matches
Mail list logo
