D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter added a comment. setting server to keepalive=false? what is this? the 90's? :O wouldn't it be simpler to `finishDav` and recurse `rename` with the redirected url? the code inside the conditional block is basically a code copy of the code above, so why not just throw away the dupli

D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Fair enough. LGTM :) Do you need sponsoring or do you have commit access? REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator.kde.org/D197

D19786: Fix WebDAV directory renaming if KeepAlive is off

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c6b5750b9527: Fix WebDAV directory renaming if KeepAlive is off (authored by hoffmannrobert, committed by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19786?

D19779: point readme to the wiki page

sitter added a comment. I am taking silence as indifference. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19779 To: sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19779: point readme to the wiki page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:998982a47cbc: point readme to the wiki page (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

sitter accepted this revision. sitter added a comment. Ha, this is also much nicer looking. I love it! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew,

D20078: RFC fix race on kcrash auto-restarts

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY When kcrash is set to auto restart Unique service processes we have potential for a race. Because KCrash will want to id

D20078: RFC fix race on kcrash auto-restarts

sitter added subscribers: broulik, davidedmundson. sitter added a comment. Still fairly messy and very verbose but working. @broulik @davidedmundson I'd love some thoughts on this. Also, @davidedmundson since you suggested the registration queuing. I do wonder if that isn't actually

D19850: Make AppStream generation opt-in

sitter added a comment. LGTM technically. Also looks crazy scary invasive though from a packaging POV :O What if a third party user of kpackage actively relied on the appstream data being auto-generated? Wouldn't this change in behavior essentially break backwards compatibility? Perhaps

D20092: New class KOSRelease - a parser for os-release files

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Imported form KInfoCenter along with test case. This also includes a license change from GPL to LGPL. When working

D20092: New class KOSRelease - a parser for os-release files

sitter added a reviewer: apol. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI system maintainability

On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with real

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 54993. sitter added a comment. - doc wording - disable cctor. no real use case for copy at this point REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20092?vs=54985&id=54993 BRANCH master REVISION DETAIL https

D20172: use the plasma icon as plasma icon

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kde is the kde logo, start-here-kde is our app menu icon which is the plasma icon TES

D20172: use the plasma icon as plasma icon

sitter added a comment. before F6742443: Screenshot_20190401_173503.png after F6742444: Screenshot_20190401_173529.png REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org

D20172: use plasma icon as icon for plasma notification category

sitter retitled this revision from "use the plasma icon as plasma icon" to "use plasma icon as icon for plasma notification category". REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D20172 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, br

D20172: use plasma icon as icon for plasma notification category

sitter added a comment. Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon

D20176: make start-here-kde also available start-here-kde-plasma

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the latter offers a less ambiguous name when we want to refer to something plasma specific. a recent example is D20172

D20172: use plasma icon as icon for plasma notification category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:8ce99b1637ef: use plasma icon as icon for plasma notification category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20172?vs=5

D20092: New class KOSRelease - a parser for os-release files

sitter added a subscriber: davidedmundson. sitter added a comment. The only relevant change in the history not from me is from @davidedmundson it seems. Dave, are you ok with changing the license from GPL to LGPL? https://phabricator.kde.org/R102:65e55f0b090247263bb3ba2b45615fa3b2ff1320

D20225: use more appropriate plasma-specific icon for plasma category

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY with D20176 landed we can now use the more appropriate icon variant for plasma her

D20176: make start-here-kde also available start-here-kde-plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9ff7e4658ded: make start-here-kde also available start-here-kde-plasma (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20176?vs=55209&id=5

D20092: New class KOSRelease - a parser for os-release files

sitter updated this revision to Diff 55338. sitter added a comment. - defaultFilePath is now static in the cpp only, the public ctor defaults to QString() for the filePath, which gets checked in the private ctor and diverted to defaultFilePath if necessary - Private ctor now copies filePath

D20225: use more appropriate plasma-specific icon for plasma category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:bf27abdb08eb: use more appropriate plasma-specific icon for plasma category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20225

D20693: Remove pixelated border

sitter added a comment. LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion. @leinir lxr says a similar thumb is also used for some of the KAboutPerson stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it

D20693: Remove pixelated border

sitter added a comment. In D20693#454750 , @leinir wrote: > So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we mi

D20092: New class KOSRelease - a parser for os-release files

This revision was automatically updated to reflect the committed changes. Closed by commit R244:1bedee3ca534: New class KOSRelease - a parser for os-release files (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20092?vs=55338&id=56813#toc REPOSITORY R244 KCoreAddon

D20955: use actually existing breeze icon for the new file Program.desktop

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Icon entry in there was a legacy name that no longer exists. this resulted in the default new program having no/brok

D20955: use actually existing breeze icon for the new file Program.desktop

sitter edited the summary of this revision. sitter added reviewers: VDG, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20955 To: sitter, #vdg, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20955: use actually existing breeze icon for the new file Program.desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b127112914df: use actually existing breeze icon for the new file Program.desktop (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20955?vs=57368&id=

D21079: make sure to also assert ScaledDirectories

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY Directories and ScaledDirectories do the same thing, the latter is however used for backwards compatibility with old the

D21079: make sure to also assert ScaledDirectories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7e974fd48e0d: make sure to also assert ScaledDirectories (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21079?vs=57753&id=57754 REVISION

D21100: don't glob everything and the kitchen sink

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY we have two themes. glob the two themes and nothing else. otherwise when keeping the build directory in ./build/ we'd

D21099: Use locale currency for donate icon

sitter added a comment. LGTM REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D21099 To: broulik, #frameworks, #vdg Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D21100: don't glob everything and the kitchen sink

This revision was automatically updated to reflect the committed changes. Closed by commit R266:009608ce8e5d: don't glob everything and the kitchen sink (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21100?vs=57808&id=57809 REVISION

D21099: Use locale currency for donate icon

sitter added a comment. For obvious reasons I'd recommend only going for the major currencies :) I've had a quick look at a part of our website visits and the following currencies would be the most relevant based on that: 1. EUR 2. USD (this is actually the default icon so it's not

D21305: Add the FreeBSD default-path for os-release.

sitter added a comment. I do wonder if we couldn't just move the freebsd path to the end of the list and drop the ifdef. As far as linux is concerned we still obey the lookup order but simply have an additional path where we may look (and where the file should not ever exist on linux). Conve

D21526: Add help-donate-[currency] icons

sitter accepted this revision. REPOSITORY R266 Breeze Icons BRANCH donate-currency (branched from master) REVISION DETAIL https://phabricator.kde.org/D21526 To: ndavis, #vdg, sitter, broulik, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

knewstuff's gpg use

Morning, I had the most peculiar incident just now. KNewstuff shouted at me because I have no bin/gpg(2). As it turns out core/security.cpp implements some form of gpg signing verification. Based on the gpg CLI app. Naturally, I am perplexed by this because CMake doesn't actually report gpg as a

[Differential] [Request, 286 lines] D4254: add new test for scalable exposure

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY the icon themes use SVG but do not want the same icon to be used for small resolutions as to not have high-detail icons at super small sizes

[Differential] [Updated, 285 lines] D4254: add new test for scalable exposure

sitter updated this revision to Diff 10460. sitter added a comment. warning-- qdebug the limited testing of the test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10459&id=10460 BRANCH master REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 54 lines] D4268: deprecate the security class

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Security class is not actually used, hasn't seen any active development in years and uses gpg in a questi

[Differential] [Closed] D4268: deprecate the security class

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0dc151ae2c8b: deprecate the security class (authored by sitter). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4268?vs=10491&id=10501 REVISION DETAIL https://

[Differential] [Closed] D4254: add new test for scalable exposure

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7d01f3d8b5c0: add new test for scalable exposure (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10460&id=10757 REVISION DETAIL

breeze-icons and the symlink business

hola breeze-icons uses lots of symlinks. Unfortunately, ever so often our icon designers make a mistake and create a bad symlink. To mitigate this I added a bunch of tests making sure everything is nice and dandy. In the mean parts of the build were changed to not tolerate broken symlinks. While

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley wrote: > On Thu, Feb 2, 2017 at 10:23 PM, Luigi Toscano > wrote: >> Il 02.02.2017 10:09 Ben Cooksley ha scritto: >> >>> Hi all, >>> >>> As a starting point: keeping the software itself running is a >>> non-starting option from my perspective. It's go

Re: breeze-icons and the symlink business

On Thu, Feb 2, 2017 at 12:24 PM, Jaroslaw Staniek wrote: > > > On 2 February 2017 at 00:49, Harald Sitter wrote: >> >> hola >> >> breeze-icons uses lots of symlinks. Unfortunately, ever so often our >> icon designers make a mistake and create a bad symlink.

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 6:17 PM, Ben Cooksley wrote: > On Thu, Feb 2, 2017 at 11:51 PM, Harald Sitter wrote: >> On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley wrote: >>> On Thu, Feb 2, 2017 at 10:23 PM, Luigi Toscano >>> wrote: >>>> Il 02.02.2017 10:09 Ben

[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

sitter accepted this revision. sitter added a comment. Ah! I hadn't even thought of QSettings. Love the change. FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing `parseContext` to

D4925: actually delete old theme caches

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 To: mart, #plasma, sitter Cc: sitter, apol, plasma-devel, #fr

D5032: drop examples dir

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - it does not build on its own (doesn't find_package anything) - it is not wired into the overall build (so you can't build it as part of t

D5032: drop examples dir

sitter added a comment. Not interesting enough to me. If someone finds it interesting, sure. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

Re: Automatic Tests and Continuous Integration

you need to drill down into the 'default' configuration http://i.imgur.com/D4Asuaa.png On Wed, Mar 15, 2017 at 10:10 AM, Matthieu Gallien wrote: > Hello, > > I am a bit lost when looking at both KFileMetaData projects under > build.kde.org. I am not able to get any coverage, cppcheck or > automat

D5079: debug when disabling kcrash due to env vars

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY otherwise it's fairly inobvious why drkonqi doesn't kick in REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.

D5079: debug when disabling kcrash due to env vars

sitter added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D5079 To: sitter, dfaure Cc: #frameworks

D5079: debug when disabling kcrash due to env vars

This revision was automatically updated to reflect the committed changes. Closed by commit R285:c916d7b8f3a2: debug when disabling kcrash due to env vars (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5079?vs=12553&id=12631 REVISION DETAI

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. I really think this should have a simple test case. In particular, the allow_edit behavior should be asserted somewhere. Also some style nitpicks. INLINE COMMENTS > fetchpo.rb:52

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > l10n.rb:217 > > -def get(srcdir) > - # FIXME: this is later used as destination for the weirdest of > reasons... > - target = "#{srcdir}/po/"

D5133: Introduce fetchpo.rb

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 To: apol, #frameworks, sitter

D5143: Introduce fetch-translations build command

sitter added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:74 > # - ``APPLE_SUPPRESS_X11_WARNING`` option since 5.14.0 > > > #= Needs documentation for the l10n awesomeness. > KDECMakeSettings.cmake:280

D5143: Introduce fetch-translations build command

sitter added a comment. A couple of things I am not sure about - defaults to stable translations, I'd say it should default to trunk. e.g. playground and kdereview don't even have stable - considering one has to enable this feature in the cmakecache I think it should be made a dependen

D5195: don't add the autotests dir when test building is disabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY autotests need qt5qml which is other than that not needed for ki18n REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabr

D5195: don't add the autotests dir when test building is disabled

sitter added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5195 To: sitter, ilic Cc: #frameworks

D5143: Introduce fetch-translations build command

sitter added a comment. The way I understand it the use case here is during development, so I am not sure the ki18n circular dep is particularly concerning. Avoiding it seems fairly difficult as find_package needs to happen at configure-time, fetch-translations at build-time, and so we only

D5195: don't add the autotests dir when test building is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R249:16750048daf7: don't add the autotests dir when test building is disabled (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5195?vs=12859&id=12894

D5143: Introduce fetch-translations build command

sitter added a comment. In https://phabricator.kde.org/D5143#97985, @apol wrote: > In https://phabricator.kde.org/D5143#97847, @aacid wrote: > > > That creates a dependency for ki18n for frameworks that only use .ts files, no? > > > One thing we can do is remove the ki18n_instal

D5143: Introduce fetch-translations build command

sitter added a comment. Oh! OTOH, given fetch-translations pulls it into bin_dir while normally we'd have it in src_dir this may well be awkward in implementation. e.g. https://phabricator.kde.org/D5197 effectively ought to be ki18n_install("${CMAKE_SOURCE_DIR}/po") ki18n_install("

D5212: support building against a qt without a11y enabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5212 AFFECTED FILES src/kcollapsiblegroupbox.cpp To: sitter

D5212: support building against a qt without a11y enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9dac68ab5b64: support building against a qt without a11y enabled (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5212?vs=12902&id=12906

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3e9993625cf3: explicitly set NO_CMAKE_FIND_ROOT_PATH (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5217?vs=12913&id=12915 REVISION DETAI

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R237:4468076a41f9: explicitly set NO_CMAKE_FIND_ROOT_PATH (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5218?vs=12914&id=12976 REVISION DETAIL

kioslave nogui

Hola, I am tyring to run filelight on windows and encountered a really strange behavior in KIO. I am building KIO with KIO_FORK_SLAVES=ON as that seems to make the most sense on Windows. That will fork the kioslave helper binary to run the slaves rather than going through kdeinit. The problem is t

D5143: Introduce fetch-translations build command

sitter added a comment. needs a version bump in the docs now 👅 beyond that LGTM INLINE COMMENTS > KDECMakeSettings.cmake:86 > +# > +# Since 5.33.0 > 5.34 now > KDECMakeSettings.cmake:323 > +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin > ${KDE_L10N_BRANCH}

D5143: Introduce fetch-translations build command

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter Cc: sitter

D5167: Move .po and .ts files look-up to build-time

sitter added a comment. The code currently isn't working for po/ in source dir and you are losing a public function. See inline comments. (Why there are no autotests for a complicated, involved, and important function like ki18n_install is entirely beyond my appreciation. How in the wor

D5352: Add a test for _repository_name() a function added for fetch-translations

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5352 To: apol, sitter, aacid Cc: #frameworks, #build_system

D5352: Add a test for _repository_name() a function added for fetch-translations

sitter added inline comments. INLINE COMMENTS > CMakeLists.txt:25 > + > +if(NOT TARGET fetch-translations AND NOT EXISTS > "${CMAKE_CURRENT_SOURCE_DIR}/../../po") > +message(FATAL_ERROR "should have a fetch-translations target") `AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po"` is the

D5167: Move .po and .ts files look-up to build-time

sitter added inline comments. INLINE COMMENTS > KF5I18NMacros.cmake:136 > +function(ki18n_install_ts_files _lang) > +message(WARNING "KI18N_INSTALL_TS_FILES is deprecated!") > +ki18n_install(${_lang}) Please use `message(AUTHOR_WARNING ...` this warning has only relevance to a developer

Re: KAuth buildability: new CI architecture

Not particularly related to the issue at hand (which is probably polkitqt having meh cmake files), but relocating stuff in general is sper unreliable and I would absolutely advise against it as it can easily screw up test results and builds alike, often in unobvious ways (all it takes is a bit

Re: KAuth buildability: new CI architecture

On Mon, Apr 17, 2017 at 9:30 AM, Martin Gräßlin wrote: >> Would it be possible to use relative-to-calling-binary paths? > > > Simply put: no. That would require quite some engineering effort especially > considering that distros do have the libexec paths different with some > adding the arch into

D5523: use correct variable for fetch-translations injection

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY KDE_L10N_AUTO_TRANSLATIONS is the name of the relevant option REPOSITORY R240 Extra CMake Modules BRANCH maste

D5523: use correct variable for fetch-translations injection

This revision was automatically updated to reflect the committed changes. Closed by commit R240:fe46a935227f: use correct variable for fetch-translations injection (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5523?vs=13634&i

D5167: Move .po and .ts files look-up to build-time

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Note that there's still an ordering problem with the new fetch-translations target now. The {ts,po}files-* targets can run before the fetch-translations target so on first run you may have

D5525: adapt to fetchpo changes and use vars for target directories to dry code

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY - fetchpo now expects the output dirs as named arguments - new argument for poqm directories where releaseme will

D5525: adapt to fetchpo changes and use vars for target directories to dry code

This revision was automatically updated to reflect the committed changes. Closed by commit R240:77623d19b627: adapt to fetchpo changes and use vars for target directories to dry code (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D5534: Fix ki18n bootstrapping

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5534 To: apol, #frameworks, sitter

D5557: fix basename handling of po files

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY get_filename_component(... ... NAME_WE) gets the name without the *longest* extension. in case of 'org.kde.plasma.kittens.po' that would lea

D5557: fix basename handling of po files

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7bce4e812836: fix basename handling of po files (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5557?vs=13728&id=13770 REVISION DETAIL https:/

D5741: Fix test when compiling from a tarball

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system

extra-cmake-modules in kdesupport?

Is there a reason ECM's project is placed in kdesupport rather than frameworks? https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/extra-cmake-modules Seems a bit fishy at best and practically means that if ECM ever were to get translations it wouldn't inherit the translatio

Re: extra-cmake-modules in kdesupport?

On Sat, Jun 3, 2017 at 11:32 AM, David Faure wrote: > On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote: >> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano > wrote: >> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: >> >> Is there a reason ECM&

D6558: do not stderr that NoDisplay is set

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KF5PackageMacros turns stderr output into cmake level warnings. setting nodisplay is perfectly reasonable and doesn't warrant a warning.

D6558: do not stderr that NoDisplay is set

This revision was automatically updated to reflect the committed changes. Closed by commit R290:48f1ece4a4ce: do not stderr that NoDisplay is set (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6558?vs=16313&id=16439 REVISION DETAIL ht

D6604: add a metainfo.yaml to make ECM a proper framework

sitter created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6604 AFFECTED FILES metainfo.

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. related to https://phabricator.kde.org/D6603 @ochurlaud I hope this will not break api.kde, given ECM hasn't had a metainfo.yaml previously it seems to have some sort of special arrangement? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabrica

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. Good point on trying it locally. So, as one could expect this adds ECM as a product F3808791: Screenshot_20170711_120142.png Unfortunately given we have no actual documentation (outside the cmake documentation) this

D6624: do not crash qaccessible by causing a resize in a resize event

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When enabling accessibility qaccessible will automatically add a11y support constructs to core qt types such as qtableview. Unfortunately

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. FWIW, this is a bit of workaround. Not having kcharselect crash for just about every search is well worth it though. Also, I am not sure I particularly like the qtimer code. It does beat having to pass `const char *` method names to `invokeMethod` and turning the pri

<    1   2   3   4   5   6   7   8   9   10   >