D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ca4028aed27b: Fixed normalization/toLower order (authored by poboiko). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4995?vs=12340=12624#toc REPOSITORY R293 Baloo CHANGES SINCE LAST

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

//git.reviewboard.kde.org/r/130013/#review102851 ------- On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote: > > --- > This is an automatically generated e-mail. To

Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

a compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

one of them. - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- On Март 14, 2017, 9:16 п.п

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

marked as submitted. Review request for KDE Frameworks and Anthony Fieroni. Changes --- Submitted with commit f9c8bb29b2cf5d46ff68c0261393084d1ff16ece by Igor Poboiko to branch master. Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On Март 15, 2017, 4:13 д.п., Anthony Fieroni wrote: > > Ship It! > > Anthony Fieroni wrote: > Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to > limit CPU usage or to discard it? > > Igor Poboiko wrote: > I didn't see much per

D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

poboiko created this revision. poboiko added a project: Frameworks. REVISION SUMMARY I've noted that on some PDF files, "balooshow -x file.pdf" segfaulted. Backtrace showed that it crashed due to having single "X" term (see line 201)

D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

poboiko added reviewers: pinakahuja, vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4995 To: poboiko, pinakahuja, vhanda Cc: #frameworks

D15431: Make PersonPluginManager API public

poboiko created this revision. poboiko added reviewers: KDE PIM, dvratil, apol. poboiko added a project: KDE PIM. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY This patch makes PersonPluginManager

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. I never experienced such corruption, though, but sanity check shouldn't hurt. INLINE COMMENTS > main.cpp:204 > +if (arr.length() <= 1) { > +stream << "Malformed term (short): " << arr << "\n"; > +continue; I'm

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. That's weird. I caught it only once and thought that it is because I trivially forgot the endl. But now I cannot reproduce it anymore. Seems like it should be fine, since we do emit finished signal, which will write the 'OK' part. Sorry for the noise. REVISION

D16165: Don't crash on invalid exiv2 data

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY The file from bug 375131 crashes `baloo_file_extractor`. The problem

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342156 , @astippich wrote: > I guess bugs > 352856 > 353848 > 361259 > will also be fixed by this? Yes, they should be. Thanks for the links! Added it to summary. REPOSITORY R286

D16165: Don't crash on invalid exiv2 data

poboiko edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

poboiko updated this revision to Diff 43526. poboiko added a comment. Replaced `size()` by `count()`, which is more appropriate here REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43506=43526 BRANCH dont-crash-invalid-exiv (branched from

D15959: Wait for the extraction process to finish before scheduling

poboiko added a comment. In D15959#339523 , @bruns wrote: > This works for me: > >void FileIndexScheduler::scheduleIndexing() >{ > -if (m_threadPool.activeThreadCount() || m_indexerState == Suspended) { > +if

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. Woops! `startedIndexingFile` does not print a newline. I guess I can just add `m_out << endl`... REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15983: React to config updates inside indexer

poboiko marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 43446. poboiko added a comment. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. Address raised issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15983?vs=42971=43446 BRANCH

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. I'm not entirely sure how translating system works, but won't it pop up as 4 identical lines in i.e. `Lokalize`, causing frustration to our translators? It would also mean that if we would want to change the message, we would have to do it in 4 different lines.

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342550 , @bruns wrote: > Unfortunately 375131 is quite vague, they all speak about "baloo" hanging, but as "baloo" is not a single process, it is impossible to tell for sure which process crashes or hangs. >

D16265: [Scheduler] Use flag to track when a runner is going idle

poboiko added a comment. I like it, it's better than D15959: Wait for the extraction process to finish before scheduling . And it seems to be working, as far as I can see :) INLINE COMMENTS > fileindexscheduler.h:57 > m_newFiles << file; >

D15959: Wait for the extraction process to finish before scheduling

poboiko abandoned this revision. poboiko added a comment. Dropped in favor of D16265: [Scheduler] Use flag to track when a runner is going idle , which handles this problem better. REPOSITORY R293 Baloo REVISION DETAIL

D16266: [Extractor] Make extractor crash resilient

poboiko added inline comments. INLINE COMMENTS > filecontentindexer.cpp:75 > +bool hadErrors = false; > +connect(, ::failed, , [, > ]() { hadErrors = true; loop.quit(); }); > + Is it OK to use `QObject::connect` inside a `while` loop? Those are not `Qt::UniqueConnection`,

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. In D15939#341094 , @smithjd wrote: > https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342433 , @bruns wrote: > These three should be CCBUG: (not test file, not able to confirm fixed), while 375131 should be BUG: (confirmed and fixed). Wait. Those three are about the very same crash I was

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. In D15985#341811 , @bruns wrote: > No, definitely not, see D15995 . I don't see how it is a problem. The problem is not that it's not written to terminal (it is), but that it

D16165: Don't crash on invalid exiv2 data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5eee9ac75b7d: Dont crash on invalid exiv2 data (authored by poboiko). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43526=43736 REVISION DETAIL

D16266: [Extractor] Make extractor crash resilient

poboiko added inline comments. INLINE COMMENTS > bruns wrote in filecontentindexer.cpp:91 > Yes, its a binary search. > Because we only have IDs here, and the progress reporting works on strings. There is `Transaction::documentId(const QByteArray& path)`, which can resolve it using

D15960: Don't check if file is directory based on mime-type

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Yep, fine by me REPOSITORY R293 Baloo BRANCH oob2 REVISION DETAIL https://phabricator.kde.org/D15826 To: bruns, #baloo, #frameworks, poboiko Cc: anthonyfieroni,

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

poboiko added a comment. That's nice! I'll test it a little. INLINE COMMENTS > app.cpp:74 > + > +memcpy(, buf, 4); > +for (quint32 i = 0; i < nIds; i++) { I haven't work with `QDataStream` before, but shouldn't `m_inputStream >> nIds` do the same? (and same below) And probably you

D16266: [Extractor] Make extractor crash resilient

poboiko added inline comments. INLINE COMMENTS > bruns wrote in filecontentindexer.cpp:91 > But it is racy - if the file is replaced in the meantime, inode and filename > no longer match. This is not completely unlikely when dealing with temporary > files. > > It would make the code also

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 45451. poboiko added a comment. Rebase on master REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15983?vs=43446=45451 BRANCH arcpatch-D15983 REVISION DETAIL https://phabricator.kde.org/D15983 AFFECTED FILES

D16876: [balooctl] Add possibility to create a copy of the index without freelist

poboiko created this revision. poboiko added reviewers: Frameworks, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Currently, after the indexing is done, there is a huge difference

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 45452. poboiko added a comment. It's a bad idea to removeRecursively starting from root of the tree (documentid 0). If user has indexed `/home/username` folder, there is also an index entry for `/home` (that's how IdTreeDB works). However, `/home`

D16878: Resolve symlinks in exclude folders

poboiko added a comment. In D16878#359442 , @bruns wrote: > IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it. Why not? This

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

poboiko added a comment. It seems like you've pushed something related to XML extractor as well REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov,

D16876: [balooctl] Add possibility to create a copy of the index without freelist

poboiko added a comment. In D16876#359454 , @bruns wrote: > You are replicating `mdb_copy -c` here. > [...] Yep, I know. It's just there is no proper documentation for this issue (well, this applies for the whole baloo - T7843:

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Apart from trivial comment, this looks fine. I've tested it on my setup (with bunch of (e)ps files), and randomly chosen files seems to be indexed nicely. It also reduced the size of the

D16878: Resolve symlinks in exclude folders

poboiko created this revision. poboiko added reviewers: Frameworks, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Assume user has `~/stuff` folder, that is symlinked to i.e.

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko updated this revision to Diff 42886. poboiko added a comment. Fixed typos REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15939?vs=42848=42886 REVISION DETAIL https://phabricator.kde.org/D15939 AFFECTED FILES src/file/fileindexscheduler.cpp

D15959: Wait for the extraction process to finish before scheduling

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Right now, a race condition might happen. Signal

D15960: Don't check if file is directory based on mime-type

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY `QDirIterator` returns URLs for directories without trailing slash.

D15943: [balooctl] Monitor also for state changes

poboiko retitled this revision from "[balooctl] Monitor also for index changes" to "[balooctl] Monitor also for state changes". poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo Cc: bruns,

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko closed this revision. REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. > Hah, looks like you pushed a commit for it last year! > > I'm not wedded to symlink support, but if we're not going to do it, we should close the bug with some good reasons. Well, I remembered that I did something on that, but I totally forgot what

D15944: [balooctl] Fix "index" command with already indexed, but moved file

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15944 To: poboiko, #baloo, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15943: [balooctl] Monitor also for state changes

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo, ngraham Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added inline comments. INLINE COMMENTS > bruns wrote in main.cpp:211 > but you are not allowed to access `word[2]` if `word.length() < 3`. We don't access it directly, and `indexOf` performs internal checks. For example, `QStringLiteral("ab").indexOf('c', 5)` seem to be perfectly valid

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. > Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted. Whoa, thanks for the notice. Not cool, forgot about it. Probably need to add some checks in IndexCleaner, about the device. But how does it

D15851: Fix signals not being emitted when merging two persons

poboiko closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15851 To: poboiko, #frameworks, dvratil Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks, vhanda. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Right now, if a file was moved / removed while baloo_file was

D15941: Fix invalid char constant

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY I assume that was a typo. Compiler pointed out that as a warning.

D15941: Fix invalid char constant

poboiko added a comment. In D15941#336481 , @broulik wrote: > I think you updated the wrong diff here True. Sorry, messed up with arc. Will revert it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D15941: Fix invalid char constant

poboiko updated this revision to Diff 42853. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42851=42853 REVISION DETAIL https://phabricator.kde.org/D15941 AFFECTED FILES src/tools/balooctl/configcommand.cpp To: poboiko, #baloo, #frameworks,

D15943: [balooctl] Monitor also for index changes

poboiko created this revision. poboiko added reviewers: Frameworks, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. TEST PLAN 1. Run `balooctl monitor` 2. In different terminal session, run `balooctl

D15944: [balooctl] Fix "index" command with already indexed, but moved file

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY If I move a file (while baloo was not running) and perform `balooctl

D15941: Fix invalid char constant

poboiko updated this revision to Diff 42851. poboiko added a comment. [balooctl] Monitor also for state changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42850=42851 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941

D15941: Fix invalid char constant

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ade5188979c4: Fix invalid char constant (authored by poboiko). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42853=42854 REVISION DETAIL

D15943: [balooctl] Monitor also for state changes

poboiko edited the summary of this revision. REPOSITORY R293 Baloo BRANCH monitor-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo, ngraham Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D15944: [balooctl] Fix "index" command with already indexed, but moved file

poboiko edited the summary of this revision. REPOSITORY R293 Baloo BRANCH fix-index-renamed (branched from master) REVISION DETAIL https://phabricator.kde.org/D15944 To: poboiko, #baloo, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. In D15939#337418 , @ngraham wrote: > Works great, thanks for all these Baloo patches! They are very much appreciated. Code looks good. As with the others, please commit for Frameworks 5.52. > > While you're cranking

D15943: [balooctl] Monitor also for state changes

poboiko added a comment. In D15943#337385 , @ngraham wrote: > Works for me and the code looks sane. Looks like this fixes https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and `FIXED-IN: 5.52` to the summary section and

D15983: React to config updates inside indexer

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY In case a config was changed, we need to: 1. Stop the ContentIndexer (bug 373430) 2. Remove all scheduled indexing of files that should not be indexed

D15959: Wait for the extraction process to finish before scheduling

poboiko added a comment. That doesn't looks like it works all the time: sometimes I still have this issue. Apparently, it still can happen that even when the process is finished, signal is emitted, but the thread is not finished yet. Also, it seems like due to `QueuedConnection`,

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY This is based on D15943: [balooctl] Monitor also for state changes . Simply print current state & file when monitor

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. I've found the relevant bug: https://bugs.kde.org/show_bug.cgi?id=333678 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: bruns, ngraham, kde-frameworks-devel, ashaposhnikov, michaelh,

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. Maybe we should print also a suggestion to user, something like (maybe rephrase it better) WARNING: Looks like your index is corrupted. We suggest you to run `balooctl disable && balooctl disable` to wipe it and rebuild from scratch so they won't

D11828: Simplify orPostingIterator and make it faster

poboiko added a comment. Looks fine to me. But do we really need to optimize it? I mean, I didn't see it running more than ~20 ms, and with this patch for small queries it runs like ~16 ms. Worst case is when user types something in KRunner, but again, the lag is negligible there. INLINE

D15851: Fix signals not being emitted when merging two persons

poboiko created this revision. poboiko added reviewers: Frameworks, dvratil. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY If I have 4 contacts, i.e. `{A,B,C,D}`, then merge `{A,B}->1` and

D15812: Don't crash if person gets removed

poboiko created this revision. poboiko added reviewers: Frameworks, dvratil, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Currently, right after removing a person (which i.e. removes it

D15812: Don't crash if person gets removed

poboiko closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15812 To: poboiko, #frameworks, dvratil, apol, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15960: Don't check if file is directory based on mime-type

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15960 To: poboiko, #baloo, #frameworks, bruns, astippich Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15960: Don't check if file is directory based on mime-type

poboiko added a comment. In D15960#375517 , @bruns wrote: > Sorry, fell through the cracks - give a ping next time something is blocked for no apparent reason ... Nevermind, I also didn't have much spare time for KDE lately :(

D16878: Resolve symlinks in exclude folders

poboiko added a comment. I believe can do something better here. I think if we stick to canonical paths everywhere, and resolve symlinks ASAP (but still follow them), that might solve all the problems. In D16878#359864 , @bruns wrote: >

D15431: Make PersonPluginManager API public

poboiko marked 4 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D15497: Fix CMakeLists.txt issues

poboiko created this revision. poboiko added reviewers: Frameworks, dvratil, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Remove redundant install(FILES) and fix PREFIX for KPeople/Widgets

D15431: Make PersonPluginManager API public

poboiko updated this revision to Diff 41616. poboiko added a comment. - Switched to QMutexLocker - Changed behavior of `addDataSource` to override existing (and delete it) - Added documentation for `addDataSource` - Switched to KPeople logging category introduced recently REPOSITORY

D15497: Fix CMakeLists.txt issues

This revision was automatically updated to reflect the committed changes. Closed by commit R307:13d933732b78: Fix CMakeLists.txt issues (authored by poboiko). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15497?vs=41641=41643 REVISION DETAIL

D15431: Make PersonPluginManager API public

This revision was automatically updated to reflect the committed changes. Closed by commit R307:73a72d53325f: Make PersonPluginManager API public (authored by poboiko). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15431?vs=41640=41645 REVISION DETAIL

D15431: Make PersonPluginManager API public

poboiko updated this revision to Diff 41640. poboiko added a comment. Added some documentation REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15431?vs=41616=41640 REVISION DETAIL https://phabricator.kde.org/D15431 AFFECTED FILES

D15431: Make PersonPluginManager API public

poboiko marked 3 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D15497: Fix CMakeLists.txt issues

poboiko updated this revision to Diff 41641. poboiko added a comment. Fixed global includes REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15497?vs=41612=41641 BRANCH cmake-issues (branched from master) REVISION DETAIL

D15497: Fix CMakeLists.txt issues

poboiko marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15497 To: poboiko, #frameworks, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15960: Don't check if file is directory based on mime-type

poboiko added a comment. In D15960#379043 , @aacid wrote: > @poboiko You broke the build, please fix it. Sorry! Apparently, I've messed up while did `git rebase` on current master. Should be fixed by c7416a41

D18664: Baloo engine: treat every non-success code as a failure

poboiko added a comment. I've looked through the patch (quite large indeed), apart from the single note I think it's good to go. INLINE COMMENTS > postingdb.cpp:238 > mdb_cursor_close(cursor); > -if (termIterators.isEmpty()) { > +if (rc || termIterators.isEmpty()) { >

D17162: Harmonize handling of underscore in query parser

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17162 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh,

D15983: React to config updates inside indexer

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko added a comment. Ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko edited the summary of this revision. poboiko added reviewers: bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh,

D15983: React to config updates inside indexer

poboiko added a comment. In D15983#434247 , @ngraham wrote: > Can you rebase this on master again? Sorry for the radio silence. :( Nevermind, I also kinda forgot about this :) Seems like this patch still applies to current master:

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:390 > yes, but just `const QString fname = ...` Right, sorry, misprinted. Actually, since there are a lot of `decodeName` calls around, probably it would be better to decode it just once, right before `event->mask`

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added inline comments. INLINE COMMENTS > bruns wrote in kinotify.cpp:390 > `QFile::decodeName(path)` twice ... I'm a bit lost, why is it a problem? Or do you mean it's a costly operation and suggest to do the following? const QString& fname = QFile::decodeName(path); Q_EMIT

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 51762. poboiko added a comment. Forgot to define `fname` inside `EventMoveTo` REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18698?vs=51739=51762 BRANCH add-watch-moved (branched from master) REVISION DETAIL

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 51739. poboiko added a comment. Updated comment, removed duplicated `QFile::decodeName` REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18698?vs=51062=51739 BRANCH add-watch-moved (branched from master) REVISION

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added a comment. Something like that? I've decided not to emit `created` signal from inside the function, just to have a bit less branching in the code (and documented this behavior, since it might be a bit confusing) Actually, I think this race condition is now handled

  1   2   3   >