D13425: Quit the file indexer when closing.

smithjd added a dependency: D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13425: Quit the file indexer when closing.

smithjd created this revision. smithjd added reviewers: bruns, mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-scheduler-ha

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 35812. smithjd added a comment. Separate out the content indexer halt on quit. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35811&id=35812 BRANCH master-scheduler-updateConfig (branched from master) REVISIO

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change, halt the file indexer and run a file changed check when the file watches are updated." to "On config change halt the file indexer and run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL h

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added reviewers: mgallien, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #balo

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH mastger-scheduler-updateConfig (branched from master) REVISI

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35810. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35730&id=35810 BRAN

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275582 , @bruns wrote: > In D13216#275581 , @smithjd wrote: > > > According to the arc documentation, a --merge commit should land the commits separately. > >

D13216: Overhaul the file index scheduler.

smithjd added a comment. According to the arc documentation, a --merge commit should land the commits separately. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, s

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275538 , @bruns wrote: > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... > If you wan't your commits to stay separated, you have to do a `git c

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35730. smithjd added a comment. Split-up scheduler overhaul patchset. - The power state signal should only be emitted when the power state changes. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 35204. smithjd added a comment. - New DBus method updateIndex(). - Change for D13216 . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=34892&id=35204 BRANCH master-filedein

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35199. smithjd added a comment. - Minor simplification + fix: call checkUnindexedFiles when folder watches are installed instead of scheduleIndexing which can't check for changes in indexable files. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE ht

D13216: Overhaul the file index scheduler.

smithjd retitled this revision from "Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now stops file indexing." to "Overhaul the file index scheduler.". smithjd

D13216: Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now sto

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY BUG: 353559 BUG: 378597 REPOSITORY R293 Baloo BRANCH master-schedule

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

smithjd added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 34892. smithjd added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - Uniformly use storageDevices. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=31136&i

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 31136. smithjd added a comment. - Ignore the symlink target, only remove the index entry if the link is removed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30804&id=31136 BRANCH master-filedeindexer (bran

D11529: Balooctl: Deindex unfound files with check command.

smithjd marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > broulik wrote in fileindexerconfig.cpp:63 > Please create the `StorageDevices` object on demand, otherwise this penalizes > all users of that class that just want to know whether Baloo itself is > enabled, which was the main reason for doing D112

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30804. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. - Partially revert the

D11038: balooctl: Add clean option to remove stale file index entries

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc: michaelh, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > michaelh wrote in fileindexerconfig.cpp:63 > Looks like you're reverting > https://cgit.kde.org/baloo.git/commit/?id=76c207a141423102ab0c5fba43fdafe3e205cca5 > with this No, making the StorageDevices object static so it can be exported. REPOSIT

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30589. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. REPOSITORY R293 Baloo

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30575. smithjd added a comment. - Fix a threading issue. - Fix check operation order. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30573&id=30575 BRANCH master-filedeindexer REVISION DETAIL https://phab

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > michaelh wrote in fileindexscheduler.h:83 > Nitpick: We're removing db entries not files. Also every file is deindexable. > Maybe 'purgeStaleEntries', 'removeLostEntries' or so would be a better name > to describe what's going on. This is doing

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30573. smithjd marked 9 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30466&id=30573 BRANCH master-filedeindexer REVISION DETAIL https://

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a comment. In D11529#233550 , @michaelh wrote: > Under the premise that I still have to learn about baloo's inner workings, here are some concerns: > > - I'm not convinced, that index cleaning should be part of the dbus interfa

D11038: balooctl: Add clean option to remove stale file index entries

smithjd added a comment. D11529 hooks up the index cleaner class. I've modified it so that it skips unmounted directories. This patch could probably be dropped, though some form of integrity checker that ignores mount points might still be useful for balo

D11529: Balooctl: Deindex unfound files with check command.

smithjd added reviewers: vhanda, michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30466. smithjd added a comment. - Change check command description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30173&id=30466 BRANCH master-filedeindexer REVISION DETAIL https://phabricator.kde.org/D115

D11452: sanitizer: Improve device listing

smithjd added a comment. In D11452#230590 , @michaelh wrote: > In D11452#230387 , @smithjd wrote: > > > Could you please make your tab spacing conform to the style of the > > codebase? This should

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30173. smithjd added a comment. Fix and optimize. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30048&id=30173 BRANCH master-filedeindexer REVISION DETAIL https://phabricator.kde.org/D11529 AFFECTED FILES

D11452: sanitizer: Improve device listing

smithjd added a comment. Could you please make your tab spacing conform to the style of the codebase? This should also be fixed in baloodb. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh, a

D11529: Balooctl: Deindex unfound files with check command.

smithjd retitled this revision from "Balooctl: Deindex unfound files with check command. Deindexing is skipped for file paths containing an unmounted mount point." to "Balooctl: Deindex unfound files with check command.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11

D11529: Balooctl: Deindex unfound files with check command. Deindexing is skipped for file paths containing an unmounted mount point.

smithjd created this revision. smithjd added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-filedeindexer REVISION DETAIL http

D11038: balooctl: Add clean option to remove stale file index entries

smithjd added a comment. In D11038#228379 , @michaelh wrote: > Sorry I took so long to respond. I needed to get the tools ready to see whats going on (D11285 and D11287 ) .

D11038: balooctl: Add clean option to remove stale file index entries

smithjd retitled this revision from "balooctl: Add prune option to remove stale file index entries" to "balooctl: Add clean option to remove stale file index entries". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc: mi

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29879. smithjd added a comment. Change the 'prune' option to 'clean'. The database must open in ReadWrite mode. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29290&id=29879 BRANCH master-purgeDb (branched f

D11038: balooctl: Add prune option to remove stale file index entries

smithjd added a comment. I was going to expose this functionality on the DBus interface and integrate it into the check command, but the lack of external mount enumeration makes this a little risky at the moment. It's probably better to at least provide a simple global prune option. I person

D11038: balooctl: Add prune option to remove stale file index entries

smithjd added a comment. I was going to expose this functionality on the DBus interface and integrate it into the check command, but the lack of external mount enumeration makes this a little risky at the moment. It's probably better to at least provide a simple global prune option. I person

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29290. smithjd added a comment. - Commit the changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29280&id=29290 BRANCH master-purgeDb (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29280. smithjd added a comment. - Open the transaction in read-write mode. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29184&id=29280 BRANCH master-purgeDb (branched from master) REVISION DETAIL https://

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29184. smithjd added a comment. - Lessen chattiness. - balooctl: Clarify the prune option description. - Fix document purging. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28987&id=29184 BRANCH master-pu

D11037: balooctl: checkDb should also verify the last known url for the documentId.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3fbabac6add9: balooctl: checkDb should also verify the last known url for the documentId. (authored by smithjd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11037?vs=28647&id=29016#toc REPO

D11038: balooctl: Add prune option to remove stale file index entries

smithjd retitled this revision from "balooctl: Add pruneDb option to remove stale file index entries." to "balooctl: Add prune option to remove stale file index entries". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc:

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd updated this revision to Diff 28987. smithjd added a comment. - balooctl: Clarify the prune option description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28747&id=28987 BRANCH master-purgeDb (branched from master) REVISION DETAIL h

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd added a comment. In D11038#220486 , @michaelh wrote: > In D11038#219353 , @smithjd wrote: > > > All mounts must be manually made available by the user before running this option, or all file

D11037: balooctl: checkDb should also verify the last known url for the documentId.

smithjd added a comment. This change includes orphan file entries as invalid database entries in checkFsTree(). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11037 To: smithjd, #baloo Cc: michaelh, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd marked 7 inline comments as done. smithjd added a comment. All mounts must be manually made available by the user before running this option, or all files on a previously available mount will be removed from the index. INLINE COMMENTS > michaelh wrote in transaction.cpp:271 > Can we

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd updated this revision to Diff 28747. smithjd added a comment. Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28656&id=28747 BRANCH master-purgeDb (branched from master) REVISION DETAIL https://phabricator.kde.org/D11038

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd created this revision. smithjd added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-purgeDb (branched from master) REVISION DETAIL https://phabricator.kde.org/D11

D11037: balooctl: checkDb should also verify the last known url for the documentId.

smithjd created this revision. smithjd added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REVISION SUMMARY Report orphan documentId's. REPOSITORY R293 Baloo BRANC

D10106: Relocate the Baloo database to the XDG cache location.

smithjd created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REVISION SUMMARY If the database exists in the old XDG Data location, migrate it to the XDG cache location. REPOS

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. In https://phabricator.kde.org/D8098#173418, @ngraham wrote: > Excellent! @smithjd, is this ready to go in now, or are you still making more changes? There are still known problems with tagged directory copies. Overall however it's in a pretty good state

D8098: Strip down and re-write the baloo tags KIO slave

This revision was automatically updated to reflect the committed changes. Closed by commit R293:16664fccb7b7: Strip down and re-write the baloo tags KIO slave (authored by smithjd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8098?vs=23146&id=23147#toc REPOSITORY R293 Baloo CHANGES

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 23146. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 23101. smithjd added a comment. - Fix tagged directory listing. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22940&id=23101 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricat

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22940. smithjd added a comment. - Fix for slash-less tag urls. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22938&id=22940 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricato

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. Currently known issues: Entering a tagged folder works, listing it from within the tags: protocol in the slave results in a folder cannot be entered error. Attempting to copy a tag tree with such a populated folder results in a file not found error for each file

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22938. smithjd added a comment. - Fix valid tag calculation. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22857&id=22938 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kio_tags.h:101 > metaData(QString{}) Doesn't work. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: anthonyfieroni, dfaure, nicol

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22857. smithjd marked 3 inline comments as done. smithjd added a comment. - Review suggestions. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22792&id=22857 BRANCH master-nestedTags (branched from master) REV

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:119 > I see an added check for "already exists" and an early return (good), but no > support for KIO::Overwrite. If the user uses dolphin to copy a tag they might > click on "overwrite" and it won't work, if copy() ju

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22792. smithjd marked 6 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22712&id=22792 BRANCH master-nestedTags (branched from master) REVISIO

D8098: Strip down and re-write the baloo tags KIO slave

smithjd marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22712. smithjd added a comment. Make work with kioclient. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22107&id=22712 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.kde

D8098: Strip down and re-write the baloo tags KIO slave

smithjd retitled this revision from "Strip down and re-write the tags KIO slave." to "Strip down and re-write the baloo tags KIO slave". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfel

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 22107. smithjd added a comment. - Merge local and tag file handling. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21851&id=22107 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phab

D8098: Strip down and re-write the tags KIO slave.

smithjd marked 14 inline comments as done. smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:64 > - merge with previous line > > - can path() really contain '?' ? I thought that wasn't possible (? delimits > the query). Yes, the url is non-hierarchical scheme, so ev

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21851. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21599. smithjd added a comment. - Create a full url instead of only a path. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21590&id=21599 BRANCH master-nestedTags (branched from master) REVISION DETAIL https

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21590. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. 1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the tags KIO slave.

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Deep tag copies (to the filesystem and also in the slave) are known to be broken (1 or more folder deep) because of the preview fix in the first revision. REPOSITORY R293 Baloo BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20362. smithjd added a comment. - Fix tag navigation display labels in Dolphin. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20320&id=20362 BRANCH master-nestedTags (branched from master) REVISION DETAIL h

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20320. smithjd added a comment. - Fix generating previews copies the file to tmp. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20222&id=20320 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Copying/cutting file tags works both from local files and also tagged files. Breaking tags works, e.g. nested tag foo in bar can be copied or cut to foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag on the folder, copying applies the dest

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Maybe update your local repo? It is against the most recent commit in master. It was diff'ed from a non-master branch... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks Cc: ngraham

D8098: Strip down and re-write the tags KIO slave.

smithjd created this revision. smithjd added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Allow for more operations on tag trees (e.g. rename, copy, delete) and fix some existing issues. BUG: 314373 BUG: 340098 BUG: 376229 BUG: 332214

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

view91122 --- On Jan. 15, 2016, 1:52 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

an equivalent way to do this in the plasmoid? Diffs (updated) - src/scriptengines/qml/plasmoid/appletinterface.h ad68499 src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, Ja

Review Request 126742: Add removeAllActions() to remove every applet interface action.

/appletinterface.cpp 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

<    1   2