D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 46655.
pstefan added a comment.


  - Fix transparency of home icon in go.svgz

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=46626&id=46655

BRANCH
  arcpatch-D15999

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 46626.
pstefan added a comment.


  - Fix stylesheet in go.svgz

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=46583&id=46626

BRANCH
  arcpatch-D15999

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  In D15999#369135 , @ndavis wrote:
  
  > In D15999#369134 , @pstefan 
wrote:
  >
  > > In D15999#369132 , @ndavis 
wrote:
  > >
  > > > In D15999#369131 , @pstefan 
wrote:
  > > >
  > > > > In D15999#369066 , @ndavis 
wrote:
  > > > >
  > > > > > With colorschemes applied, these will be your colors:
  > > > > >
  > > > > >   | Ring| Background | Symbol  |
  > > > > >   | --- | -- | --- |
  > > > > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > > > > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > > > > >
  > > > >
  > > > >
  > > > > Why would the ring and the background have different colors? They 
both have the same class attribute.
  > > >
  > > >
  > > > I must have had a slightly older version of the patch because I swear I 
saw the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?
  > >
  > >
  > > They do not have a default color for me.
  >
  >
  > Here's what I'm seeing: F6449126: Screenshot_20181201_013830.png 

  
  
  Ahh, now I get what you mean. Yes that was intentional. But only insofar as 
to check if I had set the class attributes correctly. I will change it when I 
get home.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  In D15999#369132 , @ndavis wrote:
  
  > In D15999#369131 , @pstefan 
wrote:
  >
  > > In D15999#369066 , @ndavis 
wrote:
  > >
  > > > With colorschemes applied, these will be your colors:
  > > >
  > > >   | Ring| Background | Symbol  |
  > > >   | --- | -- | --- |
  > > >Breeze | #fcfcfc | #eff0f1| #232627 |
  > > >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  > > >
  > >
  > >
  > > Why would the ring and the background have different colors? They both 
have the same class attribute.
  >
  >
  > I must have had a slightly older version of the patch because I swear I saw 
the ring using `ViewBackground` and the background using `Background`. I 
downloaded the patch again and everything looks fine there. `go.svgz` still has 
`#31363b` and `#232629` as the default colors for the background and ring. Is 
this intentional?
  
  
  They do not have a default color for me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  In D15999#369066 , @ndavis wrote:
  
  > With colorschemes applied, these will be your colors:
  >
  >   | Ring| Background | Symbol  |
  >   | --- | -- | --- |
  >Breeze | #fcfcfc | #eff0f1| #232627 |
  >   Breeze Dark | #232629 | #31363b| #eff0f1 |
  >
  
  
  Why would the ring and the background have different colors? They both have 
the same class attribute.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 46583.
pstefan added a comment.


  - Remove hardcoded background color; Switch background to 
"ColorScheme-ViewBackground"
  - Reintroduce the outline border on top of the background. Opacity set to 0.3
  - Removed superfluous entries in the style properties

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=45137&id=46583

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  In D15999#368499 , @filipf wrote:
  
  > In D15999#368498 , @ngraham 
wrote:
  >
  > > In D15999#368479 , @ndavis 
wrote:
  > >
  > > > It appears that the background colors are hardcoded. If they are meant 
to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then 
they should use the `ColorScheme-Text` class and the inner symbols should use 
the `ColorScheme-Background` class.F6447550: Screenshot_20181129_192418.png 

  > >
  > >
  > > The opposite: the background is supposed to be dark with breeze dark, and 
light with breeze light.
  >
  >
  > In general, with dark themes you want white monochrome icons and the circle 
is now the dominant icon element, meaning it should get painted white.
  >
  > But there is a tangible problem here - imagine what the logout screen when 
using dark themes would look like if the circles were dark:
  >
  > F6447627: image.png 
  >
  > They would be weird looking and would be superfluous.
  >
  > In the case of the SDDM theme I agree it's odd that the circles are colored 
differently than the input box, but the logout screen is more important.
  
  
  The problem here is, that it's not using a dark color-scheme. The login 
screen uses a mix of breeze light/dark items. The
  
  In D15999#368499 , @filipf wrote:
  
  > In D15999#368498 , @ngraham 
wrote:
  >
  > > In D15999#368479 , @ndavis 
wrote:
  > >
  > > > It appears that the background colors are hardcoded. If they are meant 
to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then 
they should use the `ColorScheme-Text` class and the inner symbols should use 
the `ColorScheme-Background` class.F6447550: Screenshot_20181129_192418.png 

  > >
  > >
  > > The opposite: the background is supposed to be dark with breeze dark, and 
light with breeze light.
  >
  >
  > In general, with dark themes you want white monochrome icons and the circle 
is now the dominant icon element, meaning it should get painted white.
  >
  > But there is a tangible problem here - imagine what the logout screen when 
using dark themes would look like if the circles were dark:
  >
  > F6447627: image.png 
  >
  > They would be weird looking and would be superfluous.
  >
  > In the case of the SDDM theme I agree it's odd that the circles are colored 
differently than the input box, but the logout screen is more important.
  
  
  The problem is that it's not a /dark/ theme. Right now we expect the user to 
manually change the theme if they do not like the color of the icons. If we'd 
follow your suggestions the problem would remain, that the white circles would 
look out of place on light backgrounds. We have no mechanism to adjust the 
theme based on the wallpaper's lightness automagically right now.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 45137.
pstefan added a comment.


  - Hardcoded background color

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44890&id=45137

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 44890.
pstefan added a comment.


  - Fixed z order

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44889&id=44890

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 44889.
pstefan added a comment.


  - Added missing class attributes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44862&id=44889

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 44862.
pstefan added a comment.


  - Sized down icons somewhat
  - Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, 
etc). 32px only for now
  - Made background darker
  - Removed outer circle
  - Merge branch 'master' of git://anongit.kde.org/plasma-framework

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=43051&id=44862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  RE:
  
  In D15999#338724 , @filipf wrote:
  
  > Would the background be grey and the icon itself black in all color 
schemes? (apropos how Inkscape shows it:)
  >
  > F6310672: image.png 
  >
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  >
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  
  The background stays the same color, no matter the color scheme used. I am 
told that it's not currently possible for the login-screen to change the color 
of the background independently of the foreground. The foreground color is the 
same color as a theme's text color. In the case of the lockscreen, that's white.
  
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  > 
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  I have never thought about that tbh. It's something to investigate, can you 
repost that thought on T9658 ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan added a comment.


  RE:
  
  In D15999#338724 , @filipf wrote:
  
  > Would the background be grey and the icon itself black in all color 
schemes? (apropos how Inkscape shows it:)
  >
  > F6310672: image.png 
  >
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  >
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  
  The background stays the same color, no matter the color scheme used. I am 
told that it's not currently possible for the login-screen to change the color 
of the background independently of the foreground. The foreground color is the 
same color as a theme's text color. In the case of the lockscreen, that's white.
  
  > Could we make it adaptable to the color scheme? I don't know if the code 
applies, but they managed to do it here: 
https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg
  > 
  > They do however just leave the icon itself transparent, but perhaps that 
wouldn't work well with Breeze icons.
  
  I have never thought about that tbh. It's something to investigate, can you 
repost that thought on T9658 ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 43051.
pstefan added a comment.


  Fix z-layering issue for the "-translucent" icons.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=43009&id=43051

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan edited the summary of this revision.
pstefan added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan created this revision.
pstefan added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Added duplicates of system.svgz' icons' with added background.
  The background color is hardcoded atm.
  
  For reference see T9658  and B398741 and 
B398742

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan accepted this revision.
pstefan added a comment.
This revision is now accepted and ready to land.


  Thank you for the changes!
  
  And I will change once I come around to it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15853: Change drive-harddisk to more adaptable style

[Phil Stefan]

pstefan requested changes to this revision.
pstefan added a comment.
This revision now requires changes to proceed.


  In the monochrome icons (size 16px and 22px) you forgot to add the 
stylesheet. Without it, the monochrome icons won't be able to adapt to a 
changing color scheme. 
  You will have to run the scripts "apply-stylesheet.sh" and 
"currentColorFillFix.sh" –from here 
– with your 
files as arguments. You will need the program "xmlstarlet" as dependency. 
  Or, if these scripts do not work correctly, you'll have to do it by hand. I 
will take icons-dark/devices/16/drive-harddisk.svg as an example.
  You'd need to copy line 2-9 from the old file to the new file. You would also 
need to change the fill to "fill:currentColor", and then add the 
"class="ColorScheme-Text" ". But if you are lucky the script will work and you 
won't need to do a thing :)
  
  PS somewhere there's a script that changes the color of your monochrome 
automagically to the dark variant. So you don't have to do it by hand.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15618: Add plus symbol to document-new.svg

[Phil Stefan]

pstefan updated this revision to Diff 41987.
pstefan added a comment.


  Add missing sizes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15618?vs=41982&id=41987

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15618

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons-dark/actions/32/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg
  icons/actions/32/document-new.svg

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

[Phil Stefan]

pstefan added a comment.


  Oops, sorry.
  
  Should be fixed now!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15618

To: pstefan, #breeze, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

[Phil Stefan]

pstefan created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Response to bug 398850

TEST PLAN
  Works for me

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15618

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons/actions/16/document-new.svg

To: pstefan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Phil Stefan]

pstefan updated this revision to Diff 40157.
pstefan added a comment.


  - changed osd-sbs-right to osd-sbs-sright

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40156&id=40157

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd.svgz
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Phil Stefan]

pstefan updated this revision to Diff 40156.
pstefan added a comment.


  - Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40154&id=40156

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd.svgz
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Phil Stefan]

pstefan updated this revision to Diff 40154.
pstefan added a comment.


  - Reverse name change

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40143&id=40154

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Phil Stefan]

pstefan updated this revision to Diff 40143.
pstefan added a comment.


  - Moved all OSD icons into video.svgz and renamed some of them.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14971?vs=40135&id=40143

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/video.svgz

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan abandoned this revision.
pstefan added a comment.


  Moved to D14971 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, 
mart, ngraham, michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D14971: Combine display OSD icon files and mobe to plasma icon theme

[Phil Stefan]

pstefan edited the summary of this revision.
pstefan added reviewers: ngraham, VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

[Phil Stefan]

pstefan retitled this revision from "Combine display OSD icon files and mobe to 
plasma icon theme" to "Combine display OSD icon files and move to plasma icon 
theme".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14971

To: pstefan, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and mobe to plasma icon theme

[Phil Stefan]

pstefan created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pstefan requested review of this revision.

REVISION SUMMARY
  Move the icons from [D10937 ] to 
plasma-frameworks and combine all the sizes

TEST PLAN
  "osd-shutd-screen.svg" does not display correctly for me. I can't find any 
difference between it and the rest of the icons. Help appreciated.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14971

AFFECTED FILES
  src/desktoptheme/breeze/icons/osd-duplicate.svg
  src/desktoptheme/breeze/icons/osd-rotate-ccw.svg
  src/desktoptheme/breeze/icons/osd-rotate-cw.svg
  src/desktoptheme/breeze/icons/osd-rotate-flip.svg
  src/desktoptheme/breeze/icons/osd-rotate-normal.svg
  src/desktoptheme/breeze/icons/osd-sbs-left.svg
  src/desktoptheme/breeze/icons/osd-sbs-right.svg
  src/desktoptheme/breeze/icons/osd-shutd-laptop.svg
  src/desktoptheme/breeze/icons/osd-shutd-screen.svg

To: pstefan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Sure, I can do that, but I'd like to get feedback on the final form first :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Sorry folks for the endless period of no activity. After some talking with 
ngraham I removed the laptop metaphor for a much more general standalone 
display. Also the projection screen was swapped out.
  
  My last feedback was that the window icons were too detailed. So I made 3 
version. (Old) fully detailed, some details and no details (well, safe for the 
window buttons :)
  
  F6193072: detailed.png 
  
  F6193074: medium-detailed.png 
  
  F6193073: empty.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  In D10937#260289 , @abetts wrote:
  
  > In D10937#260277 , @ngraham 
wrote:
  >
  > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  >
  >
  > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  
  
  Could you give me more examples of what you'd remove?  As in direction.
  
  > Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  
  It's supposed to be a projector screen. I took the original icon metaphor to 
be a projector screen, so I continued with that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Hello again,
  
  I was just wondering if there's something left I have to do now? Like some 
button I have to press or something.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, michaelh, 
crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender, 
#frameworks

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan updated this revision to Diff 31376.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10937?vs=28315&id=31376

REVISION DETAIL
  https://phabricator.kde.org/D10937

AFFECTED FILES
  icons-dark/applets/128/osd-duplicate.svg
  icons-dark/applets/128/osd-rotate-ccw.svg
  icons-dark/applets/128/osd-rotate-cw.svg
  icons-dark/applets/128/osd-rotate-flip.svg
  icons-dark/applets/128/osd-rotate-normal.svg
  icons-dark/applets/128/osd-sbs-left.svg
  icons-dark/applets/128/osd-sbs-sright.svg
  icons-dark/applets/128/osd-shutd-laptop.svg
  icons-dark/applets/128/osd-shutd-screen.svg
  icons-dark/applets/256/osd-duplicate.svg
  icons-dark/applets/256/osd-rotate-ccw.svg
  icons-dark/applets/256/osd-rotate-cw.svg
  icons-dark/applets/256/osd-rotate-flip.svg
  icons-dark/applets/256/osd-rotate-normal.svg
  icons-dark/applets/256/osd-sbs-left.svg
  icons-dark/applets/256/osd-sbs-sright.svg
  icons-dark/applets/256/osd-shutd-laptop.svg
  icons-dark/applets/256/osd-shutd-screen.svg
  icons-dark/applets/32/osd-duplicate.svg
  icons-dark/applets/32/osd-rotate-ccw.svg
  icons-dark/applets/32/osd-rotate-cw.svg
  icons-dark/applets/32/osd-rotate-flip.svg
  icons-dark/applets/32/osd-rotate-normal.svg
  icons-dark/applets/32/osd-sbs-left.svg
  icons-dark/applets/32/osd-sbs-sright.svg
  icons-dark/applets/32/osd-shutd-laptop.svg
  icons-dark/applets/32/osd-shutd-screen.svg
  icons-dark/applets/48/osd-duplicate.svg
  icons-dark/applets/48/osd-rotate-ccw.svg
  icons-dark/applets/48/osd-rotate-cw.svg
  icons-dark/applets/48/osd-rotate-flip.svg
  icons-dark/applets/48/osd-rotate-normal.svg
  icons-dark/applets/48/osd-sbs-left.svg
  icons-dark/applets/48/osd-sbs-sright.svg
  icons-dark/applets/48/osd-shutd-laptop.svg
  icons-dark/applets/48/osd-shutd-screen.svg
  icons-dark/applets/64/osd-duplicate.svg
  icons-dark/applets/64/osd-rotate-ccw.svg
  icons-dark/applets/64/osd-rotate-cw.svg
  icons-dark/applets/64/osd-rotate-flip.svg
  icons-dark/applets/64/osd-rotate-normal.svg
  icons-dark/applets/64/osd-sbs-left.svg
  icons-dark/applets/64/osd-sbs-sright.svg
  icons-dark/applets/64/osd-shutd-laptop.svg
  icons-dark/applets/64/osd-shutd-screen.svg
  icons/applets/128/osd-duplicate.svg
  icons/applets/128/osd-rotate-ccw.svg
  icons/applets/128/osd-rotate-cw.svg
  icons/applets/128/osd-rotate-flip.svg
  icons/applets/128/osd-rotate-normal.svg
  icons/applets/128/osd-sbs-left.svg
  icons/applets/128/osd-sbs-sright.svg
  icons/applets/128/osd-shutd-laptop.svg
  icons/applets/128/osd-shutd-screen.svg
  icons/applets/256/osd-duplicate.svg
  icons/applets/256/osd-rotate-ccw.svg
  icons/applets/256/osd-rotate-cw.svg
  icons/applets/256/osd-rotate-flip.svg
  icons/applets/256/osd-rotate-normal.svg
  icons/applets/256/osd-sbs-left.svg
  icons/applets/256/osd-sbs-sright.svg
  icons/applets/256/osd-shutd-laptop.svg
  icons/applets/256/osd-shutd-screen.svg
  icons/applets/32/osd-duplicate.svg
  icons/applets/32/osd-rotate-ccw.svg
  icons/applets/32/osd-rotate-cw.svg
  icons/applets/32/osd-rotate-flip.svg
  icons/applets/32/osd-rotate-normal.svg
  icons/applets/32/osd-sbs-left.svg
  icons/applets/32/osd-sbs-sright.svg
  icons/applets/32/osd-shutd-laptop.svg
  icons/applets/32/osd-shutd-screen.svg
  icons/applets/48/osd-duplicate.svg
  icons/applets/48/osd-rotate-ccw.svg
  icons/applets/48/osd-rotate-cw.svg
  icons/applets/48/osd-rotate-flip.svg
  icons/applets/48/osd-rotate-normal.svg
  icons/applets/48/osd-sbs-left.svg
  icons/applets/48/osd-sbs-sright.svg
  icons/applets/48/osd-shutd-laptop.svg
  icons/applets/48/osd-shutd-screen.svg
  icons/applets/64/osd-duplicate.svg
  icons/applets/64/osd-rotate-ccw.svg
  icons/applets/64/osd-rotate-cw.svg
  icons/applets/64/osd-rotate-flip.svg
  icons/applets/64/osd-rotate-normal.svg
  icons/applets/64/osd-sbs-left.svg
  icons/applets/64/osd-sbs-sright.svg
  icons/applets/64/osd-shutd-laptop.svg
  icons/applets/64/osd-shutd-screen.svg

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  I am glad you like them :)
  
  I will hand in the updated diff tomorrow. The color fix script somehow ate my 
icons and I have to restore them from a backup.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Latest revision:
  F5787871: pls_assess.png 
  I moved the window a bit up while maintaining the alignment, as requested. I 
had to remove the stand of the projector screen tho. Originally I "cheated" and 
moved the stand off-center to make it still visible. However, with the "header" 
of the projector screen shown, it was easily apparent that the stand wasn't 
centered anymore.
  
  As for the 16px icons … I say they can't be done. At least for the 5th row 
from the left onward. There simply is not enough room to squeeze two windows 
(as in, window icons) next to each other while 1. having them look like windows 
and 2. being meaningful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  In D10937#227525 , @ngraham wrote:
  
  > Those all look pretty great to me, honestly. A nice upgrade from the 
current icons.
  >
  > For the pink column, does it look bad if you raise the projection screen so 
that it's only a little bit higher than the laptop on the large icons? It seems 
like there's room to raise it a bit and still keep the blue window aligned 
between them. I think it's okay if they're not aligned on the smaller versions.
  
  
  You mean like in the smaller icons or like so:
  F5756076: path1394.png ?
  
  In D10937#227527 , @emateli wrote:
  
  > Hi, while I do appreciate the icons I also have a question: Why the use of 
laptop and projector over of two simple generic screens. Wouldn't that be 
better for all use cases?
  
  
  Dunno, I didn't set out to change the metaphors used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  An update:
  F5756024: thick_or_Thipng.png 
  
  Green column:
  I still haven't found a better metaphor.  With the slightly rotated window 
metaphors to its sides I can just leave out the window at smaller sizes, but I 
can't really think of something that fills the screen at larger sizes while 
still being expressive at smaller sized.
  
  Pink column:
  I tried to get rid of the skew, but at medium sizes I can't seem to manage to 
get something that 1. doesn't look like a potato and 2. is actually 
recognizable. The laptop isn't so much the issue as the second screen.
  
  Orange row:
  I am honestly not sure it can be done at this size. The first 4 icons are 
probably possible, but after that it gets extremely tricky. I haven't managed 
to find forms that are clear in their meaning and still recognizable. It's 
either super cluttered or just a blue rectangle and a red X :|
  
  I already had to get rid of the outer rim around the laptop in the 3rd row 
5th column onward. I am not a fan.
  
  As for the last row: I found that just scaling everything by a factor of 2 
works best. With a 1px line thickness things start to look "hollow" and 
incomplete.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  In D10937#216476 , @mart wrote:
  
  > one point tough: those are only going to work at a single size, as they are 
more vulnerable to become blurry when resized, so they would need other size 
versions as well (small sizes probably being like before)
  >
  > as they are part of the icon theme, one can't assume where and how they 
will be used (want it or not, app developers will just borrow them if they like 
it for whatever they want to represent) so the full sizes set is needed
  
  
  I agree, however, there's a point where the symbolism will simply break down. 
If we try to go with the laptop analogy I'd say 32x32px is the cutoff where one 
can reasonably use this symbolism. While it might be possible to cram it all 
into that confined space, there will be a lot going on. I'd say too much to 
really understand the intention behind the icon. Though I am open to be proven 
wrong.
  
  In D10937#216511 , @ngraham wrote:
  
  > This came up in the VDG telegram room: the rotate and flip icons are still 
rather unclear, just from the icon alone. We came up with a potential 
alternative: how about displaying a rotated or flipped image in the screen? It 
would have to be something with strong directionality, like a mountain or 
something. In fact, we already use  "mountain and sun" imagery elsewhere, for 
example with the Pictures folder:
  >
  > F5735330: Spectacle.x27054.png 
  >
  > I feel like a slightly less abstract version of that could work well here.
  
  
  I tried to experiment with your idea:
  
  F5736299: Screenshot from 2018-03-02 13:13:42.png 

  The top two rows are takes on "rotate left".
  
  I am not sure it'll work with photo symbolism. At for me, I definitely 
wouldn't recognize what the rotated images were supposed to symbolized if I 
didn't know beforehand. Or, at least, I need a version that's not flipped for 
comparison. I am not saying though that the idea can't work. I am just not sure 
what to use here.
  
  For the second row, I think the one to the left works best, however, due to 
the angles it'll always be blurry. Not sure if that's a good trade-off or not. 
Perhaps I should try it with the window being empty too.
  
  I'd say that I think the top row works best, however, all the ideas, safe the 
bottom row, suffer from being complicated. As @abetts noted, sometimes simpler 
is better. I'd also help with adapting the icons to smaller sized without 
losing too clarity.
  
  In D10937#216512 , @abetts wrote:
  
  > Is there a way that we can add extra clarity by adding a label below the 
icons? A label that explains what the action is? I agree that the current 
symbolism can be hard to read but it is also very simple. If you make the 
connection to label, it will be even stronger in meaning. Also, not sure I like 
the white background on those tiles, is there a way that they can be dark and 
the images light? Just a thought on colors.
  
  
  The implementation it is supposed to be used in will have labels, as can be 
seen in in this blog post. 
 However, every def 
can use them if they want.
  
  RE:Color Do you mean the laptop screen? Or the while icon? If so, there's a 
dark variant for breeze dark. The tiles are just my 64x64px working areas and 
not part of the icons themselves.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, 
aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  Some different versions. Personally, I think the first or last version is 
best, however, the last would probably only work in conjunction to the other 
icons and not as stand alones.
  
  F5735170: Screenshot from 2018-03-01 20:14:44.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, 
aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan added a comment.


  In D10937#216270 , @ngraham wrote:
  
  > But I don't like how the window and X icons in the other icons are now much 
lighter and smaller. I feel like they need to be a bit bigger and/or have 
thicker line weights to ensure that they don't recede too much in visual 
importance. Maybe not as big and thick as before, but maybe a //bit// bigger.
  
  
  I agree with you on the X. 1px diagonal strokes don't jam well standard 
resolution screens. I've updated them to 2px thick strokes now.
  
  I kinda agree with you on the windows, however, what makes the thing windows 
in my revision so recognizable as windows, compared to the current ones, is the 
ratio of the header thickness to the outline stroke thickness delineating the 
window. it's 1:3 for my windows and 2/3 for the one in the current ones. 
There's not much room to go around in the icons to make thicker windows that 
are easily renegotiable this way. 
  However, I think I found a fix, instead of making them bigger, make them more 
massive. I added some content to the windows and I think it could be a nice 
middle ground:
  
  F5735098: Screenshot from 2018-03-01 18:58:16.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, 
aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan created this revision.
pstefan added a reviewer: Breeze.
pstefan added a project: VDG.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
pstefan requested review of this revision.

REVISION SUMMARY
  **Overview**
  The icons to be replaced and their replacement
  F5734722: Screenshot from 2018-03-01 11:46:17.png 

  
  I found the current icons to have some issues that I tried to address with 
this revision:
  
  - Ambiguous symbolism
  - Inconsistent use of stroke thickness
  - Small arrowheads
  
  In the side to side comparison above it's demonstrated that IMHO the 
arrowheads are too small to make out at a glance. The shallow angle between the 
arrowhead and the arrow-body in the rotate icons, especially, make the 
arrowheads almost invisible.
  
  Another issue is the inconsistent use of stroke thickness, demonstrated in 
the image below.
  F5734732: Screenshot from 2018-03-01 11:52:43.png 

  
  In my limited user testing (7 people), people did find the last 5 icons from 
the right to be ambiguous. I think this can mostly be attributed to the to the 
use of a projector screen as a symbol for external screens. The addition of the 
screen stand to the icons seemed to clear that confusion.
  
  **Personal Opinion**
  Personally I think that my icons are more in line with the spirit of the 
breeze icon style. The breeze HIG calls for icons that represent actions to be 
monochromatic and mostly use a stroke thickness of 1px. While the HIG specifies 
that this only applies to 16x16 icons, I feel that in this special case it's 
more appropriate to design these icons for their native 64x64px size instead of 
trying to design them at 16x16 and then scale them up by a factor of 4. Which 
leads to tick and clunky looking icons.
  These icons will never be shown in an 16x16px area, so we might as well make 
use of the additional space. 
  IMHO this makes for much cleaner, lighter icons as one usually associates 
with breeze icons.
  
  **Summary**
  Pro:
  
  - Ambiguous symbolism
  - Inconsistent use of stroke thickness
  - Small arrowheads
  
  Con:
  
  - Deviate from current style for icons this size

TEST PLAN
  I tested the "new" icons with 7 people, all of which reported that this 
revision improves the symbol of the icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

AFFECTED FILES
  icons-dark/applets/64/osd-duplicate.svg
  icons-dark/applets/64/osd-rotate-ccw.svg
  icons-dark/applets/64/osd-rotate-cw.svg
  icons-dark/applets/64/osd-rotate-flip.svg
  icons-dark/applets/64/osd-rotate-normal.svg
  icons-dark/applets/64/osd-sbs-left.svg
  icons-dark/applets/64/osd-sbs-sright.svg
  icons-dark/applets/64/osd-shutd-laptop.svg
  icons-dark/applets/64/osd-shutd-screen.svg
  icons/applets/64/osd-duplicate.svg
  icons/applets/64/osd-rotate-ccw.svg
  icons/applets/64/osd-rotate-cw.svg
  icons/applets/64/osd-rotate-flip.svg
  icons/applets/64/osd-rotate-normal.svg
  icons/applets/64/osd-sbs-left.svg
  icons/applets/64/osd-sbs-sright.svg
  icons/applets/64/osd-shutd-laptop.svg
  icons/applets/64/osd-shutd-screen.svg

To: pstefan, #breeze
Cc: #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, 
aaronhoneycutt, mbohlender