Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 2:49 a.m., Lamarque Souza wrote: > > src/kdeinit/kdeinit5_proxy.cpp, line 1 > > > > > > Please add a copyright header for each new file [1]. If I am not > > mistaken all frameworks 5 files shou

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 25, 2015, 5:19 p.m.) Review request for KDE Software on Mac

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 25, 2015, 6 p.m.) Review request for KDE Software on Mac OS

Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/#review88837 --- Would it be an idea to create a framework function to run the

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Nov. 25, 2015, 6:18 p.m., René J.V. Bertin wrote: > > See qtbase/src/plugins/platforms/cocoa/qcocoaintegration.mm and > > qcocoahelpers.mm Isn't copy/paste a great tool? :) Anyway, `qt_mac_transformProccessToForegroundApplication` only reads the `LSUIElement` key to determine whether an ap

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated Nov. 25, 2015, 7:12 p.m.) Review request for KDE Software on Mac

Re: Review Request 126161: OS X housekeeping

On Thursday November 26 2015 08:54:25 David Faure wrote: >> No, with "my" fix, applications started through kwrapper appear as >> individual entries in `ps` listings, with your fix only the `kwrapper5 >> /path/to/command` entry shows up. > >I don't see how that's possible. >If kdeinit forks, sur

Re: Review Request 126161: OS X housekeeping

On Thursday November 26 2015 08:54:25 David Faure wrote: > Not at all, kdeinit on linux does fork+dlopen, no exec. Actually, that is true only when launch() is called with a library (.so), not when it's called with an executable! R ___ Kde-frameworks-

Re: Review Request 126161: OS X housekeeping

On Thursday November 26 2015 08:54:25 David Faure wrote: > But my point is exactly that: if fork+dlopen is a problem on OSX, then don't > do it, do fork+exec. That's what you do, > but then why exec something that will dlopen, instead of exec the real thing? Indeed, it's fork+dlopen that is the

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 26, 2015, 5:20 p.m.) Review request for KDE Software on Mac

Re: Review Request 126161: OS X housekeeping

> On Nov. 25, 2015, 8:39 a.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 1621 > > > > > > Yes if you have to run a separate process which will then dlopen the > > kdeinit module, the whole purpose of k

Re: Review Request 126161: OS X housekeeping

Alex Merry wrote: > If I recall rightly, it's a speed thing. kdeinit pre-loads some > libraries common across most KDE applications (eg: Qt5Core and Qt5Gui, Ah, right. Dive in too deeply and you can forget about underlying reasons. The real underlying mechanism is of course (IIUC) the fact that t

setting default widgetStyle (and ColorScheme)

Hi, Apologies is this is a bit off-topic: How does one set/define the default widgetStyle for KF5 applications? I'm now at the point where have been able to build a style (QtCurve), and can request it via the --style argument when launching the few example applications I have (not kdebugdialog5

Re: setting default widgetStyle (and ColorScheme)

On Friday November 27 2015 22:31:09 René J.V. Bertin wrote: Further observation: my font selection is also affected. The only way to get "my" widget style, fonts and colours by default is by using the Qt's Xcb plugin (unsupported, but currently it still builds) and setting KDE_FULL_SESSION=true

Re: setting default widgetStyle (and ColorScheme)

Digging through Qt's source code to figure out if and how I can get KF5 applications to honour theming settings on OS X, I observe the following in class QKdeThemePrivate in qgenericunixthemes.cpp: static QString kdeGlobals(const QString &kdeDir) { return kdeDir + QStringLiteral(

Re: [Development] setting default widgetStyle (and ColorScheme)

On Saturday November 28 2015 01:07:17 Olivier Goffart wrote: > > A pure KF5 system will not have ~/.kde*/share/config/kdeglobals, correct? > > That code was written for integrating into KDE 4. That much was clear :) > A pure KF5 appliation would anyway use the KDE platform theme plugin provided

Re: [Development] setting default widgetStyle (and ColorScheme)

Aleix Pol wrote: >> In fact, my observations probably imply that the code *is* called when >> running "pure Qt5" apps under X11 (it is with the xcb plugin on OS X; I >> checked). If indeed so, I think it should be updated to comply with KF5 >> principles if KDE_SESSION_VERSION = 5 (and use the KD

Re: setting default widgetStyle (and ColorScheme)

Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin provided > by KDE Frameworks. (in frameworkintegration) > (So in other words: that code should not be executed when kde frameworks is > installed, in theory) So... No, it doesn't. Not on OS X when u

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On Saturday November 28 2015 15:29:00 David Faure wrote: >I still have to see proof that a "pure Qt application" installed with MacPorts >really cares about where QSP points to - apart from the obvious migration issue >if this ever changes. The question is not whether individual applications care

Re: [Development] setting default widgetStyle (and ColorScheme)

Kai Uwe Broulik wrote: >> A priori users should then still be able to use Qt's native Macintosh "aqua" > theme by selecting it as their KDE widget style. > > I think it should do that automatically anyway. I wouldn't want to install > System Settings to begin with, let alone manually choosing th

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

Alex Merry wrote: > I'd be fine with adding something to KDECompilerSettings as long you had > to explicitly ask for it to be enabled when running CMake. But if you're > doing that, why not set CMAKE_EXE_LINKER_FLAGS_INIT directly on the > CMake command line, or use the LDFLAGS env var? I assume

Re: [Development] setting default widgetStyle (and ColorScheme)

btw, I'm also fine with having to set, say, KDE_SESSION_VERSION to a meaningful value in order to get automatic loading of the selected KDE theme, at least as long as it's possible to set env. variables session-wide on OS X. R. ___ Kde-frameworks-deve

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

Alex Merry wrote: > I'm not sure what you mean by "incremental", though. All CMake variables > overwrite their previous values when you set them, so you have to > explicitly include the old value when you set them, and you can't really > do this from the command line. That's what I was getting at

kdebugdialog5 doesn't respect ShowIconsOnPushButtons with the KDE platformthemeplugin

Hi, As stated in the subject, kdebugdialog5 doesn't respect the user's choice re: icons in buttons when using the platform plugin from KF5-frameworkintegration, even after forcing the hints to false in the frameworkintegration source. It does when using the native Cocoa style on OS X. Is this i

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Nov. 25, 2015, 6:18 p.m., René J.V. Bertin wrote: > > See qtbase/src/plugins/platforms/cocoa/qcocoaintegration.mm and > > qcocoahelpers.mm > > René J.V. Bertin wrote: > Isn't copy/paste a great tool? :) > > Anyway, `qt_mac_transformProccessToForegroundApplication` only reads the

Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Nov. 29, 2015, 8:53 p.m.) Review request for KDE Software on Mac

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: > In my opinion: no. I even think the frameworkintegration framework should get > removed from frameworks and moved into Plasma Workspace. Because that's what > it is about: integrating Qt applications into plasma. I don't care where the framework is, but I do think users

Re: setting default widgetStyle (and ColorScheme)

René J. V. Bertin wrote: > Of course one could work on improving the native theme, but wouldn't that be > easiest by writing a dedicated KDE theme? In fact, I ought to check what > happens if one selects the "Macintosh (aqua)" style as KDE's widget style and > then

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: Is this going to turn into another shouting match? > That's not the point! Any user can use whatever theme they want. The question > is whether we should default to our Plasma defaults on non-Plasma. And the > question to that can only be: NO! I'm not suggesting it should

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Nov. 30, 2015, 12:42 p.m., Martin Gräßlin wrote: > > I'm strictly against OSX specific changes in framework integration. In my > > opinion framework integration should only be about Plasma. I'll start a new > > thread about it. I was afraid you'd be saying that. I can only hope that thi

Re: Scope of framework integration plugin?

Boudewijn Rempt wrote: > Sort of related question... Is this also the module that picks up the font Not sort of related: I think you're spot-on. (These settings are probably moot on OS X, btw.) > hinting settings and applies it to KDE applications? I setup a gnome-only dev > env to see what Kri

Re: Scope of framework integration plugin?

Adding KDE-mac because we're the first concerned (thanks for omitting us ... again). First off: what about splitting off the KdePlatformPlugin from frameworkintegration? I can see the point that it was conceived to allow pure Qt5 applications to integrate with the look KF5 applications have und

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: > what you put on review board is in my opinion not a minimal modification. That > are lots of ifdefs and each ifdef is a huge burden for the framework. It means ... > Given that: we need to be extremely careful when we consider adding platform > specific code and need to

Re: Scope of framework integration plugin?

Aleix Pol wrote: > Correct, but the fix isn't to make Qt look in the KF5 paths. Qt should > be fixed to fetch the settings wherever gnome puts them, so that the > sizes are the same. > > IOW, we shouldn't expect users to open "kcmshell5 fonts" to set the > font size of KDE applications on Gnome.

Re: Scope of framework integration plugin?

On Monday November 30 2015 16:07:50 Jan Kundrát wrote: Hi, >Yes, I think that such a goal is fully in line with Qt's attempt at being >reasonably cross-platform. The keyword here is reasonable - and that's to be interpreted from their point of view. The last time we (including David Faure) att

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Nov. 30, 2015, 4:51 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review88970 --- File Attachment: using the KDEPlatformTheme - Screen Shot 201

kpty/utempter

I've had a quick look, and it appears that it shouldn't be overly hard to port libutempter to OS X (which has setutxent, pututxline etc. instead of "x-less" counterparts on Linux). Question is, how useful is this in KPty? R. ___ Kde-frameworks-devel m

Re: setting default widgetStyle (and ColorScheme)

Martin Graesslin wrote: > That is in deed a better approach. I'm still questioning whether it's the > right thing to do on OSX, but that would then be up to the OSX developers to > decide on. I'll handle that tomorrow. > But if the platformtheme plugin does get moved to Plasma I would say tha

Re: Review Request 126161: OS X housekeeping

On Monday November 30 2015 09:01:25 David Faure wrote: Hi, >I never realized you could pass a shared lib to kwrapper5, that is definitely >not the intended usage, and I can tell you, nobody does this ;) Ok, just to get this straight: it doesn't make sense to pass a shared lib to kwrapper5, but

Re: Review Request 126161: OS X housekeeping

On Tuesday December 01 2015 09:56:15 David Faure wrote: > >Yes - which is exactly what my suggested patch does, AFAICS. Your patch only modifies launch() IIRC. If my understanding is correct, then that means kdeinit will fail if it decides to use the kdeinit module, because that decision is not

Re: Review Request 126161: OS X housekeeping

On Tuesday December 01 2015 10:35:47 René J.V. Bertin wrote: >Your patch only modifies launch() IIRC. If my understanding is correct, then >that means kdeinit will fail if it decides to use the kdeinit module, because >that decision is not made inside launch(). Or maybe the truth is somewhere i

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 1, 2015, 2:03 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 1, 2015, 9:29 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89008 --- A couple of things I jotted down today, probably open doors bu

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89009 --- src/platformtheme/kdemactheme.mm (lines 53 - 87)

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no problem

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the appl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:46 a.m., Martin Gräßlin wrote: > > Overall I think this is now too much code duplication. With this appraoch > > you don't get bug fixes from the base code. I recommed to rather go for > > inheritance to have the actual code which can be shared still together. Yes, I was a

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin w

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. If I understand you co

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the appl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 1, 2015, 9:34 p.m., René J.V. Bertin wrote: > > src/platformtheme/kdemactheme.mm, lines 53-87 > > > > > > I thought it would be best to use a native dialog here to show a > > warning dialog, but it turn

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin w

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:42 p.m.) Review request for KDE Software on Mac

KTabBar/QTabBar and documentMode

Hi, I've been looking into ways to configure (improve) the look and feel using the native platform theme on OS X, and was reminded quite quickly about one of the nuisances that can arise with the default look of the native widget used by QTabBar. It's easy to reach the number of open tabs where

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 3, 2015, 10:51 p.m.) Review request for KDE Software on Mac

Re: KTabBar/QTabBar and documentMode

Jaroslaw Staniek wrote: > Hi, that's one of my hints from 2010 > https://blogs.kde.org/2010/09/29/elegance-4-tab-bar-uncluttered :) But that's for a different purpose, removing distracting visual clutter rather than ensuring that the tabs themselves remain useful. After looking into the issue a

Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Review Request 126241: [OS X] adapting KStyle (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126241/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Hugo Pereir

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > Please include Hugo for a review on the KStyle changes. > > > > I'd suggest to split the review into three parts: one about the adjusted > > test (ecm_foo) - that's a no brainer and doesn't need further discussion. > > One about the KStyl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 2:05 p.m.) Review request for KDE Software on Mac

Re: Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- (Updated Dec. 4, 2015, 4:49 p.m.) Status -- This change has been mar

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 7:01 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 2:40 p.m., Martin Gräßlin wrote: > > No, those we shouldn't need anymore as the toplevel CMake file will reject Qt versions earlier than 5.3.0 . Should I clean up all occurrences from platformtheme, even where they have nothing to do with the Mac version? - René J.V. --

Re: Scope of framework integration plugin?

Boudewijn Rempt wrote: From what I recall from KDE4, there was at least a KDE -> X resources path in systemsettings > without any kde integration available, and I noticed that Qt 5.6 doesn't seem > to pick up the Gnome font hinting settings. Re-reading this I'd say there must be a default setti

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. OK, hope to get around to doing that

Re: kpty/utempter

On Sunday December 06 2015 21:52:21 David Faure wrote: > > Question is, how useful is this in KPty? > > `utempter is a privileged helper program that writes utmp/wtmp entries for > unprivileged programs.` I can read, you know ;) > > Does utmp or wtmp exist on OSX? > Hmm, yes, but deprecated -

Re: kpty/utempter

On Sunday December 06 2015 22:10:03 David Faure wrote: >> Question is, what are we missing out on without it? Is this what kdesu is >> based on, for instance? > >It's just about logging, so "based on" is not really true. I'm pretty sure >kdesu works even without logging to utmp. OK, so there mu

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. Regardless of what I try (even with t

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89222 --- So with the current implementation that uses inheritance, ther

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 7, 2015, 5:43 p.m.) Review request for KDE Software on Mac

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

> On Dec. 7, 2015, 4:29 p.m., Hugo Pereira Da Costa wrote: > > I honestly have some doubt on the approach (but no counter proposal either) > > Basically the file kstyle.mm is a *copy* of the .cpp file, with a couple of > > lines changed. (which I had to track down by > > - downloading the patch

kdelibs4support forces "icons in buttons"?

Hi, I have the strong impression that applications using the kdelibs4support fw are forced to show icons in buttons, regardless of the corresponding setting (which is respected elsewhere). For some reason it does not happen when I use the native platform plugin on OS X, but if the frameworkinte

[OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

Hi, Several classes exist that have the possibility to create widgets or windows from a Qt WId, and those are used (exclusively? mostly?) by certain helper agents like the kwalletd to display dialogs parented by a window from the application that sent the request that justified posting the dial

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

On Wednesday December 09 2015 13:51:47 Martin Graesslin wrote: > > KWindowSystem::setMainWindow() is a different matter. Firstly, it does NOT > > use the plugin architecture currently, but simply assumes that > > QWindow::fromWinId() will always work (and never crash). > > oh that explains a lot.

Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

Kai Uwe Broulik wrote: > ‎> On OS X (and MS Windows?), > > And Wayland, so it affects Linux, too. Yes, I learned that while composing my message (cf. the subject). FWIW, I just provided an initial/WIP implementation of a KWindowSystem plugin for OS X: https://git.reviewboard.kde.org/r/126291/

Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- Review request for KDE Frameworks, Qt KDE and Yichao Yu. Repository: qtcu

Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Qt KDE. R

Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126309/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 10, 2015, 11:54 p.m.) Review request for KDE Software on Ma

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

system tray test?

Hi, Does KF5 provide any classes above Qt's for putting up and controlling an icon (with/out menu) in the "system tray"? If so, is there a simple test app I can try? Reason I'm asking: kwalletmanager5 isn't showing a systray interface like kwalletmanager(4) does. Not on OS X (where Qt5's systra

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:42 p.m.) Review request for KDE Software on Mac

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:47 p.m.) Review request for KDE Software on Mac

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:59 p.m.) Review request for KDE Software on Mac

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

  1   2   3   4   5   6   7   8   9   10   >