Re: Review Request 112560: Remove KNotification dependency in KCompletion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/#review39651 --- Ship it! Ship It! - Sune Vuorela On Sept. 6, 2013, 3:04

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On 2013-09-16, Martin Graesslin mgraess...@kde.org wrote: The KWindowSystems framework would need to become a tier2 framework and as it needs to depend on NETwm (X11 implementation uses it and the defines are used). It would contain: * KKeyServer * KWindowEffects (this could also stay in

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

://git.reviewboard.kde.org/r/112816/#comment29951 My initial reaction is that it could return a bool wether or not things went okay, given there is a 'path that does nothing' in the code. Besides that, everything looks great. - Sune Vuorela On Sept. 24, 2013, 2:19 p.m., Aurélien Gâteau wrote

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

On Sept. 24, 2013, 2:23 p.m., Sune Vuorela wrote: tier1/kguiaddons/src/lib/colors/kcolorutils.cpp, line 42 http://git.reviewboard.kde.org/r/112816/diff/1/?file=190519#file190519line42 My initial reaction is that it could return a bool wether or not things went okay, given

Re: Making KDocTools independent of KArchive

Maybe we can bundle the generated documentation? Distributions in general don't want pregenerated anything. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because of it?

Flaky kcodecs test depending on qt configuration

Hi Depending on the Qt configuration (built with or without ICU), the KCharsetsTest::testEncodingNames() test fails (in the #if) block. If Qt built with ICU, the tests succeeds and the ISO 8859-16, jis7 and winsami2 codecs are as expected not found. If Qt is built without ICU, those codecs are

KDirWatch vs QFileSystemWatcher

Hi If your KDirWatch backend is QFileSystemWatcher, one of the testcases fails. The last QVERIFY in testMoveTo never receives the signal dirty-signal it is looking for. Apparantly, the watch.removeFile apparantly somehow turns off the QFSW to not do any further notifications for what happens in

Re: KDirWatch vs QFileSystemWatcher

On 2013-10-27, David Faure fa...@kde.org wrote: testMoveTo passes most of the time (finally got a failure after 10 runs or so)... Fixed as well (9c6cc615676a5bb) (not a real bug, a unittest bug). 4: QDEBUG : KDirWatch_UnitTest::testMoveTo() Added Dir C:/Users/Administrator/A

Re: KDirWatch vs QFileSystemWatcher

On 2013-10-28, David Faure fa...@kde.org wrote: On Sunday 27 October 2013 22:02:18 Sune Vuorela wrote: Seems to still consistently failing here on windows :/ Good, consistency is good, we can debug that :) Can you apply this patch and try again, so I get more debug output? http

Re: Google Code-In

On 2013-10-25, Kevin Ottens er...@kde.org wrote: Excellent! Could you get in touch with Lydia about it? I'd rather have = a=20 support role, but we need someone to keep track of things and you seem = like a=20 good candidate. :-) =20 I've scrolled over kdeexamples and added 4 tasks. Ensure

Re: Use of the WIN32 executable property

On 2013-10-27, David Faure fa...@kde.org wrote: I withdraw my objection then, I guess. Let them have a console, for easier debugging. \o/ Let's get all windows test apps to get a console. /Sune ___ Kde-frameworks-devel mailing list

Re: Review Request 113479: fix kshareddatacache on windows

, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113479: fix kshareddatacache on windows

/113479/diff/ Testing --- Test suite passes Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

On 2013-10-29, Alexander Neundorf neund...@kde.org wrote: Good point. As it is, IMO for being ECM, it needs way more documentation. It needs to be documented so that it can be used by people who know nothing about KDE or KDE's icon scheme. Or should that be in the framework which deals with

Review Request 113503: make dbus dependency optional in JobWidgets

tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 Diff: http://git.reviewboard.kde.org/r/113503/diff/ Testing --- build tested on windows without dbus. not yet tested on other platforms Thanks, Sune Vuorela

Re: Review Request 113503: make dbus dependency optional in JobWidgets

the files are properly added, always returns false, so doesn't build with dbus. needs fixing - Sune Vuorela On Oct. 29, 2013, 10:27 p.m., Sune Vuorela wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113503: make dbus dependency optional in JobWidgets

on windows without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Getting ecm files from the ECM package

On 2013-11-01, Kevin Ottens er...@kde.org wrote: So far we chose the have it in cmake/ecm route. If we had what Mirko = refers=20 to, then that'd open the door to another solution. And it would open the first door towards alienating linux distributions. Of course, we could say and so what?.

Re: Getting ecm files from the ECM package

On 2013-11-01, Mirko Boehm mi...@kde.org wrote: Anyone up for hacking this up next week? I am available starting Monday afternoon. Before you start hacking, please consider the following: http vs https? should http even be allowed? certificate handling? how to do ssl? a library? will

Re: Getting ecm files from the ECM package

On 2013-11-01, Alexander Neundorf neund...@kde.org wrote: Anyway, attached is a quick experiment, which adds the 3 KDE*.cmake files= from=20 extra-cmake-modules/ to kf5umbrella/, by that turning it into tier0/, wit= h the=20 optional ability (-DWITH_ECM) to download ECM and install ECM when

Re: Getting ecm files from the ECM package

On 2013-11-01, Mirko Boehm mi...@kde.org wrote: To me, build systems should not download anything sounds like a movie from the 80ies. To me, build systems fetches code and executes it sounds like a bad horror movie. For example, from a developers point of view, what is the difference between

Re: Getting ecm files from the ECM package

On 2013-11-03, Alexander Neundorf neund...@kde.org wrote: This code unconditionally searches for QtCore (and sets a target property where I'm not sure how many people here can understand what's going on). It is hopefully a temporary hack that shouldn't be in that file. Sometimes, temporary

Re: Exceptions in KDE Frameworks

On 2013-11-02, Mirko Boehm mi...@kde.org wrote: I get from that that I can enable exceptions for threadweaver without affecting the other libraries. This makes my job a lot easier. note though that most of Qt isn't really compatiple with exceptions. see also long threads on qt-dev list. /Sune

Re: Having a Tier 0 for cmake and git submodules

On 2013-11-10, Kevin Ottens er...@kde.org wrote: Since there's been several times discussions about having a kind of Ti= er 0=20 for building our frameworks containing what is right now in ECM kde-mod= ules=20 directory, but the idea was never really on the table because of the ex= tra=20

Re: Having a Tier 0 for cmake and git submodules

Content-Type: text/plain; charset=iso-8859-1 On Sunday 10 November 2013 17:12:02 Sune Vuorela wrote: Why move it out of e-c-m ? To make e-c-m a neutral ground again, not something purely for KDE need= s. I=20 can understand that positioning. Let's just rename most of them to make them not look

Review Request 113805: Do not change the build types available with cmake

, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113805: Do not change the build types available with cmake

, visit: http://git.reviewboard.kde.org/r/113805/#review43538 --- On Nov. 11, 2013, 10:16 p.m., Sune Vuorela wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Getting ecm files from the ECM package

On 2013-11-11, Aaron J. Seigo ase...@kde.org wrote: would that work for everyone? I don't think it solves the actual hard point: Where should the final home for the stuff in ecm/kde-modules be ? I'll like to reiterate what I suggested should happen with it: KDEInstallDirs.cmake : Keep it as

Re: Review Request 113805: Do not change the build types available with cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43538 --- On Nov. 11, 2013, 10:16 p.m., Sune Vuorela wrote

Re: Review Request 113805: Do not change the build types available with cmake

not objecting, just giving comments. Sune Vuorela wrote: 1) By no surprises I mean by 3rd party users, skilled in Qt and cmake, of a KDE framework - like if I end up using one at work and some of my colleagues need to fix a bug or add a feature, then this would be a unpleasant surprise when

Re: Review Request 113503: make dbus dependency optional in JobWidgets

without dbus. not yet tested on other platforms Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113805: Do not change the build types available with cmake

://git.reviewboard.kde.org/r/113805/diff/ Testing --- Built kdelibs on linux with gcc. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

of more than a week? - Sune Vuorela On Feb. 18, 2014, 3:26 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496

KPassivePopup should be in kwidgets ?

Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and isn't really notification specific. Shouldn't it rather be in kwidgets? /Sune - hoping for a widgets

Re: qt5 polkit-qt-1 and kdesrc-build

On 2014-06-27, David Faure fa...@kde.org wrote: On Saturday 01 March 2014 17:33:45 David Faure wrote: I don't mind adding it - but what about releasing? Is anyone taking care of releasing polkit-qt-? Or should we make it a framework so I release it with the rest of the stuff ? Cc'ing

Re: Which package will provide the common KDE library version number ?

On 2012-02-23, Alexander Neundorf neund...@kde.org wrote: I'd be fine with a find_package(KF5BuildSpecs 5.3.0), assuming the version number would be mandatory, as now there'd be no risk of a kwhatever 5.3.0 claiming to be a kwhatever 5.10.0. This can be done. Then this line has to be kept in

Re: Which package will provide the common KDE library version number ?

On 2012-02-24, Alexander Neundorf neund...@kde.org wrote: * the version numbers of the projects themselves * the required Qt version This might differ across frameworks. I see no reason to artificial bump required version. * the required CMake version similar. * the required

Re: KF5 Volunteer day 2 next week?

On Sunday 18 March 2012 20:11:20 Kevin Ottens wrote: So, doable? Any volunteers (aha) to drive the volunteer day? :-) Dario indicated to me he could be available part of the afternoon, that= 's nice=20 but likely not enough. I'll most likely be around, but I*m not sure of my ability to

Re: Notifications-future, a recap

On 2012-09-17, Dario Freddi drf54...@gmail.com wrote: Hello everyone, you might or might not know by now of my intention of revamping the way we deal with notifications in KDE as I explained in my last blog post

Re: Dialogs, KMessage box and job widgets

On 2012-11-14, Valentin Rusu k...@rusu.info wrote: Hello, I have a question about KMessage class from kdeui/dialogs. According to the epics page, kdeui/dialogs will go to tier3. On the other hand, kdeui/jobs will go to tier2, only the class KDialogJobUiDelegate is actually using

Re: KArchive for Qt4

On 2012-11-15, Alexander Neundorf neund...@kde.org wrote: I thought we earlier agreed on things like you should not inherit sonames from other modules and such. We have apparantly a ECM_SOVERSION coming from somewhere and used. and we just have layers of added complexity that seems to be

Re: KArchive for Qt4

On 2012-11-17, Alexander Neundorf neund...@kde.org wrote: On Thursday 15 November 2012, Sune Vuorela wrote: On 2012-11-15, Alexander Neundorf neund...@kde.org wrote: I thought we earlier agreed on things like you should not inherit sonames from other modules and such. We have apparantly

Re: KArchive for Qt4

On 2012-11-19, Stephen Kelly steve...@gmail.com wrote: I don't have a link to 'you should not inherit sonames from other modules'. but it sholud kind of be common sense as we also see in various areas of current KDE land where e.g. libkmailprivate from kdepim 4.4 is not having a matching

Re: kemoticons is now in staging

On 2012-11-19, David Faure faure+bluesyst...@kde.org wrote: Let me say this differently: look at the huge mass of code in Qt: almost none of it uses QSettings to let the users configure things from underneath. Most of the time, the apps themselves have control over the various settings

Re: add_library NO_PREFIX

On 2012-11-29, Alexander Neundorf neund...@kde.org wrote: At least it is possible: It is possible on some systems. I think it might be limited to a GNU userland on unix-like systems, if not limited to GNU userland on linux. It is at least according to some windows people not possible to do so

Re: Separating everything ?

On 2013-02-08, Mirko Boehm mi...@kde.org wrote: As Frank said: I haven't seen any convincing argument yet why multiple repositories are better. +1. There are several things here intermixed 1) is the release tarball layout 2) is the way the software is built 3) is the repository layout all

Re: kde5 or kf5 ?

On 2013-02-16, Alexander Neundorf neund...@kde.org wrote: _set_fancy(LIBEXEC_INSTALL_DIR ${LIB_INSTALL_DIR}/kde5/libexec) I still don't see a reason for a *shared* libexec directory. libexec is implementation details of specific libraries, just like one shouldn't mess around with each others

Re: kde5 or kf5 ?

On 2013-02-16, Alexander Neundorf neund...@kde.org wrote: The tool kde4-config has also been renamed to kde5-config. What's the purpose of this tool in a non-monolithic world? /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: KF5 Update Meeting Minutes 2013-w27

On 2013-07-02, Alexander Neundorf neund...@kde.org wrote: E.g. kplotting and kwidgets have the same dependencies. I wouldn't mind having kplotting as part of kwidgets. I do think that consideratiotns like these are very important, but I also think we should wait with looking at merging them

Re: KIO progress towards tier 1 framework?

On 2013-07-10, Kevin Ottens ervin+bluesyst...@kde.org wrote: OK thanks for the clarification. I don't know where I got that impressi= on that=20 QtScript and Qml were using the same JS engine then... it was that way in qt4 :) /Sune ___

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

take a look at https://codereview.qt-project.org/#change,60560,patchset=5 which has a simpler 'top down' structure which is how CLI-apps usually are. - Sune Vuorela On July 25, 2013, 4:10 p.m., Sebastian Kügler wrote

install paths

Hi peoples. The following popped up in the chat channel today: |kf5 sonnet is looking for plugins in |$prefix/lib/x86_64-linux-gnu/plugins/sonnet_clients/ but installs them |in $prefix/lib/x86_64-linux-gnu/plugins/kf5/plugins/sonnet_clients or if I try to shorten it a bit |kf5 sonnet is

Re: Review Request 111937: Port to KF5/Qt5

versions. It is these days quite normal to have both qt4 and qt5 installed and available. - Sune Vuorela On Aug. 7, 2013, 5:15 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Smart D-Ptr in KCoreAddons

On 2013-08-23, Ivan Čukić ivan.cu...@kde.org wrote: oh. and I think it also looks a bit like your d-ptr gets in the way when you need a d-ptr hierachy. As I said, this is for non-inherited privates. That alone is - I think - a reason to not have it. The few cases where I have needed

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: I would rather change the code. The Qt behaviour was changed for a reason, to prevent accidental use of dangerous behaviour, and I'm not too keen on undoing that move for all software that uses KDECompilerSettings. agreed. - Sune

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

of a matter of taste and will let Alex comment on it: * should the qmake-query function be a secret underscore function * should the setting of the qmake_exe var happen inside the function or not - Sune Vuorela On Aug. 22, 2014, 12:40 p.m., Rohan Garg wrote

Review Request 120139: kill warning

/diff/ Testing --- Warning not printed. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: desktoptojson man page

On 2014-09-15, Alexander Richardson arichardson@gmail.com wrote: However, is this even possible? Building manpages seems to require KDocTools and kcoreaddons is a tier1 framework which would make this impossible. Do we really need a manpage for it? It seems to me that it is only used in

Re: Review Request 121712: Add install target for the KF5 Book

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121712/#review72687 --- looks right to me - Sune Vuorela On Dec. 28, 2014, 11:58

Making prison a framework

Hi The KDESupport library, libprison, a bar code rendering abstraction layer could be heading forward for the first release of a qt5, widgets free version. People also suggesting to make it a framework. So please, take a look at kde:prison and let's try to get it reviewed for frameworks /Sune

Re: Review Request 124105: Adhere a bit better to the spec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124105/#review81499 --- On June 16, 2015, 5:59 a.m., Sune Vuorela wrote

Re: Review Request 124105: Adhere a bit better to the spec

do the same. Diffs (updated) - autotests/breeze.theme 8aef88d autotests/kiconloader_unittest.cpp d1a52fc src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde

Review Request 124105: Adhere a bit better to the spec

://git.reviewboard.kde.org/r/124105/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Sune Vuorela

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

the column. - Sune Vuorela On July 14, 2015, 10:42 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

often needed other roles like color and/or decoration) - Sune Vuorela On July 13, 2015, 8:31 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

29) https://git.reviewboard.kde.org/r/124281/#comment56872 Unused ? src/notifybypopup.cpp (line 561) https://git.reviewboard.kde.org/r/124281/#comment56873 Isn,t QFont() the same as QApplication::font(), and then the #include QApplication seems unused. - Sune Vuorela On July 9, 2015

Re: phonon dep in knotifications

On 2015-10-12, Christoph Cullmann wrote: > Hi, > > I would like to make this dependency optional. > Would that be ok? Is not that much work, but if it is not wanted, don't want > to waste my time. > E.g. on Win/Mac its a real hassle to build and most applications don't need

Re: Policy for Dependencies

On 2015-10-13, Martin Graesslin wrote: > I'm not sure whether it's the best solution. The problem you try to fix with > it is distros breaking packaging. I agree with Martin K that this is a huge > problem and that it will happen - since the automation of packages I also >

Re: Review Request 125615: Make phonon dependency optional

isit: > https://git.reviewboard.kde.org/r/125615/ > --- > > (Updated Oct. 12, 2015, 9:01 p.m.) > > > Review request for KDE Frameworks and Sune Vuorela. > > > Repository: knotifications > > > Description > --- > > Make

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 75 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75 i18n instead of tr Aren't we in a tier1 framework where i18n and friends aren't available? - Sune

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 75 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75 i18n instead of tr Sune Vuorela wrote: Aren't we in a tier1 framework where i18n and friends aren't available

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

order? I am wondering if either a QList - or let the plugin do the squashing - just QIcon - is a better return value. the naming "getOverlays" feels a bit java-esque. oh. and should it be const? I think I like the concept, and it feels like kio is the right home for it.

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

tps://git.reviewboard.kde.org/r/125418/#comment59352> This function name for a setter looks weird to me. setDefaults() reset() restoreDefaults() would be better names in my opinion. defaults() doesn't look like an action, so it must be a getter. - Sune Vuorela On Sept. 27

Re: Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

the 'infinite spinner' instead of fake calculations. I'm not sure I'm enough into the kservice code to actually give a shipit, so I'll refrain from that. - Sune Vuorela On Sept. 19, 2015, 10:58 p.m., David Faure wrote

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

? - Sune Vuorela On Sept. 19, 2015, 11:29 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/#review85684 --- Ship it! Ship It! - Sune Vuorela On Sept. 19, 2015, 8:24

Re: Review Request 125325: New widget KCollapsibleGroupBox

GroupBoxPrivate. The harder way is to ... build the right NOT_EXPORT macro - Sune Vuorela On Sept. 20, 2015, 1:48 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To

Re: kcrash when started from terminal

On 2015-09-24, Harald Sitter wrote: > Uh, ah, but, CMake is too smart :P > If you add a target_link_library that isn't actually used it won't be > linked. So what every application would have to do is add the target It is not cmake that is too smart, but the linker when passed

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

://git.reviewboard.kde.org/r/120139 - Sune Vuorela On Jan. 2, 2016, 7:24 p.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120139: kill warning

/kwidgetitemdelegatepool.cpp d61802e Diff: https://git.reviewboard.kde.org/r/120139/diff/ Testing --- Warning not printed. Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

(line 137) <https://git.reviewboard.kde.org/r/126105/#comment60725> if(rc == 0) return false src/engine/database.cpp (line 167) <https://git.reviewboard.kde.org/r/126105/#comment60726> if(rc == 0) return false - Sune Vuorela On Nov. 18, 2015, 7:40 p.m., Bou

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. > > Pino Toscano wrote: > No I don't :-/ I remember it was just removing indexes with associated

Review Request 128233: Don't trust files claiming to be created on unix more than other files

://git.reviewboard.kde.org/r/128233/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Releasing prison with next frameworks

Hi peoples After a final round of api changes in libprison, I think it is just a version number bump away from being release d with next round of framework releases, and thus going from the previous kdesupport area and into a real framework. What are the exact steps needed? /Sune

Review Request 128237: add failing unit test likely showing off bug 232843

easily be recreated Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Is it able to make kservice's weightedOffers public access?

On 2016-06-28, Leslie Zhai wrote: > Hi KDE developers, > > It might needs to use static KServiceTypeTrader::weightedOffers(const > QString ) to get KServiceOfferList offers, for example, I'll let David Faure (kservice maintainer) to comment on if this makes sense or

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

marked as submitted. Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and Stephen Kelly. Changes --- Submitted with commit 3244f2ff34959f3e5c0a2c864a08737f47f96922 by Sune Vuorela to branch master. Repository: kitemmodels Description --- A skipped unit

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote: > > I tried writing a small test for it, and it seemed like I could reproduce > > the issue. But my test didn't pass when I added this changeset. > > > > Maybe I should publish my test case somewhere... https:

Review Request 128513: Unittest for content test of kdescendantsproxymodel

PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128513/diff/ Testing --- Thanks, Sune Vuorela ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review97915 --- Ship it! Ship It! - Sune Vuorela On July 24, 2016, 9

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

could reproduce the issue. But my test didn't pass when I added this changeset. Maybe I should publish my test case somewhere... - Sune Vuorela On July 8, 2016, 2:58 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an auto

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 1:06 a.m., Olivier Churlaud wrote: > > Same patch should be applied to Konversation. I think you need to submit i to konversation as well, then. - Sune --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- looks good. - Sune Vuorela On July 16, 2016, 12:52 a.m

Re: Review Request 128464: Allow scrolling in config windows for small screens

> On July 16, 2016, 9:53 a.m., Sune Vuorela wrote: > > looks good. > > Olivier Churlaud wrote: > Who should provide the ship it flag? I don't know who is the maintainer... if no one else gives a more formal shipit by monday, consider this

Re: Review Request 128420: Name supported platforms in YAML file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128420/#review97259 --- Ship it! Ship It! - Sune Vuorela On July 10, 2016, 10

Re: Review Request 128353: Unit tests of directory permissions in zip files

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit dda62267aab8893db0ff695391d0fd8b37ace1f6 by Sune Vuorela to branch master. Repository: karchive Description --- Add unit test to prevent later changes to abandon directory

Re: Review Request 128353: Unit tests of directory permissions in zip files

Previous unit test does the same - Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 ------- On

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b7d8fce0a7167f4cea7127c6142ea10c92ff546d by Sune Vuorela to branch master. Repository: karchive Description --- Don't trust files claiming to be created on unix more than other

  1   2   3   >