D22698: Support passing target to ki18n_wrap_ui macro

alexmerry added a comment. Since you tagged me in this, I'll say that (as a former maintainer of Extra-CMake-Modules as well as someone who still makes extensive use of CMake professionally despite not doing much KDE stuff these days) the change looks good (and following modern conventions)

Re: Review Request 127694: Add a Find module for WaylandProtocols

It would be a bit nicer to use the same indenting style found later in the file (ie: put COMMAND on another line, intended 4 spaces, and adjust the other lines to suit). - Alex Merry On May 3, 2016, 10:34 a.m., Martin G

Re: Taking a (semi-)break

On 2016-02-22 22:01, Stephen Kelly wrote: Alex Merry wrote: Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may

Taking a (semi-)break

Hi all, A combination of a serious illness in the family and some of the heated discussions taking place on other KDE mailing lists has led to me burning out on the KDE front. As a result, I'm taking a step back (some of you may have noticed this already). I expect to get back into the swing

Re: Review Request 127093: Drop KDocTools requirement

g/r/127093/#comment63114> You should set the package properties to say what it is needed for (and maybe make it RECOMMENDED?). See KF5Completion below. - Alex Merry On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez

Re: Review Request 127015: Move to tier2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127015/#review92177 --- Ship it! Good catch! - Alex Merry On Feb. 8, 2016, 6

Re: Reminder: Please add "Since" version info also to cmake macros and arguments

On 2016-01-18 16:45, Friedrich W. H. Kossebau wrote: Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau: I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across it, appending the Since behind the example, if that is the current syntax? # Example: #

Re: Review Request 126675: Add .kra and .ora qimagio plugins

g/r/126675/#comment62684> What about making this optional (and only building those two plugins if it is found)? - Alex Merry On Jan. 27, 2016, 9:48 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically g

Re: Review Request 126675: Add .kra and .ora qimagio plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/#review91823 --- Ship it! Ship It! - Alex Merry On Jan. 31, 2016, 1:21

Re: Review Request 126675: Add .kra and .ora qimagio plugins

all the new files are empty. Also, could you please add test cases to the autotests directory? It shouldn't be too complicated, just an example file or two and the PNG equivalents. - Alex Merry On Jan. 16, 2016, 9:55 a.m., Boudewijn Rempt wrote

Re: Review Request 126684: fix loading of RLE compressed PSD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126684/#review90831 --- Ship it! Ship It! - Alex Merry On Jan. 9, 2016, 9:58 a.m

Re: Review Request 126185: Make the KAppTemplate CMake module global

in. kde-modules/KDEPackageAppTemplates.cmake (line 19) <https://git.reviewboard.kde.org/r/126185/#comment61779> New paragraph, please. - Alex Merry On Dec. 28, 2015, 9:37 a.m., Marco Martin wrote: > > --- > This is a

Re: Review Request 126185: Make the KAppTemplate CMake module global

y to install the template package to. In most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from :kde-module:`KDEInstallDirs`. And then put a blank line before the bit about TEMPLATES, so they're separate paragraphs. - Alex Merry On Dec. 18, 2015, 10:55 a.m., Marco

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126185: Make the KAppTemplate CMake module global

() to untar the installed tarball, and examine the contents. I highly recommend you look at ECMInstallIconsTest. - Alex Merry On Dec. 17, 2015, 11:15 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-

Re: Review Request 126185: Make the KAppTemplate CMake module global

bad about the sheer number of changes I'm throwing at you! If you want to make me do some of the work, you can create a feature branch and point me at it, but I'm hoping this review is setting you up for an easy ride if you want to contribute something else to e-c-m in the future. - Alex Merry

Re: Review Request 126185: Make the KAppTemplate CMake module global

On Dec. 16, 2015, 7:14 p.m., Marco Martin wrote: > > You might want to generate the documentation and look at it (you need the > > Sphinx documentation tool installed, then you just build > > extra-cmake-modules, and look in docs/html in the build directory). In particular, you'll need to add

Re: Review Request 126185: Make the KAppTemplate CMake module global

might want to generate the documentation and look at it (you need the Sphinx documentation tool installed, then you just build extra-cmake-modules, and look in docs/html in the build directory). - Alex Merry On Dec. 16, 2015, 12:25 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126185: Make the KAppTemplate CMake module global

tps://git.reviewboard.kde.org/r/126185/#comment61287> I'd prefer ``kde_package_app_templates`` (and the module to be called ``KDEPackageAppTemplates.cmake``). - Alex Merry On Dec. 15, 2015, 10:38 a.m., Marco Martin

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wro

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 84 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line84> > > > > Use ``KDE_INSTALL_KTEMPLATESDIR`` instead of > > ``

Re: Review Request 126185: Make the KAppTemplate CMake module global

it will package the templates and install them. But I'm not going to force your hand on this if you'd rather not do it that way. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 52 > > <https://git.reviewboard.kde.org/r/126185/diff/4/?file=421458#file421458line52> > > > > Honestly, I'd just use ARG as the prefix - you're in a function, i

Re: Review Request 126185: Make the KAppTemplate CMake module global

with that if you find the idea of writing a CMake-based unit test daunting, but you can look in the tests directory for inspiration. - Alex Merry On Dec. 9, 2015, 12:12 p.m., Marco Martin wrote: > > --- > This is an automatically generat

kdesrc-build setup for kdepim

The recent splitting of kdepimlibs has caused a clean run of kdesrc-build to fail on lots of pim modules. This seems to be a combination of kde-build-metadata not recording the dependencies properly for a lot of things, and "playground/pim" in the kdepim kdesrc-build include file being far too

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

vague message about Python and Gettext being needed. If you're going to take this approach, I think you still need to define k18n_install_ts_files in the else() branch, but make it spit out an error about exactly what package(s) are missing. - Alex Merry On Dec. 4, 2015, 12:

Re: Review Request 126185: Make the KAppTemplate CMake module global

r passing in the install destination as an argument, or at least allowing that as a possibility. The actual directory could (should?) be put into KDEInstallDirs.cmake as an extra variable. - Alex Merry On Dec. 3, 2015, 12:34

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 3, 2015, 11:49 p.m., Aleix Pol Gonzalez wrote: > > kde-modules/KDETemplateMacro.cmake, line 1 > > > > > > You might want to add documentation. > > > > You can get inspired with > >

Re: Purpose as a KDE Framework

On 2015-12-03 18:29, Aleix Pol wrote: On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: I'm trying to understand what Purpose is doing exactly. I've read the readme file, but i still can't quite figure out what it's doing or where i might be able to use it. Could you

Re: Updating techbase wiki page according to KF5 policies

On 2015-12-02 08:09, David Faure wrote: On Tuesday 01 December 2015 22:36:52 Alex Merry wrote: On 2015-12-01 15:34, Martin Walch wrote: > On Saturday, November 14, 2015 06:08:55 PM Alex Merry wrote: >> On 2015-11-14 01:21, Martin Walch wrote: >> > Alright, so I h

Re: KDE PIM Split?

On 2015-12-01 09:06, laurent Montel wrote: Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > El 1 dic 2015, a las 05:10, Ben Cooksley escribió: >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel wrote: >> >> Le lundi 30 novembre 2015,

Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/#review88966 --- Ship it! Ship It! - Alex Merry On Nov. 29, 2015, 8:59 p.m

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On 2015-11-28 21:53, René J. V. Bertin wrote: BTW, not that it's already being used, but is CMAKE_EXE_LINKER_FLAGS_INIT incremental or does one have to accumulate all elements first and use a single - DCMAKE_EXE_LINKER_FLAGS_INIT=XX argument? CMAKE_EXE_LINKER_FLAGS_INIT is a bit special.

Re: KXmlGui Patched for Deployment

On 2015-11-29 08:57, Cristian Oneț wrote: Hi, I was just building some KDE apps (using frameworks) on OSX and encountered the same problem for which we (me and Patrick von Reth) created the QStandardPaths patch at Randa in 2014 [1]. The solution you propose in this mail requires all

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On 2015-11-28 19:25, René J.V. Bertin wrote: On Saturday November 28 2015 15:29:00 David Faure wrote: Otherwise, the next best idea is to get ECM to add your activator to all link lines automatically, e.g. by adding it to CMAKE_EXE_LINKER_FLAGS or whatever. This for sure beats editing every

Re: Review Request 126161: OS X housekeeping

On 2015-11-26 09:27, René J.V. Bertin wrote: There's something I don't really understand though: the exact same question you asked above. What's the difference between starting kwrite directly on the commandline (or through execve()), and dlopen'ing it? Why does the code go through that on

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88691 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 1:57 a.m

Re: Review Request 126130: [kholidays] Qt5Core should be required, not Qt5Test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126130/#review88690 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 12:52

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88689 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 11:43

Re: Review Request 126056: Use KDE_INSTALL_ICONDIR to install the icons

tps://git.reviewboard.kde.org/r/126056/#comment60632> I suspect this call *does* actually need the absolute path. - Alex Merry On Nov. 17, 2015, 12:42 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126057/#review88500 --- Ship it! Ship It! - Alex Merry On Nov. 17, 2015, 12:45

Re: Updating techbase wiki page according to KF5 policies

On 2015-11-14 01:21, Martin Walch wrote: Alright, so I have created a stub at https://techbase.kde.org/Policies/Frameworks_Coding_Style Probably most other things have remained unchanged and can be copied over from https://techbase.kde.org/Policies/Kdelibs_Coding_Style So, if anything has

Re: Review Request 126057: Use KDE_INSTALL_FULL_ICONDIR to install the icons

compatibility for what you can pass on the cmake command line. Although I'd also get rid of the distinction between WIN32 and not WIN32 - it seems pretty pointless to me. - Alex Merry On Nov. 13, 2015, 6:04 p.m., Heiko Becker wrote

Re: Review Request 126058: Add .reviewboardrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126058/#review88338 --- Ship it! Ship It! - Alex Merry On Nov. 13, 2015, 6:08 p.m

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

the bit distinguishing WIN32 from other systems is unnecessary, there are no ``*.sh`` files to exclude from the install(), and install() doesn't need full paths anyway. That said, if you just want to commit what you have here, that's fine, too. - Alex Merry On Nov. 13, 2015, 6:05 p.m., Heiko

[kapidox] src: Make kgenframeworksapidox more robust.

Git commit 13a58615d0d49709345cc4dca8eef41b991dd2a2 by Alex Merry. Committed on 11/11/2015 at 23:51. Pushed by alexmerry into branch 'master'. Make kgenframeworksapidox more robust. It should be harder to break it with unusual or broken metainfo.yaml files now. CCMAIL: allen.d.win...@gmail.com

Re: Frameworks API documentation broken

On 2015-11-11 14:15, Allen Winter wrote: On Wednesday, November 11, 2015 08:13:17 AM Allen Winter wrote: On Wednesday, November 11, 2015 11:33:17 AM Martin Graesslin wrote: > Hi all, > > I just wanted to raise awareness of the fact that the Frameworks API > documentation on api.kde.org is

Re: kpackage: reasons not to use ecm_mark_nongui_executable?

On 2015-11-10 17:39, René J.V. Bertin wrote: Hi, I've just made the MacPorts packaging for the Package framework, and noticed that both the kpackagetool and the autotests are not defined "ecm_mark_nongui_executable". That means they're build as app bundles on OS X, which is counterproductive

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

On 2015-11-09 08:18, David Faure wrote: On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote: Does anybody have problems building rocs? It builds fine here but CI complains https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

On 2015-11-09 11:11, Alex Merry wrote: On 2015-11-09 08:18, David Faure wrote: On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote: Does anybody have problems building rocs? It builds fine here but CI complains https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5

Re: kf5 frameworks autotest alters KDE4 desktop workspace settings?!

On 2015-11-06 10:34, René J.V. Bertin wrote: Hi, I've been building KF5 frameworks to install under /opt/local on a KUbuntu 14.04 host running a KDE4 desktop, using the same packaging scripts I'm developing for Mac OS X (MacPorts; evidently with some modifications for using them on Linux). I'm

Re: Review Request 124714: Add support to qmake's options to api.kde.org

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/#review88165 --- Ship it! Ship It! - Alex Merry On Nov. 8, 2015, 1:21 a.m

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125969/#review88106 --- Ship it! Ship It! - Alex Merry On Nov. 6, 2015, 4 p.m

Re: Maintenance of api.kde.org

On 2015-11-05 09:22, Ben Cooksley wrote: Hi all, For some time it has been apparent that api.kde.org is experiencing some issues with maintenance. It doesn't really fall into sysadmin's domain, but developers often lack the knowledge on how to get Doxygen working as needed to build projects API

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

> On Nov. 5, 2015, 11:37 p.m., Alex Merry wrote: > > src/kdeinit/kinit.cpp, line 370 > > <https://git.reviewboard.kde.org/r/125969/diff/1/?file=415537#file415537line370> > > > > Why call fromRawData with an explicit strlen()? > > QByteArray(display

Re: Review Request 125969: kinit: fix Coverity issues + small optimization

/r/125969/#comment60429> This whole thing is unpleasantly C-ish, and a QByteArray or QVector would have been altogether nicer, but that would be a much bigger refactoring of the code. - Alex Merry On Nov. 5, 2015, 10:16 p.m., Nick Shafor

Re: Review Request 125960: Fix build of some projects using ecm_create_qm_loader()

the files are added to. Although I haven't looked at analitza's source code to be sure. - Alex Merry On Nov. 5, 2015, 2:36 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

On 2015-11-04 21:45, René J. V. Bertin wrote: René J. V. Bertin wrote: Alex Merry wrote: Looks like your include path is wrong. /opt/local/include/KF5/KArchive should be in the include path (before wherever wherever your kdelibs4 headers are). In fact: cd /opt/local/var/macports/build

Re: [OS X] "unknown type name 'KARCHIVE_DEPRECATED'" building kdoctools

On 2015-11-04 15:53, René J.V. Bertin wrote: Hi, Building KF5/kdoctools 5.15.0 on OS X, I run into 2 issues: - the #include statement finds the corresponding header from KDELibs4 - after changing the statement into #include (which I think it should be anyway?), I get the error In file

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

situation, so I say ship it. src/util/urlhandler.cpp (line 29) <https://git.reviewboard.kde.org/r/125815/#comment60402> Unused include - Alex Merry On Nov. 4, 2015, 5:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is a

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

tps://git.reviewboard.kde.org/r/125790/#comment60318> MimeTypes and Keys need to have the same number of entries. So you want "Keys": [ "psd", "psd" ], - Alex Merry On Oct. 25, 201

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

for mpyne to give it a once-over, though. - Alex Merry On Nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124714: Add support to qmake's options to api.kde.org

build system very well, but it seems to me that at least some of these might be able to go in the .pri file (and it might be possible to protect client projects from the need to set QT_NO_KEYWORDS). - Alex Merry On Aug. 12, 2015, 1:13 p.m., Lamarque Souza wrote

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

On 2015-11-03 00:56, Michael Pyne wrote: On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: Someone went a bit too far in the "port away from time_t to QDateTime" and changed the timestamp member of the KPixmapCacheIndexHeader struct. According to mpyne and thiago this is a big no-no.

Re: Review Request 125834: Generate code with QStringLiteral

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125834/#review87612 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 8:01 a.m

Re: Review Request 125830: Read protocol info from plugin metadata

icular is a case of easily eliminating a place people could make mistakes. It also allows the binaries to be freely renamed (although that's not an important feature, really). - Alex Merry On Oct. 27, 2015, 5:43 p.m., Christoph Cullmann

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. How about "KDE-KIO-Protocols"? I think having a KDE

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

d make that clearer in the KDEInstallDirs documentation... - Alex Merry On Oct. 26, 2015, 8:40 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 125590: Patch for kimageformats that handles xcfgz / xcfbz2 (compressed GIMP) images (read-only).

ps://git.reviewboard.kde.org/r/125590/#comment59991> Oops... copy-paste error :-) src/imageformats/xcf_compressed_p.h (lines 1 - 8) <https://git.reviewboard.kde.org/r/125590/#comment59993> Same comment as for license header in cpp file - Alex Merry On

Re: Review Request 125795: Add KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125795/#review87379 --- Ship it! Ship It! - Alex Merry On Oct. 25, 2015, 6:18 p.m

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b72fc5e56579035bf987075e16324ef95ef8e3d4 by Alex Merry to branch master. Repository: kparts Description --- When a part's main widget is destroyed, we should not delete the part immediately

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

matically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125711/#review87140 --- On Oct. 20, 2015, 8:33 a.m., Alex Merry wrote: > > --- > This is an automat

Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

under valgrind no longer produces a bunch of "invalid reads" from KHTMLPart when switching around between articles. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Re: Frameworks API documentation links to projects.kde.org

On 2015-10-19 10:58, Ben Cooksley wrote: Hi all, As you probably know, projects.kde.org is on it's way out. Can someone please terminate the links from the Frameworks API documentation to projects.kde.org, and have them send people to quickgit.kde.org to browse repositories instead?

Re: Policy for Dependencies

On 2015-10-19 17:53, Christoph Cullmann wrote: On Sunday, 18 October 2015 14:45:43 BST David Faure wrote: 2) A global switch "everything that can be optional, is now optional" sounds strange to me too. If it's optional, it's optional. (The description for the suggested

Re: Policy for Dependencies

On Sunday, 18 October 2015 14:45:43 BST David Faure wrote: > On Wednesday 14 October 2015 00:33:17 Christoph Cullmann wrote: > > Lets see what David thinks about all that. > > First: thanks everyone for waiting for my input, I appreciate that (I'm just > one more voice though, no dictatorship

Re: Policy for Dependencies

On 2015-10-13 16:54, Christoph Cullmann wrote: Hi, I'm not sure whether it's the best solution. The problem you try to fix with it is distros breaking packaging. I agree with Martin K that this is a huge problem and that it will happen - since the automation of packages I also experienced

Re: Review Request 125390: Fix build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125390/#review85933 --- Ship it! Ship It! - Alex Merry On Sept. 25, 2015, 11:08

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On 2015-09-14 00:42, Kurt Hindenburg wrote: On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: Hi devs, the other day I had built version 5.13 successfully on a OSX/MacPorts-based VM. And so I wanted to try the same with the newest 5.14 just now, but failed! :( Any

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

to the reviewers (or someone else familiar with Linux library packaging) to confirm that it won't cause compatilibity issues? - Alex Merry On Aug. 23, 2015, 1:02 p.m., Hanspeter Niederstrasser wrote: --- This is an automatically generated e-mail

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: Thanks. I will commit it for you. David Rosca wrote: But I need your full name. Armin K. wrote: I've used Armin K. all the time I've been online and nobody has complained when using it in git commits. I don't feel comfortable

Re: Review Request 124736: Add Windows support.

you've left in that should be removed. CMakeLists.txt (line 23) https://git.reviewboard.kde.org/r/124736/#comment58096 Debugging line should go CMakeLists.txt (line 27) https://git.reviewboard.kde.org/r/124736/#comment58097 Debugging line should go - Alex Merry On Aug. 14, 2015

Re: Review Request 124623: Allow multiple entries in the maintainers field

marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- Allow multiple entries in the maintainers field Diffs - src/kapidox/data/templates/fwinfo.html 647baec06aa0d5df20ff6afdc9313dceabe15e02 src/kapidox/data/templates

Re: Review Request 124636: Remove DDS and JPEG-2000 plugin

(`autotests/read/jp2` and `autotests/write/*.jp2`). - Alex Merry On Aug. 5, 2015, 10:11 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124636

Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

://git.reviewboard.kde.org/r/124607/#comment57662 Why have a bool return type on an internal method, when no call actually uses that value? - Alex Merry On Aug. 3, 2015, 10:39 p.m., David Faure wrote: --- This is an automatically generated e-mail

Review Request 124623: Allow multiple entries in the maintainers field

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124623/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox

Re: [kwallet] /: Updating maintainer name

August 2015 11:16:17 Lamarque Souza wrote: Does the maintainer field accept more than one identity? That's the question. Go ahead and do that, Alex Merry volunteered to fix kapidox if necessary :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: [kwallet] /: Updating maintainer name

On Sunday 02 August 2015 19:31:36 David Faure wrote: Are you sure about this? All other frameworks use the identity login name there. This makes it possible (e.g. for api.kde.org) to determine full name and email. I just noticed that modemmanager-qt and networkmanager-qt do it wrong -

Re: Does frameworks allow move semantics unconditionally?

On Friday 31 July 2015 15:11:56 Alex Merry wrote: So when you say move semantics, what does that encompass? You can use rvalue references in 2010 just fine, but someone would need to check that Qt detects that properly and provides appropriate overloads of various methods, and you may not get

Re: Does frameworks allow move semantics unconditionally?

On Friday 31 July 2015 19:15:55 Mark Gaiser wrote: Hi Alex, What i mean with move semantics are mainly the following features: - std::move - move copy constructor - move assignment operator I know std::move is in vs2010, i'm just not so sure about the move copy and assignment operator.

Re: Review Request 124542: CMake fixes for Windows build

bug in cmake). Actually it could be that this interprets the string as a list or vice versa in which case the problem could be before this, at the time where this module sets CMAKE_MODULE_PATH (toplevel file?) Alex Merry wrote: See my comment above. This change

Re: Review Request 124542: CMake fixes for Windows build

On July 31, 2015, 5:19 p.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 I can't see how setting a variable to itself can possibly change anything, or make any sense (other than an extremely weird

Re: Review Request 124542: CMake fixes for Windows build

On July 31, 2015, 8:18 a.m., David Faure wrote: src/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20 no-op? Kevin Funk wrote: Not a no-op, this code is written into cmake_install which is used for the 'install' target.

Re: Review Request 124542: CMake fixes for Windows build

bug in cmake). Actually it could be that this interprets the string as a list or vice versa in which case the problem could be before this, at the time where this module sets CMAKE_MODULE_PATH (toplevel file?) Alex Merry wrote: See my comment above. This change

Re: date + releaseinfo in frameworks docbooks

On Wednesday 29 July 2015 15:40:22 Burkhard Lück wrote: Hi Frameworks devels, a lot of frameworks manpage docbooks have wrong date entries (pre kf5) or strange release entries like 0.01.01 or missing entry, see comments on

Review Request 124482: Search for required perl modules.

installed, the REQUIRED packages found list includes: * PerlModules , http://www.cpan.org Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124482: Search for required perl modules.

/CMakeLists.txt:4 (kdoctools_encode_uri) -- Configuring incomplete, errors occurred! With perl-uri installed, the REQUIRED packages found list includes: * PerlModules , http://www.cpan.org Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review82733 --- Ship it! Ship It! - Alex Merry On May 26, 2015, 8:04 p.m

  1   2   3   4   5   6   7   8   9   10   >