D28861: Sonnet add Malayalam trigram

2021-05-02 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Pushed in https://invent.kde.org/frameworks/sonnet/commit/6eb2c6392548772b2c594dfebf0ec53b9a8635d7 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28861 To:

Re: KF6 meeting notes 2021-04-24

2021-05-01 Thread David Faure
> > to switch the default to 24x24 (instead of 22x22) > > https://phabricator.kde.org/T14397 > > -> people are going to look which code is potentially affected this > > change. On the Frameworks side, it only affects the "when" to switch the > > size > > > > > > For the next meetings: there are tasks which would benefit from having > > around: > > > > - Kai Uwe (https://phabricator.kde.org/T12536 , > > https://phabricator.kde.org/T11833 , https://phabricator.kde.org/T11875 , > > https://phabricator.kde.org/T12008 ) > > > > - more Davids (https://phabricator.kde.org/T12275, > > https://phabricator.kde.org/T12542, etc etc etc) > > > > so if you match the description above and read this, please try to be > > around next time! > > > > Ciao > > -- > > Luigi -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.15 - Build # 58 - Still Unstable!

2021-05-01 Thread David Faure
nals > autotests 100% (5/5) 100% (5/5) 89% (382/427) 55% (243/438) > src 100% (12/12)100% (12/12)65% (1580/2444) 46% (717/1547) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2021-04-14 Thread David Faure
dfaure abandoned this revision. dfaure added a comment. This has been done meanwhile. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2021-04-14 Thread David Faure
dfaure commandeered this revision. dfaure edited reviewers, added: dvratil; removed: dfaure. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dfaure, #frameworks, davidedmundson, dvratil Cc:

Today's meeting

2021-04-10 Thread David Faure
Hi everyone, I will not be available today for the meeting. Can someone else drive the discussions? [Or exceptionally we could move the meeting to Sunday.] Reminder: today's agenda is: - KGlobalAccel (T12063) - KPluginInfo kcmservices (T13555) - KSelectAction (T12097) -- David Faure, fa

Re: KNotifications usage

2021-04-04 Thread David Faure
vironment variable so it points to the install prefix for KF5 (KNotifications specifically, if you installed it by hand). In other words, you want to set QMAKEPATH so that $QMAKEPATH/mkspecs/modules/qt_KNotifications.pri exists. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE F

Re: KNotifications usage

2021-04-04 Thread David Faure
cmake way. Of course before that you need find_package(KF5Notifications CONFIG REQUIRED) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KF6 sprint meeting notes 2021-04-03

2021-04-03 Thread David Faure
On samedi 3 avril 2021 22:42:36 CEST Ben Cooksley wrote: > On Sun, Apr 4, 2021 at 2:18 AM David Faure wrote: > > Here are the notes from today's meeting (thanks Luigi ) > > > > Feature deprecation process > > = > > - when to deprecate a fe

KF6 sprint meeting notes 2021-04-03

2021-04-03 Thread David Faure
eek! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Requiring Qt 5.15 for KDE Frameworks 5?

2021-03-27 Thread David Faure
On samedi 27 mars 2021 17:07:14 CET Nicolás Alvarez wrote: > > El 27 mar. 2021, a la(s) 12:30, Fabian Vogt > > escribió: Moin, > > > > Am Samstag, 27. M?rz 2021, 14:11:38 CET schrieb David Faure: > >>>>> On samedi 27 mars 2021 12:51:37 CET

Re: Requiring Qt 5.15 for KDE Frameworks 5?

2021-03-27 Thread David Faure
at? While at it, can we also get your feedback on * Requiring C++17 * Requiring CMake >= 3.16 Obviously this only matters for distributions that update KF5 every month. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D14967: Disable loading of translations for kformattest, which was not designed with translations

2021-02-18 Thread David Faure
dfaure added a comment. CI runs things in a sandbox, there are no translations installed that are accessible to kf5 tests. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14967 To: habacker, dfaure, aacid Cc: asturmlechner, kde-frameworks-devel, LeGast00n,

Re: Should syntax-higlighting get 5.79.1 released with the control flow color fix?

2021-02-16 Thread David Faure
month. > > I would have no issues with a .1, > guess I am just to ignorant for color changes. Done: syntax-highlighting v5.79.1 c4bb26684bd2ec8054623929f3196c6233c5e157 b2825ebee4c527f96562d18abb553195809dcc32174a4b998c71850e24527990 sources/syntax-highlighting-5.79.1.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-02-06 Thread David Faure
, all with changed & XCB_XKB_NKN_DETAIL_KEYCODES, which makes kglobalaccel ungrab+regrab all keys. Should I add another compression timer in kglobalaccel, or do you think this is fixable in setxkbmap? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: RFC: relative executables in desktop files

2021-01-31 Thread David Faure
On dimanche 10 mai 2020 19:17:01 CET Aleix Pol wrote: > On Sun, Apr 26, 2020 at 1:36 PM David Faure wrote: > > During the review of https://phabricator.kde.org/D29170 the following > > question surfaced again: should it be possible for a desktop file to > > r

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-01-31 Thread David Faure
st option though. Now I'm thinking maybe the compression should happen in the keyboard module... ? That wouldn't fix the xmodmap issue though. Maybe we're seeing a N devices * M keys multiplication issue, i.e. it would be good to compress at both levels. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-01-30 Thread David Faure
On dimanche 31 janvier 2021 00:39:38 CET Albert Astals Cid wrote: > El dissabte, 30 de gener de 2021, a les 18:32:32 CET, David Faure va escriure: > > For years, I've noticed that when resuming a laptop from sleep, > > kglobalaccel and X11 use 100% CPU for a few minutes, ma

Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-01-30 Thread David Faure
but that would be a "fix without really understanding the code", never good. I just noticed https://phabricator.kde.org/D16434 so CC'ing Fabian :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-30 Thread David Faure
not before week 10 or even better not before week 13. I can do any weekend except week 9 (= March 6-7) (and weeks 16 & 17 but hopefully we'll do it much before that). European hours OK but American hours work for me too, I get up late and finish late in the evenings :-) -- D

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2021-01-10 Thread David Faure
dfaure added a comment. Thanks Alex, you rock. TASK DETAIL https://phabricator.kde.org/T12173 To: dfaure Cc: alex, #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, cordlandwehr,

Plasma Framework and Kirigami unittests

2021-01-02 Thread David Faure
EQt514/autotests/tst_avatar_qml/ I think that one is for Carson Black, CC'ed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

2020-12-26 Thread David Faure
dfaure added a comment. So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any reason against going with D29136 after all? REPOSITORY

Re: KDE review for KWeatherCore

2020-12-25 Thread David Faure
y blowing up to 105 km/h at the very moment) :) Feel free to grab any code from qrpiweather that might be useful, BTW. The backend I ended up using was "Open Weather" (api.openweathermap.org). But well, that was 4 years ago, things might have changed since :) -- David Faure, fa...@kde.org

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-17 Thread David Faure
On jeudi 17 décembre 2020 00:20:41 CET Friedrich W. H. Kossebau wrote: > Hi, > > Am Samstag, 12. Dezember 2020, 22:25:32 CET schrieb David Faure: > > Just a data point on this discussion. Every time we raise the min Qt > > version, we make life easier for KDE developers, and

Re: Problem with ksycoca not being regenerated under flatpak

2020-12-12 Thread David Faure
lly "touch" a directory after adding new files? Otherwise, the hack you have in mind could be implemented as in the attached patch. Untested, except that it compiles. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 diff --git i/src/sycoca/ksycoca.cpp w/sr

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-12 Thread David Faure
://github.com/osm-fr/osmose-backend/issues/555 for the curious PS: I agree with moving the dates for bumping the min req to just after a KF5 release, this makes complete sense, feel free to make that adjustment. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-06 Thread David Faure
e? CC'ing kde-free...@kde.org, I know it's not the same, but maybe you guys know? ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D22764: Stabilize test KFileWidgetTest::testDropFile

2020-11-30 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > meven wrote in kfilewidgettest.cpp:481 > Let me know if I should relay you. I thought I did that in commit eb18397fe525d2e4bd9 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc:

Re: Merge tags in master branch?

2020-11-28 Thread David Faure
mes when I started doing KF5 releases. But it hasn't happened for a long while so maybe there's now a git hook or something, to prevent that from happening? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D17816: Support for xattrs on kio copy/move

2020-11-18 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > There are other parts of code that are guarded with `HAVE_POSIX_ACL`s, and > these aren't enabled ATM for FreeBSD. So, the change is needed and I'm > willing to implement it. > > I plan to move

XDG_STATE_HOME

2020-11-07 Thread David Faure
, open files, undo history, …) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D17816: Support for xattrs on kio copy/move

2020-10-30 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > > 1. enable the ACL stuff on systems with extattr, see the little bit of code > > in kpropertiesdialog.cpp > > By that you mean that I should edit the CMake module to define > `HAVE_POSIX_ACL` when

D17816: Support for xattrs on kio copy/move

2020-10-29 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > arrowd wrote in ConfigureChecks.cmake:12 > > Has this been tested on a system with sys/extattr.h? > > I was working on this revision on such system all the time. FreeBSD contains > extattr bits in its `libc`, so no

D17816: Support for xattrs on kio copy/move

2020-10-28 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:12 > check_include_files(limits.h HAVE_LIMITS_H) > +check_include_files(sys/xattr.h HAVE_SYS_XATTR_H) > +check_include_files("sys/types.h;sys/extattr.h" HAVE_SYS_EXTATTR_H) This is already done by

Re: Dropping the moderation by default flag

2020-10-23 Thread David Faure
core-devel and kde-frameworks-devel are similar, could you > please set that same setting for kde-core-devel too? > > Thanks. :) Done. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-18 Thread David Faure
/Dependency%20Build%20Extragear% > 20stable-kf5-qt5%20WindowsMSVCQt5.15/lastFailedBuild/console That looks like the usual java timeout I re-ran the exact same job and it passed. Can you re-enable normal CI service for Windows? I noticed e.g. that KIO tests were not run anymore... -- David

D22764: Stabilize test KFileWidgetTest::testDropFile

2020-10-18 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:481 > +KDirLister *dirLister = fileWidget.dirOperator()->dirLister(); > +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url))); > + For the record, this is broken, it should have been `completed(QUrl)`.

breeze-icons tests broken

2020-10-11 Thread David Faure
in the scalable directory maybe? Please everyone, keep an eye on your own project (either via the mails sent to kde-frameworks-devel, or by visiting build.kde.org), so I don't have to be the unittest police. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-09-12 Thread David Faure
dfaure added a comment. In D29299#676447 , @pino wrote: > In D29299#676446 , @dfaure wrote: > > > In D29299#676445 , @pino wrote: > > > > > > > > >

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-09-12 Thread David Faure
dfaure added a comment. In D29299#676445 , @pino wrote: > I asked for actual **valid** use cases when using the new variables first would break, and I still got none. There is a limit to how much you can keep broken code working... assuming

D29136: Use non-deprecated KDEInstallDir

2020-09-12 Thread David Faure
dfaure added a comment. (to remove some confusion: the previous comment had the wrong link and should have said "Abandoned in favour of https://phabricator.kde.org/D29299; -- but now it's reopened anyway, as an alternative to D29299 ) REPOSITORY R249

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-09-12 Thread David Faure
dfaure added a comment. @pino Other than the fact that you think D29136 is "good enough", do you have any concrete objection to this version? My own objection would simply be that "backward-compatible fallback" is a bit too strongly worded; it reads

General information for KDE Frameworks developers

2020-09-09 Thread David Faure
d.kde.org/job/Frameworks/view/Everything/ then click on the platform you're interesting in, and then click on the "S" column twice. The yellow will propagate to the top. Happy hacking! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-29 Thread David Faure
dfaure accepted this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-27 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > thumbnail.cpp:741 > +bool allowCache; > +allowCache = sharesFilesystemWithThumbRoot(filePath); > +if (!allowCache) { join with previous line (this isn't C) ;) > thumbnail.h:95 > +#ifndef Q_OS_WIN >

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-22 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > How about I set it to -1 at start and check for that instead? I checked > definitions and it looks like dev_st is unsigned, but it shouldn't be a > problem. -1 isn't exactly a great value for an unsigned int

Re: kwayland's testRemoteAccess still flaky

2020-08-22 Thread David Faure
Qt5.15/14/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-08-21 Thread David Faure
0% (0/108) > > > > src.view > > 88% (15/17) > > 88% (15/17) > > 57% (3794/6612) > > 43% (1663/3884) > > > > src.vimode > > 100% (30/30) > > 100% (30/30) > > 81% (1899/2333) > > 61% (979/1599) > > > > src.vimode.config > > 0% (0/1) > > 0% (0/1) > > 0% (0/120) > > 0% (0/76) > > > > src.vimode.emulatedcommandbar > > 100% (13/13) > > 100% (13/13) > > 98% (897/917) > > 90% (588/652) > > > > src.vimode.modes > > 100% (10/10) > > 100% (10/10) > > 87% (3266/3761) > > 79% (1884/2374) > > > > Links: > > -- > > [1] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/abi-compatibility-results.yaml [2] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/acc/KF5TextEditor-5.72.0.xml [3] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/compat_reports/KF5TextEditor_compat_report.html [4] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .15/4/artifact/logs/KF5TextEditor/5.72.0/log.txt -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-21 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > If st_dev cannot be 0 on successful call of lstat, I don't think there's need > to change anything. m_thumbnailDirDeviceId will remain zero only if lstat > returns error and as long it's zero

D28745: Skip caching thumbnails on encrypted filesystems

2020-08-19 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > No. The m_thumbnailDirDeviceId is set to 0 and only changed if lstat executes > properly. Then it takes value of

Re: KIO on Android Failure

2020-08-19 Thread David Faure
why I didn't notice this problem. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks :-) BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > krecentfilesmenu.cpp:74 > +{ > +action = new QAction(titleWithSensibleWidth(qobject_cast *>(menu->parent(; > +QObject::connect(action, ::triggered, action, [this, menu]() > { QMenu is a QWidget. Why not just pass `menu` as

Re: Dropping the moderation by default flag

2020-08-11 Thread David Faure
ve > the moderator password, not the owner password. > > Please owner[s], can you disable this? > > I *think* it's the "By default, should new list member postings be > moderated?" in "Privacy options..." -> "Sender filters". Done. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-08 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. A unittest would be useful too, especially if we then refactor the loading to use KIO jobs. But after 6 months, let's land this and keep working on it. Are you interested in writing

kirigami unittests broken

2020-08-06 Thread David Faure
/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512/autotests/tst_actiontoolbar_qml/ [1] https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kirigami/job/kf5-qt5%20SUSEQt5.12/557/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 33 - Fixed!

2020-08-06 Thread David Faure
On jeudi 6 août 2020 10:48:19 CEST CI System wrote: > BUILD SUCCESS > Build > URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20Free \o/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-02 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > nicolasfella wrote in krecentfilesmenu.cpp:150 > I'm wondering how to best make this async without selling my soul to the > mulitthreading devil. QtConcurrent::filtered looks interesting, but depending > on QtConcurrent wouldn't be feasible,

kwayland's testRemoteAccess still flaky

2020-08-01 Thread David Faure
look? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: xml_mimetypes5 and kcoreaddons

2020-07-19 Thread David Faure
On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell > >

Re: Frameworks support for Qt 5.12

2020-07-19 Thread David Faure
minimum required version 12 months after Qt 5.15, i.e. on 26 May 2021 * Qt 5.15 LTS will be the minimum required version 18 months after its release, i.e. on 26 Nov 2021 https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: xml_mimetypes5 and kcoreaddons

2020-07-14 Thread David Faure
ypes/XmlMessages.sh to rename > it. Fine with me, but don't we have more cases of the same kind, with different names? Any case of translations being "integrated" into some file leads to this. Desktop files, mimetype XML, is there really nothing else? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-07 Thread David Faure
On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: > On 2020-07-07 12:16, David Faure wrote: > > Yep :( > > > > You'll tell Simon and/or QTBUG-*? > > I will take a look if I can find some existing bug or open a new. > > Simon left Qt, or? Yes but

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-07 Thread David Faure
t; > > > src.variableeditor > > 0% (0/5) > > 0% (0/5) > > 0% (0/579) > > 0% (0/108) > > > > src.view > > 88% (15/17) > >

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2020-07-06 Thread David Faure
dfaure added a comment. Only if you can find a way to change BatchRenameJob in a binary and behaviour compatible way. And then it will be a dual-headed thing with two modes of operations, awful. All this sounds to me like much more trouble than writing a different job. REPOSITORY R241

Re: ThumbSequenceCreator in KIO not working properly

2020-07-04 Thread David Faure
hin people on kfm-devel about how Dolphin could be changed to use DelegateAnimationHandler, possibly? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

inotify on FreeBSD

2020-07-04 Thread David Faure
on FreeBSD? [1] https://build.kde.org/job/Frameworks/view/Platform%20-%20FreeBSDQt5.15/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/9/testReport/projectroot/autotests/kdirwatch_inotify_unittest/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Shift for parts of the CI system to Qt 5.15

2020-06-21 Thread David Faure
.15/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Add loop device interface to Solid framework

2020-06-13 Thread David Faure
scope question, maybe ervin will be willing to provide some input :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D26342: Allow overriding to disable auto language detection

2020-06-13 Thread David Faure
dfaure added a comment. In D26342#675180 , @aacid wrote: > In D26342#675164 , @sdepiets wrote: > > > I don't think that's a regression, in the previous behavior you could try to set any language to

D26342: Allow overriding to disable auto language detection

2020-06-13 Thread David Faure
dfaure added a comment. This actually breaks language auto-detection for me in the KMail composer. Testcase: - New Mail - I type "Bonjour," in the body Before: It's detected as French and not underlined as a typo After: The language remains English, and the word is

Re: Opening files by mimetype instead of by file extension

2020-06-10 Thread David Faure
han XXX > because you can't do this" What does "list by mimetype" mean exactly? Is this about a mimetype column in the table/tree view? (missing) Is this about the filter combobox showing mimetypes? (supported) Or is it something else? -- David Faure, fa...@kde.org, http

D29810: Don't use the setenv function after fork

2020-06-07 Thread David Faure
dfaure added a comment. This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/ REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol,

D29810: Don't use the setenv function after fork

2020-06-07 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KRunProxy

2020-06-06 Thread David Faure
/search?_filestring=*.qml&_string=KRun Am I doing this wrong? Are there other file extensions to take into consideration? If not, can I deprecate KRunProxy? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29809: Don't invoke qstring localized stuff in critical section

2020-06-06 Thread David Faure
dfaure added a comment. Done in https://invent.kde.org/frameworks/kcrash/commit/c315685f0e0920e8847afe12c97fbbe4653eb351 REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29809: Don't invoke qstring localized stuff in critical section

2020-06-06 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R285:c315685f0e09: Dont invoke qstring localized stuff in critical section (authored by dfaure). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29809?vs=83231=83233

D29814: Fix segfault on no restart args

2020-06-06 Thread David Faure
dfaure added a comment. This question is still without an answer: "Can you explain how to trigger this crash in the first place? Which application triggers it?" REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc:

D29809: Don't invoke qstring localized stuff in critical section

2020-06-06 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29814: Fix segfault on no restart args

2020-06-06 Thread David Faure
dfaure added a comment. This commit seems to include the changes requested in the other review... REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29809: Don't invoke qstring localized stuff in critical section

2020-06-06 Thread David Faure
dfaure added a comment. The changes you mention don't appear in phabricator. I suggest amending your commit locally (so there's only one) and then arc diff HEAD~ REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29809 To: jpalecek, #frameworks, dfaure Cc:

D18915: Fix batchrename changing extension to lower case

2020-06-02 Thread David Faure
dfaure added a comment. The fix will be in 5.15.1. Can you add Qt version checks if you intend to keep the KIO workaround? Or we just say it's fixed in Qt and we discard this. Your choice. But the unittest would make sense to keep (with Qt version checks, if there's no workaround).

D18915: Fix batchrename changing extension to lower case

2020-06-01 Thread David Faure
dfaure added a comment. The fix landed in dev. I now uploaded a backport to 5.15 for review. https://codereview.qt-project.org/c/qt/qtbase/+/302532 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji, dfaure Cc:

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-30 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO BRANCH arcpatch-D26113 REVISION DETAIL https://phabricator.kde.org/D26113 To: meven, #frameworks, ngraham, dfaure Cc: dfaure, feverfew, bruns, broulik,

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-29 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I have modified DesktopExecParser in kio commit d1e9325fba37eddb9cb44173edfc1fee122a0c57 to return an

D26113: Places: Use Solid::Device::DisplayName for DisplayRole

2020-05-29 Thread David Faure
dfaure added a comment. Please check that kfileplacesmodeltest and kfileplacesviewtest still pass. (they fail here with baloosearch: stuff for some reason, I didn't investigate; but it passes on CI) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113 To: meven,

D29814: Fix segfault on no restart args

2020-05-29 Thread David Faure
dfaure added a comment. Can you explain how to trigger this crash in the first place? Which application triggers it? INLINE COMMENTS > jpalecek wrote in kcrash.cpp:272 > Well I was thinking about `resize()`, then found there wasn't any. However, > if we want to be clear, maybe `args = {

D29814: Fix segfault on no restart args

2020-05-27 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm a bit confused by the bug this is fixing. Surely this doesn't happen to all cases of crashes without autorestart enabled?? Also, it sounds like a null check might be

D29810: Don't use the setenv function after fork

2020-05-27 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack,

D29809: Don't invoke qstring localized stuff in critical section

2020-05-27 Thread David Faure
dfaure added a comment. Makes sense; just two minor things. INLINE COMMENTS > kcrash.cpp:95 > +#ifdef Q_OS_LINUX > +QByteArray socketpath; > +#endif prepend `static`, it's only used in this file. > kcrash.cpp:662 > > -// Create socket path to transfer ptrace scope and open

D29668: Do not reject icon theme dir with invalid context/type.

2020-05-26 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kicontheme.cpp:761 > } else if (tmp.isEmpty()) { > // do nothing. key not required > } else { (OK, if this key is not required then surely

Re: Recent breakage in kwallet

2020-05-26 Thread David Faure
Thanks for the pointer. Pretty sure it's wrong, but I'll reply there. On mardi 26 mai 2020 09:31:26 CEST Marco Martin wrote: > would the recent patch > https://invent.kde.org/frameworks/kwallet/-/merge_requests/1 > fix anything? > > On Sat, May 16, 2020 at 10:40 AM Dav

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-25 Thread David Faure
gt; > 88% (15/17) > > 88% (15/17) > > 57% (3782/6599) > > 43% (1661/3880) > > > > src.vimode > > 100% (30/30) > > 100% (30/30) > > 81% (1898/2332) > > 61% (979/1599) > > > > src.vimode.config > > 0% (0/1) > > 0% (0/1) > > 0% (0/120) > > 0% (0/76) > > > > src.vimode.emulatedcommandbar > > 100% (12/12) > > 100% (12/12) > > 98% (896/916) > > 90% (588/652) > > > > src.vimode.modes > > 100% (10/10) > > 100% (10/10) > > 87% (3266/3761) > > 79% (1884/2374) > > > > Links: > > -- > > [1] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .14/19/artifact/abi-compatibility-results.yaml [2] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .14/19/artifact/acc/KF5TextEditor-5.71.0.xml [3] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .14/19/artifact/compat_reports/KF5TextEditor_compat_report.html [4] > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5 > > .14/19/artifact/logs/KF5TextEditor/5.71.0/log.txt -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread David Faure
dfaure added a comment. @meven you're confusing me with my clone @ervin. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabdevice.cpp:73 > +if (m_displayName.isEmpty()) { > +QStringList currentMountPoints = > FstabHandling::currentMountPoints(m_device); > +

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread David Faure
dfaure added a comment. https://invent.kde.org/frameworks/kcmutils/-/merge_requests/2 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: ahmadsamir, rikmills, wbauer, kossebau, svuorela,

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

2020-05-17 Thread David Faure
dfaure added a comment. (Intrusive) fix is up at https://invent.kde.org/frameworks/kio/-/merge_requests/3 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29738 To: marten, #frameworks, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >