D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-10 Thread David Faure
dfaure closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16674 To: dfaure, akrutzler, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-10 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenamedialog.cpp:38 > +#include > +#include > +#include Remove all the framework prefixes. E.g. this should be . This way, it fails to find the

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

2018-11-10 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ftp.cpp:1240 > if (!isfile) { > -ftpFolder(remoteEncoding()->directory(url), false);// ignore > errors > +const QString parentDir =

D7380: KCD: use modern logging classes throughout

2018-11-10 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > dfaure wrote in testkcd.cpp:64 > There's proper API for setting applications defaults, without the need for > env vars. My comment is still valid: why doesn't this use QLoggingCategory::setFilterRules() instead? > rjvbb wrote in testkcd.cpp:69

D16798: KPluginFactory: fix create() apidox

2018-11-10 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D16798 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16798: KPluginFactory: fix create() apidox

2018-11-10 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpluginfactory.h:347 > * Use this method to create an object. It will try to create an object > which inherits > - * \p T. If it has multiple

D16744: Fix crash if XDG_CACHE_HOME directory is too small or out of space

2018-11-07 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. switch would require ugly fall-through, I prefer this code. REPOSITORY R244 KCoreAddons BRANCH bug400610 REVISION DETAIL https://phabricator.kde.org/D16744 To: alexeymin, dfaure,

D16674: MTP: fix runtime warning when showing a warning to the user.

2018-11-04 Thread David Faure
dfaure created this revision. dfaure added reviewers: akrutzler, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald edited subscribers, added: kfm-devel, kde-frameworks-devel; removed: Dolphin. dfaure requested review of this revision. REVISION SUMMARY KIO says the following:

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2018-11-04 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This map will keep growing and growing... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame Cc:

D16349: [kdirlistertest] Wait a little longer for the lister to finish

2018-10-22 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks!! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16349 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH oob REVISION DETAIL https://phabricator.kde.org/D16306 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-14 Thread David Faure
dfaure added a comment. You're right. Fixed, thanks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. See also https://phabricator.kde.org/D16183 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure Cc: dfaure,

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-14 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15510: Introduce HKDF

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code. REPOSITORY R486 QCA Library BRANCH master REVISION DETAIL

D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good, but this might be worth fixing in QTest::qWaitForWindowActive itself, for all other unittests using that (including Qt's own). REPOSITORY R241 KIO REVISION DETAIL

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-13 Thread David Faure
dfaure updated this revision to Diff 43555. dfaure added a comment. add bug number REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16183?vs=43553=43555 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16183 AFFECTED FILES src/kcrash.cpp

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-13 Thread David Faure
dfaure created this revision. dfaure added reviewers: heikobecker, aacid, sitter. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY For instance in kio_help. The right fix

D16141: Disable unmount option for / or /home

2018-10-12 Thread David Faure
dfaure added a comment. +1 This whole method could put placesModel->url(index) into a local variable to avoid calling it so many times, though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: dfaure, broulik, ngraham,

Re: DBus thread shutdown issue on Windows

2018-10-11 Thread David Faure
LD_KSSLD=OFF) but we would still have client code trying to contact it, possibly generating many errors about not being able to do that. Well. Do you want to try it in CI to see what happens? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 diff --git i/CMake

Re: kiowidgets_kdirmodeltest fail

2018-10-10 Thread David Faure
t correct, you can only use a QModelIndex when you just got it or > when it's passed it to you, if you need to store it you need to use > QPersistentModelIndex. > > I don't understand much the test, but i think the attached patch is a good > fix, i.e. use the model indexes as soon as they happ

Re: DBus thread shutdown issue on Windows

2018-10-10 Thread David Faure
[Adjusting CC list] On mercredi 10 octobre 2018 11:55:01 CEST Ben Cooksley wrote: > On Thu, Oct 4, 2018 at 3:15 PM Thiago Macieira > > wrote: > > On Wednesday, 3 October 2018 18:12:08 PDT David Faure wrote: > > > On another note, if Qt knows this part of Windows is brok

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

2018-10-08 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16020 To: dfaure, jtamate Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Properties' entry in the places panel context menu

2018-10-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham, dfaure Cc: dfaure, elvisangelaccio,

D15510: Introduce HKDF

2018-10-07 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qca_basic.h:1081 > > +class QCA_EXPORT HKDF : public Algorithm > +{ Missing class documentation. Missing \since tag. > qca-botan.cpp:234 > +public: > +

D15973: Add a 'Propreties' entry in the places panel context menu

2018-10-07 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodel.cpp:957 > > +void KFilePlacesModel::requestProperties(const QModelIndex , QWidget > *parent) > +{ Why is this in the model, rather than

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-10-07 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. +2, assuming the commit log doesn't have M$ anymore (the phab review does, but you don't use arc apparently so I guess the two things are unrelated) REPOSITORY R241 KIO REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-10-07 Thread David Faure
dfaure added a reviewer: ossi. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

2018-10-07 Thread David Faure
dfaure added a comment. This looks like the kind of commit where a review by Oswald Buddenhagen would be useful. INLINE COMMENTS > kcrash.cpp:672 > +// wait while DrKonqi is running and the socket connection > exists > +while (kill(pid, 0) >= 0 &&

D16007: [KNewFileMenu] Don't open an empty QFile

2018-10-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16007 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

2018-10-07 Thread David Faure
dfaure added a comment. I don't really know, but see https://phabricator.kde.org/D4254 for the full reasoning of the unittest. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: dfaure, bruns, abetts, alex-l,

D14072: Don't try to restore invalid user places

2018-10-07 Thread David Faure
dfaure added a comment. Possible fix in https://phabricator.kde.org/D16020 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

2018-10-07 Thread David Faure
dfaure created this revision. dfaure added a reviewer: jtamate. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. TEST PLAN kfileplacesmodeltest REPOSITORY R241 KIO BRANCH master

D14072: Don't try to restore invalid user places

2018-10-07 Thread David Faure
dfaure added a comment. More generally, please please run the unittests after changing a class. I hate that I currently am the one doing this, on the day of the release, which forces me to bugfix such things, or delay the release. REPOSITORY R241 KIO REVISION DETAIL

D14072: Don't try to restore invalid user places

2018-10-07 Thread David Faure
dfaure added a comment. This commit breaks kfileplacesmodeltest. $ bin/kfileplacesmodeltest testInitialState testInitialList testInternalBookmarksHaveIds - Start testing of KFilePlacesModelTest * Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64

D15968: kreadconfig: make the tool slightly more useful

2018-10-07 Thread David Faure
dfaure added a comment. Will you port the kreadconfig usage in startkde to add --ignore-globals --ignore-cascading in order to preserve performance? Maybe it would be better to preserve behaviour compatibility and rather make globals and cascading "opt in"? REPOSITORY R237 KConfig

D15947: Start drawing emblems in the bottom-right corner

2018-10-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH emblems-start-in-bottom-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D15947 To: ngraham, #vdg, dfaure Cc: kde-frameworks-devel, michaelh,

D11880: Add firewall-config and firewall-applet icons

2018-10-06 Thread David Faure
dfaure added a comment. This commit breaks the unittest "scalabletest" : FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory: firewall-applet-panic firewall-applet firewall-applet-error

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-10-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Great stuff. Only found some typos and very minor things, feel free to fix and push. INLINE COMMENTS > mtpdevice.cpp:119 > +{ > +QList list; > +for (const MTPStorage *storage : m_storages) { Technically this is missing a

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread David Faure
dfaure added a comment. I guess the implicit part of the question is "what if kio-extras isn't installed ?". I assume it will lead to a broken item. So this should probably use a check like `KProtocolInfo::isKnownProtocol("recentdocuments")` REPOSITORY R241 KIO REVISION DETAIL

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-10-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I think I'm fine with it now, but please wait until next Monday (Oct 8) before pushing, so it doesn't break the upcoming KF5 release. I'm not 100% confident (given that earlier

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15871 To: madcatx, elvisangelaccio, sitter, dfaure Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread David Faure
dfaure added a comment. kio_file returns KIO::ERR_CANNOT_RMDIR when trying to delete a non-empty directory, maybe kio_smb could do the same? Although I see that the above isn't dependent on the command being executed But well, is there any other operation that would return ENOTEMPTY? If

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-02 Thread David Faure
dfaure closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D15890 To: dfaure, cfeck Cc: jtamate, kde-frameworks-devel, michaelh, ngraham, bruns

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-01 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > cfeck wrote in rgb.cpp:702 > head[i] → head.at(i) This would make no difference, given that I made `head` const... REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D15890 To: dfaure, cfeck Cc:

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-01 Thread David Faure
dfaure created this revision. dfaure added a reviewer: cfeck. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The code is even simpler this way. Found by using

D14162: Fix issue when reading path lists

2018-09-28 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D14162 To: apol, #frameworks, dfaure Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-25 Thread David Faure
dfaure accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15635 To: jtamate, dfaure, #baloo, #frameworks, ngraham Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15697: Fix deletion of files from DAV

2018-09-23 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15697 To: dvratil, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15697: Fix deletion of files from DAV

2018-09-23 Thread David Faure
dfaure added a comment. Patch looks ok but I'm surprised by the commit log. Doesn't this method also work for directories, even after the patch? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15697 To: dvratil, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kmtpd.json:10 > Currently the module is spawned by the ioslave on-demand. But imho it should > be possible to browse the device using only dbus, without having to open > dolphin first. > > Can we try to autostart the

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-22 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This is excellent work, thanks a lot for doing this. I just have "a few" minor comments... ;) INLINE COMMENTS > kio_mtp.cpp:107 > { > -qCDebug(LOG_KIO_MTP) << url.path(); >

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH add_QT_NO_NARROWING_CONVERSIONS_IN_CONNECT REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem,

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D15686 To: sdepiets, #framework_syntax_highlighting, mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15686: Prevent highlighter from erasing selected text

2018-09-22 Thread David Faure
dfaure added a comment. Makes sense. INLINE COMMENTS > highlighter.cpp:198 > +if (cursor.hasSelection()) > +{ > +cursor.clearSelection(); coding style: join with previous line REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15686 To:

D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread David Faure
dfaure added a comment. The question of the caching of the KUser usage remains, though. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15635 To: jtamate, dfaure, #baloo, #frameworks Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15559: Python bindings: use cmake_parse_arguments, fix documentation

2018-09-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This is technically not 100% source compatible, but since the callers were already passing "TARGET" (and others) as documented, I guess it's fine. REPOSITORY R240 Extra CMake Modules

D13315: Detect mime type of local files based on their contents

2018-09-19 Thread David Faure
dfaure added a comment. I agree, extensions are not reliable over HTTP, which is why mimeTypeForUrl doesn't use them for HTTP urls. But here we're in KFileItem, so much more likely talking about local files or FTP/SFTP/FISH/SMB/etc. where the *.php issue doesn't happen. > The case of

Fwd: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

2018-09-18 Thread David Faure
Hmm So we need to kill it? -- Forwarded Message -- Subject: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing! Date: mardi 18 septembre 2018, 16:09:33 CEST From: Thiago Macieira To: David Faure On Tuesday, 18 September 2018 00:16

D14072: Don't try to restore invalid user places

2018-09-18 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

2018-09-18 Thread David Faure
ould take a look into this that would be appreciated. > > Cheers, > Ben -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

2018-09-18 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. loadMimeTypeIcon also has the fallback to application-octet-stream if the mimetype icon isn't found, you could pass that as 2nd argument to fromTheme(). As to the extra

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

2018-09-18 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. In code that is specific to images, I have no problem with determination from content. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13416 To: miklosm,

D13315: Detect mime type of local files based on their contents

2018-09-18 Thread David Faure
dfaure added a comment. (BTW thanks for what you said about FUSE, I agree 100% and it makes me glad to see some people from the opposite camp, when so many people are trying to convince me that network mounts via FUSE is the solution to all problems on earth, see bug 75324) >

D13315: Detect mime type of local files based on their contents

2018-09-18 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. No, no. Too unreliable and against the MIME spec. You're testing it for the ideal case, images, which have proper headers. But there's no reliable "magic" (determination

D14072: Don't try to restore invalid user places

2018-09-17 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Shouldn't this skip the invalid bookmark rather than abort completely ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure,

D13316: manually set format in jpeg thumbnail creator

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks Cc: ngraham

D13676: Make it possible to change directory up even with trailing slashes in the url

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13676 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15096: [PreviewJob] Send enabled thumbnail plugins to the thumbnail slave

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15096 To: broulik, dfaure, fvogt, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14006: Fix WebDAV destination header on COPY and MOVE operations

2018-09-17 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. FullyEncoded makes perfect sense for sending in a protocol implementation. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure,

D15573: replace custom backtracing in SlaveBase with KCrash

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15573 To: sitter, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

2018-09-17 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH fixepscrashonappshutdown REVISION DETAIL https://phabricator.kde.org/D15405 To: kossebau, zccrs, dfaure, pino Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-17 Thread David Faure
dfaure added a comment. Looks OK now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

2018-09-17 Thread David Faure
dfaure added a comment. Do all frameworks build with this change? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12520: [PasteJob] Emit KDirNotify on paste

2018-09-16 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. "perhaps fix storedPut to do that?" --> I'm not in favour. Generally speaking, we want to do this at the highest level possible, so that batching N jobs doesn't trigger N notifications.

Re: Quality of Frameworks announcements

2018-09-16 Thread David Faure
ons release announcements either. It seems to me that we are just creating work for ourselves, but translating a changelog that really, in the end, only matters to people who understand English. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: kio slaves + kcrash + drkonqi

2018-09-16 Thread David Faure
d. But > then I don't know if/what performance penalty it'd entail with regards > to auto restarts.) My opinion is that a debugger is much better suited for getting useful backtraces (including parameter values, and the ability to inspect local variables). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D13034: Add mechanism to notify other clients of config changes over DBus

2018-09-14 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kconfigwatcher.cpp:72 > +watchedPaths name(); > +for (const QString file: d->m_config->additionalConfigSources()) { > +watchedPaths <<

D14724: autotests: don't fail if an unrelated window shows up.

2018-09-10 Thread David Faure
dfaure added a comment. @hein - or anyone else - ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D13034: Add mechanism to notify other clients of config changes over DBus

2018-09-08 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigtest.cpp:1793 > +#if !KCONFIG_USE_DBUS > +QEXPECT_FAIL("", "KConfig notification requires DBus", > QTest::Continue) > +

Re: ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

2018-09-08 Thread David Faure
r extraordinarily excessive amounts > of time, i've taken a sledgehammer to the offending code in ECM. Is there any indication that this code was misbehaving on Unix as well? I'm surprised that you took out everything, not just the Windows case. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-09-08 Thread David Faure
dfaure added a comment. OK after reading the bug report, I think this is more about "KRun as used by kde-open5 vs KRun as used by other apps such as konqueror". We want e.g. konqueror to follow the redirection. On the other hand we don't want kde-open5 to follow the redirection. Then what

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

2018-09-08 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm really not convinced about this. What about all the cases where you do want to see the redirection happen? - Redirection from http to https - Redirection from some

D6513: Add support for Attica tags support

2018-09-07 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > leinir wrote in tagsfilterchecker.cpp:103 > Scott Meyers' book? (might need to grab a copy of that, then :) ) Yes. REPOSITORY R304 KNewStuff REVISION DETAIL

D15317: trash: Fix directorysizes cache parsing

2018-09-06 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15317 To: volkov, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

2018-09-06 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tagsfilterchecker.cpp:33 > +{ > +qDeleteAll(validators.values()); > +} Unnecessarily slow. Remove the .values() call. >

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-05 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-05 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. No worries, that's what code review is for :-) Now this is starting to look good ;) INLINE COMMENTS > kioexecd.cpp:88 > + > +slotDirty(path); > +} Doesn't kdirwatch

D15180: kioexecd: watch for creations or modifications of the temporary files

2018-09-05 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kioexecd.cpp:36 > > +const int predefinedTimeout = 3; // 30s > + static const int... > kioexecd.cpp:86 > +{ > +m_deleted_mutex.lock(); > +

D15076: Build failures with KSyntaxHighlighting 5.49

2018-09-02 Thread David Faure
dfaure added a comment. Yes, maybe rename cantor to cantorplugins? The plugins dir already has some subdirs named plasmacalendarplugins or ruqolaplugins. Of course the loading code has to be adapted accordingly. We need the plugins in the bin dir for autotests to be able to

D8256: Add _XOPEN_SOURCE to C definitions

2018-09-01 Thread David Faure
dfaure added a comment. Indeed, 22:23:51 In file included from /usr/include/sys/mount.h:36: 22:23:51 /usr/include/sys/ucred.h:84:2: error: unknown type name 'u_int'; did you mean 'uint'? 22:23:51 u_int cr_version; /* structure layout version */ 22:23:51

D8256: Add _XOPEN_SOURCE to C definitions

2018-08-31 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R240:6684cb99bdf4: Add _XOPEN_SOURCE to C definitions (authored by awilcox, committed by dfaure). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D8256: Add _XOPEN_SOURCE to C definitions

2018-08-31 Thread David Faure
dfaure added a comment. Ah, found it in bugzilla :-) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

2018-08-31 Thread David Faure
dfaure added a comment. Let's push this then ;) You don't seem to have a developer account? I can push this but I need your email address for the git authorship. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure

D15141: [KSambaShareData] Accept spaces in ACL host name

2018-08-31 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15141 To: broulik, dfaure, fvogt Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

2018-08-31 Thread David Faure
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15146 To: broulik, dfaure, ngraham, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15141: [KSambaShareData] Accept spaces in ACL host name

2018-08-30 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ksambasharetest.cpp:26 > + > +#include > + This includes all of QtTest *and* all of QtCore. Please use instead. > ksambasharetest.h:21 > + > +#ifndef

D15161: [KFileItemListProperties] Use mostLocalUrl for capabilities

2018-08-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15161 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

2018-08-30 Thread David Faure
dfaure added a comment. commit bd86d99dda Author: Adrian Schroeter Date: Wed Apr 7 07:36:37 2004 + do not use DNOTIFY on subfs mounted devices. this would lock the drive and make an eject impossible. svn path=/trunk/kdelibs/; revision=301908

D15153: RFC: Resolve gvfsd mounts

2018-08-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15153 To: broulik, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >