D17595: Upstream Dolphin's file rename dialog

emmanuelp added a comment. In D17595#473825 , @meven wrote: > I guess we need now to reach to schwarz...@gmail.com romaninflianskas mfuchs chinmoyr mitchell emateli emmanuelp freininghaus to have lgplv2+ approval. Added myself to the rel

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

emmanuelp added a comment. In https://phabricator.kde.org/D5138#97024, @adridg wrote: > So, Linux, sort out your *stat(2) interfaces first and we'll get back to you. xstat patches have been merged into 4.11 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabric

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

e.org/r/129394/#review101007 --- On Nov. 14, 2016, 12:44 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129394/ &

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

tps://git.reviewboard.kde.org/r/129083/#comment67358> int -> qreal src/kiconloader.cpp (line 516) <https://git.reviewboard.kde.org/r/129083/#comment67357> QPointF - Emmanuel Pescosta On Oct. 6, 2016, 10 p.m., Kai Uwe Broulik wrote: > >

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/#review99295 --- Looks good to me! - Emmanuel Pescosta On Sept. 6, 2016

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97482 --- Ship it! Good idea! - Emmanuel Pescosta On July 16

Re: Review Request 128088: Load KFileItemAction plugins with json metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128088/#review96284 --- Ship it! Ship It! - Emmanuel Pescosta On June 5, 2016

Re: Review Request 127888: use selected icon effect for current KPageView page

> On May 10, 2016, 5:17 p.m., Emmanuel Pescosta wrote: > > src/kpageview_p.cpp, line 402 > > <https://git.reviewboard.kde.org/r/127888/diff/1/?file=464590#file464590line402> > > > > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? &

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

:State_Active) maybe? - Emmanuel Pescosta On May 10, 2016, 1:57 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 127888: use selected icon effect for current KPageView page

tps://git.reviewboard.kde.org/r/127888/#comment64660> option.state & (QStyle::State_Selected | QStyle::State_Active) maybe? - Emmanuel Pescosta On May 10, 2016, 5:12 p.m., Marco Martin wrote: > > --- > This is an automatically generat

Re: Review Request 127779: use system colors for monochrome icons

e remaining code path as the "QImageReader from path" to avoid breakages. - Emmanuel Pescosta On April 28, 2016, 1:53 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 127587: [Kate view] Correct override cursor

> On April 8, 2016, 9:29 a.m., Kåre Särs wrote: > > What is it that needs fixing? > > > > I don't have a problem in either case listed. > 3. Context menu is closed I can reproduce this problem - Emmanuel --- This is an automatically g

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

dialogtest? - Emmanuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93651 --- On March 17, 2016, 10:37 a.m.,

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

marked as submitted. Review request for KDE Frameworks, Andreas Sturmlechner and David Faure. Changes --- Submitted with commit bf37e9aa27a2321f4a6ce7188a0901fabd47c962 by Emmanuel Pescosta to branch master. Bugs: 360488 https://bugs.kde.org/show_bug.cgi?id=360488 Repository: kio

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

> On March 17, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > > Emmanuel Pescosta wrote: > > Would it be possible to get a test? > > autotest (is it allowed to show

Review Request 127410: Fix crash in rename dialog (KF 5.20)

/renamedialog.cpp 2d456c7 Diff: https://git.reviewboard.kde.org/r/127410/diff/ Testing --- Yes, I tried it by overwriting a file with the same file and with a different file -> no crash :) Thanks, Emmanuel Pescosta ___ Kde-frameworks-de

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

hich they think is best. KRun invocation can then also be implemented as a strategy, which is directly used when no dbus is available, or within the dbus strategy as fallback when the dbus call failed. - Emmanuel Pescosta On Feb. 7, 2016, 7:20 p.m.

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

/wiki/De_Morgan's_laws src/lib/io/kdirwatch_p.h (line 109) <https://git.reviewboard.kde.org/r/126392/#comment61449> Same here - Emmanuel Pescosta On Dec. 18, 2015, 4:33 a.m., Andrey Cygankov wrote: > > --- > Thi

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 2a506e8ee3ea25eb0b0d6c3323a924a57becb01b by David Faure on behalf of Emmanuel Pescosta to branch master. Bugs: 354981 https://bugs.kde.org/show_bug.cgi?id=354981 Repository

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

anks! :) - Emmanuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89400 --- On Nov. 28, 2015, 10:36 p.m., Em

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

> On Dec. 12, 2015, 11:54 a.m., Emmanuel Pescosta wrote: > > Sorry for breaking this code :/ > > > > Would it be possible to add some test cases to prevent such problems in > > future? > > Xuetian Weng wrote: > I don't know. It's not a good

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89168 --- On Nov. 28, 2015, 10:36 p.m., Emmanuel Pescosta wrote: > >

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

some test cases to prevent such problems in future? - Emmanuel Pescosta On Dec. 12, 2015, 10:35 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Purpose as a KDE Framework

On Dienstag, 1. Dezember 2015 15:01:10 CET Aleix Pol wrote: Hi, looks really interesting! > I'd like to see it used in other cases than sharing as well as in other applications Would you accept a plugin which can be used to compare selected files? - e.g. by starting kompare This would replace

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

8563c src/widgets/kurlcompletion.cpp c6764e4 Diff: https://git.reviewboard.kde.org/r/125988/diff/ Testing --- All test cases for KUrlCompletion pass Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

: Completion with '.', should find all hidden folders * KUrlCompletionTest::testLocalRelativePath: Completion with '.', should find all hidden folders - Emmanuel --- This is an automatically generated e-mail. To rep

Re: Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 9dbe36f734b5b839b2a6a934fad29d639e954498 by Emmanuel Pescosta to branch master. Bugs: 354678 https://bugs.kde.org/show_bug.cgi?id=354678 Repository: kio Description

Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

8d750e Diff: https://git.reviewboard.kde.org/r/126009/diff/ Testing --- All tests pass Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

test covered. Diffs - autotests/kurlcompletiontest.cpp ca8563c src/widgets/kurlcompletion.cpp c6764e4 Diff: https://git.reviewboard.kde.org/r/125988/diff/ Testing --- All test cases for KUrlCompletion pass Thanks, Emmanuel Pescosta

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

- 582) <https://git.reviewboard.kde.org/r/125928/#comment60305> You can hand over the srcFile directly to storedPut, storedPut has an overload which takes a QIODevice - Emmanuel Pescosta On Nov. 3, 2015, 9:24 a.m., David Faure

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/#review87359 --- Ship it! Ship It! - Emmanuel Pescosta On Oct. 25, 2015

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

tps://git.reviewboard.kde.org/r/125436/#comment59823> virtual dtor?! - Emmanuel Pescosta On Oct. 17, 2015, 5:06 p.m., Olivier Goffart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

iewboard.kde.org/r/125538/#review86411 --- On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 6128e94f689d416abb60255bb3792f127e52783c by Emmanuel Pescosta to branch master. Repository: kio Description --- Gives the user info about the trash occupancy when opening the

Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

://git.reviewboard.kde.org/r/125538/diff/ Testing --- Works fine (with and without maximum size limit) Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125400: Allow trash: in addition to trash:/ as url for listDir

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit c89897d0aa6bbc926ed860a3a050d6aaae007a9c by Emmanuel Pescosta to branch master. Bugs: 353181 https://bugs.kde.org/show_bug.cgi?id=353181 Repository: kio Description

Review Request 125400: Allow trash: in addition to trash:/ as url for listDir

://git.reviewboard.kde.org/r/125400/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 821abd02047f15aceb106cd390df2cea502c72bf by Emmanuel Pescosta to branch master. Bugs: 351585 and 352207 http://bugs.kde.org/show_bug.cgi?id=351585 http://bugs.kde.org

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

--- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

sting! > +1 for Phab Next time ;) - Emmanuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125044/#review84820 --- O

Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

/fileitemplugin/FileItemLinkingPlugin_p.h 05a39b4 Diff: https://git.reviewboard.kde.org/r/125044/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 124690: Show custom folder icons again

marked as submitted. Review request for KDE Frameworks, Àlex Fiestas and David Faure. Changes --- Submitted with commit d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by Emmanuel Pescosta to branch master. Bugs: 350612 https://bugs.kde.org/show_bug.cgi?id=350612 Repository: kio

Review Request 124690: Show custom folder icons again

properly again in Dolphin. Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

(line 297) <https://git.reviewboard.kde.org/r/123940/#comment55465> The result of create can be null (on error). - Emmanuel Pescosta On May 30, 2015, 12:09 a.m., Ragnar Thomsen wrote: > > --- > This is an automatica

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e919daeb5b144b146dbf459fadb116729b866d21 by Emmanuel Pescosta to branch master. Bugs: 345174 https://bugs.kde.org/show_bug.cgi?id=345174 Repository: kio Description --- Remove bookmarks

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit e41e0c922a641cea68a1f2d360bb2bb0fa8896f6 by Emmanuel Pescosta to branch master. Repository: kio Description --- Added KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123523/#review79577 --- On April 27, 2015, 1:49 p.m., Emmanuel Pescosta wrote: > >

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

/kfileplacesmodel.cpp 6c92012 src/filewidgets/kfileplacessharedbookmarks.cpp 3e7ffb9 src/filewidgets/kfileplacessharedbookmarks_p.h 2f9f4b8 Diff: https://git.reviewboard.kde.org/r/123525/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde

Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

/kfileplacessharedbookmarks_p.h 2f9f4b8 Diff: https://git.reviewboard.kde.org/r/123525/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

/kpropertiesdialog.cpp 37fa88f Diff: https://git.reviewboard.kde.org/r/123523/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Places bookmark bug - Help needed

> On Thursday 23 April 2015 18:24:26 Marco Martin wrote: > > On Thursday 23 April 2015, Emmanuel Pescosta wrote: > > > So the possible solutions I see are: > > > * Store the bookmarks in one file (user-places.xbel) and remove the > > > syncing > > > >

Places bookmark bug - Help needed

Hi everyone, I want to ask you, if you can help me to fix the "Places bookmarks disappear" bug [1], which was introduced by commit 2b5c6e42fc8114c6854ce490b9cdd4356be683d9 in kdelibs [2]. The adoption for Dolphin [3] has no effect on this bug. I have done some research and I'm a little bit confu

Re: Review Request 123443: Make it possible to call a put job from an IODevice

> On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: > > src/widgets/accessmanager.cpp, line 255 > > <https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255> > > > > IMO you should always verify if the data is readable, because not a

Re: Review Request 123443: Make it possible to call a put job from an IODevice

tps://git.reviewboard.kde.org/r/123443/#comment54156> IMO you should always verify if the data is readable, because not all lib users are trustworthy (assert isn't meant for input validation of untrustworthy callers - public api) - Emmanuel Pescosta On April 22, 2015, 1:46 a.m., Aleix Pol Gon

Re: Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

marked as submitted. Review request for KDE Frameworks and Andreas Schneider. Changes --- Submitted with commit e8d5a84156c6fc94d12894fb8ef9070b1b5cce99 by Emmanuel Pescosta to branch master. Repository: kio-extras Description --- Check if the ssh server supports the stat

Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

cpp 36bb28b Diff: https://git.reviewboard.kde.org/r/123081/diff/ Testing --- Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9793f3ae8d1739bec2a4a167f249c4f270aabdad by Emmanuel Pescosta to branch master. Repository: kio Description --- Use KIO::FileSystemFreeSpaceJob to retrieve free space information in

Re: Review Request 122978: Add unit test for crash of bug 343976

tps://git.reviewboard.kde.org/r/122978/#comment53287> unchecked m_menu - Emmanuel Pescosta On March 16, 2015, 1:04 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

tps://git.reviewboard.kde.org/r/122620/#comment53015> use a better comment - Emmanuel Pescosta On Feb. 18, 2015, 11:05 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

Diff: https://git.reviewboard.kde.org/r/122621/diff/ Testing --- Works Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

reviewboard.kde.org/r/122621/#review77155 --- On Feb. 18, 2015, 12:14 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 122614: Fix a porting bug in the http ioslave

aded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png Webdav (Fixed) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png Thanks, Emmanuel Pescosta ___ Kde-framew

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

il. To reply, visit: https://git.reviewboard.kde.org/r/122616/#review77154 --- On Feb. 18, 2015, 9:17 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically gener

Re: Review Request 122755: Add testcases for KIO::del()

nalSpy(const QObject * object, const char * signal) instead This applies for all other QSignalSpy usages in this test - Emmanuel Pescosta On March 6, 2015, 10:57 p.m., Martin Blumenstingl wrote: > > --- > This is a

Re: Review Request 122614: Fix a porting bug in the http ioslave

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/#review77150 ------- On March 7, 2015, 10:29 a.m., Emmanuel Pescosta wrote: > > --

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review77149 --- Ping - Emmanuel Pescosta On Feb. 18, 2015, 12:14 p.m

Re: Review Request 122614: Fix a porting bug in the http ioslave

rd.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png Webdav (Fixed) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png Thanks, Emmanue

Re: Review Request 122755: Add testcases for KIO::del()

tead of using a global definintion or constant. autotests/deldirtest.cpp <https://git.reviewboard.kde.org/r/122755/#comment52845> KJob::NoError instead of 0? - Emmanuel Pescosta On Feb. 28, 2015, 4:28 p.m., Martin Blumenstingl wrote: > >

Re: Split kde-baseapps?

s Cid : > El Dimecres, 25 de febrer de 2015, a les 11:13:37, Emmanuel Pescosta va > escriure: > > > We can make a release of it. > > > > Thanks! But I think it's already too late to move Dolphin into a new > repo, > > given that the freeze is only a few hours away.

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

--- On Feb. 18, 2015, 12:14 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122621/ > --

Re: Split kde-baseapps?

Albert Astals Cid wrote: > >> El Dimarts, 24 de febrer de 2015, a les 21:02:03, Emmanuel Pescosta va >> escriure: >> > > Hope you don't want to do this before tomorrow, do you? >> > >> > If moving Dolphin to a new repo is still possible then yes,

Re: Split kde-baseapps?

es 21:02:03, Emmanuel Pescosta va > escriure: > > > Hope you don't want to do this before tomorrow, do you? > > > > If moving Dolphin to a new repo is still possible then yes, because I > would > > prefer a KF5 based version of Dolphin in 15.04 :) > > A

Re: Split kde-baseapps?

also ok. Cheers, Emmanuel 2015-02-24 19:51 GMT+01:00 Albert Astals Cid : > El Dimarts, 24 de febrer de 2015, a les 10:55:20, Emmanuel Pescosta va > escriure: > > Hi everyone, > > > > > We can split off Dolphin as soon as Dolphin is konq-lib free > > > >

Re: Split kde-baseapps?

Hi everyone, > We can split off Dolphin as soon as Dolphin is konq-lib free Dolphin is almost ready for splitting (pending Review Request: https://git.reviewboard.kde.org/r/122687/) or merging (frameworks -> master) How should we proceed? Cheers, Emmanuel 2014-09-29 15:45 GMT+02:00 Em

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

tps://git.reviewboard.kde.org/r/122616/#comment52568> memo: set "Unknown size" as text - Emmanuel Pescosta On Feb. 18, 2015, 9:17 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail.

Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

-extras Description --- Implemented SlaveBase::GetFileSystemFreeSpace to enable free space information in sftp ioslave. Diffs - sftp/kio_sftp.h e088472 sftp/kio_sftp.cpp 057fcd4 Diff: https://git.reviewboard.kde.org/r/122621/diff/ Testing --- Works Thanks, Emmanuel

Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

Owncloud (share.kde.org) File Attachments webdav_freespace.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/c90a8f70-e12b-44b3-a0b8-651f1ee7d602__webdav_freespace.png Thanks, Emmanuel Pescosta ___ Kde-frameworks

Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

in Dolphin) Diffs - src/widgets/kpropertiesdialog.cpp 0dc4881 src/widgets/kpropertiesdialog_p.h 5858eed Diff: https://git.reviewboard.kde.org/r/122616/diff/ Testing --- Works for local and smb file systems Thanks, Emmanuel Pescosta _

Re: Review Request 122614: Fix a porting bug in the http ioslave

aded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png Webdav (Fixed) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/de96eb2e-45d8-4388-83b6-77199f677c75__webdav_fixed.png Thanks, Emmanuel Pescosta ___ Kde-framew

Review Request 122614: Fix a porting bug in the http ioslave

pp 78f50f9 Diff: https://git.reviewboard.kde.org/r/122614/diff/ Testing --- Works (see screenshots) File Attachments Webdav (Bug) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/18/d0ae2572-3770-4781-88e3-4d40e626fd85__webdav_bug.png Thanks, Emmanue

Re: Review Request 121461: Fix for bug 341773 and minor changes

g/r/121461/#comment50069> std::all_of() maybe? std::all_of(basename.cbegin(), basename.cend(), [](QChar c) { return c == QLatin1Char('.'); }); - Emmanuel Pescosta On Dec. 12, 2014, 11:56 a.m., Arjun AK wrote: > > --

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

> On Dec. 11, 2014, 3:27 p.m., Mark Gaiser wrote: > > src/core/kfileitem.cpp, line 255 > > > > > > --> add here > > > > } else { > > // Fix for IO slaves that don't set UDS_MIME_TYPE for a folder

Re: Review Request 120605: cleanup overlay icon usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review69638 --- Ping? No git account? - Emmanuel Pescosta On Oct. 16, 2014

Re: Review Request 120886: Show script execution prompt only if asked to

886/#comment48510> since 5.4 src/widgets/krun.h <https://git.reviewboard.kde.org/r/120886/#comment48509> Better name instead of b? showPrompt maybe? - Emmanuel Pescosta On Oct. 29, 2014, 12:01 p.m., Arjun AK wrote: > >

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 11:43 a.m., David Faure wrote: > > Thanks for the patch. > > > > Calling init() again surprised me a bit, since this method was never called > > twice before, but OK, anything else would be much more invasive. I would > > suggest to at least add a comment e.g. in the call t

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > <https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013> > > > > Any reason why using show instead of exec? Exec would avoid the rather

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > <https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013> > > > > Any reason why using show instead of exec? Exec would avoid the rather

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

g/r/120666/#comment48256> Any reason why using show instead of exec? Exec would avoid the rather complex and error-prone code path. IMHO we should prefer a blocking dialog in this case, because it asks the user for permission. - Emmanuel Pescosta On Oct. 22, 2014, 6:10 p.m., Ar

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

he cast hack and the need of a member variable. - Emmanuel Pescosta On Oct. 22, 2014, 6:10 p.m., Arjun AK wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Re: Review Request 120605: cleanup overlay icon usage

> On Oct. 16, 2014, 8:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem) > > Stefan Brüns wrote: > Any more comments? Is t

Re: Review Request 120605: cleanup overlay icon usage

you commit this patch, because it only fixes one mentioned problem) - Emmanuel Pescosta On Oct. 16, 2014, 5:32 p.m., Stefan Brüns wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Split kde-baseapps?

> - dolphin: could be split out, I added emmanuel as a CC to know his opinion Thanks for adding me and sorry for the late response. +1 for splitting up kde-baseapps We can split off Dolphin as soon as Dolphin is konq-lib free (David has already done a huge amount of work in this field :) Cheers,

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

g/r/120058/#comment45989> Q_DECL_OVERRIDE maybe? Given that you have done other cleanups as well, touching one line more shouldn't be a problem. thumbnail/imagecreator.cpp <https://git.reviewboard.kde.org/r/120058/#comment45988> Wrong indentation! - Emmanuel Pesc

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

g/r/119809/#comment45245> constBegin() because m_urlsIterator is a const iterator - Emmanuel Pescosta On Aug. 17, 2014, 11:01 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

org/r/118775/#comment41931> "using KFileItem::KFileItem;" maybe? src/core/kcoredirlister_p.h <https://git.reviewboard.kde.org/r/118775/#comment41932> {} - Emmanuel Pescosta On June 16, 2014, 9:58 a.m., F

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

Is "mimeData->setUrls(kdeUrls);" correct? lib/konq/konqmimedata.cpp <https://git.reviewboard.kde.org/r/118313/#comment40627> Is "mimeData->setUrls(mostLocalURLs);" correct? - Emmanuel Pescos

Review Request 118313: [Konqlib] KUrl -> QUrl

urned FALSE. konqpopupmenutest: (local setup problem maybe?!) QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory() favicontest: (local setup problem maybe?!) QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTy