Hi,
On torsdag 20 augusti 2020 kl. 01:02:36 EEST Andreas Müller wrote:
> Hi,
>
> a while back I needed syntax-highlighting in a QML based application.
> Since I could not find some QML support for syntax-highlighter, I
> wrote a wrapper library [1]. That worked perfectly fine but now that I
>
sars accepted this revision.
sars added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! I had not noticed the problem before :)
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D29680
To: davidedmundson, #kate,
sars added a comment.
I'm starting to think that we need an option for enabling/disabling this
change/feature. I would not want to have the extra space between the lines, but
at the same time I can see that actually not seeing the whole character is not
an acceptable situation...
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:92e5b0b9aac0: Avoid unwanted horizontal scrolling
(authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26071?vs=71736=72239
REVISION DETAIL
sars added reviewers: Kate, dhaumann, cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D26071
To: sars, #kate, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
REVISION SUMMARY
It looks like the horizontal scrolling is a bit too sensitive while
also scrolling vertically. This patch
sars added a comment.
Yes it works :)
(I added QLocale::setDefault(QLocale(QString::fromLatin1(languageCode))); to
the end of the if statement in initializeLanguages())
Hmm... For an application like Kate it is totally fine to set the language
through kxmlgui, but kxmlgui is tier 3
sars added a comment.
I would agree that a UNIX/POSIX env var is not the most logical thing to use
on Windows, but how do we ensure that we are in sync with ki18n? The usage of
QLocale in ki18n looks like it is just adding extra languages to a list of
languages, not actually using QLocale
sars added a comment.
So the conclusion is that we are not using setDefault() yet and ki18n &
gettext uses the LANGUAGE env so the logical thing, for now, is to also use
LANGUAGE env here in KCoreAddons for the plugin metadata translations?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
sars added a comment.
ki18n does not seem to use QLocale to get the language for translation, but
uses LANGUAGE env. Also gettext uses the env variable.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D25599
To: sars, aacid, vonreth
Cc: kde-frameworks-devel,
sars added reviewers: aacid, vonreth.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D25599
To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns,
cullmann, kfunk
sars created this revision.
sars added a project: Windows.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sars requested review of this revision.
REVISION SUMMARY
On Windows, the plugin metadata always follows the current region setting and
any language
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2d941799251c: Minimap: Do not grab the
left-mmouse-button-click on up/down buttons (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
sars created this revision.
sars added a reviewer: brauch.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
REVISION SUMMARY
The arrow buttons stopped working when we implemented "jump to position" in
sars added a comment.
LGTM
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21940
To: ahmadsamir, #ktexteditor, cullmann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, dhaumann
sars added a comment.
I think a partially highlighted line is better than a totally non-highlighted
one. And I think that the user is more likely to instinctively guess correctly
why the end of the line is not highlighted than if the line is not highlighted
at all.
REPOSITORY
R39
sars added a comment.
I tried the patch and it improved the performance really much! :) I was able
to edit a line that contained over a million characters!
Unfortunately I can't comment on the code too much, as I don't know the code
enough.
Some general stuff:
1. Should there
sars added a comment.
Yes I also have a memory that there was a bug report about it, but I can't
find it now
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19764
To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2b53012b3b50: Fix Minimap with QtCurve style (authored by
sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19764?vs=53895=55057
REVISION DETAIL
sars added reviewers: dhaumann, cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19764
To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham,
bruns, demsking, cullmann, sars, dhaumann
sars created this revision.
sars added a reviewer: brauch.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
REVISION SUMMARY
The handle of the scrollbar in QtCurve is much smaller than the scrollbar
sars added inline comments.
INLINE COMMENTS
> kateviewinternal.cpp:2702
> // Move cursor to end (or beginning) of selected word
> +#ifndef Q_OS_MACOS
> if (view()->selection()) {
does this even compile on OSX? Why did you change this?
> kateviewinternal.cpp:2718
> -
> -
sars added a comment.
Adding as a warning message in the view could be another review and needs
comments from others first
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17956
To: loh.tar, #ktexteditor, sars
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor,
sars accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17956
To: loh.tar, #ktexteditor, sars
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham,
bruns, demsking,
sars added a comment.
@dhaumann OK the limit is too low for Kile that is clear. Visual Studio Code
is limiting the highlighting on a line to 1 characters.
I tried to set the limit to 1, but that was very noticeably slow.
Selecting a whole line took multiple seconds, which is
sars marked an inline comment as done and an inline comment as not done.
sars added a comment.
The new limit is now limiting the number of characters highlighted on a line.
It is only the rest of the line that is not highlighted. This is IMO nicer as
you don't see the non-highlighted part at
sars retitled this revision from "WIP:Disable highlighting for lines longer
than 1024 characters." to "WIP:Disable highlighting after 512 characters on a
line.".
sars edited the summary of this revision.
sars edited the test plan for this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
sars updated this revision to Diff 48461.
sars added a comment.
Disable highlighting after [limit] characters on a line in stead of the whole
line.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17241?vs=47146=48461
BRANCH
disable_hl2
REVISION
sars added a comment.
+1
I think this is fine, but let Christoph and Dominik decide if we want style
fixing commits.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17729
To: loh.tar, #ktexteditor, dhaumann
Cc: sars, kwrite-devel, kde-frameworks-devel,
sars added inline comments.
INLINE COMMENTS
> katedocument.cpp:117
>
> -static inline QChar matchingStartBracket(QChar c, bool withQuotes)
> +static inline QChar matchingStartBracket(const QChar )
> {
I'm not familiar with the auto-bracket code, but the change from QChar to const
QChar &
sars added a comment.
@zetazeta I'm not sure the highlighting length limit is worth an option as
the editing of the document is not effected. I it is just a bit inconvenient
that the highlighting disappears...
REPOSITORY
R39 KTextEditor
REVISION DETAIL
sars marked 2 inline comments as done.
sars added a comment.
@dhaumann: You are right, the highlighting of the document still takes place
and it is only KateRenderer that stops using the highlighting info for all
lines longer than 1024 characters. All shorter lines are highlighted.
So
sars updated this revision to Diff 47146.
sars added a comment.
- Use a bit different config key to force a value reset for the limit.
- Fix reading the config value.
- Update the line-highlight disabled info message and position.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
sars added a comment.
The highlighting limit is now returned in a function in KateRenderer as it is
used also in katedocument.cpp for the warning/information message.
INLINE COMMENTS
> mwolff wrote in katerenderer.cpp:400
> this style-change should be submitted independently of this code
sars updated this revision to Diff 46957.
sars edited the summary of this revision.
sars added a comment.
Add a message to inform about why the lines are not highlighted.
Add a note about disabled highlighting to the wrapped lines warning.
Increase the default line length limit to 100 000
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when
endPos() is invalid. (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
sars added a comment.
OK, I have used this patch actively for a week now, and I have not noticed
any regression... ;)
I also now removed the temporary as it did not provide noticeable
improvements.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17243
To:
sars updated this revision to Diff 46937.
sars edited the summary of this revision.
sars added a comment.
Remove unneeded temporary
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17243?vs=46500=46937
BRANCH
lessUpdateView
REVISION DETAIL
sars retitled this revision from "Disable highlighting for lines longer than
1024 characters." to "WIP:Disable highlighting for lines longer than 1024
characters.".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: sars, cullmann, vkrause, dhaumann, mwolff
sars added a comment.
I agree, we need to do something about the line length limit (that only wraps
the lines at the limit when opening the file).
The question is: do we totally remove the option and limit or only the option
and raise the limit.
You can still edit the document at
sars updated this revision to Diff 46633.
sars retitled this revision from "WIP: Disable highlighting for lines longer
than 1024 characters." to "Disable highlighting for lines longer than 1024
characters.".
sars edited the summary of this revision.
sars added a reviewer: dhaumann.
sars added a
sars updated this revision to Diff 46632.
sars added a comment.
Also disable highlighting in selections for lines that are longe than 1024
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17241?vs=46499=46632
BRANCH
master
REVISION DETAIL
sars added a comment.
Note: this is especially bad when the "on the fly spellchecking" is enabled
as visibleRange() is used to "optimize" and only highlight what is currently
visible. It is called multiple times.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
sars added a comment.
If we get it working properly we could make the limit much higher. I tried
with 3 characters and it still worked very good. (except when selecting the
line)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: sars, cullmann,
sars created this revision.
sars added reviewers: cullmann, Kate, dhaumann.
sars added a project: Kate.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
Herald added a project: Frameworks.
sars requested review of this revision.
REVISION SUMMARY
visibleRange() has a side-effect
sars retitled this revision from "Disable highlighting for lines longer than
1024 characters." to "WIP: Disable highlighting for lines longer than 1024
characters.".
sars edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To:
sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17241
AFFECTED FILES
sars added a comment.
If I understand the comments correct it assumes that if we use a libc that
already has what we need, we don't need to use a separate library for it.
REPOSITORY
R877 Craft Blueprints for KDE
REVISION DETAIL
https://phabricator.kde.org/D14938
To: sdepiets, #craft,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e63efbdb8e4c: Search: Add workaround for missing icons in
Gnome icon-theme (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
sars marked an inline comment as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14856
To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew, ngraham, bruns, demsking, cullmann, sars
sars updated this revision to Diff 39772.
sars added a comment.
use fromTheme("foo", fromTheme("fall-back"));
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14856?vs=39766=39772
REVISION DETAIL
https://phabricator.kde.org/D14856
AFFECTED FILES
sars edited the test plan for this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14856
To: sars
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cullmann, sars, dhaumann
sars added a reviewer: Kate.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D14856
To: sars, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cullmann, sars, dhaumann
sars created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.
TEST PLAN
Install Gnome-icon-theme and start kate using that theme
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ee34537ff55c: KMultiTabBar: Fix regression in conversion
to new style connect() (authored by sars).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
sars closed this revision.
sars added a comment.
For some reason this review was not closed automatically by the commit.
Closing manually.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
sars created this revision.
sars added reviewers: Frameworks, mlaurent.
Restricted Application added a project: Frameworks.
sars requested review of this revision.
REVISION SUMMARY
The conversion to new style connect introduced a bug. The old connect
properly used the base class signal while
On måndag 11 december 2017 kl. 21:55:23 EET Albert Astals Cid wrote:
> El dijous, 7 de desembre de 2017, a les 22:13:21 CET, Alexander Semke va
>
> escriure:
> > Hi all,
> >
> > https://bugs.kde.org/show_bug.cgi?id=387626
> > we've got this problem reported and I don't see how to easily fix
sars added a comment.
I'm OK with an option for this. The only problem, with the option in the
screen-shot, is that it could be interpreted as also effecting the tabulator
mark.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7884
To: helio, mwolff, kfunk
Cc:
sars added a comment.
I think "spaceWidth() / 2" goes a little bit too far.
Shouldn't spaceWidth() fix the HiDPI problem?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7884
To: helio, mwolff, kfunk
Cc: sars, #frameworks, cullmann, dhaumann
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
On Windows the library was found during config, but not during compilation
without the variable EditorConfig_LIBRARIES.
sars added a comment.
I think I fixed it.
The comment about the dragging was only partially correct. The press must be
inside the slider for dragging, so when the initial press is outside or not
translated from the mini-map coordinates, the dragging does not start.
My solution is to
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:7bb1f434afaf: Jump to the clicked scrollbar position when
minim-map is enabled. (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
sars updated this revision to Diff 15180.
sars added a comment.
Use qBound() + remove one set of unneeded parenthesis
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6086?vs=15128=15180
REVISION DETAIL
https://phabricator.kde.org/D6086
AFFECTED FILES
sars added a comment.
Reasoning behind the change of behavior:
- With mini-map it is seems a bit more logical to jump to the clicked place
in stead of "searching your way there". (You already know where you want to go).
- Page Up/Down and mouse scroll can still be used.
- The middle
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch implements the jump to clicked position in "show-minimap" mode for
the scrollbar.
REPOSITORY
R39 KTextEditor
sars closed this revision.
sars added a comment.
https://commits.kde.org/ktexteditor/1bd9d474763ca891ef67c736398289cfd61bf21f
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5102
To: sars, #kate, #ktexteditor, dhaumann
Cc: mwolff, dhaumann, kwrite-devel,
Hi,
What version of Qt are you using?
I think this might be a Qt bug that you are encountering.
https://www.mail-archive.com/kde-windows@kde.org/msg07290.html
There was a patch for KIO to workaround the problem, but it was rejected
because the proper fix
is in Qt 5.8.
For building Kate on
sars added a comment.
I searched through the kdevelop repo and found marks 8, 21-27 in use + the
"reserved" for Bookmark,... So for KDevelop it looks OK, but we have other
users also.
Should I add "SearchMatch = markType32" to the MarkTypes enum to reserve it?
REPOSITORY
R39
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch adds scroll-bar-marks to the matches of "Find all" in the advanced
search bar
TEST PLAN
find all results in
> On June 16, 2016, 4:47 p.m., Kåre Särs wrote:
> > I'm getting this error on Windows with MSVC 2015 after this commit.
> >
> > ...etsaddons\src\kcapacitybar.h(234): error C2668:
> > 'KCapacityBar::KCapacityBar': ambiguous call to overloaded function
> > .
: or
'KCapacityBar::KCapacityBar(QWidget *)'
...etsaddons\src\kcapacitybar.h(234): note: while trying to match the argument
list '()'
- Kåre Särs
On June 16, 2016, 1:10 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an auto
with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.
We get the icon .rcc file and the icons where not installed
Thanks,
Kåre Särs
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
ard.kde.org/r/128187/#review96587
---
On June 16, 2016, 3:26 p.m., Kåre Särs wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128187/
> -
Diff: https://git.reviewboard.kde.org/r/128187/diff/
Testing
---
Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.
We get the icon .rcc file and the icons where not installed
Thanks,
Kåre Särs
___
Kde-frameworks
not installed
Thanks,
Kåre Särs
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
g/r/127896/#comment64789>
Why is this not: option(DISABLE_DBUS "Remove..." OFF) ?
For the rest I'm happy :)
- Kåre Särs
On May 20, 2016, 9:13 p.m., Nick Shaforostoff wrote:
>
> ---
> This is an autom
> On May 15, 2016, 5:03 p.m., Kåre Särs wrote:
> > Looks good :) A couple of questions:
> >
> > - If we create the .rcc do we also want to install the icons?
> > - I creates a similar solution for Kate on Windows (in a separate repo),
> > but I needed to add a
/... to do the same directly in breeze-icons.git? My
application is in git://anongit.kde.org/scratch/sars/kate-windows.git (icon-rcc)
- Kåre Särs
On May 14, 2016, 8:27 a.m., Gleb Popov wrote:
>
> ---
> This is an automatically ge
> On May 12, 2016, 6:15 a.m., Kåre Särs wrote:
> > I think this patch should not include any platform specific defines.
> > Disabling DBus requirement on Windows might also be interesting for some
> > projects. I propose to do something similar to what is done in kx
lobalaccel is not required or
searched for.
- Kåre Särs
On May 12, 2016, 5:16 a.m., Nick Shaforostoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
> On April 8, 2016, 7:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> >
> > I don't have a problem in either case listed.
>
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
>
> I can reproduce this problem
>
>
> On April 8, 2016, 7:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> >
> > I don't have a problem in either case listed.
>
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
>
> I can reproduce this problem
>
>
in either case listed.
- Kåre Särs
On April 8, 2016, 4:36 a.m., Anthony Fieroni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 7ac7a605923f0bb2f0f367f6069a101a24bead9f by Kåre Särs to
branch master.
Repository: kcoreaddons
Description
---
Without this patch kcoreaddons_desktop_to_json() will not find the service type
marked as submitted.
Review request for KDE Frameworks and Gregor Mi.
Changes
---
Submitted with commit def01c5bb668a284d9db48c4c402adc8268b895a by Kåre Särs to
branch master.
Repository: knewstuff
Description
---
On Windows we sometimes get null-pointers in stead of pointers
cmake 5d8e3d4
Diff: https://git.reviewboard.kde.org/r/126618/diff/
Testing
---
KTextEditor compiles on windows
Thanks,
Kåre Särs
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
the root
> > cause for the null pointers, I would feel better if the comment states
> > clearly that we don't know what is happening and that it is happening on
> > Windows only.
>
> Kåre Särs wrote:
> This one is not needed at the moment (I did not get null
ch.
Diffs (updated)
-
KF5CoreAddonsMacros.cmake 5d8e3d4
src/lib/plugin/desktopfileparser.cpp 319d29f
Diff: https://git.reviewboard.kde.org/r/126618/diff/
Testing (updated)
---
KTextEditor compiles on windows
Thanks,
Kåre Särs
___
Kde-frameworks-de
and adds a nullptr check before
> adding them to the list.
>
>
> Diffs
> -
>
> src/kmoretools/kmoretoolsmenufactory.cpp 30f4d02
> src/kmoretools/kmoretoolspresets.cpp 2405321
>
> Diff: https://git.reviewboard.kde.org/r/127237/diff/
>
>
> Testing
> ---
>
> Compiled and run on windows. No crashes in Kate when right-clicking files in
> the project plugin.
>
>
> Thanks,
>
> Kåre Särs
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kmoretoolsmenufactory.cpp 30f4d02
src/kmoretools/kmoretoolspresets.cpp 2405321
Diff: https://git.reviewboard.kde.org/r/127237/diff/
Testing (updated)
---
Compiled and run on windows. No crashes in Kate when right-clicking files in
the project plugin.
Thanks,
Kåre Särs
27265/
> -------
>
> (Updated March 3, 2016, 5:49 p.m.)
>
>
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs.
>
>
> Repository: ki18n
>
>
> Description
> ---
>
>
/kmoretoolspresets.cpp 2405321
Diff: https://git.reviewboard.kde.org/r/127237/diff/
Testing
---
Compiled and run on windows. No crashes in Kate when running without DBus and
right-clicking files in the project plugin.
Thanks,
Kåre Särs
___
Kde-frameworks-devel
/../share/hunspell/ and get spelling to work without depending on
LibreOffice installation on Windows.
Thanks,
Kåre Särs
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl
Sandsmark.
Changes
---
Submitted with commit af4c6011d545fec7bf5a1a0a548ae68aa96e2fc8 by Kåre Särs to
branch master.
Repository: sonnet
Description
---
The default search path
to a relocatable /../share/hunspell/ and get spelling to work without depending on
LibreOffice installation on Windows.
Thanks,
Kåre Särs
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
On Thursday, February 18, 2016 02:51:58 PM René J.V. Bertin wrote:
> On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote:
> >>> > since QIcon::fromTheme() apaprently isn't able to find app icons.
>
> Care to explain? QIcon::fromTheme() doesn't find anything "out of the box"
> on OS X
marked as submitted.
Review request for KDE Frameworks, Alex Richardson and David Faure.
Changes
---
Submitted with commit 5420b5752a30c294486fbaf967187c8a6f64fe42 by Kåre Särs to
branch master.
Repository: frameworkintegration
Description
---
Qt does not know if the remote URL
-----
On Feb. 14, 2016, 6:25 a.m., Kåre Särs wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126876/
>
What is the proper solution here?
- Kåre
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/#review92369
---
On
1 - 100 of 148 matches
Mail list logo
