Stepping down as KRunner maintainer

2020-10-08 Thread Kai Uwe Broulik
Hi everyone, you might not even have known this but officially I have been KRunner's maintainer for several years at this point :-) However, I have decided to step down as its maintainer as I believe won't be able to really move KRunner forward for KF6 despite a grand vision [1] for a lack of

Re: Add loop device interface to Solid framework

2020-06-13 Thread Kai Uwe Broulik
Hi, isn't that something that should just be in StorageVolume or something? We can already handle mounted ISOs in Solid just find - we only need some way to create/delete them? Cheers Kai Uwe

D29050: KRunner fix prepare/teardown signals

2020-06-07 Thread Kai Uwe Broulik
broulik added a comment. I now have runner queries never "finish". I type "plasmashell", get the results I expect, and the busy indicator keeps spinning forever. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc:

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-29 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in kopenwithdialog.cpp:1008 > https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? But I don't want to create a `QFIleInfo` just because REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik,

D21555: [KFilePlacesModel] Explicitly query for PTP cameras

2020-05-29 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21555 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-29 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Forgot that also existed, will update Actually, that doesn't exist REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc: ahmadsamir, dfaure,

D21126: [KUiServerJobTracker] Register jobs asynchronously

2020-05-29 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. I've got a jobviewv2 thing in the works which is qvariantmap-based so it can easily queue any changes and send them out once registered. I think jobviewv1 should just stay as is and be phased out eventually, cf. T12574

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

2020-05-29 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. I've got a jobviewv2 thing in the works which is qvariantmap-based so it can easily queue any changes and send them out once registered. I think jobviewv1 should just stay as is and be phased out eventually, cf. T12574

D29035: Install service files for kwin

2020-05-22 Thread Kai Uwe Broulik
broulik marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29035 To: broulik, #plasma, #frameworks Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen,

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Kai Uwe Broulik
broulik added a comment. I'm sorry, I don't really know how this teardown stuff all works :/ REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck,

D29035: Install service files for kwin

2020-05-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 83108. broulik added a comment. - Use `After` instead of `Wants` REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29035?vs=80723=83108 REVISION DETAIL https://phabricator.kde.org/D29035 AFFECTED FILES CMakeLists.txt

D29825: Add SystemdService to DBus service file

2020-05-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Using the new `ECMGenerateDBusServiceFile` of D29051

D29051: Add ecm_generate_dbus_service_file

2020-05-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 83105. broulik added a comment. - Clarify docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80776=83105 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED FILES

D29051: Add ecm_generate_dbus_service_file

2020-05-22 Thread Kai Uwe Broulik
broulik marked 3 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham,

D25461: [KCM GridDelegate] Use non-attached ToolTip

2020-05-21 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25461 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29420: Generate DBus interface

2020-05-20 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > notifybypopup.cpp:363 > +watcher->deleteLater(); > +QDBusPendingReply reply = *watcher; > +notifications.insert(reply.argumentAt<0>(),

D29228: [KProcessRunner] Use only executable name for scope

2020-05-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:19d23d386cf7: [KProcessRunner] Use only executable name for scope (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29228?vs=81338=83058 REVISION

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Kai Uwe Broulik
broulik added a comment. so, can the regexp be replaced or does it need to stay? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > knotification.h:253 > */ > CloseWhenWidgetActivated = 0x04, > Should we deprecate this? Or just use this one instead. I don't see why we would have separate enum values for those REPOSITORY R289 KNotifications REVISION

D25984: Load translations

2020-05-18 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Looks like D27595 fixes the issue REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: vkrause, mart,

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-05-18 Thread Kai Uwe Broulik
broulik added a comment. I am not sure we can just do this given the amount of modules kded loads. Can we be certain that all the modules don't do custom pixmap painting? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks Cc: broulik,

D28312: Implement urls using hints

2020-05-18 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH urlshint REVISION DETAIL https://phabricator.kde.org/D28312 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

2020-05-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R297:4ae4de9ff469: Add systemd user service file for kded (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29034?vs=82868=82949 REVISION DETAIL

D29034: Add systemd user service file for kded

2020-05-14 Thread Kai Uwe Broulik
broulik updated this revision to Diff 82868. broulik added a comment. - fix exec - add slice REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29034?vs=80722=82868 REVISION DETAIL https://phabricator.kde.org/D29034 AFFECTED FILES src/CMakeLists.txt

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-08 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2020_05_openurljob REVISION DETAIL https://phabricator.kde.org/D29385 To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela Cc: feverfew,

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-08 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-07 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kcolorcombo.h:60 > +/** Struct used in NamedColors list */ > +struct KNamedColor > +{ Do we really want to leak this `struct` into public API? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

2020-05-06 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D29479: Fix rounded borders

2020-05-06 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Notifications don't use `PlasmoidHeading` INLINE COMMENTS > PlasmoidHeading.qml:71 > +enabledBorders: { > +var borders = new Array() > +borders

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in kopenwithdialog.cpp:1008 > Why not QFileInfo::isAbsolute()? Forgot that also existed, will update REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc: ahmadsamir,

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > meven wrote in previewjob.cpp:433 > Maybe make this static, so that apps have to do it once per app sort of like > we do with `Qt::AA_UseHighDpiPixmaps`, rather than by KPreviewJob. Not a fan. You can have different dpi per screen. Maybe instead

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `QStandardPaths::findExecutable` only finds executable binaries, so when

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-05 Thread Kai Uwe Broulik
broulik added a comment. > At the risk of asking a stupid question, why? The text thumbnailer should be able to produce readable text on high dpi, or the folder thumbnailer should render the folder icon sharply and the picture frames non-pixelated REPOSITORY R241 KIO REVISION DETAIL

D29420: Generate DBus interface

2020-05-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > notifybypopup.cpp:115 > > - bool connected = QDBusConnection::sessionBus().connect(QString(), // > from any service > - > QString::fromLatin1(dbusPath), Previously it would

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > thumbcreator.h:139 > */ > -virtual bool create(const QString , int width, int height, QImage > ) = 0; // KF6 TODO: turn first arg into QUrl (see > thumbnail/htmlcreator.cpp) > +virtual bool create(const QString , int width, int

D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment. Yes, please! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29434 To: ngraham, #plasma, #vdg, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Kai Uwe Broulik
broulik added a comment. > Maybe we need something similar to `X-GNOME-UsesNotifications=true` Or we just also use that :D REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29405 To: nicolasfella, #frameworks, broulik, vkrause Cc: apol,

D29336: Remove galago from method/variable naming

2020-05-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH nogalago REVISION DETAIL https://phabricator.kde.org/D29336 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28499: [LauncherJobs] Emit description

2020-05-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:692d9bc81f00: [LauncherJobs] Emit description (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28499?vs=79700=81849#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Kai Uwe Broulik
broulik added a comment. Generally +1 The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? Not a fan of the timer. Also, we might want to deprecate the `QWidget` one now? REPOSITORY R289

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-03 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > broulik wrote in openurljob.cpp:274 > I know what you always say when I say what I always say but can we use a > mimetype job here? :) Seems I forgot to remove this when I added the comment above instead :) REPOSITORY R241 KIO REVISION

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-03 Thread Kai Uwe Broulik
broulik added a comment. Cool! INLINE COMMENTS > openurljob.cpp:261 > + > +void KIO::OpenUrlJobPrivate::determineLocalMimeType() > +{ I know what you always say when I say what I always say, but why not just always stat/mimetype job? > openurljob.cpp:274 > +QMimeDatabase db; > +

D29292: Port KKeySequenceItem to QQC2

2020-04-30 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in KeySequenceItem.qml:57 > > Can we use the non-attached version here please since it's not likely > > It's the worst! > > > Are we able to use some form of units? Hardcoding this seems wrong. > > It's come up before, this

D29292: Port KKeySequenceItem to QQC2

2020-04-29 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > KeySequenceItem.qml:57 > +ToolTip.visible: hovered > +ToolTip.delay: 1000 > +ToolTip.text: _tr.i18n("Click on the button, then enter the > shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl > key

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-29 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Verified that close signal works and that quitting plasma, sending a notification, then has the notification show up when plasma is started. Please wait until after Frameworks tagging

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

2020-04-28 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > applicationlauncherjob.cpp:155 > +} > +proceedAfterSecurityChecks(); > +} With this it starts to look as hard to follow as KRun :) REPOSITORY R241 KIO

D28624: Print a warning if runner is incompatible with KRunner

2020-04-28 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Would be lovely if we could get this date parsing into `QVersionNumber` of `KFormat`, I'm seeing similar code also in kscreenlocker, kwin, libksysguard, ... REPOSITORY R308 KRunner

D29228: [KProcessRunner] Use only executable name for scope

2020-04-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Slashes aren't allowed in scope names, so when a full executable path is

Re: changing icon sizes no longer emits signal

2020-04-27 Thread Kai Uwe Broulik
(That's why confirmation prompts are pointless, one gets so used to just acknowledge them all that that I sent this mail mid-sentece :) ...so perhaps we should just change it to always emit the dbus signal manually when something changed, rather than it being nested inside exportToKDE4().

Re: changing icon sizes no longer emits signal

2020-04-27 Thread Kai Uwe Broulik
Hi, A patch like the one attached seems to help, but someone who knows the KCM better (or has time to dig) should make this conditional on the user actually changing icon sizes, and only emit for the groups that have changed. Patch makes sense, though I wonder why we do both emitChange and a

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

2020-04-25 Thread Kai Uwe Broulik
broulik added a comment. The question is how that will work in conjunction with `KNotificationJobUiDelegate`? In principle we could also make it emit a `KNotification` with buttons INLINE COMMENTS > untrustedprogramhandlerinterface.h:79 > + */ > +bool

D29034: Add systemd user service file for kded

2020-04-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > bruns wrote in plasma-kded.service.in:5 > How about using some LIBEXEC dir instead, this should never be called > directly, or am I missing something? This is unrelated and kded has been there forever REPOSITORY R297 KDED REVISION DETAIL

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to QProcess (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29062?vs=80785=80973 REVISION

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

2020-04-21 Thread Kai Uwe Broulik
broulik added a comment. At first glance I thought that drawing tablet icon was about the scroll bar REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D29037 To: guoyunhe, #breeze, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack,

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Part of T12185 Verified it's

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 80776. broulik added a comment. Add docs rst REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80775=80776 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED FILES

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 80775. broulik added a comment. - Improve docs - Add `DESTINATION` arg REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80766=80775 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem,

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh,

D29051: Add ecm_generate_dbus_service_file

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, kossebau, kfunk, habacker. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It serves

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik
broulik planned changes to this revision. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29036: Print meaningful warning when there is no QGuiApplication

2020-04-21 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R278:57e41449ed82: Print meaningful warning when there is no QGuiApplication (authored by broulik). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D28499: [LauncherJobs] Emit description

2020-04-21 Thread Kai Uwe Broulik
broulik added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29036: Print meaningful warning when there is no QGuiApplication

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY KWindowSystem plug-in loading (and everything regarding a window system, like X or

D29035: Install service files for kwin

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, Frameworks. Herald added a project: KWin. Herald added a subscriber: kwin. broulik requested review of this revision. TEST PLAN See T11914 and D28305

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > plasma-kded.service.in:5 > +[Service] > +ExecStart=@CMAKE_INSTALL_PREFIX@/bin/kded5 > +BusName=org.kde.kded5 Didn't we have a `KDE_INSTALL_BIN_DIR` or something? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To:

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik
broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added reviewers: Plasma, Frameworks. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack,

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Merge branch 'master' into broulik/systemd_startup Rename unit to plasma-kded Merge branch 'master' into

D28919: Drop delayed second phase

2020-04-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R297:093a673f0e59: Drop delayed second phase (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28919?vs=80388=80621 REVISION DETAIL

D28919: Drop delayed second phase

2020-04-20 Thread Kai Uwe Broulik
broulik requested review of this revision. broulik added a comment. Waiting for @dfaure REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D28919 To: broulik, #plasma, dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh,

D28919: Drop delayed second phase

2020-04-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY kded runs Phase 0 and Phase 1 on startup and then

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Kai Uwe Broulik
broulik added a comment. It used to be 2 minutes, now it's 1? INLINE COMMENTS > app.cpp:59 > +static int s_idleTimeout = 1000 * 60; // 1 min > +m_idleTime = KIdleTime::instance(); > +m_idleTime->addIdleTimeout(s_idleTimeout); Why the member variable? It's a singleton after all

D26650: Use KService to look for Filelight

2020-04-14 Thread Kai Uwe Broulik
broulik added a comment. Superseded by D28266 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28770: Avoid blocking the UI thread

2020-04-13 Thread Kai Uwe Broulik
broulik added a comment. I don't fully understand the need for a thread here. It merely blocks because the API is synchronous and thus we create a nested eventloop. I don't think the writing and parsing of the cache file is a real bottleneck here. INLINE COMMENTS > currency.cpp:57 > +

D28787: Fix PC3 BusyIndicator binding loop

2020-04-13 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-busyindicator-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28787 To: ngraham, #plasma, davidedmundson, broulik Cc:

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Kai Uwe Broulik
broulik added a comment. Don't use global statics in library code REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To: bruns, #frameworks, apol Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

2020-04-11 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26016: [KeySequenceHelper] Work around Meta modifier behavior

2020-04-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R296:4306fb8f4e19: [KeySequenceHelper] Work around Meta modifier behavior (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2020-04-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R263:577e8cddde7d: [KKeySequenceWidget] Work around Meta modifier behavior (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26017?vs=71597=79708

D28499: [LauncherJobs] Emit description

2020-04-09 Thread Kai Uwe Broulik
broulik updated this revision to Diff 79700. broulik added a comment. - Drop ellipsis REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28499?vs=79105=79700 REVISION DETAIL https://phabricator.kde.org/D28499 AFFECTED FILES src/gui/applicationlauncherjob.cpp

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

2020-04-09 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R289:524bdc640dcc: [KNotificationJobUiDelegate] Append Failed for error messages (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-04-09 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Yeah, can probably be a `startsWith` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

2020-04-08 Thread Kai Uwe Broulik
broulik added a comment. > assuming we have a way of telling which slaves are remote `KProtocolInfo::protocolClass(url.scheme())` not being `":local"` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik,

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-04-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids recompiling it every time. TEST PLAN Called 27 times on plasmashell startup

D27848: Remove the panel tooltip icon

2020-04-06 Thread Kai Uwe Broulik
broulik added a comment. > For all panel widgets which are all governed by a single place: `plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml` Imho an unacceptable behavior break for a Frameworks component. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28570: Add 3mf thumbnail support

2020-04-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D28570 To: davidedmundson, broulik Cc: kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28555: File ioslave : use Better setting for sendfile syscall

2020-04-04 Thread Kai Uwe Broulik
broulik added a comment. > reduce the overhead of processedSize dbus progress notification in each iteration since it is called less often, adding some more speed. From what I recall in copy job the processed size in emitted by a timer and not every time a chunk got processed

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

2020-04-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:60d7cfec0595: [CommandLauncherJob] Also mention setDesktopName in constructor (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28552: [CommandLauncherJob] Also mention setDesktopName in constructor

2020-04-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY I think it's to be preferred over name + icon. REPOSITORY R241 KIO

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5f2be012c27d: [CommandLauncherJob] Add constructor taking an executable and argument list (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-04 Thread Kai Uwe Broulik
broulik requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-04 Thread Kai Uwe Broulik
broulik updated this revision to Diff 79267. broulik added a comment. This revision is now accepted and ready to land. - Add test for binary in path with space REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28515?vs=79189=79267 REVISION DETAIL

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-04 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Good idea REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

2020-04-03 Thread Kai Uwe Broulik
broulik retitled this revision from "[KNotificationJobUiDelegate] Prepend "Failed" for error messages" to "[KNotificationJobUiDelegate] Append "Failed" for error messages". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28531 To: broulik, #frameworks Cc:

D28499: [LauncherJobs] Emit description

2020-04-03 Thread Kai Uwe Broulik
broulik added a comment. Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably shouldn't do it here either? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28531: [KNotificationJobUiDelegate] Prepend "Failed" for error messages

2020-04-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Makes the resulting error notification resemble one like a KJobTracker failure

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-03 Thread Kai Uwe Broulik
broulik added a comment. Not sure how I would test running a command with a space in it.. putting a shell script in running it through QFINDTESTDATA? Not sure how to make that sort of stuff work on Windows REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To:

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

2020-04-03 Thread Kai Uwe Broulik
broulik updated this revision to Diff 79189. broulik edited the test plan for this revision. broulik added a comment. - Quote executable in commandline - Add unittest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28515?vs=79136=79189 REVISION DETAIL

  1   2   3   4   5   6   7   8   9   10   >