D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2019-11-15 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > sortfiltermodel.cpp:84 > +QQmlEngine *engine = QQmlEngine::contextForObject(this)->engine(); > +args << > engine->toScriptValue(idx.data(m_roleIds.value(m_filterRole))); > + Can we also just have it send `source_row` and

D25223: Avoid side effects during menu initialization

2019-11-12 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:27 > #include > +#include > Already included in the header file > kdeplatformsystemtrayicon.cpp:33 > : QPlatformMenu() > -, m_enabled(true) > -, m_visible(true) > -,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-08 Thread Kai Uwe Broulik
broulik added a comment. This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: F7748305: Screenshot_20191108_151344.png (note the

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Kai Uwe Broulik
broulik added a subscriber: davidedmundson. broulik added a comment. In D25119#558084 , @cullmann wrote: > Hmm, where does that happen? https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888 > And does that work for icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Kai Uwe Broulik
broulik added a comment. > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. But why would you need this anyway? At least with `KIconEngine` we colorize the icons dynamically. I don't have to switch to breeze-dark when I use a dark color scheme on

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Kai Uwe Broulik
broulik added a comment. Can you expand on that dark theme issue? We just colorize the same SVGs as needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt Cc: broulik, rempt, kde-frameworks-devel,

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

2019-10-31 Thread Kai Uwe Broulik
broulik added a comment. `KDesktopFile::desktopGroup()` just gives you a `KConfigGroup` of the ´[Desktop Entry]` section at which point you can read whatever you want REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25003 To: meven, #frameworks, apol Cc: broulik,

T11627: Improve KIO asynchronicity

2019-10-30 Thread Kai Uwe Broulik
broulik added a comment. I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can cause apps to hang or slow down if whatever they're trying to call into is busy.

D24958: Delete nepomuk icon

2019-10-29 Thread Kai Uwe Broulik
broulik added a comment. https://cgit.kde.org/dolphin.git/tree/src/panels/information/informationpanelcontent.cpp#n231 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2,

D24958: Delete nepomuk icon

2019-10-29 Thread Kai Uwe Broulik
broulik added a comment. Note that Dolphin still uses that icon for its information panel when in search mode. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-25 Thread Kai Uwe Broulik
broulik added a comment. > Don't you already have the free space information in the status bar though? Isn't that supposed to be removed by default in that ominous Dolphin redesign? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg,

D24895: [RFC] Drop implicit size from PC buttons

2019-10-24 Thread Kai Uwe Broulik
broulik added a comment. Perhaps only when it has no text so icon-only can become rightfully square? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: broulik, ngraham, kde-frameworks-devel, mart,

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

2019-10-18 Thread Kai Uwe Broulik
broulik added a comment. However, `setDummyHistoryEntry` has some logic for icon being `null` and "reuse previous pixmap if null" which would be moot if I change it to always fall back to `application-octet-stream`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

2019-10-18 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Yes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451 To: broulik, #frameworks, dfaure, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-17 Thread Kai Uwe Broulik
broulik added a comment. Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so it gets assigned a window. INLINE COMMENTS > keysequencehelper.cpp:118 > QString shortcutDisplay; > - > +QQuickItem* keySequenceItem; > //! Check the key sequence against

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

2019-10-17 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24716 To: davidedmundson, #plasma, ervin, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

2019-10-16 Thread Kai Uwe Broulik
broulik added a comment. > bool takeOwnership = true); If only Qt/we used modern C++ features to communicate object ownership :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc:

D24697: Expose isImmutable to introspection (e.g. QML)

2019-10-16 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24697 To: ervin, #plasma, #frameworks, mart, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

2019-10-16 Thread Kai Uwe Broulik
broulik added a comment. I checked Qt source code and Qt indeed should handle this on its own, it also works fine hwere without the code. Worse, the explicit assignment from QML breaks any binding set on `currentIndex`. In the handler that's called when the delegate model creates a

D24431: Restore cursor thumbnailer

2019-10-15 Thread Kai Uwe Broulik
broulik planned changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23835: Add TabKCM

2019-10-10 Thread Kai Uwe Broulik
broulik added a comment. Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a Framework which has a minimum version version support of Qt 5.11 (last three, 5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12 REPOSITORY R296 KDeclarative REVISION DETAIL

D24263: edit mode action

2019-10-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > corona.cpp:378 > +switch (d->immutability) { > +case Types::UserImmutable: > +action->setEnabled(false); Why is this switch to explicitly stating all the cases? The action is always visible and enabled only when

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-08 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. https://cgit.kde.org/kcmutils.git/commit/?id=8cea2dacd80565f6d22bf1e5151e5c7be1620eab REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24430 To: broulik, #plasma, ngraham, mart Cc: kde-frameworks-devel,

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R296:2c2942cee9ec: [ConfigModule] Expose mainUi component status and error string (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-07 Thread Kai Uwe Broulik
broulik added a comment. Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24476: [KPropertiesDialog] Only show volume-related info for volumes

2019-10-07 Thread Kai Uwe Broulik
broulik added a comment. Having the free space info bar on folders was always very useful imho REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-07 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-07 Thread Kai Uwe Broulik
broulik added a comment. > Is the text in the window mouse-selectable? I don't think so (didn't test, just read the code) but should be trivial to add. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: ngraham,

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Kai Uwe Broulik
broulik added a comment. Can you also check `KRun`, I'm sure we've had issues with startup reporting stuff in the past REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24431: Restore cursor thumbnailer

2019-10-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fredrik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Baiscally just find xlib and change the link targets.

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik
broulik added a dependent revision: D24430: [KCModuleLoader] Show error when QML fails to load. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently it just prints a warning to console and shows an empty dialog leaving the

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 AFFECTED FILES

D24239: make editMode a corona global property

2019-09-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:416 > I think you should check for `SystemImmutable` here (KIOSK) Nevermind, it just moved :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart,

D24239: make editMode a corona global property

2019-09-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:416 > - > -if (m_containment->immutability() != Plasma::Types::Mutable) { > -return; I think you should check for `SystemImmutable` here (KIOSK) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

2019-09-25 Thread Kai Uwe Broulik
show up though) Thanks, Kai Uwe Broulik

D23857: Honor global animation speed factor

2019-09-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d5a5d07f0f89: Honor global animation speed factor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23857?vs=65804=66828

D21897: Address some issues reported by Krazy analysis

2019-09-20 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ktextedit.cpp:373 > + > +delete dialog; > } You can do `dialog->setAttribute(Qt::WA_DeleteOnClose);` when creating the dialog instead of an explicit delete call REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564 (branched from master)

D24046: Allow triggering sort from QML

2019-09-18 Thread Kai Uwe Broulik
broulik added a comment. Meh, I could have sworn `sort` was `Q_INVOKABLE` :( REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

2019-09-17 Thread Kai Uwe Broulik
broulik added a comment. I surely don't want to have apps start to #ifdef a ton of stuff out, which works against the nature of Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel,

D24025: Don't use KCrash on Android

2019-09-17 Thread Kai Uwe Broulik
broulik added a comment. Can't we make KCrash just no-op on Android? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

2019-09-17 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23985: Consider UNC paths as NetworkShare context

2019-09-17 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R308:8df6c719617e: Consider UNC paths as NetworkShare context (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23985?vs=66194=66289 REVISION

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-09-16 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:920784722205: [Exe Thumbnailer] Match 16 bit executables and dont request icon types… (authored by broulik).

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

2019-09-16 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D23995 To: dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

2019-09-16 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kcombobox.cpp:59 > Q_Q(KComboBox); > -q->QComboBox::setAutoCompletion(false); // otherwise setLineEdit will > create a completer... > With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind autocompletes history entries

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

2019-09-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8e3b39635cb5: [KUrlNavigatorPlacesSelector] Properly identify teardown action (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

2019-09-16 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18425 To: broulik, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23985: Consider UNC paths as NetworkShare context

2019-09-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Location runner uses `KUriFilter` which translates "\\foo\bar" to smb://foo/bar" but

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-09-16 Thread Kai Uwe Broulik
broulik added a comment. This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks,

D22569: [Dialog] Apply window type after changing flags

2019-09-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:67811e152a67: [Dialog] Apply window type after changing flags (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-09-15 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23145 To: broulik, vonreth, pali, antlarr, bruns Cc: apol, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D23944: Move more functionality from KRun::runCommand/runApplication to KProcessRunner

2019-09-14 Thread Kai Uwe Broulik
broulik added a comment. This breaks the build: https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/219/ /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/src/widgets/krun_p.h:97:10: error: ���unique_ptr��� in namespace ���std��� does not name a template

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Kai Uwe Broulik
broulik added a comment. Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face" REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze Cc:

D23917: Use const_iterator

2019-09-12 Thread Kai Uwe Broulik
broulik added a comment. If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin Cc: broulik, zzag, kde-frameworks-devel,

D23916: Remove capture of this in lambda

2019-09-12 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23916 To: gladhorn, #kwin, zzag, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23857: Honor global animation speed factor

2019-09-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Multiplies the animation speed by the given factor. TEST PLAN See

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

2019-09-10 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

2019-09-09 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23809 To: vkrause, dfaure, broulik Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-09-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > author.h:111 > + */ > +void setProfilepage(const QString ); > + `ProfilePage`? > commentsmodel.cpp:184 > +default: > +value.setValue(i18nc("The value returned for an unknown role > when requesting data from

D23782: Add "edit-none-border" icon

2019-09-08 Thread Kai Uwe Broulik
broulik added a comment. In D23782#527560 , @GB_2 wrote: > No, then it doesn't fall back to `edit-none`. Alright, makes sense. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis

D23787: [baloo_file_extractor] Improve handling of large plain-text files

2019-09-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > app.cpp:183 > +// have trouble processing them > +if ((ex->extractorProperties()["Name"].toString() == > QLatin1String("PlaintextExtractor")) && (QFileInfo(url).size() >= 10 * 1024 * > 1024)) { > +qCWarning(BALOO) <<

D23782: Add "edit-none-border" icon

2019-09-08 Thread Kai Uwe Broulik
broulik added a comment. Shouldn't it be "edit-border-none"? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23722: Warn if KPackage is invalid

2019-09-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R296:19bf8ad69bde: Warn if KPackage is invalid (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23722?vs=65380=65567 REVISION DETAIL

D23759: Remove unneeded media icons

2019-09-06 Thread Kai Uwe Broulik
broulik added a comment. -1 we've had do much trouble when we touched media icons last, and still get bug reports about "missing icons" so i prefer not touching them again for no good reason. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23759

D23722: Warn if KPackage is invalid

2019-09-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > apol wrote in configmodule.cpp:174 > maybe put it after checking the mainscript? the "no QML file provided" error > is more accurate. We can keep ::isValid as a fallback. > Actually, if there's no mainscript it probably shouldn't be valid. Is

D23722: Warn if KPackage is invalid

2019-09-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: mart, tcanabrava. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Previously it would warn about no "mainscript" having been provided but all

D23694: Add support for sshfs to the fstab backend

2019-09-03 Thread Kai Uwe Broulik
broulik added a reviewer: KDE Connect. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23694: Add support for sshfs to the fstab backend

2019-09-03 Thread Kai Uwe Broulik
broulik added a comment. This causes KDE connect drive to show up as "/run/user/1000/HASH (fuse.sshfs)" in places panel while being accessed. I really don't like KDE connect using sshfs, though, so +1 from me :P REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694

D23682: Make use of KPluginMetaData where we can

2019-09-02 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > containmentactions.h:70 > * including name, pluginName and icon > - * @since 5.0 > + * @since 5.0 use metadata > */ @deprecated since 5.62 use metadata > dataengine.cpp:70 > : QObject(parent), > - d(new

D23670: [KPropertiesDialog] Always check mount point being null

2019-09-02 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b571aacf7e9: [KPropertiesDialog] Always check mount point being null (authored by broulik). REPOSITORY R241 KIO

D23660: [KRun] Check mime type for isExecutableFile first

2019-09-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:9b12a872da35: [KRun] Check mime type for isExecutableFile first (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23660?vs=65206=65241 REVISION

D23660: [KRun] Check mime type for isExecutableFile first

2019-09-02 Thread Kai Uwe Broulik
broulik added a comment. > will still be used by isPromptNeeded, so this can go in. Speaking of which, that prompt check should be done after the mimetypejob has finished, not casually blocking everything in synchronous mime type determination beforehand :) REPOSITORY R241 KIO

D23670: [KPropertiesDialog] Always check mount point being null

2019-09-02 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23670 To: broulik, #frameworks, dfaure, shubham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23670: [KPropertiesDialog] Always check mount point being null

2019-09-02 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY File type got added after the fact and outside the guard.

D13867: [KMessageWidget] Pass widget to standardIcon()

2019-09-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R236:dbee23dd939b: [KMessageWidget] Pass widget to standardIcon() (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13867?vs=61989=65220

D23660: [KRun] Check mime type for isExecutableFile first

2019-09-02 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The mime type is passed into the function, so it's already known. Checking

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

2019-09-01 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > slavebase.cpp:189 > +} > +if (config != nullptr) { > +delete config; `delete nullptr` is fine, no need to check first > slavebase.cpp:281 > d->needSendCanResume = false; > -d->config = new KConfig(QString(),

D23650: Add an icon for the trash root and a proper label

2019-09-01 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kio_trash.cpp:280 > entry.clear(); > -entry.fastInsert(KIO::UDSEntry::UDS_NAME, QStringLiteral(".")); > entry.fastInsert(KIO::UDSEntry::UDS_FILE_TYPE, S_IFDIR); `UDS_NAME` has to be "." to denote it's the root entry. You want to be

D23584: Cache windows thumbnails

2019-08-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R320:1658029fd29e: Cache windows thumbnails (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23584?vs=65001=65012 REVISION DETAIL

D23584: Cache windows thumbnails

2019-08-30 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, pali, vonreth, antlarr. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the timestamp of the file changes, the

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2019-08-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:933887dc334f: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16311?vs=43909=64852#toc REPOSITORY R241

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

2019-08-28 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > slavebase.h:343 > + */ > +QMap *mapConfig(); > + Why return a pointer, and why is this method not `const`? Or is this supposed to be writable? Then I would prefer returning a reference to communicate ownership properly. REPOSITORY

D23367: make the sizing of the toolbuttons more coherent

2019-08-28 Thread Kai Uwe Broulik
broulik added a comment. This breaks the sizing of larger buttons like in media controller: F7288011: Screenshot_20190828_100935.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23367 To: camiloh,

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-28 Thread Kai Uwe Broulik
broulik added a comment. > . The question is how to know inside the KIO slave which application requested its services. If all else fails we could pass a query parameter `recentdocuments://?application=...` since this is mainly meant for the file dialog I presume, there could be some

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

2019-08-28 Thread Kai Uwe Broulik
broulik updated this revision to Diff 64792. broulik added a comment. - Remove pointless `isEmpty` check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18425?vs=64791=64792 REVISION DETAIL https://phabricator.kde.org/D18425 AFFECTED FILES

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

2019-08-28 Thread Kai Uwe Broulik
broulik updated this revision to Diff 64791. broulik edited the test plan for this revision. broulik added a comment. - Iterate all actions - Set the id on the separator as well so we can identify it easily REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

2019-08-27 Thread Kai Uwe Broulik
broulik updated this revision to Diff 64777. broulik added a comment. - Minimize unrelated changes... REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23145?vs=63697=64777 REVISION DETAIL https://phabricator.kde.org/D23145 AFFECTED FILES

D23103: Add decibel power units (dBW and multiples)

2019-08-27 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R292 KUnitConversion BRANCH log_power_units REVISION DETAIL https://phabricator.kde.org/D23103 To: iasensio, broulik, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

2019-08-27 Thread Kai Uwe Broulik
broulik added a comment. > isSlow() didn't check linkDest before. Even more reason to do it properly now :P `KFileSystemType` uses `statfs`. I didn't find any documentation on whether it follows symlinks, but it is documented to return an `ELOOP` error code "Too many symbolic links

D23420: Use solid to check if a KFileItem is located on a network mount

2019-08-27 Thread Kai Uwe Broulik
broulik added a comment. Now we still need the `linkDest` check :) REPOSITORY R241 KIO BRANCH arcpatch-D23420 REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Kai Uwe Broulik
broulik added a comment. What about symlink resolution, though? Maybe this needs to check `linkDest()`, too. This might block but for our usecase in local files you have `UDS_LINK_DEST` populated on the kioslave side already. INLINE COMMENTS > kfileitem.cpp:766 > +const

D23420: Use solid to check if a a KFileItem is located on a network mount

2019-08-26 Thread Kai Uwe Broulik
broulik added a comment. I'm always hesitant to use Solid but since `KFilePlacesModel` already queries Solid for everything, it has already loaded all its backends and queried everything, so the overhead of this during normal Dolphin use, is surprisingly negligible. +1 good call! :)

D23314: Fix runnertest exiting early

2019-08-21 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D23314 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23313: improve code in Snore backend

2019-08-21 Thread Kai Uwe Broulik
broulik added a comment. I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better INLINE COMMENTS > notifybysnore.cpp:141 > + > +void NotifyBySnore::notify(KNotification* notification, KNotifyConfig > *config) > +{ The

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. In D16311#353808 , @dfaure wrote: > This map will keep growing and growing... Are you sure? It didn't grow during my testing, even after moving places around and adding and removing items. It could always

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. Can we keep it on mobile? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D13757: Move parsing .desktop file for folder Comment to file KIO

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. Theres's also the directory icon reading which potentially blocks, so doing both in the KIO slave improves the situation without having to introduce new API and rewrite everything and the kitchen sink. REPOSITORY R241 KIO REVISION DETAIL

  1   2   3   4   5   6   7   8   9   10   >