D14302: Don't block forever in ensureKdeinitRunning

lvsouza added a comment. I think I know what is happening. This line QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes -1 as "forever" passes the result of qMax() to QDeadlineTimer's constructor. That constructor receives a quint64. Since qMax() is a template:

D6687: Adding support to ipv*.route-metric

lvsouza accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

lvsouza requested changes to this revision. lvsouza added a comment. This revision now requires changes to proceed. The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes? INLINE COMMENTS >

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > T

Re: Review Request 128958: Add application/x-openvpn-profile mime type

> On May 1, 2017, 2:05 p.m., Lamarque Souza wrote: > > ping > > David Faure wrote: > ping? did you see my comment? ;) Yes, I did see your comment. The "ping" was to this review's author to follow your instructions :-) I am one of the Plasma NM developers and th

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. Fixed. Thanks for the quick report about the broken build and sorry for not adding all files to the commit. - Lamarque --- This is an

Re: Review Request 128958: Add application/x-openvpn-profile mime type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128958/#review103166 --- ping - Lamarque Souza On Sept. 20, 2016, 11:59 a.m., Kai

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 28, 2017, 1:28 p.m., Lamarque Souza wrote: > > Ship It! > > KJ Tsanaktsidis wrote: > Great - thanks for your help and for bearing with my rusty C++! What > happens now? I'm waiting on this patch to land for another patch I submitted

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103148 --- Ship it! Ship It! - Lamarque Souza On April 23, 2017

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 22, 2017, 10:27 a.m., Lamarque Souza wrote: > > autotests/CMakeLists.txt, line 66 > > <https://git.reviewboard.kde.org/r/130090/diff/5/?file=494817#file494817line66> > > > > CMake's developers recommend using else() instead of > > else(). T

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

ps://git.reviewboard.kde.org/r/130090/#comment68589> Here too. - Lamarque Souza On April 22, 2017, 12:38 a.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

tps://git.reviewboard.kde.org/r/130090/#comment68567> It is common practice to pass QString parameters QString as const &: FakeUdisks2BlockDevice(QObject *parent, const device, quint64 device_number); - Lamarque Souza On April 20, 2017, 8:49 a.m., KJ Tsanakts

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

//git.reviewboard.kde.org/r/130090/#comment68564> Code style: remove the extra whitespace at the end of the line. - Lamarque Souza On April 19, 2017, 11:05 a.m., KJ Tsanaktsidis wrote: > > --- > This is an automatically gen

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

31) <https://git.reviewboard.kde.org/r/130090/#comment68558> Usually we use uppper case for macros. That would also save some lines in this patch. nitpik: add spaces around >>, like you did for & in the line below. - Lamarque Souza On April 17, 2017, 8:42 a.m.,

Re: Review Request 123534: Add public dependency on ModemManager

n Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123534/ > --- > > (Updated April 27, 2015, 2:44 p.m.) > > > Review

Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/#review101731 --- Ship it! Ship It! - Lamarque Souza On Jan. 2, 2017

Re: Review Request 129607: Display Application version in About dialog header

> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128843/#review98937 --- Ship it! Ship It! - Lamarque Souza On Sept. 6, 2016

Re: Review Request 128843: Use standard org.freedesktop.DBus.Properties interfaces for monitoring PropertiesChanged signal for NM 1.4.0+

d-pointer. src/wirelessdevice.cpp (line 71) <https://git.reviewboard.kde.org/r/128843/#comment66611> There is no dbusPropertiesChanged slot in the d-pointer. It's odd not having a propertiesChanged slot for wireless. Is this correct? - Lamarque Souza On Sept. 6, 2016, 11:56 a.m., Jan Grulich wrote: > > --

Re: Review Request 128083: Find CPUs by subsystem rather than driver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128083/#review96241 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

) <https://git.reviewboard.kde.org/r/128084/#comment65041> This extracts the current cpu speed, not the maximum. Is that what you want? Yes then I think you should rename extractCpuSpeed() to extractCurrentCpuSpeed(). - Lamarque Souza On June 3, 2016, 12:15 p.m., David Edmundson

Re: Review Request 128085: Fix check that CPU is a valid CPU

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128085/#review96239 --- Ship it! Ship It! - Lamarque Souza On June 3, 2016, 12

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 8:36 AM, Harald Sitter wrote: > On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > > Hi, > > > > we decided to drop WiMAX support in nm-qt when it's compiled against NM > 1.2.0, > > but this seems to break binary compatibility

Re: Review Request 127209: Fix some issues found by Coverity

de.org/r/127209/#comment6> Same here. - Lamarque Souza On Feb. 28, 2016, 7:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89112 --- Ship it! Ship It! - Lamarque Souza On Dec. 3, 2015, 10:19

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

tps://git.reviewboard.kde.org/r/126222/#comment60992> Code style: move the bracket at the end of this line to the next line. - Lamarque Souza On Dec. 3, 2015, 10:19 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

> On Dec. 2, 2015, 4:45 p.m., Lamarque Souza wrote: > > That code was added to fix this bug > > https://bugs.kde.org/show_bug.cgi?id=171343#c6 > > Xuetian Weng wrote: > Emm.. interesting feature. But code inside mouseMoveEvent looks fishy, > and this fea

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

/show_bug.cgi?id=171343#c6 - Lamarque Souza On Dec. 2, 2015, 4:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126161: OS X housekeeping

tps://git.reviewboard.kde.org/r/126161/#comment60862> Please add a copyright header for each new file [1]. If I am not mistaken all frameworks 5 files should use LGLP+ license. [1] https://techbase.kde.org/Policies/Licensing_Policy - Lamarque Souza On Nov. 24, 2015, 11:03 p.m., René J.V.

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 17, 2015, 10:58 p.m., Lamarque Souza wrote: > > src/plugins/osx/macpoller.h, line 24 > > <https://git.reviewboard.kde.org/r/126078/diff/6/?file=417216#file417216line24> > > > > Nitpick: this should go after #include > > René J.V. Bertin w

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

g the failure to allocate memory. src/plugins/osx/macpoller_helper.mm (line 78) <https://git.reviewboard.kde.org/r/126078/#comment60682> There is no point in doing this if the next line will delete nativeGrabber. src/plugins/osx/macpoller_helper.mm (line 82) <https://git.reviewboard.kde.org/r/

Re: Review Request 124714: Add support to qmake's options to api.kde.org

- DEFINES += QT_NO_KEYWORDS - PKGCONFIG += libnm Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124714: Add support to qmake's options to api.kde.org

Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124714: Add support to qmake's options to api.kde.org

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/#review87955 ------- On Nov. 8, 2015, 1:21 a.m., Lamarque Souza wrote: > >

Re: Documentation on adding new Solid Backends

Hi, The documentation is located in http://techbase.kde.org/Development/Tutorials/Solid_Tutorials. I am afraid it is scarse and in some cases outdated. You can also take a look at available backends in git://anongit.kde.org/solid/src/solid/devices/backends as examples, specially udev and udisks2

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 75 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line75 i18n instead of tr Sune Vuorela wrote: Aren't we in a tier1 framework where i18n and friends aren't available

Re: Review Request 124963: New widget: KNewPasswordWidget

in that particular case? - Lamarque Souza On Aug. 28, 2015, 9:24 a.m., Elvis Angelaccio wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963

Re: Review Request 124963: New widget: KNewPasswordWidget

On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 92 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line92 Is there any documentation explaining this calculation? Elvis Angelaccio wrote: I don't know, sorry

Review Request 124714: Add support to qmake's options to api.kde.org

/metainfo.html and kapidox created the correct output: qmakepro: - config: link_pkgconfig - defines: QT_NO_KEYWORDS - pkgconfig: libnm Thanks, Lamarque Souza ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: [kwallet] /: Updating maintainer name

:16:17 Lamarque Souza wrote: Does the maintainer field accept more than one identity? That's the question. Go ahead and do that, Alex Merry volunteered to fix kapidox if necessary :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: [kwallet] /: Updating maintainer name

Does the maintainer field accept more than one identity? Lamarque V. Souza http://planetkde.org/pt-br On Mon, Aug 3, 2015 at 7:11 AM, Alex Merry alex.me...@kde.org wrote: On Sunday 02 August 2015 19:31:36 David Faure wrote: Are you sure about this? All other frameworks use the identity

Re: Review Request 124413: Enable PAM opening KWallet again

. - Lamarque Souza On July 21, 2015, 3:52 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413

Re: Review Request 124413: Enable PAM opening KWallet again

On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string

Re: Review Request 124413: Enable PAM opening KWallet again

On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

://git.reviewboard.kde.org/r/124133/#comment56243 Please call QLabel pointer-setTextInteractionFlags(Qt::TextSelectableByMouse) before calling versionLayout-addWidget(QLabel pointer). - Lamarque Souza On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: +1 for adding all that info -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add

Re: Review Request 123533: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123533/#review79634 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2

Re: Review Request 123534: Add public dependency on ModemManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/#review79635 --- Ship it! Ship It! - Lamarque Souza On April 27, 2015, 2

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

the extra-cmake-module maintainer to give the final ship it. - Lamarque Souza On April 27, 2015, 2:38 p.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123532

Re: Review Request 123477: Add public dependency on NetworkManager

/ --- (Updated April 23, 2015, 1:01 p.m.) Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Lamarque Souza. Repository: networkmanager-qt Description --- I'm not 100% sure how this should work and I couldn't find another framework doing

Re: Review Request 123401: Fix usage of the networkmanagerqt_export.h after commit 9966897

blocks 'git pull' (among serveral other services) so I could not test it myself. Plasma NM can be fixed later. - Lamarque Souza On April 17, 2015, 3:53 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 123360: Introduce LoopSound flag

On April 14, 2015, 3:50 p.m., Lamarque Souza wrote: src/notifybyaudio.cpp, line 89 https://git.reviewboard.kde.org/r/123360/diff/1/?file=361076#file361076line89 Should not this patch be followed by another patch that set LoopSound flag for Persistant notifications that *really

Re: Review Request 123360: Introduce LoopSound flag

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123360/#review78950 --- Ship it! Ship It! - Lamarque Souza On April 14, 2015, 2

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

On April 13, 2015, 7:13 a.m., David Faure wrote: examples/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5 well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

. - Lamarque Souza On April 12, 2015, 7:57 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/ --- (Updated

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

Hi all, Following the obsolete action, could someone mark Network Management product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM,

Re: libmm-qt/libnm-qt as KF5

2014 19:51:05 Lamarque Souza wrote: I understood that, I just do not know all the other things we need to do to make NMQt/MMQt part of KF5. And yes, I agree in making NMQt/MMQt part of KF5. The other doubt I still have is where _kde_add_platform_definitions is defined. By what I could

Re: libmm-qt/libnm-qt as KF5

2014 19:51:05 Lamarque Souza wrote: I understood that, I just do not know all the other things we need to do to make NMQt/MMQt part of KF5. And yes, I agree in making NMQt/MMQt part of KF5. The other doubt I still have is where _kde_add_platform_definitions is defined. By what

Re: libmm-qt/libnm-qt as KF5

kde...@unormal.org wrote: Am Montag, 07. April 2014, 14.38:14 schrieb Lamarque Souza: Hi all, Morning Lamarque I have cloned ECM git repo and looked at it. I agree that it is small and it has useful features for NMQt/MMQt. I like the fact that it provides a FindNetworkManager.cmake. Ok

Re: Re: libmm-qt/libnm-qt as KF5

Hi all, I have cloned ECM git repo and looked at it. I agree that it is small and it has useful features for NMQt/MMQt. I like the fact that it provides a FindNetworkManager.cmake. Ok, we can make ECM a hard dependency for NMQt/MMQt. My only concern now is the kde-modules that Jan used in

Re: libmm-qt/libnm-qt as KF5

probably change versions, releasing etc. Jan On Monday 07 of April 2014 09:38 Lamarque Souza wrote: Hi all, I have cloned ECM git repo and looked at it. I agree that it is small and it has useful features for NMQt/MMQt. I like the fact that it provides a FindNetworkManager.cmake. Ok, we can

Re: libmm-qt/libnm-qt as KF5

Qt API for NetworkManager/ModemManager, so you can manage connections and devices. Jan On Friday 04 of April 2014 05:29 Lamarque Souza wrote: Both libraries are meant to be reusable. What I meant with merge is the fact that the branches frameworks in NMQt and MMQt depends on KF5's cmake

Re: libmm-qt/libnm-qt as KF5

Ottens er...@kde.org escreveu: Hello, On Thursday 03 April 2014 20:19:45 Lamarque Souza wrote: Well, NetworkManagerQt and ModemManagerQt are Qt only libraries since the beginning. They are not meant to depend on any KDE libraries as I said, so they are not meant to be merged to KF5. Note

Re: libmm-qt/libnm-qt as KF5

V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Sat, Apr 5, 2014 at 12:08 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 4 d'abril de 2014, a les 07:57:26, Lamarque Souza va escriure: NMQt and MMQt used to be backends for Solid. We moved them from Solid

Re: libmm-qt/libnm-qt as KF5

Is using ECM required to be part of KF5? Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Sat, Apr 5, 2014 at 12:56 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 5 d'abril de 2014, a les 12:39:27, Lamarque Souza va escriure: In CMakeLists.txt

Re: libmm-qt/libnm-qt as KF5

Hi all, 1) I do not see a real need to rename (again) ModemManagerQt and NetworkManagerQt. They are named that way to indicate they depend only on Qt and not on any library created by KDE, so they are tier1 since the beginning. I am not familiar with KF5's library naming conventions but I would

Re: libmm-qt/libnm-qt as KF5

keep them Qt only and not depend on KF5, the opposite is ok though. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Thu, Apr 3, 2014 at 1:11 PM, Jan Grulich jgrul...@redhat.com wrote: On Thursday 03 of April 2014 12:52 Lamarque Souza wrote: Hi all, 1

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- Ship it! Ship It! - Lamarque Souza On March 4, 2014, 4:13

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: Ship It! Lamarque Souza wrote: This should be ported to branches master and NM/0.9.8 as well. Alexander Richardson wrote: How should I commit it? Commit to oldest branch and then merge? Or rather put this into qt5

Re: Review Request 116098: Use KDEInstallDirs

for everybody. Is there any real issue solved by GNUInstallDirs that cannot be solved by -DLIB_SUFFIX=64? - Lamarque Souza On March 1, 2014, 11:14 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail