D7175: Redesign CMake syntax

dhaumann added a comment. Sure? It was reverted a month ago once. Was it applied again? REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, #frameworks, michaelh, ngraham, bruns

D7175: Redesign CMake syntax

cullmann closed this revision. cullmann added a comment. This is already pushed ;=) Autor: Alex Turbov 2017-08-07 08:01:46 Eintragender: Alex Turbov 2018-03-28 21:17:34 Eltern: aa5a8e08e0a2004536ab87531ef93217cf4a

D7175: Redesign CMake syntax

cullmann accepted this revision. cullmann added a comment. Yes, please push your change. Thanks for the work! REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, #frameworks, michaelh, ngraham,

D7175: Redesign CMake syntax

dhaumann added a comment. Oh, and btw. sorry that this review took essentially 7 months. Sometimes we simply suck and things go badly wrong :-) REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann, #frameworks,

D7175: Redesign CMake syntax

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. So everyone seems to agree that in general it's a good idea. @turbov Please go ahead and commit. Don't forget to run make test, and possibly update the unit test rererence with

D7175: Redesign CMake syntax

turbov updated this revision to Diff 26933. turbov added a comment. Updates for CMake 3.11 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=23100=26933 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#202300, @vkrause wrote: > I'm with Christoph on this. Having the generated code checked in is fine, I'd like to avoid running this on compile time due to the extra dependencies. It doesn' needed to run anything @

D7175: Redesign CMake syntax

cullmann added a comment. If the new highlighting better covers what CMake has around on features now than the old, I am for adding the new one. If the generator is optimal or not is an other thing, but as long as we would just check in the result and have the generator as addition to

D7175: Redesign CMake syntax

turbov added a comment. @cullmann , @dhaumann if there is no intereset, I'll close this review and will distribute my CMake syntax in other ways... REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann,

D7175: Redesign CMake syntax

turbov added a comment. ping REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann, #frameworks

D7175: Redesign CMake syntax

turbov updated this revision to Diff 23100. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=6=23100 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh data/generators/cmake.xml.tpl data/generators/cmake.yaml

D7175: Redesign CMake syntax

turbov updated this revision to Diff 6. turbov edited the summary of this revision. turbov added a comment. Updated for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21208=6 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES

D7175: Redesign CMake syntax

turbov updated this revision to Diff 21208. turbov added a comment. Include updates for CMake 3.10 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=21207=21208 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D7175: Redesign CMake syntax

turbov updated this revision to Diff 21207. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=18322=21207 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake.yaml data/generators/generate-cmake-syntax.py data/syntax/cmake.xml To:

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#138554, @dhaumann wrote: > What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right? correct. it

D7175: Redesign CMake syntax

dhaumann added a comment. What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right? I would be fine with this change, but the other point still stand: remove hard-coded

D7175: Redesign CMake syntax

turbov updated this revision to Diff 18322. turbov added a comment. Remove spaces around `` CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7175?vs=17801=18322 REVISION DETAIL https://phabricator.kde.org/D7175 AFFECTED FILES data/generators/cmake-gen.sh

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#133152, @dhaumann wrote: > I see seveal issues that imo should be addressed: > > 1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?) no, I don't run tests yet (it

D7175: Redesign CMake syntax

dhaumann added a comment. I see two issues that imo should be addressed: 1. Please add a test case in autotest/input/ or extend it if one already exists (did you run make test?) 2. How does it work, are we supposed to run this command from time to time manually? If so, then I'd be

D7175: Redesign CMake syntax

cullmann added a reviewer: vkrause. cullmann added a comment. If that makes it easier to keep the syntax file up-to-date, I would have no issues with a generator build in this way. If we ever want to go away from it, we still have the generated file around as base. But Volker should give

D7175: Redesign CMake syntax

turbov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake syntax has been redesigned to pursue the following goals: - the former generator has used an output of `cmake --help` (and