D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#394818 , @filipf wrote: > +1 in regards to at least getting the new switch user icon into master, it's great @pstefan, any chance we can cudgel you into doing this? 😛 REPOSITORY R242 Plasma Framework

D15999: Add icons with added background to system.svgz

filipf added a comment. They only work for me when using a dark theme: F6552425: image.png F6552428: image.png We could just do QML circles. Pro is they assure legibility with many non-Breeze icons, co

D15999: Add icons with added background to system.svgz

ngraham requested changes to this revision. ngraham added a subscriber: rooty. ngraham added a comment. This revision now requires changes to proceed. I still haven't managed to get these icons to actually work, per recent discussions. The background is always light instead of dark. Also the p

D15999: Add icons with added background to system.svgz

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can you also bump the version numbers in the `metadata.desktop` files? REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D15999 REVISION DETAIL https://phabricator.kde.org

D15999: Add icons with added background to system.svgz

ndavis accepted this revision as: ndavis. ndavis added a comment. Looks like you've addressed all of my concerns, so I'll accept this. @ngraham ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis,

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46655. pstefan added a comment. - Fix transparency of home icon in go.svgz REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=46626&id=46655 BRANCH arcpatch-D15999 REVISION DETAIL https://p

D15999: Add icons with added background to system.svgz

ndavis added a comment. Is the home button in `go.svgz` meant to be partially transparent? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46626. pstefan added a comment. - Fix stylesheet in go.svgz REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=46583&id=46626 BRANCH arcpatch-D15999 REVISION DETAIL https://phabricator.kde.

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369135 , @ndavis wrote: > In D15999#369134 , @pstefan wrote: > > > In D15999#369132 , @ndavis wrote: > > > > > In D1

D15999: Add icons with added background to system.svgz

ndavis added a comment. In D15999#369134 , @pstefan wrote: > In D15999#369132 , @ndavis wrote: > > > In D15999#369131 , @pstefan wrote: > > > > > In D15

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369132 , @ndavis wrote: > In D15999#369131 , @pstefan wrote: > > > In D15999#369066 , @ndavis wrote: > > > > > With

D15999: Add icons with added background to system.svgz

ndavis added a comment. In D15999#369131 , @pstefan wrote: > In D15999#369066 , @ndavis wrote: > > > With colorschemes applied, these will be your colors: > > > > | Ring| Backgro

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#369066 , @ndavis wrote: > With colorschemes applied, these will be your colors: > > | Ring| Background | Symbol | > | --- | -- | --- | >Breeze | #f

D15999: Add icons with added background to system.svgz

ndavis added a comment. With colorschemes applied, these will be your colors: | Ring| Background | Symbol | | --- | -- | --- | Breeze | #fcfcfc | #eff0f1| #232627 | Breeze Dark | #232629 | #31363b| #eff0f1 | REPOSITOR

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46583. pstefan added a comment. - Remove hardcoded background color; Switch background to "ColorScheme-ViewBackground" - Reintroduce the outline border on top of the background. Opacity set to 0.3 - Removed superfluous entries in the style properties

D15999: Add icons with added background to system.svgz

filipf added a comment. In D15999#368500 , @ngraham wrote: > In D15999#368499 , @filipf wrote: > > > But there is a tangible problem here - imagine what the logout screen when using dark themes would

D15999: Add icons with added background to system.svgz

ngraham added a comment. Urgh, never mind, it was my fault all along. There was some cache somewhere; bumping the version number of the plasma theme fixed the issue entirely. I'm sorry for wasting your time. :( I'm happy with this now, though now that it's all working, there are two nic

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#368499 , @filipf wrote: > In D15999#368498 , @ngraham wrote: > > > In D15999#368479 , @ndavis wrote: > > > > > It ap

D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#368499 , @filipf wrote: > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark[;] They would be weird looking and would be superf

D15999: Add icons with added background to system.svgz

filipf added a comment. In D15999#368498 , @ngraham wrote: > In D15999#368479 , @ndavis wrote: > > > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze

D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#368479 , @ndavis wrote: > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the `ColorScheme-T

D15999: Add icons with added background to system.svgz

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the `ColorSch

D15999: Add icons with added background to system.svgz

ngraham added a comment. The existing icons in this style are already in the Plasma Breeze theme though; that was our reasoning for adding them here. In the medium-to-long-term, I strongly support deprecating the concept of the Plasma Breeze icon theme and centralizing everything in the gene

D15999: Add icons with added background to system.svgz

ndavis added a comment. Could these icons be moved into the breeze-icons repo? That would make it simpler to edit and review these in the future. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis,

D15999: Add icons with added background to system.svgz

ngraham added a reviewer: ndavis. ngraham added a subscriber: ndavis. ngraham added a comment. Sorry this took a while. I had to stop work on D16031 until other changes got accepted and merged in, which happened today. Back to these icons... I hate to

D15999: Add icons with added background to system.svgz

ngraham added a comment. Ahh, much better! Reviewing... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 45137. pstefan added a comment. - Hardcoded background color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44890&id=45137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D159

D15999: Add icons with added background to system.svgz

ngraham added a comment. I'm afraid that didn't change anything for me. If the experiment to make the background color adapt to the theme isn't working, maybe we should revert that change for now and just keep it hardcoded for now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAI

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 44890. pstefan added a comment. - Fixed z order REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44889&id=44890 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15999 AFFECTED

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 44889. pstefan added a comment. - Added missing class attributes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44862&id=44889 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D15999: Add icons with added background to system.svgz

ngraham added a comment. Hmm, I just deployed with the latest change and suddenly the icons are weird: F6391195: Weird icons.jpeg REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 44862. pstefan added a comment. - Sized down icons somewhat - Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, etc). 32px only for now - Made background darker - Removed outer circle - Merge branch 'master' of git://anong

D15999: Add icons with added background to system.svgz

ngraham added a comment. Any update on this, @pstefan? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ngraham added a comment. So to recap recent discussions, here are the requested changes: - (Required) Create a version of the `go-previous` icon with this same style, and name it `go-previous-translucent` - (Required) Make the background circle more opaque and/or darker - (Optional, y

D15999: Add icons with added background to system.svgz

filipf added a comment. So what I suggested and tried to sketch in D16031 was to scale the icon down a bit inside the circles just so it's proportionally more satisfactory to the eye. I also removed the faint outer border to not oversaturate the new icons

D15999: Add icons with added background to system.svgz

ngraham added a subscriber: broulik. ngraham added a comment. This came up in D16031#339966 : @broulik suggested putting a drop shadow behind the icon, and I gave it a try with your new icons. The result was radically improved contrast and a very

D15999: Add icons with added background to system.svgz

pstefan added a comment. RE: In D15999#338724 , @filipf wrote: > Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) > > F6310672: image.png

D15999: Add icons with added background to system.svgz

pstefan added a comment. RE: In D15999#338724 , @filipf wrote: > Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) > > F6310672: image.png

D15999: Add icons with added background to system.svgz

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ngraham added a task: T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, b

D15999: Add icons with added background to system.svgz

ngraham removed a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham,

D15999: Add icons with added background to system.svgz

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, b

D15999: Add icons with added background to system.svgz

filipf added a comment. Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) Could we make it adaptable to the color scheme? I don't know if the code applies, but they managed to do it here: https://github.com/PapirusDevelopmentTe

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 43051. pstefan added a comment. Fix z-layering issue for the "-translucent" icons. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=43009&id=43051 BRANCH master REVISION DETAIL https://ph

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. pstefan added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan created this revision. pstefan added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pstefan requested review of this revision. REVISION SUMMARY Added duplicates of system.svgz' icons' with added background. The background color