---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79510
---
Ship it!
Ship It!
- Matthew Dawson
On April 25, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 25, 2015, 11:42 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79507
---
autotests/kconfig_compiler/test13.h.ref (line 55)
On April 25, 2015, 3:50 a.m., Matthew Dawson wrote:
autotests/kconfig_compiler/test13.h.ref, line 55
https://git.reviewboard.kde.org/r/123367/diff/9/?file=363036#file363036line55
Also, I guess brightnessChanged and usrWriteconfig don't need to be
generated anymore if a signal
On April 24, 2015, 8:47 p.m., Matthew Dawson wrote:
autotests/kconfig_compiler/test13.cpp.ref, line 33
https://git.reviewboard.kde.org/r/123367/diff/7-8/?file=362762#file362762line33
Is there a reason this got moved back?
Well, Modified needs to be called together with Changed,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79450
---
autotests/kconfig_compiler/test13.cpp.ref (line 18)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 25, 2015, 3:39 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79483
---
Ok, I think this should be last set of comments. One thing I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 24, 2015, 6:56 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79473
---
Looks good, one last comment:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79403
---
autotests/kconfig_compiler/test13.cpp.ref (line 18)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 24, 2015, 2:53 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 22, 2015, 6:07 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79346
---
autotests/kconfig_compiler/test13.h.ref (line 38)
On April 22, 2015, 4:36 p.m., Vishesh Handa wrote:
autotests/kconfig_compiler/test_signal.h.ref, line 126
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361167#file361167line126
Is the move required?
This is a unit test, this is how it gets generated after the patch.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 22, 2015, 4:51 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79343
---
autotests/kconfig_compiler/test_signal.h.ref (line 121)
On April 22, 2015, 10:53 a.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79347
---
Ship it!
- Vishesh Handa
On April 22, 2015, 2:51 p.m.,
On April 22, 2015, 4:53 p.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
On April 22, 2015, 4:53 p.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
On April 22, 2015, 10:53 a.m., Matthew Dawson wrote:
src/kconfig_compiler/kconfig_compiler.cpp, line 100
https://git.reviewboard.kde.org/r/123367/diff/3/?file=361168#file361168line100
Is there a reason not to generate Q_PROPERTIES for all classes, or at
least do it by default?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79353
---
If the first issue doesn't fit into this commit, this has a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 23, 2015, 3:20 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79355
---
autotests/kconfig_compiler/test13.h.ref (line 20)
On April 22, 2015, 5 p.m., Albert Astals Cid wrote:
autotests/kconfig_compiler/test13.h.ref, line 20
https://git.reviewboard.kde.org/r/123367/diff/5/?file=362514#file362514line20
Why is there no brightness property anymore?
I still see it on line 40.
- Matthew
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79361
---
autotests/kconfig_compiler/test13.h.ref (line 20)
On April 15, 2015, 5:20 p.m., Albert Astals Cid wrote:
properties that are read only should have CONSTANT in the Q_PROPERTY, no?
I wasn't sure. Checking the implementation I see that it's using a local
variable rather than fetching the information from the configuration, so it's
probably
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 15, 2015, 5:38 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
Review request for KDE Frameworks and Matthew Dawson.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 15, 2015, 5:11 p.m.)
Review request for KDE Frameworks
31 matches
Mail list logo
