D11452: sanitizer: Improve device listing

michaelh added a comment. In D11452#231277 , @smithjd wrote: > If you browse your recently committed code in Diffusion, you'll notice that your linespaces can be copy and pasted. This doesn't match the current style where the tabs are spaces

D4716: Add some more directives to MIPS assembler highlighting

arichardson updated this revision to Diff 30212. arichardson marked 2 inline comments as done. arichardson added a comment. address comments will try to add tests soon REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4716?vs=11618=30212 BRANCH

D11487: optimization of TextLineData::attribute

mwolff added a comment. @jtamate looking at your screenshots, it represents closely what I see locally. Most notably, there are no red underlines in your screenshots which could arise due to spell checking. Thus I really wonder why you are seeing such a big hotspot there. Try perf, or

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/109/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Mar 2018 11:49:32 + Build duration: 4 min 57 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/84/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Mar 2018 11:49:32 + Build duration: 7 min 24 sec and counting

D11557: remove anchors of item in a layout

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6291c4852fdf: remove anchors of item in a layout (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham retitled this revision from "Improve consistency of "Open With" UI" to "Improve consistency of "Open With" UI by always showing top app inline". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure,

D11569: Improve consistency of "Open With" UI by always showing top app inline

davidedmundson added a comment. +1 looks good REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

broulik added a comment. "Open With..." are quite memorable labels used in Windows, I fear "Open With Application" will take away the recognizability of "Öffnen mit …" in German to "Mit Anwendung öffnen". But I won't object. REPOSITORY R241 KIO REVISION DETAIL

D11569: Improve consistency of "Open With" UI

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

abetts added a comment. +1 on this! Easy access to apps! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11582: Generate the rcc file every time, at install time

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D11582 To: apol, #frameworks, #plasma, mart Cc: michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Mar 2018 14:21:43 + Build duration: 4 min 24 sec and counting JUnit

D11569: Improve consistency of "Open With" UI

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitemactions.cpp:654 > +// Always show the top app inline > +QAction *act = d->createAppAction(offers.first(), menu); > +menu->addAction(act); Use offers.takeFirst(), it will get and remove. >

D11569: Improve consistency of "Open With" UI

ngraham updated this revision to Diff 30233. ngraham added a comment. Use `takeFirst()` to avoid a separate `remove()` invocation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30227=30233 BRANCH open-with-usability (branched from master) REVISION

D11569: Improve consistency of "Open With" UI by always showing top app inline

rkflx added a comment. @ngraham Thanks for setting me as a reviewer, I try to have a look before Frameworks string freeze on saturday. Focussing on on Apps string freeze today ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg,

D11569: Improve consistency of "Open With" UI

ngraham retitled this revision from "Improve usability of "Open With" UI" to "Improve consistency of "Open With" UI". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To:

D11569: Improve consistency of "Open With" UI

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: anthonyfieroni, abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI

ngraham updated this revision to Diff 30227. ngraham added a comment. Add a separator to the top menu when there's a submenu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30226=30227 BRANCH open-with-usability (branched from master) REVISION

D11566: KCapacityBar: set QStyle::State_Horizontal state

This revision was automatically updated to reflect the committed changes. Closed by commit R236:e489bebd3df0: KCapacityBar: set QStyle::State_Horizontal state (authored by zzag). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11566?vs=30171=30228

D11569: Improve consistency of "Open With" UI

anthonyfieroni added reviewers: dfaure, elvisangelaccio. anthonyfieroni added subscribers: elvisangelaccio, dfaure. anthonyfieroni added a comment. +1 @dfaure and @elvisangelaccio can have other objections. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To:

D11487: optimization of TextLineData::attribute

mwolff added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katetextline.cpp:214-216 > Use operator->, it's faster than operator* and operator. > > first->offset sorry, but that's simply not true at all. Stylistic wise I agree, but an optimizing compiler will generate the same

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#231522 , @mwolff wrote: > @jtamate looking at your screenshots, it represents closely what I see locally. Most notably, there are no red underlines in your screenshots which could arise due to spell checking.

D11569: Improve usability of "Open With" UI

ngraham updated this revision to Diff 30226. ngraham added a comment. Always show top app inline, and others in the sub-menu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30182=30226 BRANCH open-with-usability (branched from master) REVISION

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Mar 2018 14:21:43 + Build duration: 3 min 9 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 14:21:43 + Build duration: 14 min and counting JUnit Tests

D11582: Generate the rcc file every time, at install time

apol created this revision. apol added reviewers: Frameworks, Plasma. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY In the case of bundles, installing consists of putting all the files in the rcc and put this file on the right

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. In D11569#231663 , @mmustac wrote: > I have two questions regarding this "open with" topic. > Is the displayed app the one which is also set as default for this file type or the first alternative (2nd app) ? If it's

Re: Experimental class in baloo

p.s. It is common for the pimpl classes in Qt and KF5 to be named ClassName::Private or ClassNamePrivate and for the pointer to be named `d` - not ClassNameImpl and m_pimpl. p.p.s. I've seen that the DatabaseSanitizer is exported in libKF5BalooEngine.so.5 - if this is a library meant for 3rd

Re: Experimental class in baloo

Hi, Is this a class that is supposed to be available in the library (.so file) - to be used in applications that use baloo, or is it only a class in the backend? If it is the second case (which I guess it is since I don't see the symbols exported in libKF5Baloo.so), then this should not be a

D1231: Add Remote Access interface to KWayland

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:430 > +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui > KF5::WaylandClient KF5::WaylandServer) > +add_test(kwayland-testRemoteAccess testRemoteAccess) > +ecm_mark_as_test(testRemoteAccess) `add_test(NAME

D11583: Add platform detection and adjustment to kded

graesslin created this revision. graesslin added reviewers: Frameworks, Plasma, apol. Restricted Application added a project: Frameworks. graesslin requested review of this revision. REVISION SUMMARY Current Plasma/master branch does no longer set the QT_QPA_PLATFORM env variable on Wayland.

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 20:20:45 + Build duration: 4 min 22 sec and counting JUnit Tests Name:

D11238: filemetadatawidgettest: Enforce en_US locale

This revision was automatically updated to reflect the committed changes. Closed by commit R824:469037b96b20: filemetadatawidgettest: Enforce en_US locale (authored by michaelh). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11238?vs=29833=30255

D11569: Improve consistency of "Open With" UI by always showing top app inline

mmustac added a comment. I have two questions regarding this "open with" topic. Is the displayed app the one which is also set as default for this file type or the first alternative (2nd app) ? If it's the default one why should someone make a right click on a file to open it with his/her

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 52 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Mar 2018 20:20:45 + Build duration: 6 min 17 sec and counting JUnit Tests Name:

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY This test is essentially a duplication of `TermGeneratorTest` which could not be extended by

D11552: [WIP] Handle CJK characters

michaelh updated this revision to Diff 30252. michaelh edited the test plan for this revision. michaelh added a comment. - Base on D11587 - Make tests pass - Use QChar.script() and QChar.isLetter() REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh added a dependent revision: D11552: [WIP] Handle CJK characters. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11587 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11552: [WIP] Handle CJK characters

michaelh edited the summary of this revision. michaelh edited the test plan for this revision. michaelh added a dependency: D11587: [WIP] autotests: Introduce TermGeneratorTestUTF. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns,

D11506: baloodb: Add experimental message

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a49cac4781ad: baloodb: Add experimental message (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11506?vs=29984=30254 REVISION DETAIL

D11552: [WIP] Handle CJK characters

cfeck added inline comments. INLINE COMMENTS > characterrangescjk.cpp:35 > +for (int i = 0; i < text.length(); i++) { > +const QChar& c = text.at(i); > +if (m_graphemeWords.contains(c.script()) && c.isLetter()) { Add surrogate pair handling. Basic outline: uint c =

D11552: [WIP] Handle CJK characters

michaelh added a comment. In D11552#231784 , @bruns wrote: > In D11552#231330 , @hein wrote: > > > For the record though - a better way to do this is to use QTextBoundaryFinder which will operate

D11552: [WIP] Handle CJK characters

michaelh updated this revision to Diff 30257. michaelh added a comment. - Add surrogate pair handling - Remove obsolete #include REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11552?vs=30252=30257 BRANCH cjk (branched from master) REVISION DETAIL

D11552: [WIP] Handle CJK characters

michaelh added inline comments. INLINE COMMENTS > characterrangescjk.cpp:40 > +} > +if (c.isLetter() && m_graphemeWords.contains(c.script())) { > +result << c; Like that? Only 60% aware of what I'm doing here. Do you know of an example text I can incorporate into the

D11552: [WIP] Handle CJK characters

bruns added a comment. In D11552#231330 , @hein wrote: > For the record though - a better way to do this is to use QTextBoundaryFinder which will operate e.g. on grapheme cluster boundaries. This still isn't super great for Chinese though. If

D11452: sanitizer: Improve device listing

smithjd added a comment. In D11452#230590 , @michaelh wrote: > In D11452#230387 , @smithjd wrote: > > > Could you please make your tab spacing conform to the style of the > > codebase? This

D11487: optimization of TextLineData::attribute

jtamate added a comment. In D11487#231110 , @mwolff wrote: > Considering spell checking is involved - can you show a screenshot for how the file looks like for you? There shouldn't be a lot of spell checking going on, or so I hope...

D11570: Introduce GamingInputBattery type

fvogt edited reviewers, added: lbeltrame; removed: fvogt. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11570 To: broulik, #frameworks, apol, dollinger, lbeltrame Cc: michaelh, ngraham

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Mar 2018 23:44:42 + Build duration: 53 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 23:44:42 + Build duration: 1 min 37 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Mar 2018 23:44:42 + Build duration: 1 min 44 sec and counting JUnit Tests

D11552: [WIP] Handle CJK characters

cfeck added inline comments. INLINE COMMENTS > characterrangescjk.cpp:41 > +if (c.isLetter() && m_graphemeWords.contains(c.script())) { > +result << c; > +} To add a uint to a QStringList, convert the uint character to a QString. Either manually compose the

D11582: Generate the rcc file every time, at install time

This revision was automatically updated to reflect the committed changes. Closed by commit R290:afa1fc1aa49e: Generate the rcc file every time, at install time (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11582?vs=30237=30262#toc REPOSITORY R290 KPackage CHANGES

D11552: [WIP] Handle CJK characters

cfeck requested changes to this revision. cfeck added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > characterrangescjk.cpp:38 > +if (i < length - 1 && c.isHighSurrogate() && > text.at(i+1).isLowSurrogate()) { > +c = c.surrogateToUcs4(c,

D11553: Adding Battery Devices Enum

This revision was automatically updated to reflect the committed changes. Closed by commit R245:619d7a492b18: Adding Battery Devices EnumAdding Battery Devices Enum (authored by dollinger, committed by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D11331: add gaming_input devices and others to Battery

broulik added a comment. Thanks a lot for yout patience and sorry it had to go through that many revisions. I took the liberty of altering it to check each value explicitly, so when a new one is added it isn't forgotten to evaluate whether it makes sense to support or not, I hope

D11552: [WIP] Handle CJK characters

hein added a comment. For the record though - a better way to do this is to use QTextBoundaryFinder which will operate e.g. on grapheme cluster boundaries. This still isn't super great for Chinese though. If you want to really-properly do it you'll end up depending on ICU and using its

D11557: remove anchors of item in a layout

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D11557 To: davidedmundson, #plasma, broulik Cc: #frameworks, michaelh,

D11552: [WIP] Handle CJK characters

hein added a comment. If you're going to loop over a QString and break it down into QChars anyway, why don't you just use QChar::script? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11552 To: michaelh, hein Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck,

D11331: add gaming_input devices and others to Battery

This revision was automatically updated to reflect the committed changes. Closed by commit R245:12dc9354e598: add gaming_input devices and others to Battery (authored by dollinger, committed by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11331?vs=30141=30195#toc REPOSITORY

D11570: Introduce GamingInputBattery type

broulik created this revision. broulik added reviewers: Frameworks, apol, fvogt, dollinger. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This is for e.g. wireless gamepads and joysticks TEST PLAN Compiles, Don't have the