e.
[1] - https://quickgit.kde.org/?p=solid-power.git[1]
Regards,
Jan
--
Jan Grulich
Software Engineer, Desktop team
Red Hat Czech
On Wednesday 10 of February 2016 15:55:51 Aleix Pol wrote:
> Hi,
> I've been looking in the last days what applications and uses make our
> soft
that error then it means
either LastSeen property was introduced in older NM version or it was
backported in your distribution. I'll check that and update that
NM_CHECK_VERSION accordingly.
- Jan Grulich
On Kvě. 3, 2016, 2:04 odp., Allen Wi
> On Kvě. 3, 2016, 2:30 odp., Jan Grulich wrote:
> > That doesn't make much sense to me, if you are getting that error then it
> > means either LastSeen property was introduced in older NM version or it was
> > backported in your distribution. I
r exactly by one composed character so I was trying to find a way to do it
similarly.
Diffs
-
src/document/katedocument.cpp 73778a1
src/view/kateview.h 08db0df
src/view/kateview.cpp fda6b2d
Diff: https://git.reviewboard.kde.org/r/127843/diff/
Testing
-
posted them here:
https://paste.kde.org/piptzo584
- Jan Grulich
On Kvě. 5, 2016, 10:05 dop., Jan Grulich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
is is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---
On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
>
> ---
pointer is possibly a nullptr?
> >
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution
> > would be to expose this class so that proper text navigation is available
> > everywhere (e.g. KTextEditor::ViewCursor, just like
> > KTextEditor::Do
pointer is possibly a nullptr?
> >
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution
> > would be to expose this class so that proper text navigation is available
> > everywhere (e.g. KTextEditor::ViewCursor, just like
> > KTextEditor::Do
pointer is possibly a nullptr?
> >
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution
> > would be to expose this class so that proper text navigation is available
> > everywhere (e.g. KTextEditor::ViewCursor, just like
> > KTextEditor::Do
you think is a better option?
Change review: https://git.reviewboard.kde.org/r/123642/
I'm really sorry for this problem and will be more careful next time when
doing such changes. Thanks.
Regards,
Jan
--
Jan Grulich
Software Engineer, Deskto
y to change.
I just took inspiration from some Tier1 frameworks and changed it accordingly.
NOTE: plasma-nm is not ported to use framework branches, it is still using
master branches and I don't want to port it yet.
Thanks a lot.
Cheers,
Jan
--
Jan Grulich
Red Hat Cz
gt;
Plasma NM is already ported to KF5/Plasma2 and it is working perfectly, except
a few things that needs to be polished or finished. I meant it is not ported to
my latest changes in libmm-qt/libnm-qt (framework branches).
Jan
> On Thu, Apr 3, 2014 at 11:47 AM, Jan Grulich wrote:
> > Hi
reasons to not have those two in KF5, but the one you
> > advance
> > is clearly the wrong one.
> >
> > Regards.
> > --
> > Kévin Ottens, http://ervin.ipsquad.net
> >
> > KDAB - proud supporter of KDE, http://www.kdab.com
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> >
> > You
> >
> > > can make that dependency optional but do not force it over everybody
> > > like
> > > you did in NMQt/MMQt's frameworks branches.
> > >
> > > Besides depending on KF5's cmake modules wha
, Martin Gräßlin wrote:
> > On Monday 07 April 2014 10:14:12 David Faure wrote:
> > > On Monday 07 April 2014 09:47:43 Jan Grulich wrote:
> > > > You are still talking about users, but I'm sure that 99% of them will
> > > > install it from distro repositories
ou'd better merge them in plasma-nm.
>
> Personally I doubt they're useful outside of plasma-nm though. But that's
> your job as maintainer to pick a choice.
>
I'm convinced that they could be useful for others, i.e ModemMana
py my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
My phone is visible in Dolphin and I was able to finally copy my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
My phone is visible in Dolphin and I was able to finally copy my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
119382/diff/
Testing
---
My phone is visible in Dolphin and I was able to finally copy my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/l
s://git.reviewboard.kde.org/r/119382/#review62770
-----------
On Čec. 21, 2014, 11:02 dop., Jan Grulich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119382/
> -
119382/diff/
Testing
---
My phone is visible in Dolphin and I was able to finally copy my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/l
d.kde.org/r/119382/diff/
Testing
---
My phone is visible in Dolphin and I was able to finally copy my photos from
phone to my laptop.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.
://git.reviewboard.kde.org/r/120598/diff/
Testing
---
I tested it in Dolphin and it seems to work.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/diff/
Testing
---
Tested in dolphin and now I'm able to create a new text file or link to an
application.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Diffs
-
src/filewidgets/knewfilemenu.cpp a24ac9c
Diff: https://git.reviewboard.kde.org/r/120599/diff/
Testing
---
Tested in dolphin and now I'm able to create a new text file or link to an
application.
Thanks,
Jan Grulich
___
Kde-
RenameDialog in Kio::CopyJob.
Diffs
-
src/core/copyjob.cpp 9f1826a
Diff: https://git.reviewboard.kde.org/r/120598/diff/
Testing
---
I tested it in Dolphin and it seems to work.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde
option to RenameDialog in Kio::CopyJob.
Diffs (updated)
-
src/core/copyjob.cpp 9f1826a
Diff: https://git.reviewboard.kde.org/r/120598/diff/
Testing
---
I tested it in Dolphin and it seems to work.
Thanks,
Jan Grulich
___
Kde
RenameDialog in Kio::CopyJob.
Diffs
-
src/core/copyjob.cpp 9f1826a
Diff: https://git.reviewboard.kde.org/r/120598/diff/
Testing
---
I tested it in Dolphin and it seems to work.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing
error.
Diffs
-
src/filewidgets/knewfilemenu.cpp a24ac9c
Diff: https://git.reviewboard.kde.org/r/120599/diff/
Testing
---
Tested in dolphin and now I'm able to create a new text file or link to an
application.
Thanks,
Jan Grulich
_
aded/files/2014/10/16/eda6fb7e-a75e-4c28-ac87-5d16a39a366d__kurlnavigator.png
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
e.html
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120606/#review68553
---
On Říj. 16, 2014, 1:56 odp., Jan
Url(path))? Also using QUrl::fromUserInput() seems to
work correctly and I think it should't get a relative path, otherwise the path
wouldn't work in KUrlNavigator if you would like to go back.
- Jan
---
This is an automaticall
diff/
Testing
---
Tested in dolphin and works fine now.
File Attachments
Screenshot of the problem
https://git.reviewboard.kde.org/media/uploaded/files/2014/10/16/eda6fb7e-a75e-4c28-ac87-5d16a39a366d__kurlnavigator.png
Thank
ile Attachments
Screenshot of the problem
https://git.reviewboard.kde.org/media/uploaded/files/2014/10/16/eda6fb7e-a75e-4c28-ac87-5d16a39a366d__kurlnavigator.png
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-deve
he.h PRE-CREATION
mtp/devicecache.cpp PRE-CREATION
mtp/filecache.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121090/diff/
Testing
---
I have tested copying files, creating and removing folders in Dolphin with my
Nexus 4 and everything seems to work fine.
Thanks,
Jan
kio-extras with the rest of kioslaves.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review70301
-----------
.kde.org.
Here is our library http://quickgit.kde.org/?p=libnm-qt.git
Thanks a lot.
Cheers,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailm
t kio's as well in kio-extras. Question is, is it
> useful outside the workspace? Would a cross-platform application use it?
>
> It seems to me they would, I can see amarok requiring it even on windows
> or gnome.
>
> Jan Grulich wrote:
> To me it makes more sense
i understand the maintainers preferred to tie it to the nm
> > releases and not to the frameworks releases. Has this changed?
>
> Oh man, that is what i get for email being weird and getting David answer
> before Jan's email, so yes i guess this has changed :D
>
There is
ni-qt. I had the same problem on Fedora and installing sni-qt.i686
solved this problem.
Cheers,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
agation.
Done, I moved all propertiesChanged() slots to private classes.
See https://git.reviewboard.kde.org/r/121304/
Anything else?
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ting and removing folders in Dolphin with my
Nexus 4 and everything seems to work fine.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1] - https://community.kde.org/Frameworks/CreationGuidelines
[2] -
https://bugs.kde.org/describecomponents.cgi?product=frameworks-networkmanager-qt
Thanks a lot.
Regards,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-dev
removing folders in Dolphin with my
Nexus 4 and everything seems to work fine.
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
c
Diff: https://git.reviewboard.kde.org/r/121471/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
atchextract.cpp 9480e99
kerfuffle/extractiondialog.h 5907403
kerfuffle/extractiondialog.cpp f602861
part/part.cpp 82d6f9c
Diff: https://git.reviewboard.kde.org/r/121471/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel m
act.cpp 9480e99
kerfuffle/extractiondialog.h 5907403
kerfuffle/extractiondialog.cpp f602861
part/part.cpp 82d6f9c
Diff: https://git.reviewboard.kde.org/r/121471/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-f
-networkmanager-qt component in KDE
bugzilla. I would like to thank to everyone who made this happen or
contributed to libnm-qt in any way.
Regards,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks
il. To reply, visit:
https://git.reviewboard.kde.org/r/121471/#review73086
-----------
On Pro. 17, 2014, 11:58 dop., Jan Grulich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org
https://projects.kde.org/projects/kde/workspace/libmm-qt
Thanks a lot.
Regards,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinf
& to params of ip4ConfigChanged, ip6ConfigChanged and
> networkTimeZoneChanged?
Done.
> Cheers,
> Albert
>
Thanks, is there anything else?
Regards,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ng to keep Plasma
5.2.x you need to keep also libmm-qt in the version released together with it.
Regards,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
jgrul...@redhat.com
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kd
onathan Riddell wrote:
> Congratulations
>
> Would a recompile do or is the source incompatible with Plasmaßnm 5.2.2
>
> Jonathan
>
> On Tue, Mar 31, 2015 at 01:15:30PM +0200, Jan Grulich wrote:
> > Hi,
> >
> > we have finally moved libmm-qt library to fram
On Tuesday 31 of March 2015 21:55 Albert Astals Cid wrote:
> El Dimarts, 31 de març de 2015, a les 13:15:30, Jan Grulich va escriure:
> > Hi,
> >
> > we have finally moved libmm-qt library to frameworks and renamed it to
> > modemmanager-qt. It's now going
On Saturday 04 of April 2015 10:51 David Faure wrote:
> On Tuesday 31 March 2015 23:37:22 Albert Astals Cid wrote:
> > El Dimarts, 31 de març de 2015, a les 22:32:10, Jan Grulich va escriure:
> > > On Tuesday 31 of March 2015 21:55 Albert Astals Cid wrote:
> > > > El
isit:
> https://git.reviewboard.kde.org/r/123349/
> ---
>
> (Updated Dub. 12, 2015, 7:57 odp.)
>
>
> Review request for KDE Frameworks and Jan Grulich.
>
>
> Repository: networkmanager-qt
>
>
> Description
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123349/#review78887
---
Ship it!
Ship It!
- Jan Grulich
On Dub. 12, 2015, 7:57
pp... but ok IIRC it also shows that on api.kde.org
>
> Jan Grulich wrote:
> +1 for removing, it should be same for all frameworks, so there is no
> need to mention how to find the library.
>
> Lamarque Souza wrote:
> In quick search I could not find those informatio
needed for
ModemManagerQt.
Diffs
-
CMakeLists.txt c9e3274
KF5NetworkManagerQtConfig.cmake.in cdabe8e
Diff: https://git.reviewboard.kde.org/r/123477/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-framew
> On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote:
> > KF5NetworkManagerQtConfig.cmake.in, line 4
> > <https://git.reviewboard.kde.org/r/123477/diff/1/?file=362685#file362685line4>
> >
> > nitpick. weird 1 space indentation.
Already spotted.
On Dub.
On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote:
> > And yes, this is required as long as NetworkManager headers are included by
> > NetworkManagerQt headers.
>
> Jan Grulich wrote:
> I just found out that installing FindNetworkManager.cmake into CMake
> modules i
xtra-cmake-modules.
If this is how it should be done, then similar patch would be needed for
ModemManagerQt.
Diffs
-
CMakeLists.txt c9e3274
KF5NetworkManagerQtConfig.cmake.in cdabe8e
Diff: https://git.reviewboard.kde.org/r/123477/diff/
Testing
---
Thanks,
J
://git.reviewboard.kde.org/r/123532/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/FindNetworkManager.cmake ece8835
src/CMakeLists.txt e2be7d8
src/fakenetwork/CMakeLists.txt 97c2867
Diff: https://git.reviewboard.kde.org/r/123533/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks
/FindModemManager.cmake d522e93
src/CMakeLists.txt 29a7a63
src/fakemodem/CMakeLists.txt b6d4a90
Diff: https://git.reviewboard.kde.org/r/123534/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
://git.reviewboard.kde.org/r/123532/#review79633
---
On Dub. 27, 2015, 2:38 odp., Jan Grulich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote:
> > It worked here, so it's a +1 from me. I just would like the
> > extra-cmake-module maintainer to give the final "ship it".
>
> Jan Grulich wrote:
> Hmm, I realized that this would break b
ledge of CMake is quite limited, so proper review
would be needed :).
Diffs (updated)
-
find-modules/FindModemManager.cmake PRE-CREATION
find-modules/FindNetworkManager.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123532/diff/
Testing
---
Thanks,
Jan Gr
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123768/#review80283
---
Ship it!
Ship It!
- Jan Grulich
On Kvě. 13, 2015, 9 dop
act.cpp 9480e99
kerfuffle/extractiondialog.h 5907403
kerfuffle/extractiondialog.cpp f602861
part/part.cpp 82d6f9c
Diff: https://git.reviewboard.kde.org/r/121471/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
but after it gets saved then everything
is merged into one component called "System settings". This was working fine
before this change.
- Jan Grulich
On Čec. 1, 2015, 7:49 dop., Martin Gräßlin wrote:
>
> ---
> This is an
ping me
anytime on
IRC on #solid channel.
[1] - https://quickgit.kde.org/?p=plasma-nm.git[1]
> Thanks
> Heiko
Regards,
Jan
--
Jan Grulich
Software Engineer, Desktop team
Red Hat Czech
[1] https://quickgit.kde.org/?p=plasma-nm.git
___
K
hen NM loads them from it's storage and secret agent is
not used at all.
> Thank in advance for your help.
>
> Best Regards
> Heiko
I hope that helps.
Regards,
Jan
--
Jan Grulich
Software Engineer, Desktop team
Red Hat Czech
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
clude/QtCrypto/qca_safetimer.h 68dde5c
Diff: https://git.reviewboard.kde.org/r/125289/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Ivan Romanov.
Changes
---
Submitted with commit 66b9754170759d9333d5fc1e348642814d0310dd by Jan Grulich
to branch master.
Repository: qca
Description
---
This is used also in other header files from include folder. I&#
27;s qt5 branch into master and
> replacing the qt5 tarball with a new release that supports both qt4
> and qt5?
>
+ 1, we added qca as dependency for plasma-nm and to be able to build it you
need the latest fix I pushed to qca thus new release of qca before Plasma
5.5.0 rel
nately time for that.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95764
---
On Kvě. 5, 2016,
s/src/katedocument_test.h 8abbad9
autotests/src/katedocument_test.cpp dd41e0f
src/document/katedocument.cpp 73778a1
src/view/kateview.h 08db0df
src/view/kateview.cpp fda6b2d
Diff: https://git.reviewboard.kde.org/r/127843/diff/
Testing
-
p dd41e0f
src/document/katedocument.cpp 73778a1
src/view/kateview.h 08db0df
src/view/kateview.cpp fda6b2d
Diff: https://git.reviewboard.kde.org/r/127843/diff/
Testing
---
Thanks,
Jan Grulich
___
Kde-frameworks-devel mailing list
Kde-frame
marked as submitted.
Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik
Haumann.
Changes
---
Submitted with commit c7096f60bbe094ba92456fd39ff3102435d9c677 by Jan Grulich
to branch master.
Repository: ktexteditor
Description
---
When using Indic locales
src/vlandevice.cpp 415dec9
src/vpnconnection.cpp d2d17e4
src/vpnconnection_p.h 25ba589
src/wimaxdevice.cpp daec0a6
src/wireddevice.cpp af147b1
src/wirelessdevice.cpp dad918d
Diff: https://git.reviewboard.kde.org/r/128843/diff/
Testing
---
Thanks,
Jan Grulich
src/vpnconnection_p.h 25ba589
src/wimaxdevice.cpp daec0a6
src/wireddevice.cpp af147b1
src/wirelessdevice.cpp dad918d
Diff: https://git.reviewboard.kde.org/r/128843/diff/
Testing
---
Thanks,
Jan Grulich
these changes
locally. I was messing with them when trying to find out why my active
connections don't get notified about changed state.
- Jan Grulich
On Zář. 6, 2016, 11:56 dop., Jan Grulich wrote:
>
> ---
> This is an
rtiesChanged signal.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128843/#review98930
---
On Zář. 6, 2016, 11:56 dop.
> On Zář. 6, 2016, 12:01 odp., Lamarque Souza wrote:
> >
>
> Jan Grulich wrote:
> Every DeviceType inherits from Device, same as DeviceTypePrivate inherits
> from DevicePrivate so when DeviceType is connected to PropertiesChanged
> signal and doesn't imple
marked as submitted.
Review request for KDE Frameworks, Network Management and Lamarque Souza.
Changes
---
Submitted with commit 7671424efb02e7194a18a4913da16bc2044a4cb9 by Jan Grulich
to branch master.
Repository: networkmanager-qt
Description
---
Since NM 1.2.x they switched to
device.cpp 6118f2f
src/wireddevice.cpp 66bb649
src/wirelessdevice.cpp 3f2972b
Diff: https://git.reviewboard.kde.org/r/129042/diff/
Testing
---
Thanks,
Jan Grulich
297
src/vpnconnection.cpp 5dee6fc
src/vpnconnection_p.h a8195ad
src/wimaxdevice.cpp 6118f2f
src/wireddevice.cpp 66bb649
src/wirelessdevice.cpp 3f2972b
Diff: https://git.reviewboard.kde.org/r/129042/diff/
Testing
---
Thanks,
Jan Grulich
device.cpp fdfa297
src/vpnconnection.cpp 5dee6fc
src/vpnconnection_p.h a8195ad
src/wimaxdevice.cpp 6118f2f
src/wireddevice.cpp 66bb649
src/wirelessdevice.cpp 3f2972b
Diff: https://git.reviewboard.kde.org/r/129042/diff/
Testing
---
Thanks,
Jan Grulich
t; &, const QVariant &) Unhandled property "S390Subchannels"
> > ```
You can ignore that, that was there even before.
For "AllDevices" and "Devices" properties we ignore them intentionally, because
there is also "DeviceAdded" and "
marked as submitted.
Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and
Lamarque Souza.
Changes
---
Submitted with commit 00acf17a2071d86e218d3d49a0e53157eaa265dd by Jan Grulich
to branch master.
Repository: networkmanager-qt
Description
---
Uses
t that properly.
- Jan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123533/#review100170
---
On Dub. 27, 2015, 2:42
, they are used in many places.
- Jan Grulich
On Lis. 1, 2016, 8:24 dop., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129303/#review100460
---
Ship it!
Ship It!
- Jan Grulich
On Lis. 1, 2016, 8:21
/kpropertiesdialog.cpp 18c8479
src/widgets/krun.cpp d93b1f2
Diff: https://git.reviewboard.kde.org/r/129395/diff/
Testing
---
Thanks,
Jan Grulich
into account and set required
variable accordingly.
Diffs
-
src/kdeinit/ktoolinvocation.cpp c9eb922
src/services/kservice.h 66525b4
src/services/kservice.cpp 6574367
Diff: https://git.reviewboard.kde.org/r/129396/diff/
Testing
---
Thanks,
Jan Grulich
-
src/klauncher/klauncher.cpp 828038b
Diff: https://git.reviewboard.kde.org/r/129397/diff/
Testing
---
Thanks,
Jan Grulich
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/14/89203f95-9267-47db-b2ad-0eeb42357a1c__kpropertiesdialog.png
Thanks,
Jan Grulich
---
Thanks,
Jan Grulich
1 - 100 of 370 matches
Mail list logo
