D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a comment. In D16490#352199 , @astippich wrote: > In D16490#352109 , @bruns wrote: > > > In D16490#351935 , @astippich wrote: > > > > > In

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. In D16490#352109 , @bruns wrote: > In D16490#351935 , @astippich wrote: > > > In D16490#351799 , @bruns wrote: > > > > > In

D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a comment. In D16490#351935 , @astippich wrote: > In D16490#351799 , @bruns wrote: > > > In D16490#351662 , @astippich wrote: > > > > >

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. In D16490#351799 , @bruns wrote: > In D16490#351662 , @astippich wrote: > > > Only one minor thing: please also check that the mimetype is in the list of supported

D16490: [KFileMetaData] Add unittest for XML extractor

bruns marked an inline comment as done. bruns added a comment. In D16490#351662 , @astippich wrote: > Only one minor thing: please also check that the mimetype is in the list of supported mimetypes This can actually happen and is

D16490: [KFileMetaData] Add unittest for XML extractor

astippich added a comment. Only one minor thing: please also check that the mimetype is in the list of supported mimetypes REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo,

D16490: [KFileMetaData] Add unittest for XML extractor

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > lbeltrame wrote in xmlextractortest.cpp:38 > IIRC you shouldn't use `QDir::separator()`. See > http://agateau.com/2015/qdir-separator-considered-harmful/ Thx, fixed here and elsewhere (D16505

D16490: [KFileMetaData] Add unittest for XML extractor

bruns updated this revision to Diff 44409. bruns added a comment. Replace QDir::Separator with "/" REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16490?vs=44375=44409 BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16490

D16490: [KFileMetaData] Add unittest for XML extractor

lbeltrame added a comment. Generally looks OK to me, one note on `QDir::separator()` usage. INLINE COMMENTS > xmlextractortest.cpp:38 > +{ > +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + > QDir::separator() + fileName; > +} IIRC you shouldn't use `QDir::separator()`. See

D16490: [KFileMetaData] Add unittest for XML extractor

bruns added a dependency: D16489: [KFileMetaData] Add extractor for generic XML and SVG. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16490: [KFileMetaData] Add unittest for XML extractor

bruns edited the test plan for this revision. bruns added reviewers: Frameworks, astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16490: [KFileMetaData] Add unittest for XML extractor

bruns created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH xml_extractor REVISION DETAIL https://phabricator.kde.org/D16490 AFFECTED FILES