Review Request: Update against new NetworkManager

0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https

Re: Review Request: Update against new NetworkManager

settings.h 818ef5b settings.cpp 0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing

Re: Review Request: Update against new NetworkManager

b2029bb manager.cpp 5cf3266 manager_p.h bb377bd settings.h 818ef5b settings.cpp 0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Update against new NetworkManager

it.reviewboard.kde.org/r/106852/#review20330 ----------- On Oct. 14, 2012, 6:50 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: Update against new NetworkManager

manager.cpp 5cf3266 manager_p.h bb377bd settings.h 818ef5b settings.cpp 0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Update against new NetworkManager

manager.cpp 5cf3266 manager_p.h bb377bd settings.h 818ef5b settings.cpp 0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Update against new NetworkManager

b2029bb manager.cpp 5cf3266 manager_p.h bb377bd settings.h 818ef5b settings.cpp 0c76d51 settings_p.h 1f6900b wirelessdevice.h b7ff859 wirelessdevice.cpp 925d744 Diff: http://git.reviewboard.kde.org/r/106852/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request: Update against new NetworkManager

git.reviewboard.kde.org/r/106852/#review20391 ----------- On Oct. 15, 2012, 7:30 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request: Add option to configure IPv6 Privacy Extension

> On Jan. 2, 2013, 10:11 p.m., Lamarque Vieira Souza wrote: > > libs/internals/settings/ipv6.cpp, line 14 > > > > > > I think you should create a enum like there Ipv6Setting::EnumMethod > > instead of using hardco

Re: Review Request: Add option to configure IPv6 Privacy Extension

above, the docs do not mention > "Unknown" at all... but it is the default value. > > [1] http://bugzilla-attachments.gnome.org/attachment.cgi?id=217377 > [2] > http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=af0eb9e7adf0732921ebe92

Review Request 108941: Missing password field in password dialog when using wpa2 connections

://bugs.kde.org/show_bug.cgi?id=299868 Diffs - libs/ui/security/security8021xauth.cpp 5c67355 Diff: http://git.reviewboard.kde.org/r/108941/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org

Re: Review Request 108941: Missing password field in password dialog when using wpa2 connections

visit: http://git.reviewboard.kde.org/r/108941/#review27363 ------- On Feb. 13, 2013, 11:02 a.m., Jan Grulich wrote: > > --- > This is an automatically generat

Re: Status of libModemManagerQt supporting ModemManager 0.8

t for ModemManager > 0.6. There is a branch with some code for MM 0.8, but nothing working yet. Even plasma-nm won't work (Mobile broadband connections) with newer versions of ModemManager. Regards Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com __

Review Request 112963: Add IPv6 information into connection details

solidcontrolfuture/networkipv6config.h 3fe68a6 solidcontrolfuture/solid/networkmanager-0.9/networkinterface.cpp 2a69e96 Diff: http://git.reviewboard.kde.org/r/112963/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde

Re: Review Request 118516: Load the networkmanager applet on demand

> On June 4, 2014, 11:02 a.m., Lukáš Tinkl wrote: > > How would you connect to a VPN in that case? > > Marco Martin wrote: > Is networkmanager used to connect a VPN? > (and more generally, are there any features in the plasmoid that can be > used without networkmanager running?) > > Lu

Re: Review Request 118516: Load the networkmanager applet on demand

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118516/#review59176 --- Ship it! Ship It! - Jan Grulich On June 4, 2014, 10:59

Re: Review Request 118980: Add Local Port selector to VPNC advanced settings dialog

ly, visit: > https://git.reviewboard.kde.org/r/118980/ > --- > > (Updated June 28, 2014, 7:38 a.m.) > > > Review request for Network Management, Jan Grulich and Lukáš Tinkl. > > > Repository: plasma-nm > > > Descri

Re: Review Request 119392: Missing Control For ModemManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119392/#review62842 --- Ship it! Ship It! - Jan Grulich On Čec. 22, 2014, 1:59

Re: Review Request 119392: Missing Control For ModemManager

> On Čec. 22, 2014, 7:09 dop., Jan Grulich wrote: > > Ship It! Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a lot. - Jan --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 119392: Missing Control For ModemManager

> On Čec. 22, 2014, 7:09 dop., Jan Grulich wrote: > > Ship It! > > Jan Grulich wrote: > Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a > lot. > > Ömer Fadıl Usta wrote: > committed to 0.9.3 then cherrypicked to Plasma/5.0 then a

Review Request 119973: Import secrets previously stored in plaintext files

create a file with secrets (for vpn, wifi, gsm) manually and they were successfuly transfered to KWallet. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 119973: Import secrets previously stored in plaintext files

/secretagent.cpp 26f8faa Diff: https://git.reviewboard.kde.org/r/119973/diff/ Testing --- I tried to create a file with secrets (for vpn, wifi, gsm) manually and they were successfuly transfered to KWallet. Thanks, Jan Grulich ___ kde

Re: Review Request 119973: Import secrets previously stored in plaintext files

26f8faa Diff: https://git.reviewboard.kde.org/r/119973/diff/ Testing --- I tried to create a file with secrets (for vpn, wifi, gsm) manually and they were successfuly transfered to KWallet. Thanks, Jan Grulich ___ kde-networkmanager mailing

Re: Review Request 120145: Directly connect transfer rate label to the engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120145/#review66272 --- Ship it! Ship It! - Jan Grulich On Zář. 11, 2014, 2:53

Review Request 120313: Do not keep trying to open KWallet if we failed before

open it again, which should be done in my patch. BUG: https://bugs.kde.org/show_bug.cgi?id=339223 Diffs - kded/secretagent.h a438191 kded/secretagent.cpp 77438ca Diff: https://git.reviewboard.kde.org/r/120313/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 120313: Do not keep trying to open KWallet if we failed before

://git.reviewboard.kde.org/r/120313/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 120313: Do not keep trying to open KWallet if we failed before

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120313/#review67182 --- On Zář. 22, 2014, 11:38 dop., Jan Grulich wrote: > > ---

Re: Review Request 120313: Do not keep trying to open KWallet if we failed before

----------- On Zář. 22, 2014, 11:38 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120313/ > --

Re: Review Request 120313: Do not keep trying to open KWallet if we failed before

most kwallet > > users use it so they do not need to remember their passwords. Just showing > > a password dialog when kwallet fails is not a good usability action in my > > opinion. > > Jan Grulich wrote: > Why for every request? It should show a password dialog only

Re: Review Request 120483: Use regular IconItem for CompactRepresentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120483/#review67868 --- Ship it! Ship It! - Jan Grulich On Říj. 3, 2014, 4:58 odp

Review Request 120530: Ask user whether he wants to copy certificates under KDE configuration when importing OpenVPN configuration

Diff: https://git.reviewboard.kde.org/r/120530/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 120530: Ask user whether he wants to copy certificates under KDE configuration when importing OpenVPN configuration

only the first one is copied to our location. Diffs - vpn/openvpn/openvpn.cpp e83d148 Diff: https://git.reviewboard.kde.org/r/120530/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org

Re: Review Request 121167: Use Interactive resize mode instead of ResizeToContents

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121167/#review70572 --- Ship it! Ship It! - Jan Grulich On Lis. 18, 2014, 5:28

Review Request 121304: Move all propertiesChanged() slots from public API to private classes

src/adsldevice_p.h PRE-CREATION src/bluetoothdevice.h ac7014a Diff: https://git.reviewboard.kde.org/r/121304/diff/ Testing --- I'm using it now with plasma-nm and it seems to work as before. Thanks, Jan Grulich ___ kde-networkmanager mailin

Re: Review Request 121304: Move all propertiesChanged() slots from public API to private classes

, visit: https://git.reviewboard.kde.org/r/121304/#review71149 ------- On Pro. 1, 2014, 9:30 dop., Jan Grulich wrote: > > --- > This is an automatically genera

Re: Review Request 121304: Move all propertiesChanged() slots from public API to private classes

https://git.reviewboard.kde.org/r/121304/diff/ Testing --- I'm using it now with plasma-nm and it seems to work as before. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 121304: Move all propertiesChanged() slots from public API to private classes

ith plasma-nm and it seems to work as before. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 121304: Move all propertiesChanged() slots from public API to private classes

t seems to work as before. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

https://git.reviewboard.kde.org/r/121467/#comment50117> Coding style. https://techbase.kde.org/Policies/Kdelibs_Coding_Style - Jan Grulich On Pro. 12, 2014, 4:23 odp., William Boren wrote: > > --- > This

Re: Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

> On Pro. 12, 2014, 5:01 odp., Jan Grulich wrote: > > Do not use classes like KComboBox, KLineEdit or KDialog, those are removed > > in KDE Frameworks 5. I also don't think you managed to compile this. You > > need to compile master branch of libnm-qt first (you can

Review Request 122012: Add support for storing Openconnect secrets to KWallet

to KWallet or they are not stored at all. I know I should avoid using synchronous calls when opening KWallet, but in this case it would be probably complicated to use it asynchronously. Diffs - Diff: https://git.reviewboard.kde.org/r/122012/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

: https://git.reviewboard.kde.org/r/122012/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

.org/r/122012/#review73841 --- On Led. 12, 2015, 11:35 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

> On Led. 12, 2015, 12:30 odp., Lukáš Tinkl wrote: > > Ship It! > > Lamarque Souza wrote: > The big problem with using synchronous API is blocking the entire Plasma > Desktop sometimes. That is very annoying from user point of view. > > Jan Grulich wrote: >

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

/openconnect/openconnectwidget.cpp f9bc3cf Diff: https://git.reviewboard.kde.org/r/122012/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

ce2be vpn/openconnect/openconnectwidget.cpp f9bc3cf Diff: https://git.reviewboard.kde.org/r/122012/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 122012: Add support for storing Openconnect secrets to KWallet

/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Review Request 122070: Prepare for NetworkManager 1.0.0

/ipconfig.h cc85fc5 src/manager.cpp b0dfe00 src/secretagent.cpp 55da800 Diff: https://git.reviewboard.kde.org/r/122070/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman

Re: Review Request 122070: Prepare for NetworkManager 1.0.0

f7abff4 src/connection.cpp 3137c05 src/fakenetwork/CMakeLists.txt 3c30e2a src/ipconfig.h cc85fc5 src/manager.cpp b0dfe00 src/secretagent.cpp 55da800 Diff: https://git.reviewboard.kde.org/r/122070/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 122860: Set LEAP password mode on by default in ui.

> On Bře. 8, 2015, 9:28 odp., Lamarque Souza wrote: > > Ship It! Next time put "REVIEW:122860" into the commit message so it gets closed automatically, now you need to close it manually. - Jan --- This is an automatically generated e-m

Re: Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121467/ > --- > > (Updated Pro. 12, 2014, 4:23 odp.) > > > Review request for Network Management and Jan Grulich. > > > Repository: plasma-nm > >

Re: Review Request 121467: Added support for SSTP VPN in plasma-nm (GCI task)

> On Bře. 15, 2015, 7:05 odp., Lamarque Souza wrote: > > Any idea why this patch has not been updated in months? > > Lamarque Souza wrote: > By the way, bug 338521 should be added to this bug's information. > > Jan Grulich wrote: > Because the stu

Review Request 123465: Add support for SSH VPN plugin

all values were stored/loaded properly. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 123465: Add support for SSH VPN plugin

/simpleipv6addressvalidator.h 934dc99 Diff: https://git.reviewboard.kde.org/r/123465/diff/ Testing --- I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly. Thanks, Jan Grulich

Re: Review Request 123465: Add support for SSH VPN plugin

-CREATION Diff: https://git.reviewboard.kde.org/r/123465/diff/ Testing --- I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly. Thanks, Jan Grulich

Re: Review Request 123465: Add support for SSH VPN plugin

erated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123465/#review79341 ----------- On Dub. 22, 2015, 2:41 odp., Jan Grulich wrote: > > --- > This is

Review Request 123474: Use Qt5 syntax for all signals/slots

https://git.reviewboard.kde.org/r/123474/diff/ Testing --- Everything seems to work as before. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 123474: Use Qt5 syntax for all signals/slots

marked as submitted. Review request for Network Management, Lukáš Tinkl and Lamarque Souza. Changes --- Submitted with commit d418067e5a21b8596df79e251e66abd82d93990f by Jan Grulich to branch master. Repository: plasma-nm Description --- This patch transforms old signals/slot

Re: Review Request 123465: Add support for SSH VPN plugin

(kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly. Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 123465: Add support for SSH VPN plugin

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123465/#review79433 ----------- On Dub. 24, 2015, 1:14 odp., Jan Grulich wrote: > > ---

Re: Review Request 123465: Add support for SSH VPN plugin

marked as submitted. Review request for Network Management, Lukáš Tinkl and Lamarque Souza. Changes --- Submitted with commit d76fb3dee7ed20545ae1bb3b2a2d2e78517f6698 by Jan Grulich to branch master. Bugs: 341070 http://bugs.kde.org/show_bug.cgi?id=341070 Repository: plasma-nm

Review Request 123642: Drop WiMAX support for NM 1.2.0+

/fakenetwork/fakenetwork.cpp c7a29fd src/fakenetwork/fakenetwork.h 64077a9 autotests/managertest.cpp 6cc2429 src/CMakeLists.txt e2be7d8 Diff: https://git.reviewboard.kde.org/r/123642/diff/ Testing --- Thanks, Jan Grulich ___ kde

Re: Review Request 123642: Drop WiMAX support for NM 1.2.0+

marked as submitted. Review request for Network Management, Lukáš Tinkl and Lamarque Souza. Changes --- Submitted with commit 1611028164fed9f2ec5915e042b0b6e18a8a0892 by Jan Grulich to branch master. Repository: networkmanager-qt Description --- NM developers decided to drop WiMAX

Review Request 123657: Drop support for WiMAX for NM 1.2.0+

/models/networkmodel.h d506960 libs/models/networkmodel.cpp ee95aaa libs/models/networkmodelitem.cpp b8cd03d libs/uiutils.h 6ed411d libs/uiutils.cpp c624b30 Diff: https://git.reviewboard.kde.org/r/123657/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 123657: Drop support for WiMAX for NM 1.2.0+

marked as submitted. Review request for Network Management, Lukáš Tinkl and Lamarque Souza. Changes --- Submitted with commit c3004a42dea04efed319e18da6e89711afae86ba by Jan Grulich to branch master. Repository: plasma-nm Description --- This patch drops support for WiMAX when using

Re: Review Request 123768: port to new ecm_add_test PROPERTIES argument

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123768/#review80283 --- Ship it! Ship It! - Jan Grulich On Kvě. 13, 2015, 9 dop

Review Request 124279: Asynchronous loading of secrets in the connection editor

.h 69beb97 vpn/vpnc/vpncwidget.cpp 4d5330d Diff: https://git.reviewboard.kde.org/r/124279/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124279: Asynchronous loading of secrets in the connection editor

vpn/strongswan/strongswanwidget.cpp 88a2ede vpn/vpnc/vpncwidget.h 69beb97 vpn/vpnc/vpncwidget.cpp 4d5330d Diff: https://git.reviewboard.kde.org/r/124279/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-network

Re: Review Request 124279: Asynchronous loading of secrets in the connection editor

vpn/vpnc/vpncwidget.h 69beb97 vpn/vpnc/vpncwidget.cpp 4d5330d Diff: https://git.reviewboard.kde.org/r/124279/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/li

Re: Review Request 124279: Asynchronous loading of secrets in the connection editor

--- On Čec. 9, 2015, 9:36 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124279/ >

Re: Review Request 124279: Asynchronous loading of secrets in the connection editor

marked as submitted. Review request for Network Management and Lamarque Souza. Changes --- Submitted with commit 2d7a689b79d6ca9752ada7ccdc1e635149d2ba36 by Jan Grulich to branch master. Bugs: 349002 http://bugs.kde.org/show_bug.cgi?id=349002 Repository: plasma-nm Description

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

appears and you click on the button it works and the button remains visible. Diffs - applet/contents/ui/ConnectionItem.qml 3fa93b5 applet/contents/ui/PopupDialog.qml 2a0d352 Diff: https://git.reviewboard.kde.org/r/124314/diff/ Testing --- Thank

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

---------- On Čec. 14, 2015, 7:43 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124314/ >

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

nnect button visible and this is > not changed until you move mouse cursor to another item, thus when a > notification appears and you click on the button it works and the button > remains visible. > > > Diffs > - > > applet/contents/ui/ConnectionItem.qml 3fa93b5 &

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

marked as submitted. Review request for Network Management and Plasma. Changes --- Submitted with commit f1ae6f60769876e5f7ddc0c710f5dec9f862a6e6 by Jan Grulich to branch master. Bugs: 348905 http://bugs.kde.org/show_bug.cgi?id=348905 Repository: plasma-nm Description

Review Request 124485: Add missing traffic monitor

://bugs.kde.org/show_bug.cgi?id=268022 Repository: plasma-nm Description --- See summary. Diffs - applet/contents/ui/ConnectionItem.qml ff722a7 Diff: https://git.reviewboard.kde.org/r/124485/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 124485: Add missing traffic monitor

his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83026 --- On Čec. 27, 2015, 10:06 dop., Jan Grulich wrote: > > --- > This i

Re: Review Request 124485: Add missing traffic monitor

) ---  Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124485: Add missing traffic monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83033 ----------- On Čec. 27, 2015, 10:17 dop., Jan Grulich wrote: > > --- > This is an automa

Re: Review Request 124485: Add missing traffic monitor

monitor](https://jgrulich.fedorapeople.org/plotter.png) Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124485: Add missing traffic monitor

---------- On Čec. 27, 2015, 10:55 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124485/ > ---

Re: Review Request 124485: Add missing traffic monitor

marked as submitted. Review request for Network Management, Plasma and KDE Usability. Changes --- Submitted with commit e20839806450cd018de2e7a24fb23a54a70fe6da by Jan Grulich to branch master. Bugs: 333070 http://bugs.kde.org/show_bug.cgi?id=333070 Repository: plasma-nm

Re: Review Request 124485: Add missing traffic monitor

To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83041 --- On Čec. 27, 2015, 1:08 odp., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To r

Review Request 124922: Replace "show password" checkboxes with a custom password field

0a1393b vpn/vpnc/vpncwidget.cpp 6a777fe Diff: https://git.reviewboard.kde.org/r/124922/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124922: Replace "show password" checkboxes with a custom password field

sting --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124922: Replace "show password" checkboxes with a custom password field

marked as submitted. Review request for Network Management and Lamarque Souza. Changes --- Submitted with commit 5dad876a2a329271287952c67d2eaba6ba01ab67 by Jan Grulich to branch master. Repository: plasma-nm Description --- Add a new custom password field which has a small icon

Review Request 124998: Add new properties from the latest NM snapshot/releases

/generictypes.h b5b4072 src/ipconfig.h f9207c9 src/ipconfig.cpp 46f8572 src/manager.h 80030a2 src/manager.cpp 04fdbc3 src/manager_p.h e7a27aa src/wirelessdevice.h e205a64 Diff: https://git.reviewboard.kde.org/r/124998/diff/ Testing --- Thanks, Jan Grulich

Re: Review Request 124998: Add new properties from the latest NM snapshot/releases

: https://git.reviewboard.kde.org/r/124998/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 124998: Add new properties from the latest NM snapshot/releases

marked as submitted. Review request for Network Management, Lukáš Tinkl and Lamarque Souza. Changes --- Submitted with commit 7e57f90c85295e3596aa1b618fa148892bb46f0d by Jan Grulich to branch master. Repository: networkmanager-qt Description --- This patch adds properties

Review Request 125233: WPA/WPA2 Enterprise - add options to use system certificates

://git.reviewboard.kde.org/r/125233/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 125233: WPA/WPA2 Enterprise - add options to use system certificates

isit: https://git.reviewboard.kde.org/r/125233/#review85438 --- On Zář. 15, 2015, 6:23 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 125233: WPA/WPA2 Enterprise - add options to use system certificates

/security802-1x.cpp 0f8f71d libs/editor/settings/ui/802-1x.ui ac5732a Diff: https://git.reviewboard.kde.org/r/125233/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org

Re: Review Request 125233: WPA/WPA2 Enterprise - add options to use system certificates

new certificate as it > > comes in *unless* you used the Profile installation tool and you have put > > exactly the CAs you trust into the profile." Please add him to this review > > request. > > Jan Grulich wrote: > It seems he doesn't have active developer acc

Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

02-1x.cpp 0f8f71d libs/editor/settings/ui/802-1x.ui ac5732a libs/editor/settings/wifisecurity.cpp b2b80fb libs/editor/widgets/editlistdialog.h PRE-CREATION libs/editor/widgets/editlistdialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125281/diff/ Testing -

Re: Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

stead of KComboBox, > > right? We can use KComboBox, it's in KCompletion framework. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125281/#review85566 --

Re: Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

RE-CREATION Diff: https://git.reviewboard.kde.org/r/125281/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

to remove it, it's from my another work. - Jan Grulich On Zář. 18, 2015, 10:31 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

RE-CREATION Diff: https://git.reviewboard.kde.org/r/125281/diff/ Testing --- Thanks, Jan Grulich ___ kde-networkmanager mailing list kde-networkmanager@kde.org https://mail.kde.org/mailman/listinfo/kde-networkmanager

Re: Review Request 125281: Add WPA/WPA2 Enterprise (partial) validation + options to add subjectMatch and altSubjectMatch properties

, visit: https://git.reviewboard.kde.org/r/125281/#review85620 ----------- On Zář. 18, 2015, 10:31 dop., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125281/ &

  1   2   3   >