Re: Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128961/ --- (Updated Sept. 20, 2016, 2:37 p.m.) Status -- This change has been

Re: Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128961/#review99331 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 20,

Re: Review Request 128960: [KTp/Declarative/MessagesModel] Use message token to prevent message duplication on scrollback received

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128960/#review99330 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 20,

Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128961/ --- Review request for Telepathy. Repository: ktp-common-internals

Re: Review Request 128960: [KTp/Declarative/MessagesModel] Use message token to prevent message duplication on scrollback received

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128960/ --- (Updated Sept. 20, 2016, 6:27 p.m.) Review request for Telepathy.

Re: Review Request 128960: [KTp/Declarative/MessagesModel] Use message token to prevent message duplication on scrollback received

> On Sept. 20, 2016, 6:13 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 245 > > > > > > this shouldn't be a reference, as you're actually storing it. Copied from the first usage:

Re: Review Request 128960: [KTp/Declarative/MessagesModel] Use message token to prevent message duplication on scrollback received

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128960/#review99328 --- Fix it, then Ship it! I was not aware of this

Review Request 128960: [KTp/Declarative/MessagesModel] Used token to prevent incoming message duplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128960/ --- Review request for Telepathy. Repository: ktp-common-internals

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128954/ --- (Updated Sept. 20, 2016, 5:46 p.m.) Status -- This change has been

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 12:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 3:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 12:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128867: [KTp/Message] Direction of received message now depends on sender

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128867/ --- (Updated Sept. 20, 2016, 7:05 a.m.) Status -- This change has been

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 3:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128847: [ktp-common-internals] [debugger] Split logic and UI

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128847/#review99309 --- I'd say that if these changes fit you, they should go in. I

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 12:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128867: [KTp/Message] Direction of received message now depends on sender

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128867/#review99307 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 9,

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

> On Sept. 20, 2016, 3:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator? > >

Re: Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128954/#review99301 --- KTp/Declarative/messages-model.cpp (line 221)

Review Request 128954: [KTp/Declarative/MessagesModel] Implemented message sort by sent timestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128954/ --- Review request for Telepathy. Repository: ktp-common-internals