Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated July 28, 2017, 12:05 p.m.) Status -- This change has been d

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Jan. 28, 2017, 4:54 p.m.) Review request for Telepathy and Marti

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Jan. 3, 2017, 8:34 p.m.) Review request for Telepathy and Martin

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Dec. 15, 2016, 7:08 p.m.) Review request for Telepathy and Marti

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Nov. 21, 2016, 10:29 p.m.) Review request for Telepathy and Mart

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 23, 2016, 2:03 a.m., Alexandr Akulich wrote: > > telepathy-mpris.cpp, line 96 > > > > > > Here you're iterating over non-const list of dbus services (usually > > 60-100 entries). > > James Smith wrote

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 23, 2016, 1:03 p.m., Alexandr Akulich wrote: > > telepathy-mpris.cpp, line 96 > > > > > > Here you're iterating over non-const list of dbus services (usually > > 60-100 entries). > > James Smith wrote

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 23, 2016, 1:03 p.m., Alexandr Akulich wrote: > > telepathy-mpris.cpp, line 96 > > > > > > Here you're iterating over non-const list of dbus services (usually > > 60-100 entries). > > James Smith wrote

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 23, 2016, 2:03 a.m., Alexandr Akulich wrote: > > telepathy-mpris.cpp, line 96 > > > > > > Here you're iterating over non-const list of dbus services (usually > > 60-100 entries). According to the docu

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review99480 --- telepathy-mpris.cpp (line 80)

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Sept. 22, 2016, 6:41 p.m.) Review request for Telepathy and Mart

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 21, 2016, 9:19 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. > > > > That said, I still don't ag

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On Sept. 21, 2016, 8:19 p.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. > > > > That said, I still don't ag

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review99369 --- > Use c++11 for loops instead of Q_FOREACH for new code. Ple

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated Sept. 17, 2016, 10:03 p.m.) Review request for Telepathy and Mar

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On May 14, 2016, 5:11 a.m., Martin Klapetek wrote: > > My position still stands - kill the mpris thing, simplify the whole plugin handling to a single "hardcoded" plugin (autoaway) and focus on what actually matters today, like making OTR work properly and easily. - Martin

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review95457 --- - Martin Klapetek On May 14, 2016, 4:44 a.m., James Smith w

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated April 15, 2016, 8:56 a.m.) Review request for Telepathy. Chang

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On April 8, 2016, 1:08 a.m., David Edmundson wrote: > > telepathy-mpris.cpp, line 132 > > > > > > In English that makes it sound like the other person is physically > > playing the song with guitars and stuff.

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

> On April 7, 2016, 11:08 p.m., David Edmundson wrote: > > telepathy-mpris.cpp, line 132 > > > > > > In English that makes it sound like the other person is physically > > playing the song with guitars and stuff

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review94413 --- Fix it, then Ship it! config/telepathy-kded-config.cpp (l

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/ --- (Updated March 7, 2016, 6:52 a.m.) Review request for Telepathy. Change

Re: Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review92931 --- I would like to have some investigation if and how we can reu