How about a step further from fixing bugs: setting up unit/module/regression
test frameworks and writing some tests for kdenlive and maybe mlt too?
Jenkins build job with tests and code coverage measurements, and some
static analysis tools like cppcheck, maybe Coverity?
-Mikko
---
On Thu, Dec 05, 2013 at 12:28:03PM +0100, Vincent PINON wrote:
> I found JBM's phone number and decided to call yesterday evening.
> Good surprise: I talked to him!
> Topmost important, he is now fine.
Great news!
> 1) put master back in good shape, restoring v0.9.6+, and moving back
> refactor
On Mon, Dec 02, 2013 at 09:20:38PM +0200, Yuri Chornoivan wrote:
> Can it be integrated with KDE build service:
>
> http://build.kde.org/view/extragear/
>
> ?
Propably yes. I'll try to read into kde infra a bit. Or maybe someone already
knows the details, processes and links to correct wiki page
Hi,
Is there a build server for kdenlive somewhere? Maybe some of the downstream
distributions?
I would like to automate cppcheck and Coverity runs but don't have a build
server at hand. The Coverity run would need to store a password token somewhere
to do the upload of data, and of course instal
cppcheck is a simple but effective static analysis tool. Here's how I run
it with latest kdenlive 0.9 branch:
$ cppcheck -I src -I /usr/include -I thumbnailer -I plugins/sampleplugin/ \
-I renderer/ --enable=all -v --force . 2> cppcheck_log.txt
Results show partially similar issues than Coverit
Hi all,
I did another Coverity static analysis run for kdenlive 0.9 branch and
results are available at https://scan.coverity.com/ .
At the moment only me and JBM are members of the kdenlive Coverity project
and can view results, but anyone else is free to join in as well.
Just create an account
About kdenlive stable/0.9:
Since summer I've tried to edit a few clips with kdenlive on Debian unstable
and it was crashing a bit too much. I hope it's not lagging behind some
ffmpeg/libav/mlt/kde/qt API changes which could explain these, but running
cppcheck and Coverity scan on the sources and f
Fixes Coverity CID 709292 and 709293:
Dereference after null check (FORWARD_NULL) [select defect]
1917if (original == NULL || clip == NULL) {
1918kDebug() << "// ERROR GRABBING CLIP AFTER SPLIT";
1919}
1920Mlt::Service clipService(original->get_service());
1921Mlt::Service d
Fixes Coverity CID 709287: Division or modulo by zero (DIVIDE_BY_ZERO)
Call to "this->loadEnvelope()" set "this->m_envelopeMax" to 0.
182loadEnvelope();
...
Division by expression "this->m_envelopeMax" which may be zero has undefined
behavior
189fy = m_envelope[x]/double(m_envelope
Fixes Coverity CID 709312: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""addClipToProject"" is not initialized in this
constructor nor in any functions that it calls.
---
src/projecttree/meltjob.cpp |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/
Fixes Coverity CID 709282: Unchecked return value (CHECKED_RETURN)
Calling function "QFile::open(QFlags)" without
checking return value (as is done elsewhere 45 out of 47 times).
No check of the return value of
"xmlf.open(QIODevice::OpenMode(_ZN9QIODevice9WriteOnlyE))".
300xmlf.open(QIODevice
Fixes Coverity CID 709302: Dereference before null check (REVERSE_INULL)
Dereferencing pointer "this->m_render". [show details]
736int width = (int)(height * m_render->dar());
...
Dereferencing "this->m_render" before a null check.
749if (m_render == NULL) {
750
Fixes Coverity CID 709291: Explicit null dereferenced (FORWARD_NULL)
Passing null variable "item" to function "FolderProjectItem::groupName()
const", which dereferences it. [show details]
272props.insert("groupname", item->groupName());
...
Assigning: "item" = 0.
276
Fixes Coverity CID 709294: Missing break in switch (MISSING_BREAK)
This case (value 9) is not terminated by a 'break' statement.
70case PLAYLIST:
71connect(this, SIGNAL(updateThumb()), m_previewTimer,
SLOT(start()));
The above case falls through to this one.
72case I
Fixes Coverity CID 709308: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""m_begin"" is not initialized in this constructor nor
in any functions that it calls.
Non-static class member ""m_end"" is not initialized in this constructor nor in
any functions that it calls.
Non-stat
Fixes Coverity CID 709288: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "STEPS" which may be zero has undefined behavior
139avg=avg/STEPS;
...
150return delta / STEPS;
---
thumbnailer/westleypreview.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/thumbnaile
Fixes Coverity CID 709281: Unchecked return value (CHECKED_RETURN)
Calling function "QFile::open(QFlags)" without
checking return value (as is done elsewhere 45 out of 47 times).
No check of the return value of
"xmlf.open(QIODevice::OpenMode(_ZN9QIODevice9WriteOnlyE))".
552xmlf.open(QIODevice
Fixes Coverity CID 709284: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "byteCount >> 7" which may be zero has undefined behavior
87const float scaling = (float)partH/(byteCount >> 7);
---
src/colorcorrection/histogramgenerator.cpp |5 -
1 file changed, 4 inserti
CID 709285: Division or modulo by zero (DIVIDE_BY_ZERO)
Division by expression "STEPS" which may be zero has undefined behavior
250avg=avg/STEPS;
---
src/kthumb.cpp |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/kthumb.cpp b/src/kthumb.cpp
index c5e1691..428
Fixes Coverity CID 709286: Division or modulo by zero (DIVIDE_BY_ZERO)
Assigning: "maxVal" = "this->max()".
On this path, function call "this->max()" has return value of 0
78int64_t maxVal = max();
...
Division by expression "maxVal" which may be zero has undefined behavior
86val = m_co
Fixes Coverity CID 709290: Dereference after null check (FORWARD_NULL)
Comparing "this->m_clipref" to null implies that "this->m_clipref" might be
null.
717else if (m_clipref) {
...
Passing null variable "this->m_clipref" to function "AbstractClipItem::info()
const", which dereferences it. [s
Fixes Coverity CID 709289: Explicit null dereferenced (FORWARD_NULL)
Assigning: "effectToMove" = 0.
790CollapsibleEffect *effectToMove = NULL;
...
Passing null variable "effectToMove" to function
"CollapsibleGroup::addGroupEffect(CollapsibleEffect *)", which dereferences it.
[show details]
80
hub.com/mcfrisk/kdenlive.git
Mikko Rapeli (16):
histogramgenerator.cpp: check for division by zero
effectstackview2.cpp: check for null pointer
effectstackview2.cpp: check for null
audioCorrelationInfo.cpp: check for division by zero
audioEnvelope.cpp: check for division by zero
meltjob.
Fixes Coverity CID 709275: Unchecked return value (CHECKED_RETURN)
Calling function "QDomDocument::setContent(QIODevice *, QString *, int *, int
*)" without checking return value (as is done elsewhere 6 out of 7 times).
No check of the return value of "doc.setContent(&file, NULL, NULL, NULL)".
134
Oops, wrong list. Sorry.
-Mikko
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will includ
From: Christian Marillat
They have changed in Debian.
---
src/modules/avformat/vdpau.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/modules/avformat/vdpau.c b/src/modules/avformat/vdpau.c
index 7756cc0..c4ae33a 100644
--- a/src/modules/avformat/vdpau.c
++
From: Christian Marillat
In file included from producer_avformat.c:157:0:
vdpau.c: In function ‘vdpau_get_buffer’:
vdpau.c:162:10: error: ‘AVFrame’ has no member named ‘age’
vdpau.c:169:10: error: ‘AVFrame’ has no member named ‘age’
---
src/modules/avformat/vdpau.c |2 --
1 file changed, 2 d
These patches are needed to compile on Debian unstable with
debian-multimedia.org packages. Hopefully they are generic enough
to not break compilation or functionality with older library versions.
I don't have nvidia GPU so I could not properly test these.
Christian Marillat (2):
vdpau compilati
Found by Coverity:
CID 709303: Uninitialized scalar variable (UNINIT)
Declaring variable "profile".
2400MltVideoProfile profile;
At conditional (1): "this->m_activeDocument" taking the false branch.
2401if (m_activeDocument) profile = m_activeDocument->mltProfile();
Using uninitial
Found by Coverity:
31class ScopeManager : QObject
32{
33Q_OBJECT
34
35struct GfxScopeData {
CID 709313: Uninitialized pointer field (UNINIT_CTOR)
Class member declaration for ""scope"".
36AbstractGfxScopeWidget *scope;
Class member declaration for ""scopeDockWidget"".
37
Hope it's the correct default. Found by Coverity:
42/** @brief Build an abstract MLT Renderer
43 * @param name A unique identifier for this renderer
44 * @param winid The parent widget identifier (required for SDL
display). Set to 0 for OpenGL rendering
45 * @param profile
Found by Coverity:
41/* Dragging variables */
CID 709309: Uninitialized scalar field (UNINIT_CTOR)
...
CID 709309: Uninitialized pointer field (UNINIT_CTOR)
Class member declaration for ""m_pixmapCache"".
61QPixmap *m_pixmapCache;
62
63/* In/Out controls */
Class member declaration
Coverity says:
82for (int i = 0; i < m_extraGeometries.count(); i++) {
At conditional (1): "@dim2 < 5U" taking the true branch.
At conditional (2): "@dim2 < 5U" taking the true branch.
At conditional (3): "@dim2 < 5U" taking the false branch.
CID 709298: Resource leak (RESOURCE_LE
Found by Coverity:
18AudioInfo::AudioInfo(Mlt::Producer *producer)
19{
20// Since we already receive an MLT producer, we do not need to initialize
MLT:
21// Mlt::Factory::init(NULL);
22
23// Get the number of streams and add the information of each of them if
it is an audio stream.
2
Found by Coverity:
37MeltJob::MeltJob(CLIPTYPE cType, const QString &id, QStringList parameters)
: AbstractClipJob(MLTJOB, cType, id, parameters),
38m_producer(NULL),
39m_profile(NULL),
40m_consumer(NULL),
41m_length(0)
42{
43jobStatus = JOBWAITING;
44m_params = pa
Found by Coverity:
CID 709305: Uninitialized scalar variable (UNINIT)
Declaring variable "info".
191ItemInfo info;
Using uninitialized value "info": field "info".track is uninitialized when
calling "EffectStackEdit::transferParamDesc(QDomElement const &, ItemInfo,
bool)". [show details]
Just in case someone uses the class/struct without setting all of the
variables.
---
src/definitions.h |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/definitions.h b/src/definitions.h
index a48306e..3d8ce6a 100644
--- a/src/definitions.h
+++ b/src/definitions.h
Found by Coverity:
60TitleDocument::TitleDocument()
61{
62m_scene = NULL;
CID 709315: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""m_height"" is not initialized in this constructor nor
in any functions that it calls.
Non-static class member ""m_width"" is not initiali
Found by Coverity:
At conditional (1): "this->m_length > 0" taking the true branch.
33if (m_length > 0) {
34Q_ASSERT(m_length+m_offset <= m_envelopeSize);
35m_envelopeSize = m_length;
36}
CID 709310: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""m_e
Found by Coverity:
CID 709297: Resource leak (RESOURCE_LEAK)
Calling opening function "open".
Assigning: "fd" = handle returned from "open((char
*)QByteArray(this->m_device.toUtf8()).data(), 0)".
89const int fd = KDE_open((char *) m_device.toUtf8().data(), O_RDONLY);
At conditional (1): "fd
with my own editing projects.
Mikko Rapeli (14):
audioEnvelope.cpp: initialize Mean and StdDev to zero
audioInfo.cpp: initialize m_producer pointer
meltjob.cpp: initialize m_showFrameEvent
scopemanager.h: initialize pointers
v4lcapture.cpp: free src in the end
abstractmonitor.h
Found by Coverity:
47QStringList V4lCaptureHandler::getDeviceName(QString input)
48{
49
CID 709299: Resource leak (RESOURCE_LEAK)
Calling allocation function "strdup".
Assigning: "src" = storage returned from
"strdup(QByteArray(input.toUtf8()).constData())".
50char *src = strdup(input.toUt
Just in case someone uses the class/struct without setting all of the
variables.
---
src/definitions.h |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/definitions.h b/src/definitions.h
index 3d8ce6a..b663fc6 100644
--- a/src/definitions.h
+++ b/src/definitions.h
@@
Fixes this warning from krazy:
Check for C++ ctors that should be declared 'explicit' [explicit]...OOPS! 33
issues found!
src/wizard.h: line# 79 (1)
src/kis_curve_widget.h: line# 59 (1)
src/beziercurve/beziersplinewidget.h: line# 37 (1)
src/encodingprofilesdialog.h: line# 33 (1)
src/scopes/colors
krazy says:
Check for foreach loop issues [foreach]...OOPS! 22 issues found!
src/projecttree/proxyclipjob.cpp: non-const ref iterator line# 55 (1)
src/projecttree/meltjob.cpp: non-const ref iterator line# 99,122,131,153 (4)
src/titlewidget.cpp: non-const ref iterator line# 515 (1)
src/initeffects.
Should be faster than using a full string. Found by krazy.
---
src/kdenlivedoc.cpp | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp
index b210a5b..e5597b5 100644
--- a/src/kdenlivedoc.cpp
+++ b/src/kdenlivedoc.cpp
@@ -87,9
Should be faster than using a full string. Found by krazy.
---
src/mltdevicecapture.cpp |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mltdevicecapture.cpp b/src/mltdevicecapture.cpp
index e93e541..948e86e 100644
--- a/src/mltdevicecapture.cpp
+++ b/src/mltdevic
Should be faster than using a full string. Found by krazy.
---
src/utils/resourcewidget.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/utils/resourcewidget.cpp b/src/utils/resourcewidget.cpp
index 0ef2287..002d3ec 100644
--- a/src/utils/resourcewidget.cpp
+++ b/src/
Should be faster than using a full string. Found by krazy.
---
src/kthumb.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kthumb.cpp b/src/kthumb.cpp
index a87f654..c5e1691 100644
--- a/src/kthumb.cpp
+++ b/src/kthumb.cpp
@@ -355,7 +355,7 @@ void KThumb::slotGetIntra
Should be faster than using a full string. Found by krazy.
---
src/clipproperties.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/clipproperties.cpp b/src/clipproperties.cpp
index ed3c037..ed52808 100644
--- a/src/clipproperties.cpp
+++ b/src/clipproperties.cpp
@
Should be faster than using a full string. Found by krazy.
---
src/utils/openclipart.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/utils/openclipart.cpp b/src/utils/openclipart.cpp
index a120266..e106d22 100644
--- a/src/utils/openclipart.cpp
+++ b/src/utils/opencl
Should be faster than using a full string. Found by krazy.
---
src/utils/archiveorg.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/utils/archiveorg.cpp b/src/utils/archiveorg.cpp
index 86f9c7d..7be89ab 100644
--- a/src/utils/archiveorg.cpp
+++ b/src/utils/archiv
Should be faster than using a full string. Found by krazy.
---
src/projectlist.cpp | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index 6c77cd7..df1ac4f 100644
--- a/src/projectlist.cpp
+++ b/src/projectlist.
Should be faster than using a full string. Found by krazy.
---
src/documentchecker.cpp |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/documentchecker.cpp b/src/documentchecker.cpp
index 5caafe0..8614eea 100644
--- a/src/documentchecker.cpp
+++ b/src/documentchecke
Should be faster than using a full string. Found by krazy.
---
src/stopmotion/stopmotion.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/stopmotion/stopmotion.cpp b/src/stopmotion/stopmotion.cpp
index 8294c1e..f03fbb9 100644
--- a/src/stopmotion/stopmotion.cpp
++
Should be faster than using a full string. Found by krazy.
---
src/cliptranscode.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cliptranscode.cpp b/src/cliptranscode.cpp
index fac4a04..59701ae 100644
--- a/src/cliptranscode.cpp
+++ b/src/cliptranscode.cpp
@@ -79,7 +
Should be faster than using a full string. Found by krazy.
---
src/parameterplotter.cpp | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/parameterplotter.cpp b/src/parameterplotter.cpp
index 21bf09b..a34a320 100644
--- a/src/parameterplotter.cpp
+++ b/sr
Should be faster than using a full string. Found by krazy.
---
src/clipmanager.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/clipmanager.cpp b/src/clipmanager.cpp
index edd2ddf..13f4e5c 100644
--- a/src/clipmanager.cpp
+++ b/src/clipmanager.cpp
@@ -531,7 +531,7 @@
Should be faster than using a full string. Found by krazy.
---
src/mainwindow.cpp | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index f15afb1..b046c30 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@
Should be faster than using a full string. Found by krazy.
---
src/databackup/backupwidget.cpp | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/databackup/backupwidget.cpp b/src/databackup/backupwidget.cpp
index 8b5bf96..2b9fde7 100644
--- a/src/databackup/backu
Should be faster than using a full string. Found by krazy.
---
src/keyframeedit.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/keyframeedit.cpp b/src/keyframeedit.cpp
index 0bb08a2..8014cd0 100644
--- a/src/keyframeedit.cpp
+++ b/src/keyframeedit.cpp
@@ -126,7 +126,
Should be faster than using a full string. Found by krazy.
---
src/dragvalue.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/dragvalue.cpp b/src/dragvalue.cpp
index c76c636..b85ad47 100644
--- a/src/dragvalue.cpp
+++ b/src/dragvalue.cpp
@@ -361,7 +361,7 @@ Custom
Should be faster than using a full string. Found by krazy.
---
src/effectstack/collapsibleeffect.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/effectstack/collapsibleeffect.cpp
b/src/effectstack/collapsibleeffect.cpp
index e4b0c07..60e5d3d 100644
--- a/src/effects
Should be faster than using a full string. Found by krazy.
---
src/renderer.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/renderer.cpp b/src/renderer.cpp
index 3f423ae..5effeb8 100644
--- a/src/renderer.cpp
+++ b/src/renderer.cpp
@@ -285,7 +285,7 @@ void Render::bu
Should be faster than using a full string. Found by krazy.
---
src/effectstack/parametercontainer.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/effectstack/parametercontainer.cpp
b/src/effectstack/parametercontainer.cpp
index 9e5ecbd..82b228a 100644
--- a/src/effe
Should be faster than using a full string. Found by krazy.
---
src/customtrackview.cpp |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp
index 17a7331..8293189 100644
--- a/src/customtrackview.cpp
+++ b/src/customtrackv
Should be faster than using a full string. Found by krazy.
---
src/encodingprofilesdialog.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/encodingprofilesdialog.cpp b/src/encodingprofilesdialog.cpp
index 6a88d16..59116f7 100644
--- a/src/encodingprofile
Should be faster than using a full string. Found by krazy.
---
src/projecttree/meltjob.cpp |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/projecttree/meltjob.cpp b/src/projecttree/meltjob.cpp
index 1476072..27bc049 100644
--- a/src/projecttree/meltjob.cpp
+++ b/sr
Should be faster than using a full string. Found by krazy.
---
src/trackdialog.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/trackdialog.cpp b/src/trackdialog.cpp
index 0f4ffc0..b11b91a 100644
--- a/src/trackdialog.cpp
+++ b/src/trackdialog.cpp
@@ -36,7 +36,7 @@ Tr
Should be faster than using a full string. Found by krazy.
---
src/scopes/audioscopes/audiospectrum.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/scopes/audioscopes/audiospectrum.cpp
b/src/scopes/audioscopes/audiospectrum.cpp
index 10ac5f3..dfdfc5c 100644
--- a/sr
Should be faster than using a full string. Found by krazy.
---
src/slideshowclip.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/slideshowclip.cpp b/src/slideshowclip.cpp
index e9cb422..457af2e 100644
--- a/src/slideshowclip.cpp
+++ b/src/slideshowclip.cpp
@@ -35
Should be faster than using a full string. Found by krazy.
---
src/abstractclipitem.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abstractclipitem.cpp b/src/abstractclipitem.cpp
index 50290cb..1a0adfd 100644
--- a/src/abstractclipitem.cpp
+++ b/src/abstractclipitem
Should be faster than using a full string. Found by krazy.
---
src/unicodedialog.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/unicodedialog.cpp b/src/unicodedialog.cpp
index 51d462d..7576c3b 100644
--- a/src/unicodedialog.cpp
+++ b/src/unicodedialog.cpp
@@ -21
Should be faster than using a full string. Found by krazy.
---
src/kdenlivesettingsdialog.cpp | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/kdenlivesettingsdialog.cpp b/src/kdenlivesettingsdialog.cpp
index b91654e..1b1bce5 1006
Should be faster than using a full string. Found by krazy.
---
src/clipstabilize.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/clipstabilize.cpp b/src/clipstabilize.cpp
index fcae509..6114707 100644
--- a/src/clipstabilize.cpp
+++ b/src/clipstabilize.cpp
@@ -14
Should be faster than using a full string. Found by krazy.
---
src/transitionsettings.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/transitionsettings.cpp b/src/transitionsettings.cpp
index 8946e8d..6a6fe3b 100644
--- a/src/transitionsettings.cpp
+++ b/src/transiti
Should be faster than using a full string. Found by krazy.
---
src/clipitem.cpp | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/clipitem.cpp b/src/clipitem.cpp
index e50ba6e..281953a 100644
--- a/src/clipitem.cpp
+++ b/src/clipitem.cpp
@@ -343,7
Should be faster than using a full string. Found by krazy.
---
src/trackview.cpp |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/trackview.cpp b/src/trackview.cpp
index 9cda82d..af723ce 100644
--- a/src/trackview.cpp
+++ b/src/trackview.cpp
@@ -641,7 +641,7 @@ int
Should be faster than using a full string. Found by krazy.
---
src/renderwidget.cpp |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp
index f7df0ab..0c5b139 100644
--- a/src/renderwidget.cpp
+++ b/src/renderwidget.cpp
@@ -459,7
Should be faster than using a full string. Found by krazy.
---
src/projectsettings.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/projectsettings.cpp b/src/projectsettings.cpp
index ddc8d14..ba8aebf 100644
--- a/src/projectsettings.cpp
+++ b/src/projec
Should be faster than using a full string. Found by krazy.
---
src/transition.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/transition.cpp b/src/transition.cpp
index 12519ea..27f66cd 100644
--- a/src/transition.cpp
+++ b/src/transition.cpp
@@ -377,7 +377,7 @@ bool
Should be faster than using a full string. Found by krazy.
---
src/archivewidget.cpp | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/archivewidget.cpp b/src/archivewidget.cpp
index ef31b85..4a99f75 100644
--- a/src/archivewidget.cpp
+++ b/src/
amp; with foreach loops where possible.
kdenlive compiles and I able to edit and play around with my test projects
as before.
Mikko Rapeli (46):
kdenlive_render.cpp: Use char for single character
lideshowclip.cpp: Use char for single character
meltjob.cpp: Use char for single
Should be faster than using a full string. Found by krazy.
---
src/recmonitor.cpp | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/recmonitor.cpp b/src/recmonitor.cpp
index 1ffd419..aec7b36 100644
--- a/src/recmonitor.cpp
+++ b/src/recmonitor.cpp
@@ -267,7 +267,
Should be faster than using a full string. Found by krazy.
---
src/wizard.cpp | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/wizard.cpp b/src/wizard.cpp
index f62ceff..a0a0c71 100644
--- a/src/wizard.cpp
+++ b/src/wizard.cpp
@@ -213,19 +213,19 @@ void Wizard::
Should be faster than using a full string. Found by krazy.
---
src/scopes/colorscopes/vectorscope.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/scopes/colorscopes/vectorscope.cpp
b/src/scopes/colorscopes/vectorscope.cpp
index 55437ff..7666133 100644
--- a/src/scop
Should be faster than using a full string. Found by krazy.
---
renderer/kdenlive_render.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/renderer/kdenlive_render.cpp b/renderer/kdenlive_render.cpp
index 07cb3f8..056c251 100644
--- a/renderer/kdenlive_render.cpp
+++ b/rend
Should be faster than using a full string. Found by krazy.
---
src/spacerdialog.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spacerdialog.cpp b/src/spacerdialog.cpp
index 3cd4132..2b21e01 100644
--- a/src/spacerdialog.cpp
+++ b/src/spacerdialog.cpp
@@ -39,7 +39,7
Should be faster than using a full string. Found by krazy.
---
src/docclipbase.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp
index be5a321..4694e17 100644
--- a/src/docclipbase.cpp
+++ b/src/docclipbase.cpp
@@ -66,7 +66,7 @
Should be faster than using a full string. Found by krazy.
---
src/titlewidget.cpp |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/titlewidget.cpp b/src/titlewidget.cpp
index 3c0f067..b5073a2 100644
--- a/src/titlewidget.cpp
+++ b/src/titlewidget.cpp
@@ -2248,7 +2248
On Sun, Jul 01, 2012 at 09:51:06PM +0200, Till Theato wrote:
> The refactored code is completely different, so rebasing/merging
> definitely won't work. It's a bit confusing currently because the old
> code is still there, but nothing outside src/core and src/plugins
> (besides main.c) is used.
We
On Sat, Jun 30, 2012 at 09:56:53AM +0200, jb wrote:
> On Friday 29 June 2012 12:37:50 Mikko Rapeli wrote:
> > Hi JB and others,
> >
> > How about registering Kdenlive to Coverity scan program to get some static
> > analysis runs and results?
> >
> > http:
Hi JB and others,
How about registering Kdenlive to Coverity scan program to get some static
analysis runs and results?
http://scan.coverity.com/developers-faq.html
If you are too busy, I can try to handle the process but only with your
permission.
Regards,
-Mikko
Fixes crashes if parent is destroyed. Found by krazy. Details at:
http://blogs.kde.org/node/3919
---
src/kdenlivedoc.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp
index 1e3e586..b210a5b 100644
--- a/src/kdenlivedoc.cpp
+++ b/sr
Fixes crashes if parent is destroyed. Found by krazy. Details at:
http://blogs.kde.org/node/3919
---
src/clipproperties.cpp |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/clipproperties.cpp b/src/clipproperties.cpp
index d1d610a..ed3c037 100644
--- a/src/clippro
Fixes krazy warnings:
Check for QString compares to "" [emptystrcompare]...OOPS! 5 issues found!
src/titlewidget.cpp: line# 638 (1)
src/clipstabilize.cpp: line# 236 (1)
src/jogaction.cpp: line# 77 (1)
src/unicodedialog.cpp: line# 83 (1)
src/jogshuttleconfig.cpp: line# 67 (1)
Do not compare a QStri
krazy complains about these.
---
src/projecttree/meltjob.cpp |3 ++-
src/utils/resourcewidget.cpp |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/projecttree/meltjob.cpp b/src/projecttree/meltjob.cpp
index 2587975..1476072 100644
--- a/src/projecttree/meltjob.cp
Fixes crashes if parent is destroyed. Found by krazy. Details at:
http://blogs.kde.org/node/3919
---
src/mainwindow.cpp | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 78aa154..66ae06a 100644
--- a/src/mainwindow.cpp
++
Fixes crashes if parent is destroyed. Found by krazy. Details at:
http://blogs.kde.org/node/3919
---
src/monitor.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/monitor.cpp b/src/monitor.cpp
index aebf23c..2effe24 100644
--- a/src/monitor.cpp
+++ b/src/monitor.cpp
@@
Fixes crashes if parent is destroyed. Found by krazy. Details at:
http://blogs.kde.org/node/3919
Also delete dialog on exit paths.
---
src/mainwindow.cpp | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index c28579e..b64eba7
1 - 100 of 252 matches
Mail list logo
