Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
Great thanks! I will re-spin the release. Colm. On Tue, May 9, 2017 at 4:01 PM, Emmanuel Lécharny wrote: > > > Le 09/05/2017 à 16:54, Colm O hEigeartaigh a écrit : > > OK I have added all of the parts from the Netty NOTICE that were > "modified" > > in Netty and licenses, so long as they weren'

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 16:54, Colm O hEigeartaigh a écrit : > OK I have added all of the parts from the Netty NOTICE that were "modified" > in Netty and licenses, so long as they weren't ASL v2.0. Emmanuel, please > review and let me know if it's finally right. > > https://github.com/apache/directory-ke

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
OK I have added all of the parts from the Netty NOTICE that were "modified" in Netty and licenses, so long as they weren't ASL v2.0. Emmanuel, please review and let me know if it's finally right. https://github.com/apache/directory-kerby/tree/trunk/kerby-dist/kdc-dist Colm. On Tue, May 9, 2017 a

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 14:23, Colm O hEigeartaigh a écrit : > Hi Kai, > > What matters is what jars we are including in the "lib". Any changes Netty > made to third party dependencies in these jars must be in the > NOTICE/licenses. Colm is right. Now, it's enough - assuming that they have been double

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
Hi Kai, What matters is what jars we are including in the "lib". Any changes Netty made to third party dependencies in these jars must be in the NOTICE/licenses. Colm. On Tue, May 9, 2017 at 1:20 PM, Zheng, Kai wrote: > Hi Colm and Emmanuel, > > Regarding Netty, what we used is the TCP/UDP net

RE: Questions about the release

2017-05-09 Thread Zheng, Kai
Hi Colm and Emmanuel, Regarding Netty, what we used is the TCP/UDP network transport support, which should be one of its basic functionalities. We haven't used any other parts, like the one JBoss marshalling function. The relevant codes are in kerby KDC. Hope this helps. Regards, Kai -Or

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
I haven't. So I think I should include all "This product contains a modified portion" portions from the NOTICE file, but not "This product optionally depends on" from here: https://github.com/netty/netty/blob/4.1/NOTICE.txt ? As well as any of the licenses that are referred. Colm. On Tue, May 9

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 12:24, Colm O hEigeartaigh a écrit : > Thanks Emmanuel. The user would have to add zookeeper/nimbus in the poms > before generating the distribution to add them, so I am going to remove > these from the NOTICE file as they are not required. > > OK here are the changes I have made.

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
Thanks Emmanuel. The user would have to add zookeeper/nimbus in the poms before generating the distribution to add them, so I am going to remove these from the NOTICE file as they are not required. OK here are the changes I have made...please review: 1) The root NOTICE just includes the standard

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 11:16, Colm O hEigeartaigh a écrit : > OK, seeing as we don't bundle them by default, then IMO we don't need to > include them in the NOTICE file. Emmanuel, can you confirm? Everything that is not bundled does not have to be into N&L files. If there is no way a user can grab the

RE: Using Kerby kerb-client as an alternative for GSS-API.... Sgt Request succeeds 8-) Response fails Integrity check

2017-05-09 Thread Christopher Lamb
I was on the point of parking this for a while when I "tried one more thing" and made a great step forward! With all Kdc Options explicitly set to false, with the exception of forwardable, I know can make an Sgt which is accepted by my FreeIPA KDC? requestOptions.add(KrbKdcOption.PROXIABLE, fals

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
OK, seeing as we don't bundle them by default, then IMO we don't need to include them in the NOTICE file. Emmanuel, can you confirm? Colm. On Tue, May 9, 2017 at 10:11 AM, Zheng, Kai wrote: > Hi Colm, > > Thanks for this! > > >> Kai, is there a reason that the zookeeper + nimbus dependencies ar

RE: Questions about the release

2017-05-09 Thread Zheng, Kai
Hi Colm, Thanks for this! >> Kai, is there a reason that the zookeeper + nimbus dependencies are not in >> the lib directories of the distributions? This is a good question I happened to know the answer. Yes we have already supported various KDC back ends, like the LDAP, ZK ones, but which on

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
OK I have made some changes based on my understanding of what is required. Please correct me if I'm wrong! Mockito, Hamcrest (junit) are test dependencies and are not required in the NOTICE file or to specify the license. We bundle Netty and SLF4J in the distribution. So we have the SLF4J license