Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
Great thanks! I will re-spin the release. Colm. On Tue, May 9, 2017 at 4:01 PM, Emmanuel Lécharny wrote: > > > Le 09/05/2017 à 16:54, Colm O hEigeartaigh a écrit : > > OK I have added all of the parts from the Netty NOTICE that were > "modified" > > in Netty and licenses,

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
OK I have added all of the parts from the Netty NOTICE that were "modified" in Netty and licenses, so long as they weren't ASL v2.0. Emmanuel, please review and let me know if it's finally right. https://github.com/apache/directory-kerby/tree/trunk/kerby-dist/kdc-dist Colm. On Tue, May 9, 2017

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 14:23, Colm O hEigeartaigh a écrit : > Hi Kai, > > What matters is what jars we are including in the "lib". Any changes Netty > made to third party dependencies in these jars must be in the > NOTICE/licenses. Colm is right. Now, it's enough - assuming that they have been double

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
t; > -Original Message- > From: Colm O hEigeartaigh [mailto:cohei...@apache.org] > Sent: Tuesday, May 09, 2017 8:12 PM > To: kerby@directory.apache.org > Subject: Re: Questions about the release > > I haven't. So I think I should include all "This product contains a

RE: Questions about the release

2017-05-09 Thread Zheng, Kai
-Original Message- From: Colm O hEigeartaigh [mailto:cohei...@apache.org] Sent: Tuesday, May 09, 2017 8:12 PM To: kerby@directory.apache.org Subject: Re: Questions about the release I haven't. So I think I should include all "This product contains a modified portion" portions from

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
I haven't. So I think I should include all "This product contains a modified portion" portions from the NOTICE file, but not "This product optionally depends on" from here: https://github.com/netty/netty/blob/4.1/NOTICE.txt ? As well as any of the licenses that are referred. Colm. On Tue, May

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 12:24, Colm O hEigeartaigh a écrit : > Thanks Emmanuel. The user would have to add zookeeper/nimbus in the poms > before generating the distribution to add them, so I am going to remove > these from the NOTICE file as they are not required. > > OK here are the changes I have

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
Thanks Emmanuel. The user would have to add zookeeper/nimbus in the poms before generating the distribution to add them, so I am going to remove these from the NOTICE file as they are not required. OK here are the changes I have made...please review: 1) The root NOTICE just includes the standard

Re: Questions about the release

2017-05-09 Thread Emmanuel Lécharny
Le 09/05/2017 à 11:16, Colm O hEigeartaigh a écrit : > OK, seeing as we don't bundle them by default, then IMO we don't need to > include them in the NOTICE file. Emmanuel, can you confirm? Everything that is not bundled does not have to be into N files. If there is no way a user can grab the

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
r. For now less change much better. > > Thanks again. > > Regards, > Kai > > -Original Message- > From: Colm O hEigeartaigh [mailto:cohei...@apache.org] > Sent: Tuesday, May 09, 2017 4:52 PM > To: kerby@directory.apache.org > Subject: Re: Questions about the r

RE: Questions about the release

2017-05-09 Thread Zheng, Kai
For now less change much better. Thanks again. Regards, Kai -Original Message- From: Colm O hEigeartaigh [mailto:cohei...@apache.org] Sent: Tuesday, May 09, 2017 4:52 PM To: kerby@directory.apache.org Subject: Re: Questions about the release OK I have made some changes based on my u

Re: Questions about the release

2017-05-09 Thread Colm O hEigeartaigh
sage- > From: Emmanuel Lécharny [mailto:elecha...@gmail.com] > Sent: Tuesday, May 09, 2017 7:17 AM > To: kerby@directory.apache.org > Subject: Re: Questions about the release > > > > Le 08/05/2017 à 21:40, Colm O hEigeartaigh a écrit : > > I don't th

Re: Questions about the release

2017-05-08 Thread Emmanuel Lécharny
Le 08/05/2017 à 21:40, Colm O hEigeartaigh a écrit : > I don't think we need the Mockito notice as it's a test dependency, right? right. -- Emmanuel Lecharny Symas.com directory.apache.org

Re: Questions about the release

2017-05-08 Thread Colm O hEigeartaigh
I don't think we need the Mockito notice as it's a test dependency, right? Colm. On Mon, May 8, 2017 at 3:02 PM, Colm O hEigeartaigh wrote: > Actually, scratch that, it's fine to have the NOTICE file with the > dependency information in the source as well. > > Colm. > > On

Re: Questions about the release

2017-05-08 Thread Colm O hEigeartaigh
Thanks Emmanuel! So if I understand correctly, the changes that were made to the NOTICE file in Kerby are incorrect: https://github.com/apache/directory-kerby/blob/trunk/NOTICE Instead, the NOTICE file should just have the standard Apache bit. However, we need to update the distribution source

Re: Questions about the release

2017-05-08 Thread Emmanuel Lécharny
Le 08/05/2017 à 14:44, Stefan Seelmann a écrit : > On 05/08/2017 01:23 PM, Emmanuel Lécharny wrote: >> >> Le 08/05/2017 à 11:26, Colm O hEigeartaigh a écrit : >>> Hi Emmanuel, >>> >>> Is there a wiki page or something that you are aware of at Apache that >>> clearly lays out what the obligations

Re: Questions about the release

2017-05-08 Thread Stefan Seelmann
On 05/08/2017 01:23 PM, Emmanuel Lécharny wrote: > > > Le 08/05/2017 à 11:26, Colm O hEigeartaigh a écrit : >> Hi Emmanuel, >> >> Is there a wiki page or something that you are aware of at Apache that >> clearly lays out what the obligations of projects are for licenses + notice >> files for

Re: Questions about the release

2017-05-08 Thread Colm O hEigeartaigh
Hi Emmanuel, Is there a wiki page or something that you are aware of at Apache that clearly lays out what the obligations of projects are for licenses + notice files for third party dependencies? It's something I've yet to clearly wrap my head around. Colm. On Mon, May 8, 2017 at 10:22 AM,

Re: Questions about the release

2017-05-08 Thread Emmanuel Lecharny
As soon as I'll beback home ! Le lun. 8 mai 2017 à 09:27, Li, Jiajia a écrit : > I've added the slf4j N, mockito N, netty's NOTICE, hamcrest N, > bouncycastle N(used by netty, but not included in it's N), > Jline N(used by zookeeper, but not included in it's N) > You can

RE: Questions about the release

2017-05-07 Thread Li, Jiajia
Hi Emmanuel, Thanks very much for listing out the dependencies of each modules, I will add the N based on your work. Thanks Jiajia -Original Message- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Monday, May 8, 2017 12:18 PM To: kerby@directory.apache.org Subject: