From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3070#note_1871493816
Please bring the pieces of the last commit ("rh_flags: Fix of build errors and
warnings") to the individual commits. While some projects do such cumulative
fixes at the end o
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2403#note_1438205693
The only non-rt core networking related change seems to be that
CONFIG_INET_TABLE_PERTURB_ORDER is being set to 16. I don't know what caused
this to be added but this is the default value
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1432295679
This slipped my radar. Thanks for the ping, Patrick!
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409821891
That looks much better. And yes, I think it's something for upstream.
IMHO Documentation/kbuild/kbuild.rst documents HOSTCFLAGS as something that
can be overriden from the make command
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2490#note_1409378737
I wonder whether it's not a problem in the upstream commits playing weird
games with the makefile variables. For example, this sentence in upstream
commit 13e07691a16f ("
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2286#note_1273813728
Scratch that, this is not about the bpf object files but about the (host
native) binary running them. Sorry for my misunderstanding.
___
kernel
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2286#note_1273804191
This is a good workaround. I wonder though whether it should not be more
generic. We already have custom code to install the bpf selftest files (since
the upstream `make install` does
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124642864
I find this useful when working on a bug report. By getting /proc/config.gz,
I'm 100% sure I've got the correct config. No space for mishandling a script
fetching from /boot, no space
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124638254
I'd argue that if you're running 1000 VMs, 50 MB hardly matters. The kernels
are what, 30 GB at that point? 0.1% is still 0.1%.
___
kernel
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2021#note_1114008796
Thanks!
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2021#note_1110837378
Good idea.
The name is a bit misleading, since the option applies to all selftests we
build, not just the bpf ones. I mentioned bpf in the description, as the
problem with failing build
On Sat, 17 Sep 2022 12:10:57 -, Prarit Bhargava (via Email Bridge) wrote:
> redhat: kernel.spec: selftests: abort on build failure
>
> When a selftest does not compile, abort the whole build. We want to know
> that we broke selftests by a backport.
>
> This commit is forward ported from RHEL
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1858#note_980591912
Please put this to common/generic and delete ark/generic/CONFIG_DEBUG_NET.
___
kernel mailing list -- kernel@lists.fedoraproject.org
From: Jiri Benc
Enable net reference count trackers in all debug kernels
A leaked netdev or netns entry is a common source of bugs, which are
hard to debug. The refcount tracker for them is already enabled for
Fedora debug kernels. Enable it also for ARK debug kernels.
Signed-off-by: Jiri Benc
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846679718
This leaves the semicolon here in the GENKSYMS pass. I don't think we want
that; the kABI checksum would be generated from:
```
union {
unsigned long xyz[_size
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1619#note_846001310
Sabrina, I suggest enabling CONFIG_RH_KABI_SIZE_ALIGN_CHECKS only in
redhat/configs/ark and disabling them in redhat/configs/fedora. That config
option is not useful for Fedora
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1422#note_698589843
Acked-by: Jiri Benc
(via approve button)
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1422#note_694688949
Acked-by: Jiri Benc
(via approve button)
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1422#note_694678839
The other file is just a list of modules that should not be put into the main
rpm and it's the correct thing to do.
___
kernel mailing list
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1226#note_692091567
Acked-by: Jiri Benc
(via approve button)
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1325#note_659345171
Acked-by: Jiri Benc
(via approve button)
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1325#note_659253997
@bnemeth, maybe leave this enabled in Fedora and disable for ARK only?
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1311#note_659027149
Acked-by: Jiri Benc
(via approve button)
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc
kernel.spec: fix build of samples/bpf
Due to some change of the kernel makefiles, "samples/bpf" does not work
anymore as a make target. Use M= instead.
Signed-off-by: Jiri Benc
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
index blahblah
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/994#note_561200965
Thanks for putting the explanation in the patch description. I'm okay
with this approach.
___
kernel mailing list -- kernel
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/994#note_554516072
Thanks for the link to the upstream discussion. I read the whole thread
and it doesn't seem to me the idea was rejected. Just a different
implementation was requested. We should pursue
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1029#note_552917820
From a quick look, this seems reasonable even for RHEL. However, it
needs a verification. Which is easy, you take the rpms built before and
after the patch set and compare their content
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/987#note_546473354
Looks good. Thanks!
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/994#note_546471110
That's a good point. I agree that this should be submitted upstream
first.
___
kernel mailing list -- kernel@lists.fedoraproject.org
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/987#note_541631004
Don, you're disabling CONFIG_NET_ACT_CTINFO and CONFIG_NET_ACT_MPLS
options everywhere but they should stay enabled in Fedora. Keep them as
'm' in common/generic and disable them in ark
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/987#note_540836903
Thanks for letting me know! After some digging, I found the reason. In
RHEL 8, CONFIG_NET_ACT_CTINFO and CONFIG_NET_ACT_MPLS are disabled and
those modules do not appear in mod
On Thu, 18 Feb 2021 10:24:42 -, CKI Gitlab (via Email Bridge) wrote:
> From: CKI Gitlab on gitlab.com
> Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/812
Acked-by: Jiri Benc
___
kernel mailing list --
On Tue, 22 Dec 2020 13:16:20 -, GitLab Bridge on behalf of Patrick Talbert
wrote:
> I think this is good to go now; all concerns appear to be addressed.
>
> Jiri what do you think?
Acked-by: Jiri Benc
Thanks!
___
kernel mailing list
On Fri, 4 Dec 2020 14:24:37 +0100, Jiri Benc wrote:
> The review of this is non-trivial and time consuming. Could you please
> wait with merging this a few more days? I'll review it. Given that
> there were not so nice bugs in the previous version, extra scrutiny is
> warranted h
On Tue, 22 Dec 2020 13:45:43 +0100, Jiri Benc wrote:
> (As another topic, it would be great if the email bridge could CC
> people when they are mentioned in the text.)
Turns out that Gitlab actually sent me a notification. I'm just not
used to the format and since I get tons of notification
I'd say that CONFIG_INIT_STACK_NONE can be disabled even on the debug
kernel but that's minor and can be done later.
series
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.o
On Mon, 14 Dec 2020 21:52:19 -, GitLab Bridge on behalf of Josh Poimboeuf
wrote:
> CI passed this time. @jbencrh can you please re-review?
Sorry, I didn't see this until I got pinged in bugzilla. I was too
buried in RHEL work in the past two weeks and didn't have time to read
mailing lists.
On Wed, 16 Dec 2020 13:35:52 -, GitLab Bridge on behalf of redhat-patchlab
wrote:
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_NFT_REJECT_NETDEV
> @@ -0,0 +1 @@
> +# CONFIG_NFT_REJECT_NETDEV is not set
This sounds like something we want in both ARK and Fedora. Florian,
what
_OCP is not set
This is a cool project. However, I doubt that Fedora will be ran on it.
If I'm proven wrong, this should be enabled for Fedora (not for ARK).
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscrib
On Wed, 09 Dec 2020 21:19:34 -, GitLab Bridge on behalf of jpoimboe wrote:
> Enable CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL for both fedora and ARK.
[...]
> +++ b/redhat/configs/fedora/generic/CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL
> @@ -0,0 +1 @@
> +# CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL is
f" \
Thanks, Augusto. I was not as thorough with my review as I should have
been.
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https:/
On Fri, 04 Dec 2020 14:25:21 -, GitLab Bridge on behalf of Ben Crocker
wrote:
> I made the change you suggested; thanks!
Thanks!
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to ker
On Sun, 06 Dec 2020 19:38:47 -, GitLab Bridge on behalf of jolsa1 wrote:
> From: Jiri Olsa
>
> Enabling kheaders module that carries kernel headers
> to compile eBPF programs and will allow bcc-tools rpm
> to get rid of kernel-devel dependency.
Acke
On Thu, 19 Nov 2020 20:05:34 -, GitLab Bridge on behalf of bcrocker wrote:
> From: bcrocker on gitlab.com
>
> Fix syntax flagged by shellcheck in all scripts in the redhat/ subtree.
I'm sorry that I haven't got back to this, yet. I know it's been posted
weeks ago and I should do better.
The
On Tue, 24 Nov 2020 19:03:43 -, GitLab Bridge on behalf of bcrocker wrote:
> -dist-clean: dist-clean-sources dist-clean-configs dist-clean-rpmdirs
> +dist-clean-scripts:
> + @if [ -f dist-dump-variables.sh ]; then rm dist-dump-variables.sh; fi
This does the same thing and is usually used:
gt; zhenhua.ko
It's safe to remove this also from rhel_files, ARK has
CONFIG_INPUT_JOYSTICK disabled, this is a dead entry anyway.
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le
On Thu, 26 Nov 2020 15:46:17 -, GitLab Bridge on behalf of Jiri Olsa wrote:
> IIUC that seems like some big reorg change that I'm not competent
> to do..
You are :-)
> I just need to add an option to ark kernel
ARK inherits from common. We're trying to have as few files in configs/
as
I'm sorry I did not clearly worded what I intended to say. Let me try
again.
On Thu, 19 Nov 2020 03:25:28 -, GitLab Bridge on behalf of Ben Crocker
wrote:
> The warning actually comes from the text that is being cat'ed to
> the output file, so I think this is legitimate, if somewhat
On Thu, 19 Nov 2020 03:16:12 -, GitLab Bridge on behalf of Ben Crocker
wrote:
> I reworked the logic thus:
>
> floppylist=("$RpmDir"/"$ModDir"/extra/drivers/block/floppy.ko*)
> if [[ -n ${floppylist[0]} && -f ${floppylist[0]} ]]; then
> blacklist "floppy"
> fi
I like this. The -n is
On Fri, 13 Nov 2020 21:12:22 -, GitLab Bridge on behalf of bcrocker wrote:
> -STAMP=$(echo $MARKER | cut -f 1 -d '-' | sed -e "s/v//");
> +# STAMP=$(echo $MARKER | cut -f 1 -d '-' | sed -e "s/v//"); # unused
Good catch. Could you add a separate patch removing this line?
A separate patch would
On Fri, 13 Nov 2020 21:12:21 -, GitLab Bridge on behalf of bcrocker wrote:
> -upload $upload_list
> +upload "$upload_list"
The 'upload' function is expecting multiple parameters, not a single
one, and relies on word splitting. You're introducing a bug by this
change.
Jiri
On Fri, 13 Nov 2020 21:12:21 -, GitLab Bridge on behalf of bcrocker wrote:
> WARNING: I don't think this script ever would have worked, before
> or after shellcheck-suggested changes; I think the logic should be:
There is a bug but a different one. The entries in $entries are
separated by
On Fri, 13 Nov 2020 21:12:21 -, GitLab Bridge on behalf of bcrocker wrote:
> -rngd -r /dev/hwrandom >& /dev/null
> -if [ $? -ne 0 ]; then
This is deciding based on the rngd return code,
> +if [ "$(rngd -r /dev/hwrandom >& /dev/null)" ]; then
while this is deciding based on rngd *output*.
On Fri, 13 Nov 2020 21:12:20 -, GitLab Bridge on behalf of bcrocker wrote:
> +if [ -n "$repo" ] && [ -n "$local" ]; then
Another candidate for [[ ]].
Jiri
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to
On Fri, 13 Nov 2020 21:12:20 -, GitLab Bridge on behalf of bcrocker wrote:
> -cat >${output} < +# We are generating, e.g., /lib/modules//bls.conf;
> +# bootprefix may legitimately be undefined here in this script:
The comment seems to be off. Did you confuse $rootfs with $bootprefix?
Should
On Fri, 13 Nov 2020 21:12:20 -, GitLab Bridge on behalf of bcrocker wrote:
> #!/bin/bash
> -if [ -z "$1" -o -z "$2" ]; then
> - echo "$(basename $0) " >&2;
> +if [ -z "$1" ] || [ -z "$2" ]; then
if [[ -z $1 || -z $2 ]]
More readable, no quotes needed, etc. This is bash anyway, so why
On Fri, 13 Nov 2020 21:12:19 -, GitLab Bridge on behalf of bcrocker wrote:
> -arch="$(echo "$file" | sed "s/$PACKAGE_NAME-\([^-]*\).*.config/\1/")"
> +arch="${file/$PACKAGE_NAME-/}"
> +arch="${arch/-*/}"
Just noting this is not equal. It doesn't seem to matter in practice,
though,
On Fri, 13 Nov 2020 21:12:19 -, GitLab Bridge on behalf of bcrocker wrote:
> -if [ -f $RpmDir/$ModDir/extra/drivers/block/floppy.ko* ]; then
> - blacklist "floppy"
> -fi
Since the script is /bin/bash, just use [[ ]]. You will not have to
worry about the glob matching multiple files. You
On Fri, 13 Nov 2020 11:55:17 +0100, Sergio Lopez wrote:
> On Fri, Nov 13, 2020 at 11:51:47AM +0100, Jiri Benc wrote:
> > On Fri, 13 Nov 2020 11:42:32 +0100, Sergio Lopez wrote:
> > > Is it acceptable to package non-bootable kernels in Fedora?
> >
> > Based
On Fri, 13 Nov 2020 11:42:32 +0100, Sergio Lopez wrote:
> Is it acceptable to package non-bootable kernels in Fedora?
Based on what you described, I'd say no?
Jiri
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email
On Fri, 13 Nov 2020 10:50:53 +0100, Sergio Lopez wrote:
> Let me clear here, there's absolutely no intention of keeping things
> downstream, but there may be changes that won't be accepted upstream
> because they only make sense for this particular use case.
If they are not accepted upstream,
On Thu, 12 Nov 2020 21:56:55 +0100, Sergio Lopez wrote:
> The intention is to keep the gap as small as possible by trying
> to upstream all changes. Probably there will be a some of them that
> won't make upstream, but those will be super-small changes (such as
> not complaining loudly if init
test: The bats package is not installed" ; \
Please merge this to the patch that is introducing this code instead of
piling a fixup on top. Similarly for other patching in this set.
Nacked-by: Jiri Benc
___
kernel mailing list -- kernel@li
On Tue, 10 Nov 2020 16:20:49 -, GitLab Bridge on behalf of dcaratti wrote:
> From: Davide Caratti
>
> so that MPTCP-level socket diagnostics are available to userspace
> applications like 'ss'.
Acked-by: Jiri Benc
___
kernel
On Tue, 3 Nov 2020 09:14:10 -0600, Justin Forbes wrote:
> Gitlab allows me to "squash commits on merge" which will change these
> to a single commit in git history, and should address your concern.
Sounds great, thanks a lot! I appreciate that you're taking time to
look into all of this on top of
ion to no, only to flip it to yes right after?
2. Include a reason on why the config option is set in the way it is?
Something like: "As requested by Jiri Benc " would
be totally enough.
I'm very sure both of these points can be easily automated.
Than
On Mon, 19 Oct 2020 16:12:12 -0400, Don Zickus wrote:
> Sorry about that. I thought things were failing because of ARK infra but
> now they are failing due to libbpf on s390x. Does bpf compile there?
>
[...]
> 00:01:25 LINK resolve_btfids
> 00:04:11 libbpf: non-native ELF endianness is
On Thu, 15 Oct 2020 12:20:41 +0200, Jiri Benc wrote:
> On Thu, 15 Oct 2020 09:13:27 -, CKI Project wrote:
> > Overall result: FAILED (see details below)
> > Merge: OK
> >Compile: FAILED
>
> Given the failure emails are sent to ker
On Thu, 15 Oct 2020 09:13:27 -, CKI Project wrote:
> Overall result: FAILED (see details below)
> Merge: OK
>Compile: FAILED
Given the failure emails are sent to kernel@lists.fedoraproject.org
daily, I wonder, is there any value in them? I'm just ignoring them and
On Tue, 13 Oct 2020 15:09:43 -, GitLab Bridge on behalf of Justin Forbes
wrote:
> The resulting changeset is still exactly as it should be, why be
> pedantic on rewriting history where it doesn't matter?
> https://gitlab.com/cki-project/kernel-ark/-/merge_requests/695/diffs
Because we often
On Tue, 13 Oct 2020 17:03:51 +0200, Jiri Benc wrote:
> What I expect is you sending v5 with just two patches. Patch 3 and
> patch 4 should be folded into patch 1.
Correction, patch 2 and patch 4.
Jiri
___
kernel mailing list --
On Tue, 13 Oct 2020 09:51:44 -0500, Justin Forbes wrote:
> The extra newline was a mistake that I saw when viewing the MR on
> gitlab, so I thought I would be quick and edit it using their web UI,
> but it deleted the newline at the end of the file. I added that
> newline back, and the V4 patch is
mmon/generic/CONFIG_SPEAKUP_SYNTH_DUMMY
> +++ b/redhat/configs/common/generic/CONFIG_SPEAKUP_SYNTH_DUMMY
> @@ -1,2 +1 @@
> -# CONFIG_SPEAKUP_SYNTH_DUMMY is not set
> -
> +# CONFIG_SPEAKUP_SYNTH_DUMMY is not set
> \ No newline at end
uced in the very same patch set.
> \ No newline at end of file
You should keep one of the new line characters.
Politely,
Nacked-by: Jiri Benc
Jiri
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel
ore
reviewers' feedback.
series
Nacked-by: Jiri Benc
Also, do not push hastily new versions. All your force pushes create
chaos in reviews, unnecessary traffic to mailing list, etc. You are
also supposed to describe what changed between the versions.
___
ker
ot, I can do a redhat/configs/fedora commit, and then
> remove it when this one gets acks.
Sounds good.
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.
On Thu, 8 Oct 2020 10:10:31 -0500, Justin Forbes wrote:
> It has been on my radar since FESCo approved it, but please leave the
> MR open, as it is also a RHEL change, this needs acks. I was just
> pointing out that regardless of ack status, Fedora will handle this at
> the appropriate time, and
g. redhat/selftests (or
whatever), to make it clear what the script is good for to anyone
browsing through redhat/.
Thanks!
Politely requesting a new version,
Nacked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send
On Wed, 07 Oct 2020 19:48:50 -, GitLab Bridge on behalf of bcrocker wrote:
> From: Ben Crocker
>
> Add dist-dump-variables and dist-check-variables for dynamically
> deriving variables from Makefile.common and dumping or checking them.
> At the moment, the dist-dump-variables and
dditional information
> and/or does additional processing before and/or after (or
> even instead of) invoking /usr/bin/git.
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lis
On Wed, 30 Sep 2020 15:13:49 -, GitLab Bridge on behalf of bcrocker wrote:
> From: Ben Crocker
>
> GIT ?= git
>
> and replace literal occurrences of 'git' with $(GIT).
> This change enables us to override 'git' with, e.g., some
> arbitrary shell script that prints additional information
>
?
Thanks for the clarification! I admit I got lost in the changes.
Changing my ack for the third time. Sorry for the mess.
Acked-by: Jiri Benc
Fedora enablement can be done in a separate follow up patch.
Jiri
___
kernel mailing list -- kernel@lists.fedorapr
On Wed, 30 Sep 2020 11:16:32 -0300, Marcelo Ricardo Leitner wrote:
> On Wed, Sep 30, 2020 at 01:46:53PM -, GitLab Bridge on behalf of
> jmflinuxtx wrote:
> > --- /dev/null
> > +++ b/redhat/configs/common/generic/CONFIG_NET_ACT_GATE
> > @@ -0,0 +1 @@
> > +# CONFIG_NET_ACT_GATE is not set
>
On Wed, 30 Sep 2020 16:14:02 +0200, Jiri Benc wrote:
> On Wed, 30 Sep 2020 13:46:53 -, GitLab Bridge on behalf of jmflinuxtx
> wrote:
> > --- /dev/null
> > +++ b/redhat/configs/common/generic/CONFIG_NET_ACT_GATE
> > @@ -0,0 +1 @@
> > +# CONFIG_NET_ACT_GATE is
On Wed, 30 Sep 2020 13:46:41 -, GitLab Bridge on behalf of jmflinuxtx wrote:
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
> @@ -0,0 +1 @@
> +# CONFIG_INET6_ESPINTCP is not set
We have CONFIG_INET_ESPINTCP enabled, so this should be enabled, too.
Unless Sabrina
On Wed, 30 Sep 2020 13:46:53 -, GitLab Bridge on behalf of jmflinuxtx wrote:
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_NET_ACT_GATE
> @@ -0,0 +1 @@
> +# CONFIG_NET_ACT_GATE is not set
Acked-by: Jiri Benc
___
kernel
On Wed, 30 Sep 2020 09:24:30 -, GitLab Bridge on behalf of perexg wrote:
> The patch series is too large to sent by email.
3148 patches for ARK surely doesn't sound correct.
Nacked-by: Jiri Benc
___
kernel mailing list -- ker
it Bhargava
> Cc: jbast...@redhat.com
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/pr
On Thu, 24 Sep 2020 18:49:42 +0200, Jiri Benc wrote:
> Justin, please revert this change. Now every email appears as being sent
> by . Meaning the information about the
> author of email is lost, it's impossible to reply all, etc.
I have to correct myself. Not every email, as mine was
On Thu, 24 Sep 2020 09:17:22 -0700, stan via kernel wrote:
> This is a test reply to see if the setting change worked. Will post
> whether I receive the email or not. I am assuming that 1 hr is enough
> time to propagate the change.
Justin, please revert this change. Now every email appears as
fig
It doesn't make sense to introduce undesirable quoting in one patch and
immediately fixing it in a follow up. This should be just a single patch.
Nacked-by: Jiri Benc
And when you update this, please be sure you run all the checks etc.
and that you are satisfied with the result before for
add "$SCRIPT_DIR"/pending"$FLAVOR"
Or here. Etc, there are more places such as this.
> +SCRIPT="$(readlink -f "$0")"
> +SCRIPT_DIR="$(dirname "$SCRIPT")"
Readlink returns an absolute path, so similarly to above, ther
not networking but I don't see any reason why we would want to
keep this disabled.
Please enable.
Nacked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fed
y are either the same or do override it.
Makes sense to me.
Acked-by: Jiri Benc
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedo
On Fri, 31 Jul 2020 14:55:54 -, GitLab Bridge on behalf of prarit wrote:
> +fedora-configs: dist-configs-prep
> + @cd $(REDHAT)/configs; rm -f *rhel*.config
> +
> +rh-configs: dist-configs-prep
> + @cd $(REDHAT)/configs; rm -f *fedora*.config
Prarit, I wouldn't expect doing
make
On Mon, 13 Jul 2020 17:07:35 +0100, Peter Robinson wrote:
> Not that I'm aware of, they were from patchwork
Could you put a link to patchwork to each particular patch? I think that
would be enough to get an idea where the patches are coming from and
should hopefully not be too intrusive to your
On Mon, 13 Jul 2020 14:55:15 -, GitLab Bridge on behalf of Justin Forbes
wrote:
> This tree is literally based on Linus' up to date tree, upstream
> commit-id's don't exist in patches because if they have the upstream
> commit id, the patch no longer applies.
I'm not sure I follow - of
On Mon, 13 Jul 2020 14:50:36 -, GitLab Bridge on behalf of pbrobinson wrote:
> It's been accepted into selinux/next
Great. Could you please add this information to the patch description,
add a relevant upstream commit id and resubmit?
Thanks!
Jiri
t.
>
> Signed-off-by: Icenowy Zheng
> Signed-off-by: Ondrej Jirman
> Acked-by: Rob Herring
This is missing an upstream commit id reference. Similarly for other
patches in this series.
Please submit v2 with the references added.
Politely,
Nacked-by: Jiri Benc
mit enables the first part.
>
> [1] https://github.com/coreos/fedora-coreos-tracker/issues/94
>
> Acked-by: Stephen Smalley
> Signed-off-by: Jonathan Lebon
> Signed-off-by: Paul Moore
It doesn't seem the patch has been accepted
1 - 100 of 130 matches
Mail list logo
