Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-05-15 Thread Seth Hillbrand
​Sorry about the broke builds. I've adjusted the FindOCE section to a better override, restoring how it searched previously. OpenCascade changes should now only affect builds specifically requesting KICAD_USE_OCC. -Seth Am Di., 15. Mai 2018 um 05:42 Uhr schrieb Simon Richter <

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-05-15 Thread Simon Richter
Hi, On 15.05.2018 10:40, Nick Østergaard wrote: > The occ patch makes the build fail on macos when enabling oce. I don't > understanf why the error message suggest the occ path instead of the occ > one. Also I don't understand why the defualt would not work as before. FWIW, it also makes MSVC

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-05-15 Thread Nick Østergaard
The occ patch makes the build fail on macos when enabling oce. I don't understanf why the error message suggest the occ path instead of the occ one. Also I don't understand why the defualt would not work as before. http://ci.kicad-pcb.org/job/osx-kicad-adam-head/659/console tir. 20. mar. 2018

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-19 Thread Seth Hillbrand
Nick, as always, thanks for the detailed helpful comments. To specify the installation, we will need to set -DOCC_LIBRARY_DIR and -DOCC_INCLUDE_DIR. That works on my machine and the docker file. I'll implement your suggestions and give people another few days to test if they're interested in

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-18 Thread Nick Østergaard
Hi Seth, I tried to test your patch. It bascially works. Some observations follows: I think the message printed from cmake "from /opt/oce/lib/libTKernel.so I found /opt/oce/lib" should be removed from the output, it looks liek a debug message to me. I guess the same information is available in

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-16 Thread Nick Østergaard
Thank you very much, I will try to remember it after the weekend. 2018-03-17 0:46 GMT+01:00 Seth Hillbrand : > Hi Nick- > > I finally found a moment to figure out Docker and get this up and running > in your build configuration. > > Please take a look when you have a

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-03-16 Thread Seth Hillbrand
Hi Nick- I finally found a moment to figure out Docker and get this up and running in your build configuration. Please take a look when you have a chance and let me know if you have any issues with this patch. Best- Seth 2018-02-10 7:12 GMT-08:00 Seth Hillbrand : >

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-10 Thread Seth Hillbrand
Nick was having an unknown issue but I haven't heard back from him on whether the issue was resolved by doing a clean cmake. If it isn't then I'll need to address that. Nick did you have a chance to test that? -S 2018-02-10 6:18 GMT-08:00 Wayne Stambaugh : > Seth, > >

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-10 Thread Wayne Stambaugh
Seth, What is the current status of this patch? I would like to get it merged before rc1 so the package devs can test it. Cheers, Wayne On 01/30/2018 02:12 PM, Seth Hillbrand wrote: > Nick- > > Thanks for the test.  I'm attaching revised patch that allows multiple > OpenCASCADE installations

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-08 Thread Seth Hillbrand
> -Thomas > > > > *From:* Seth Hillbrand <seth.hillbr...@gmail.com> > *Sent:* Thursday, February 08, 2018 10:49 AM > *To:* Thomas Figueroa <tom_figue...@hotmail.com> > > *Cc:* kicad-developers@lists.launchpad.net > *Subject:* Re: [Kicad-developers] [PATCH] Allow

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-08 Thread Thomas Figueroa
..@gmail.com> Sent: Tuesday, February 6, 2018 2:34 PM To: kicad-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net> Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition I've updated this to allow use of OpenCascade 7.2 as well. Nick, I add

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-08 Thread Seth Hillbrand
> > *From: *Seth Hillbrand <seth.hillbr...@gmail.com> > *Sent: *Tuesday, February 6, 2018 2:34 PM > *To: *kicad-developers@lists.launchpad.net > > *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard > edition > > > > I've updated this to allow

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-06 Thread Seth Hillbrand
*Thomas Figueroa <tom_figue...@hotmail.com> > *Cc: *kicad-developers@lists.launchpad.net > *Subject: *Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard > edition > > > > Hi Thomas- > > > > I located a windows machine to try this. I suspect that thi

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-02 Thread Thomas Figueroa
d-developers@lists.launchpad.net<mailto:kicad-developers@lists.launchpad.net> Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition Hi Thomas- I located a windows machine to try this. I suspect that this is an artifact of OpenCascade 7.2. Can you test with OpenCascade 7.1? I ha

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-02 Thread Seth Hillbrand
Hi Nick- Thanks. Can you clear your build directory, re-run your Cmake command and send the full output? The snippet suggests that it is finding a library in your kicad-source-mirror directory. -Seth 2018-02-01 13:03 GMT-08:00 Nick Østergaard : > Hi Seth > > The second

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-02 Thread Seth Hillbrand
try them out. > > > > - Thomas > > > > *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa= > hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand > *Sent:* Monday, January 29, 2018 12:55 PM > *To:* KiCad Developers <kicad-devel

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-01 Thread Nick Østergaard
Hi Seth The second patch seems more broken. I get something like this when configuring: ... -- Found OCC: /opt/oce/lib/oce-0.18/../../include/oce (found version "6.9.1") -- Found OpenCASCADE Community Edition version: 6.9.1 -- ++ OpenCASCADE Community Edition include directory:

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-01 Thread Thomas Figueroa
et> Subject: Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition Hi Thomas- Thanks for testing! Couple questions: - Which version of OCCT are you testing? - Are you able to correctly export the board when using OCE? - Do you not see the missing model messages when using OCE? -Seth 20

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-02-01 Thread Seth Hillbrand
eas, I’d be very willing > to try them out. > > > > - Thomas > > > > *From:* Kicad-developers <kicad-developers-bounces+tom_figueroa= > hotmail@lists.launchpad.net> *On Behalf Of *Seth Hillbrand > *Sent:* Monday, January 29, 2018 12:55 PM >

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-31 Thread Thomas Figueroa
Behalf Of Seth Hillbrand Sent: Monday, January 29, 2018 12:55 PM To: KiCad Developers <kicad-developers@lists.launchpad.net> Subject: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition ​Hi All- Currently, the build requires the opencascade community edition. For various reasons, I

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-30 Thread Nick Østergaard
I get the same issue with OCCT 7.2.0. 2018-01-29 23:30 GMT+01:00 Nick Østergaard : > Hi Seth, > > I just took the patch for a testrun and will state some comments below. > > This looks a bit strange: > > -- Boost version: 1.66.0 > -- -- OpenCASCADE Community Edition has been

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-30 Thread Cirilo Bernardo
OCCT is usually quite a few commits ahead of OCE; in fact OCE is usually based on the earlier release of OCCT. In addition to that, since we build in MSYS on MSWin, a patch (which is an ugly hack) is required to support non-ASCII characters in file names. - Cirilo On Mon, Jan 29, 2018 at 8:08

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Wayne Stambaugh
Please ignore this, I see that you've chosen occ as the fallback. Sorry about the noise. Wayne On 01/29/2018 05:28 PM, Wayne Stambaugh wrote: Seth, Looking at the information at hand, I'm comfortable adding occ. I was working under the assumption that you were making occ and option for oce

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Nick Østergaard
Hi Seth, I just took the patch for a testrun and will state some comments below. This looks a bit strange: -- Boost version: 1.66.0 -- -- OpenCASCADE Community Edition has been found. -- -- Found OCE/OpenCASCADE version: 6.8.0 -- -- OCE/OpenCASCADE include directory:

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Wayne Stambaugh
Seth, Looking at the information at hand, I'm comfortable adding occ. I was working under the assumption that you were making occ and option for oce but after looking at the patch, I see that is not the case. Please revise your patch to make occ an optional replacement for oce and keep oce as

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Seth Hillbrand
Maybe the confusion is between LGPL v2.1, which is compatible with GPL3 and GPL2, which is not. There are two aspects here: - Clause 3 states that we can substitute GPL v2 or any newer version instead of LGPL v2.1. That would apply if we decided to use a copy of the library (e.g. static

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Wayne Stambaugh
We might actually have an out. The exception specifies: "Open CASCADE exception (version 1.0) to GNU LGPL version 2.1. The object code (i.e. not a source) form of a "work that uses the Library" can incorporate material from a header file that is part of the Library. As a special exception to

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread José Ignacio
I think you might be confusing the GPL with the *L*GPL, they are very different licenses in practice On Mon, Jan 29, 2018 at 2:04 PM, Wayne Stambaugh wrote: > Hey Seth, > > One of us missed something. Here is my interpretation: > > The opencascade website license states:

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Andrew Zonenberg
My understanding is that LGPL can be DYNAMICALLY linked with arbitrarily licensed code (GPL of any version, proprietary, permissive, etc) as long as: 1) any modifications to the LGPL'd module are redistributed under the copyleft terms of the LGPL, and 2) patched/updated versions of the LGPL

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Simon Wells
please see https://lists.launchpad.net/kicad-developers/msg31544.html There are different minimum versions required of OCCT and nick also had issues with occt working iirc i think i would still prefer being able to set whether to

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Wayne Stambaugh
Hey Seth, One of us missed something. Here is my interpretation: The opencascade website license states: "Open CASCADE Technology version 6.7.0 and later are governed by GNU Lesser General Public License (LGPL) version 2.1 with additional exception." It makes no mention of later versions of

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Seth Hillbrand
Hi Wayne- My reading of your links is different. Here's the relevant quote: "GNU Lesser General Public License (LGPL) version 2.1 (#LGPLv2.1) This is the previous version of the LGPL: a free software license, but not a strong copyleft license, because it permits linking with nonfree modules. It

Re: [Kicad-developers] [PATCH] Allow OpenCASCADE standard edition

2018-01-29 Thread Wayne Stambaugh
Seth, There maybe licensing issues involved with this. OpenCascade is licensed using LGPL v2.1 not v2.1[1] or later. LGPL v2.1 is not compatible with GPL 3[2]. If OpenCascade is willing to change their license LPGL 2.1 or later or if this is just an oversight on their part, than I can include