Re: [Kicad-developers] New Footprint libs and wizard issues

I looked at the commit and I’m starting to remember why I didn’t: there’s also a bug in wxWidgets where if you start typing into a grid cell it will open the editor, but the first keystroke never goes through the validator. So I fixed that too, but between that one and the issue commented in

Re: [Kicad-developers] New Footprint libs and wizard issues

Le 09/04/2018 à 18:03, Jeff Young a écrit : > FWIW, this is already fixed in 6.0. See the last routine in this file: > > https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0 > Perhaps you could commit this fix to the current V5. It does not look like risky. --

Re: [Kicad-developers] New Footprint libs and wizard issues

FWIW, this is already fixed in 6.0. See the last routine in this file: https://git.launchpad.net/~jeyjey/kicad/tree/common/validators.cpp?h=6.0 ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] New Footprint libs and wizard issues

On 2018-04-09 10:21 AM, jp charras wrote: It has an issue: if I try to enter a lowercase char, it is converted to the corresponding uppercase char (as expected), but the cursor moves to the beginning of the text after the char is inserted. The simplest solution is to do the conversion from

Re: [Kicad-developers] New Footprint libs and wizard issues

On 2018-04-07 06:42 PM, kristoffer Ödmark wrote: Agreed, hereis a patch for that :) - Kristoffer On 2018-04-06 17:18, Kevin Cozens wrote: [snip] I added MYSYSMOD as a custom path ages ago. What I find odd about the dialog boxes that let you add paths is that they won't accept lower case

Re: [Kicad-developers] New Footprint libs and wizard issues

Thank you JP! I will have a look when I get home, It was not happening on linux, and I do not currently have a windows computer anywhere, but maybe I can force the cursor to the end some other way. -Kristoffer On 2018-04-09 16:21, jp charras wrote: Le 08/04/2018 à 00:42, kristoffer Ödmark

Re: [Kicad-developers] New Footprint libs and wizard issues

Le 08/04/2018 à 00:42, kristoffer Ödmark a écrit : > Agreed, hereis a patch for that :) Hi kristoffer, I tested your patch (about lowercase) on W7. It has an issue: if I try to enter a lowercase char, it is converted to the corresponding uppercase char (as expected), but the cursor moves to the

Re: [Kicad-developers] New Footprint libs and wizard issues

I know its not the most elegant solution, but it is actually quite convenient. Just checking so that this tiny improvement isnt lost :) -Kristoffer On 2018-04-08 00:42, kristoffer Ödmark wrote: Agreed, hereis a patch for that :) - Kristoffer On 2018-04-06 17:18, Kevin Cozens wrote: On

Re: [Kicad-developers] New Footprint libs and wizard issues

Agreed, hereis a patch for that :) - Kristoffer On 2018-04-06 17:18, Kevin Cozens wrote: On 2018-04-06 06:30 AM, kristoffer Ödmark wrote: Attached is a patch that adds support for custom environment paths. Previously the wizard would only accept KISYSMOD, KIPRJMOD and the github one. I

Re: [Kicad-developers] New Footprint libs and wizard issues

On 2018-04-06 06:30 AM, kristoffer Ödmark wrote: Attached is a patch that adds support for custom environment paths. Previously the wizard would only accept KISYSMOD, KIPRJMOD and the github one. I added MYSYSMOD as a custom path ages ago. What I find odd about the dialog boxes that let you

Re: [Kicad-developers] New Footprint libs and wizard issues

I think the reason is that KIPRJMOD is not editable. Still, it would be better to show it in the dialog and just make it read-only (as then the user would know it existed without opening the help window). Feel free to log a bug for that (just set its milestone to 6.0). I’ll merge your patch.

Re: [Kicad-developers] New Footprint libs and wizard issues

Turns out the redundant code was not very redundant. There would have to be some more refactoring of the code to get this all using the NormalizePath command in common/env_paths.cpp I am also uncertain, since I dont understand the codebase good enough, to why Pgm.GetLocalEnvVars does not

Re: [Kicad-developers] New Footprint libs and wizard issues

Found a bug shortly after, I will reupload. I will also remove the redundant code and check if it still works. On 2018-04-06 13:05, Jeff Young wrote: Patch looks good to me, although I’d rather see the redundant code removed. On 6 Apr 2018, at 11:30, kristoffer Ödmark

Re: [Kicad-developers] New Footprint libs and wizard issues

Patch looks good to me, although I’d rather see the redundant code removed. > On 6 Apr 2018, at 11:30, kristoffer Ödmark > wrote: > > <0001-Footprint-Wizard-now-also-handles-custom-Env-paths.patch> ___ Mailing list:

Re: [Kicad-developers] New Footprint libs and wizard issues

Attached is a patch that adds support for custom environment paths. Previously the wizard would only accept KISYSMOD, KIPRJMOD and the github one. left some legacy handling in the GetAutoPath, as to not break anything, I can remove it if wanted. - Kristoffer On 2018-04-04 11:02, jp

Re: [Kicad-developers] New Footprint libs and wizard issues

Ah, I was using it wrong. I was looking for someway to start a new lib, not realising I need to start a new footprint and then start a new lib from that. Thanks and sorry for that. Although, would be nice to be able to start a new footprint in a new lib directly when opening the footprint

Re: [Kicad-developers] New Footprint libs and wizard issues

Le 04/04/2018 à 10:01, kristoffer Ödmark a écrit : > Hello! > > So it was a while since I made some noise, so its time again. > > Is there a way to create new footprint libs from KiCad? I cannot find it, > right now I create them by mkdir name.pretty, thento be able to add them > with the

[Kicad-developers] New Footprint libs and wizard issues

Hello! So it was a while since I made some noise, so its time again. Is there a way to create new footprint libs from KiCad? I cannot find it, right now I create them by mkdir name.pretty, thento be able to add them with the wizard, I have to create a temp.kicad_mod file in that folder. Should