Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Alexander Shuklin
Hi Dino, Thanks for direction. I'm not sure, that counting pixels is good way, but for sure I will look how Plot function is implemented. >Среда, 31 июля 2019, 15:08 +03:00 от Dino Ghilardi : > >Hi Alexander, > > > > > Maybe that's not too bad, as far as I remember, copper layers are > >

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Alexander Shuklin
Thanks, I was looking in my forked repo, so I've got lost))) >Среда, 31 июля 2019, 16:13 +03:00 от Wayne Stambaugh : > >Hi Alexander, > >The 6.0.0-rc1 milestone[1] tag is the HEAD of master or at least what >the next release version that master will become once it's ready to release. > >Cheers,

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Wayne Stambaugh
Hi Alexander, The 6.0.0-rc1 milestone[1] tag is the HEAD of master or at least what the next release version that master will become once it's ready to release. Cheers, Wayne [1]: https://launchpad.net/kicad/+milestone/6.0.0-rc1 On 7/31/19 6:31 AM, Alexander Shuklin wrote: > > Hi! Thanks for

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Dino Ghilardi
Hi Alexander, > > Maybe that's not too bad, as far as I remember, copper layers are > polygons with get area method already implemented. But for sure that > will take hours for debug. > A little bit of "brainstorming": copper layer weight: For the covered area extimation one possible way

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Ian McInerney
To work with the current 6.0 development code, just use the master branch at its HEAD. -Ian On Wed, Jul 31, 2019 at 12:32 PM Alexander Shuklin wrote: > > Hi! Thanks for that. > Currently I cannot reproduce the bug. > I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and >

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Alexander Shuklin
About the weight estimation of the pcb, considering that in the (probably near) future a board stackup definition with copper thickness and dielectric properties will be a part of pcbnew, the weight calculation as another data of the statistics window will become possible,

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-31 Thread Alexander Shuklin
Hi! Thanks for that. Currently I cannot reproduce the bug. I think it can be connected to KiCad 6.0.0-rc1 tag. I will compile and look. Can somebody please explain me about 6.0 version tag? I mean, should I look for bugs in that tag or just follow master? Sorry if that's stupid question. I

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Diego Herranz
>> About the weight estimation of the pcb, considering that in the (probably near) future a board stackup definition with copper thickness and dielectric properties will be a part of pcbnew, the weight calculation as another data of the statistics window will become possible, once the density of

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Dino Ghilardi
Hi, About the weight estimation of the pcb, considering that in the (probably near) future a board stackup definition with copper thickness and dielectric properties will be a part of pcbnew, the weight calculation as another data of the statistics window will become possible, once the density of

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Diego Herranz
I agree both are useful. (Max width x Max height) area is useful as a worst case scenario for manufacturing: it may end up being better depending on the shape of the board and panel design. Regarding actual area, I'm working on a project right now where I need to provide an estimation of the

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Diego Herranz
Done: https://bugs.launchpad.net/kicad/+bug/1838325 Thanks! On Sun, 28 Jul 2019 at 15:04, Wayne Stambaugh wrote: > Diego, > > Please file a bug report for this and include the board file that causes > this so it's easier for us to figure out what is going on. > > Thanks, > > Wayne > > On

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Wayne Stambaugh
I agree. There is utility in both the actual area of a board and the manufacturing area. The latter should be fairly trivial to implement. Cheers, Wayne On 7/29/19 9:30 AM, Clemens Koller wrote: > Hi! > I think it could be good to see both: > - The actual PCB area of the outline (well,

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Clemens Koller
Hi! I think it could be good to see both: - The actual PCB area of the outline (well, without drills). - The max-width * max-height which is usually what you have to pay for when you get it manufactured. The second one could be also an interesting task to calculate if you have an odd shaped

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Alexander Shuklin
  Hi! I've been asked to do actually PCB area calculation. Since English is not my first language, maybe I just miss-understood. Do you mean, that area has to be just max width * max height? I never seen that, but there's a message in thread about sometimes you need proper area. I utilized

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Alexander Shuklin
Hi, I was without internet for few days, I will look for problem. Anyway, information about that bug will be very helpful. >Воскресенье, 28 июля 2019, 17:04 +03:00 от Wayne Stambaugh >: > >Diego, > >Please file a bug report for this and include the board file that causes >this so it's easier

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Mark Roszko
Huh, looking at the statistics code, it actually tries and find the more "detailed area" of a board based on any polygonal outline. Is there any value in it this way? PCB manufacturing charges are generally per-square area because ultimately the price is on panel space you are using. On Sat, Jul

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-29 Thread Alexander Shuklin
Here you are) >Воскресенье, 28 июля 2019, 19:28 +03:00 от jp charras : > >Le 24/07/2019 à 14:52, Alexander Shuklin a écrit : >> Hi Ian, >> Sorry for delay, also I added feature to save statistics in txt file, as >> Dino suggested. >> >> -- >> Alexander Shuklin >> > >Hi Alexander, > >I just

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-28 Thread Wayne Stambaugh
Diego, Please file a bug report for this and include the board file that causes this so it's easier for us to figure out what is going on. Thanks, Wayne On 7/27/19 5:06 AM, Diego Herranz wrote: > I've been testing this dialog and I think it is a nice addition. Thanks! > > There seems to be

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-27 Thread Diego Herranz
I've been testing this dialog and I think it is a nice addition. Thanks! There seems to be something wrong with the area calculation, though. See image below: [image: area.png] Thanks, Diego On Tue, 23 Jul 2019 at 11:18, Ian McInerney wrote: > Alexander, > > Instead of declaring the 2 static

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-24 Thread Alexander Shuklin
Hi Ian, Sorry for delay, also I added feature to save statistics in txt file, as Dino suggested. >Понедельник, 22 июля 2019, 23:57 +03:00 от Ian McInerney >: > >Alexander, > >Instead of declaring the 2 static variables separately, I would suggest >creating a struct for the settings then store

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Alexander Shuklin
Hi Ian, That's good point. I'll change the patch tomorrow.  >Понедельник, 22 июля 2019, 23:57 +03:00 от Ian McInerney >: > >Alexander, > >Instead of declaring the 2 static variables separately, I would suggest >creating a struct for the settings then store that as the static variable. For

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Ian McInerney
Alexander, Instead of declaring the 2 static variables separately, I would suggest creating a struct for the settings then store that as the static variable. For an example of this see the dialog_create_array.cpp file. This way if any new options must be added in the future, they can just be

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Alexander Shuklin
Damn ><, don't use last patch, please. It doesn't count total vias amount. Use this one. >Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin >: > >Hi, >thanks for sharing experience, as I never used that translations or wxWidgets >before. And I have no idea where else could I get

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Alexander Shuklin
Hi Dino, Thanks for that, I just haven't seen that stuff: >>If you move the statistic window and check/uncheck one of the checkboxes >>("subctract holes" or "Exclude components...") the window "jumps" to >>the center of the screen (its default position on open): do you have >>also this

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Alexander Shuklin
Hi, thanks for sharing experience, as I never used that translations or wxWidgets before. And I have no idea where else could I get that information. )) So, there's the patch with vias information and some tiny improvements. >Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney >: > > >

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Ian McInerney
On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi wrote: > Hi Alexander, > > One possible solution for the translation could be put the ":" in a > different column of the table and right-align the field description text > (so all the colons will be aligned). A rapid google search shown that in >

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Dino Ghilardi
Hi Alexander, One possible solution for the translation could be put the ":" in a different column of the table and right-align the field description text (so all the colons will be aligned). A rapid google search shown that in French and Vietnamese there should be a space before the colon,

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread jp charras
Le 22/07/2019 à 10:13, Alexander Shuklin a écrit : > Hi! > I'll have a look to add vias count to dialog. > There's some questions: > > 1)I don't have too much experience with wxdialogs. There was commit on > master, which says: >>> remove settings for fg/bg color: the result is unpredictable: was

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-22 Thread Alexander Shuklin
Hi! I'll have a look to add vias count to dialog. There's some questions: 1)I don't have too much experience with wxdialogs. There was commit on master, which says: >> remove settings for fg/bg color: the result is unpredictable: was black >> texts on black background on my computer. And now

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-21 Thread Dino Ghilardi
Makes sense. Instead of a generic "via count" a more complete table similar to the one generated in the drill report file could be useful, but may be it can became quite long if a lot of different drill sizes are used (ok, scrollbars are made to handle that). Also having "vias", "blind vias"

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-21 Thread Mark Roszko
> Since making every hole in the pcb costs time, manufacturers calculate the price of the PCB using also that number. A long time ago, holes cost alot. These days if your manufacturer is charging alot per hole, you should run far away. Usually manufactuers include 20k-40k holes in the base price

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-21 Thread Dino Ghilardi
I just tried the board statistics dialog and looks good, I like it. A thing I'd like to have to make it better is adding the number of vias to the statistics: Since making every hole in the pcb costs time, manufacturers calculate the price of the PCB using also that number. Also the option

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-20 Thread Jeff Young
Hi Alex, Looks good. I’m going to go ahead and merge it and follow it up with a commit to make the GUI look a little better on MacOS. I’ll send another reply when they’re pushed to master. Cheers, Jeff. > On 17 Jul 2019, at 23:45, Alexander Shuklin wrote: > > > Hi Jeff, > Have a nice

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-17 Thread Jeff Young
Hi Alex, I’m about to go on vacation myself so I’ll be on a plane all day tomorrow, but I’ll look at this when I get there. Cheers, Jeff. > On 17 Jul 2019, at 19:06, Alexander Shuklin wrote: > > Hi Jeff, > > That's not a problem. Now I'm on 2 weeks vacation )) > We don't use header

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-17 Thread Jeff Young
Hi Alex, No need for apologies. It’s a steep learning curve. Some more comments: 1) Dialog items use sentence-capitalization and colons; dialog headers use title-capitalization and no colons. So “Components:” should be “Components”, “Front side:” should be “Front Side”, etc. 2) Right-align

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-08 Thread Jeff Young
Hi Alex, I don’t like the top-side/bottom-side checkboxes (because I want to see both numbers at once), but I do like the other three. I think we need to move to a list or grid presentation, though. One of the other features we’ve talked about is user-defined attributes, so there might be

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-08 Thread Alexander Shuklin
Hi!, I added stuff for footprints THT,SMD,virtual properties and now it's calculate area. But for me dialog is not very straight forward now. Can you please advice, what better to do? I attached 2 pics. I think, maybe right way is to add few checkboxes which will change dialog data as soon as

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-05 Thread Jeff Young
Hi Alex, Yes, MessageTextFromValue() is what you want. (There’s also StringFromValue(), but that produces very exact numbers to prevent round-off errors so they’re much less human-readable.) Use ShowModal(), not ShowQuasiModal(). ShowQuasiModal() is a bit of a hack for modal dialogs which

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-05 Thread Alexander Shuklin
Hi All! Jeff, I don't think, it should have it's own tool either ))) But I couldn't realize by myself, where to put it. No problems, I will rename to PCB_INSPECTION_TOOL. Ian, 1) I will look at that. To be honest, I don't know much about imperial units ) But I think that's some parameter in

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-05 Thread Шуклин Александр
Hi! Sorry for delay in my answer, I have 2 small kids and sometimes there's no time for everything. Do I answer just to kicad-developers@lists.launchpad.net , right? Mario, Shuklin is my surname. Name is Alex))) I will try to do what you are asking for. Do you mean "count" components, not list

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-04 Thread Jeff Young
I agree that it shouldn’t be its own tool, but PCB_EDITOR_CONTROL is getting too big. Let’s just name this tool the PCB_INSPECTION_TOOL, and then I’ll move the highlight and list nets stuff, and the DRC dialog to it later. That’ll nicely parallel the EE_INSPECTION_TOOL. Cheers, Jeff. > On 4

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-04 Thread Ian McInerney
This looks nice, but a few comments from my initial usage of it: Usability: 1) When I use english units, your statistics dialog gives the dimensions in mils. It should probably give those in inches instead, since that is what the grid panel at the bottom gives. 2) Including the board area would

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-04 Thread easyw
Hi, nice addition indeed... You may find someone with the same needs at the forum https://forum.kicad.info/t/how-to-get-pin-count-and-board-size-for-assembly/17792 There is a small plugin offering this option ATM, listing what Mario is asking for... It would be nice to have it in the

Re: [Kicad-developers] [PATCH] Board statistics dialog

2019-07-04 Thread Mário Luzeiro
Hi SHuklin! ( is this the romanization of your name? :) ) This is just my user feedback: That is a cool addition, another feature suggestions would be to list the components by "Fabrication attributes" "Through hole"/"Surface mount"/"Virtual" Each footprint has this attribute so I guess you can